From nobody Sat Feb 7 06:13:45 2026 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A06F37080E for ; Fri, 26 Dec 2025 07:20:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766733623; cv=none; b=Ugi/KRyslTS4WAEYMl3Lhw7vNIvumNKp1sf4SVS8oYaYTGPRAcUwIcLDaQ00KtKHAZQ3t+h4uE8JeGZeYNuF40umXsGv9FKZpB/vKG7bAmhCC0CC+sK0YFdkjUZXPfKmq91FLiG5lSSKp3mhV77N3hGbndFEsf6Bfn60+LvvVmE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766733623; c=relaxed/simple; bh=PpUyUvqbe/B9yufsazvVkYxhT2I2pIJ5qzVaPYJVW14=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=W8in2Dp/nSlEd7oRzN7NLHEB3aGsuNayOsHNQlaq79/00TYP7/5XwMR3H25vmj0mw3wJyDzpVgYZzFcNjI+F4E3ZalI28FN7jWhmuOlv8Z+cd3KFI1dNDQpDSHxjsEQ/EnsF8uAhsGFpA3YyYmOSlJLK73lRU/A1u2uWCOjzvJU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qrvxv3dc; arc=none smtp.client-ip=209.85.167.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qrvxv3dc" Received: by mail-lf1-f66.google.com with SMTP id 2adb3069b0e04-5943d20f352so7620189e87.0 for ; Thu, 25 Dec 2025 23:20:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766733620; x=1767338420; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yFhZ1Iob5g8D9+twOAxyKqI3iKjJAC/mwXdTyun7kXA=; b=Qrvxv3dccQ5cF9sJfCc/yVDir5W/bSeVmxBLehGpiJcL5+QMmnyjHKj60TSY+w6pDe TWV6YZvBKHvD/aw2irSgqMvAz2DydbFMCE5svPDSGd6c3E29O75sELbfzGFA7/h2RHuI dnNbN7lTpssdsKrd3bdEFzbHIOkVH2SddbnGcDSVN9hJdpgaeouyfHSCUsKx3JyMc4KK V9pV3mgfC/+x+GFptW4QR4+DRn1M9rbz24pHLQCtBNqejv1FKCFLvdELqaaSxYa5RXJD RJYt0DztQdopQYevhnFppnyJxuNy3FmNnGWVr/IhFaZ7WVEn2DJatnRQGQCVqNXMB4IJ VQhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766733620; x=1767338420; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yFhZ1Iob5g8D9+twOAxyKqI3iKjJAC/mwXdTyun7kXA=; b=amWFkc7gtDuhpYoIALFxihJsnKqnAeu3XKww92HXDYnEhElxr+JAPKJC2gCsTicEXy ptmqYZdpIvrBMSiq1K0HoYTOuGHmF/9uRmbpH/eeyNXKEMWgssOehVlEbXRUMexbmlpJ 2adDLpcPkNjtxH9YyVHGJabn5WcL6xD7MTgDDDPubEfLAA2wSjBTbYhFCUTr5UQR/pAa Ni8LFbZB8mTWp0Mzd4LOXSq6LcvtJzNbGNQwVfvvrUKqYub0qEiYfoRxBEXjeW2bqCG6 BHLzRlnLrS/q3MoJd17rk6fc3hd5dfNQqhsb0+cSl/8SNzYIWBzpQsms9ToeBQTTW6/T Evlw== X-Forwarded-Encrypted: i=1; AJvYcCW1MzKlMi2qzm6syKWVCWq4JTdTE4KVdxIvy5W6CCIE08hf75kPUImsvWi7aHNndNu2n8Deng51KldZb2w=@vger.kernel.org X-Gm-Message-State: AOJu0YyLgt6Qhep1exqQR9wyNcgnwJNaDiTBxaESIaaZUmcFNZyPNEjM fP04zn4nFDqnk/pOMsebSw39H7Pt9U6fHj9BEympAyWO6ysowCsDiYoe X-Gm-Gg: AY/fxX7oVn9LtLk8rGVWsIUQy39JA+1ONGzAYJ/Ny1lT0uZCtFrnh8tdTUMlizrunMD hMS3LZGBRa0gjM5j7IrvQBjTsTa1f9uf0by+eGwvgUFwAyTCEZiZzPcK7OmEt6Z1tRVqp1yEbGf f5Mu1ZTk9bNHpv9bK5rLRfCzfHN8oLdh8Cmz79dxQtaMCKtsFtTwCB9/HV+1okbKpsnv5INcTy1 n7PJjbBHkSOUnzGP29MmV3C8HzF/xwvpa83VKUYpX94Kkg/GS1B8F2/EZxdMLlR3K4TNErFGSab WsQkZGBqq5H0JXmjU2fLRBOnZF6ZricvRFXPhMegqiqw/KRm898Qb3QEDM+VaEzklETudICV/NB GJLGitaQBUWsHGFaqKDtOVGJbQ8HoQqmJTx5d8Xk2i5jxFGYVkB2QFlGiM2GqD0q4uOAYTu5IZG zCj0e4YtT2xw7LmfK8RANYYMmhgB7T6XwB3Rsuzg== X-Google-Smtp-Source: AGHT+IHlCQMw1f05szzb0x+RXSFO0IxMOoazPQzDzIpEMXPOv+jyWa/qcp4LOJQgOzSPbOu2RVETTw== X-Received: by 2002:a05:6512:2388:b0:598:e8b7:665d with SMTP id 2adb3069b0e04-59a17d7228amr8142851e87.3.1766733619414; Thu, 25 Dec 2025 23:20:19 -0800 (PST) Received: from localhost.localdomain ([176.33.65.121]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a185dd229sm6320723e87.22.2025.12.25.23.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Dec 2025 23:20:17 -0800 (PST) From: Alper Ak To: andy.yan@rock-chips.com Cc: Alper Ak , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/bridge: synopsys: dw-dp: Pass dp->irq instead of ret to ERR_PTR() on IRQ failure Date: Fri, 26 Dec 2025 10:20:01 +0300 Message-ID: <20251226072001.16623-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The error handling after platform_get_irq() incorrectly passes ret to ERR_PTR(), but ret still holds the value 0 from the previous successful devm_add_action_or_reset() call. This causes ERR_PTR(0) which returns NULL instead of a proper error pointer. Pass dp->irq to ERR_PTR() since platform_get_irq() returns the negative error code directly in dp->irq on failure. Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support = library") Signed-off-by: Alper Ak Reviewed-by: Andy Yan --- drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/brid= ge/synopsys/dw-dp.c index 36382956bbe0..718397a29e80 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c @@ -2079,7 +2079,7 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct d= rm_encoder *encoder, =20 dp->irq =3D platform_get_irq(pdev, 0); if (dp->irq < 0) - return ERR_PTR(ret); + return ERR_PTR(dp->irq); =20 ret =3D devm_request_threaded_irq(dev, dp->irq, NULL, dw_dp_irq, IRQF_ONESHOT, dev_name(dev), dp); --=20 2.43.0