From nobody Mon Feb 9 20:36:16 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD8F115853B for ; Fri, 26 Dec 2025 06:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766729077; cv=none; b=R5q1SDS204DqRm+AW7DoReVgzKWi05n/JJ2HRagcFywApR8QNfK4BuTBKuMTIz4Uce+82bqSUMdAPEZi/q8stqFb0acoLoa4bOpha7v6eDz8vVvopdqcvNB2+7VLk7fXodbx0J1qfHJAPJAhTl4119usO1aD6JX4urv224UZg5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766729077; c=relaxed/simple; bh=OKO8pPQ2u1PVbIbGFtwSsJ8PUCHGOqHmtWYFr7S9Uf4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=j7oDApNqShgHapMReAfDSvd62LoobhxSS/Y+vFSiMF37Tn/DJFtmrlDOx+Jw/l8oU2trdIrXWyf2UfmlbUhkshLs18BoGYSFLoH1Jp4cSxI/mBW4adE+x9cJBlZX4sLaN+q76qHx8XEBl4L3Ukt1IgiBZZfuwTYxVp/oZWzraNo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b=cI+vNnf1; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b="cI+vNnf1" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7bb710d1d1dso9675005b3a.1 for ; Thu, 25 Dec 2025 22:04:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20230601.gappssmtp.com; s=20230601; t=1766729073; x=1767333873; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=j4xGho7aYPu0F2BOeXnW+h7VL+kSgq0Xp5r0+dbQtUA=; b=cI+vNnf1uUnYbrrx3IjPLs1moi2coHQLtkzNejX7Pka+zTg4SPoKVrG3eklXax2pxZ jQCnPgjliO69vuZ7XpyxKu9czN4+9I9PixYceRrjER6FBxTB6k/0d1PaExmnT4txHmSN 6AiWVMgenegnSMkuieLZ3ev9x7b++OLyzTM9Sdvfu6DiI7A+qvGsKZ/dTT2Njq0ZE+3P fV68IDoPNYxFR1Avh63kOx3isk1NrxUtUGRT2s5usI98opgQy1PH9kIuJuC57jDEW6RG QXXou5u7I7ktESXevN7vaHELmLrE1rq7/Odc0wTqN0RkzkI+luyhiI3R3rXGRtkaiNY9 Z/Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766729073; x=1767333873; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j4xGho7aYPu0F2BOeXnW+h7VL+kSgq0Xp5r0+dbQtUA=; b=CQUO6b7jCLrHIKymEJ28kj41W7cHdX5PaBDuctBfno/SeWoUbzf7ompG3xEgFHBjiT 4m3AyMDjRFrqNglY1eaNgAgpWbdCzKoaEVvFZOgjJjj/JiSiSwmWBAY6fWLex9cIte09 f96DNVzerxSeFdb1aMc448DP+JRixn3Qe8JNHw0MLHNvjLcmc6HRuirDvCShbeJ3anh/ 9XTASyWjWcENX2RNcc+x1cClEQ05XOiypCadnZmCEry10G+aJ+3Y7mYVs+usyz2otYX0 9a86OQYB9zJjFz6BxuasUyNY2iC0FMK31d3uzT3Ssq6JYdSg6x2wXtE6pUckTbayDO0K YIgg== X-Forwarded-Encrypted: i=1; AJvYcCWSC9P2dPWxq2HCICyGMQCOjL0G6kJY0kqw1dPFyBcH3u3TY57kS885/kmiSugh3c67lLpufFaUy4vhYdg=@vger.kernel.org X-Gm-Message-State: AOJu0YwWyptCG/XFvch0mT0ffccuxNY4L1Q+L3vdIIfQLzwh/Ezt26jM XtTKYOlqmxPPGr1iu64FczG9Pn0AC/1grhvxNq4DwNUeX3J3w8S03M6GEMcrq3rJMso= X-Gm-Gg: AY/fxX41d3OW8feT1PJTAsvnRZwrhjddq6WTaUEqv+TaBXFA59qSAC3PkMhg83ucqxh zMeNjekWjzx7WzzzEiISXYzqkt1GpuRtytCdDnDtX/TGIRsz9RhjfGzQCGgq4+saG5sbcTAmiQI 63Lt0GkcD2fDceME1DUlPsqZhUeflIc2HQjn4hQrOnZ1oC38g6xfyCind1yOmrmjivyEfwDBh03 JIHE68BDu6QDz5MLHvafPWzjxeKfApglNxugXTVryhLYkZETr9fNGhv7xrbcvCeE22fuyO0WzWg HRYZTkSX49pJgicaQA6RoAca8/4aKUnWlUvncSLlKz1acC/DJVWEayyt8P6oBxIpIf2bRWZj6hM HP2DR8b1kDBiarymNHA3jubgVDXC423FNZZbSlMFwTl6UiCYhtD3rcKO3/xbziAkkp4wBnApgUt SWyFCW4zGx1mAGkRURp1+Ug/Db X-Google-Smtp-Source: AGHT+IG+gJCqvf6cX/cvf23QXKpxJilzTTZX3/LI0nMqhPGbDIqafJa+NVZYkW9sVgMEo5U1DYe4PA== X-Received: by 2002:a05:6a00:302a:b0:7b7:79ca:9a73 with SMTP id d2e1a72fcca58-7ff646f9664mr22376207b3a.10.1766729072784; Thu, 25 Dec 2025 22:04:32 -0800 (PST) Received: from localhost.localdomain ([103.158.43.19]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7ff7e48cea1sm21262129b3a.45.2025.12.25.22.04.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Dec 2025 22:04:32 -0800 (PST) From: Abdun Nihaal To: linusw@kernel.org Cc: Abdun Nihaal , brgl@kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2] gpio: mpsse: fix reference leak in gpio_mpsse_probe() error paths Date: Fri, 26 Dec 2025 11:34:10 +0530 Message-ID: <20251226060414.20785-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The reference obtained by calling usb_get_dev() is not released in the gpio_mpsse_probe() error paths. Fix that by using device managed helper functions. Also remove the usb_put_dev() call in the disconnect function since now it will be released automatically. Cc: stable@vger.kernel.org Fixes: c46a74ff05c0 ("gpio: add support for FTDI's MPSSE as GPIO") Signed-off-by: Abdun Nihaal --- Compile tested only. Not tested on real hardware. v1->v2: - Switched to use devm_add_action_or_reset() to avoid unnecessary gotos, as suggested by Bartosz Golaszewski. Link to v1: https://lore.kernel.org/all/20251223065306.131008-1-nihaal@cse.= iitm.ac.in/ drivers/gpio/gpio-mpsse.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-mpsse.c b/drivers/gpio/gpio-mpsse.c index ace652ba4df1..12191aeb6566 100644 --- a/drivers/gpio/gpio-mpsse.c +++ b/drivers/gpio/gpio-mpsse.c @@ -548,6 +548,13 @@ static void gpio_mpsse_ida_remove(void *data) ida_free(&gpio_mpsse_ida, priv->id); } =20 +static void gpio_mpsse_usb_put_dev(void *data) +{ + struct mpsse_priv *priv =3D data; + + usb_put_dev(priv->udev); +} + static int mpsse_init_valid_mask(struct gpio_chip *chip, unsigned long *valid_mask, unsigned int ngpios) @@ -592,6 +599,10 @@ static int gpio_mpsse_probe(struct usb_interface *inte= rface, INIT_LIST_HEAD(&priv->workers); =20 priv->udev =3D usb_get_dev(interface_to_usbdev(interface)); + err =3D devm_add_action_or_reset(dev, gpio_mpsse_usb_put_dev, priv); + if (err) + return err; + priv->intf =3D interface; priv->intf_id =3D interface->cur_altsetting->desc.bInterfaceNumber; =20 @@ -713,7 +724,6 @@ static void gpio_mpsse_disconnect(struct usb_interface = *intf) =20 priv->intf =3D NULL; usb_set_intfdata(intf, NULL); - usb_put_dev(priv->udev); } =20 static struct usb_driver gpio_mpsse_driver =3D { --=20 2.43.0