From nobody Mon Feb 9 09:23:14 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3744529ACFD; Fri, 26 Dec 2025 17:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766769782; cv=none; b=gLWD9Jk+oVPfFG+O2N1Ljuj3H/24qPWnvY9f4VV9i17EyRs+ZGJ+967gLllMbqHsZDKvxScU/P4/B4KsjfM6X+9wLNDIAP+2o41/RSXUuSLWzBwETzhc+WQjGOFcpAgxl0TiZBQObZoPk8Zc4DGTl00kSpdqbqHmuG4C+QcAaA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766769782; c=relaxed/simple; bh=4cVn8UL6hNWEcg/YdhbCzOX9yeZWfbignrYfO4IkjYU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=uy5vrjgy7NA3Y4EWjmWbBW6IxVrfVTvhb+MrHzLv9R4HGU+Ags/bu6sM/S/cUc660yUL/dvRdZdEW9HANDfcUK5xaGbAwpJhtRzeY4Pz7NEmR/ROxlHh512X+8+reIc+lm563BYJ4ofpiOCm+tXGHVKdo5ZhjWapy205dBsVUyE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NppR/zRY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NppR/zRY" Received: by smtp.kernel.org (Postfix) with ESMTPS id E6CD6C4CEF7; Fri, 26 Dec 2025 17:23:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766769782; bh=4cVn8UL6hNWEcg/YdhbCzOX9yeZWfbignrYfO4IkjYU=; h=From:Date:Subject:To:Cc:Reply-To:From; b=NppR/zRY6hVQHrSy1rvfbiL36FVszbN8T+YBp0QUapzE4D9UYEhWSiH/XFwGfzdx8 vqWQM7WE43LAaep06loLgtDnP88lYHTsJTNZ8myh8Da11zGI5wZCaRSL7mjsa0RuXv d7qf0c7Wg0BUahRlUDO6jr3T7PFz3H9ZnP9qlitjSyA0J7Of04cXT1z5vaMdH5PpFJ hJu5cUisEntG7qFAxCe4gJbMufifJj8+cav68aZE3JLg571u9QNFQDVTvJg9jBlAaW ua1Z9nFWGMdwmJpuXAZ8OhKeCHUtWSEFuiI8XZlHsypZjW3JjFcWZrEnlFXpU3tc8j bSz+m6dDKnPyA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCDFBE7AD77; Fri, 26 Dec 2025 17:23:01 +0000 (UTC) From: Ewan Chorynski via B4 Relay Date: Fri, 26 Dec 2025 18:22:36 +0100 Subject: [PATCH] rust: drm: Improve safety comment when using `Pin::into_inner_unchecked` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251226-drm-gem-safety-comment-v1-1-5ae56d8194b9@ik.me> X-B4-Tracking: v=1; b=H4sIAFvETmkC/x2MMQqAMBAEvyJXe2AOo+BXxEJ0o1ckSiKiiH83y FRTzDyUEBWJuuKhiFOTbiGLKQua1jEsYJ2zk1RijUjDc/S8wHMaHY6bp817hIONsYLathlHOd4 jnF7/uB/e9wOI2Z1/aAAAAA== To: David Airlie , Simona Vetter , Danilo Krummrich , Alice Ryhl , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Ewan Chorynski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766769780; l=1350; i=ewan.chorynski@ik.me; s=20251226; h=from:subject:message-id; bh=cr9xZXsdzg4gFRm4XD7QgBo5pAiTHyiIcr0OoAXNvbY=; b=QHme9hYoeeJ096eavEfMxvGDXboOP72kgL0MmQOVOXx33RBK6szLkQSKUzNcIeKuHaFxRcIZi jsIytm5GTXxDf0S/2mC8WMFLNWBe7z61mZQe6bTkFCq8FR1FjEYKKYt X-Developer-Key: i=ewan.chorynski@ik.me; a=ed25519; pk=Qzaw5giL/U3IFVpYyrZjtONgXMAOpXYyUsXRpiS8hUQ= X-Endpoint-Received: by B4 Relay for ewan.chorynski@ik.me/20251226 with auth_id=587 X-Original-From: Ewan Chorynski Reply-To: ewan.chorynski@ik.me From: Ewan Chorynski The safety requirements for `Pin::into_inner_unchecked` state that the returned pointer must be treated as pinned until it is dropped. Such a guarantee is provided by the `ARef` type. This patch improve the safety comment to to better reflect this. --- Signed-off-by: Ewan Chorynski --- rust/kernel/drm/gem/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs index a7f682e95c01..ed11d9c0f427 100644 --- a/rust/kernel/drm/gem/mod.rs +++ b/rust/kernel/drm/gem/mod.rs @@ -210,7 +210,7 @@ pub fn new(dev: &drm::Device, size: usize) -= > Result> { // SAFETY: The arguments are all valid per the type invariants. to_result(unsafe { bindings::drm_gem_object_init(dev.as_raw(), obj= .obj.get(), size) })?; =20 - // SAFETY: We never move out of `Self`. + // SAFETY: We will never move out of `Self` as `ARef` is alw= ays treated as pinned. let ptr =3D KBox::into_raw(unsafe { Pin::into_inner_unchecked(obj)= }); =20 // SAFETY: `ptr` comes from `KBox::into_raw` and hence can't be NU= LL. --- base-commit: 6c8e404891e1059564d1a15a71d3d76070304dde change-id: 20251226-drm-gem-safety-comment-1152e457575f Best regards, --=20 Ewan Chorynski