From nobody Sun Feb 8 11:43:27 2026 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA6441A76DE for ; Thu, 25 Dec 2025 23:22:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766704951; cv=none; b=ImH6CR30c24k7nGQxJ/wDPjmVGocKE6H0DfWuzQhc/1CiGQ/XkCgSaQ5N+EkgfsxiDiJ+Xn5/VkcvsayhX0fXkz6OTgnh2M5Gr04zbkYIHD3/SHzH/ECSPhiGFaMb5oQP+UVIIDYOl9BPX4JO7cdVTkL+KRi3WiJ7baoIWycQFM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766704951; c=relaxed/simple; bh=6tIArGlSqpof+0rDw58wC/1JKZYFEvHKklYcbVdtYO4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TIgE0jr0fdvBxHFihxYZ8Bhtv7C5zUjYLdy+C/xgxSvBB5qD8XSzfkebKpuExBHthWFOQB7zX+asI6WKFrHpqHazB/hEcQ7eR5FR/bU0d8e41OvAGdzxDZqqUSyHFu4KOGwzkOy/5Nv24NGcL0DrtqYYSOO93EZOAtKwJLdaC0k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=lpuglBuc; arc=none smtp.client-ip=95.215.58.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="lpuglBuc" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1766704948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Emeg4oe9Wf0hyjEB6RFxn5Oy5f9oafLtHS4W3VCookU=; b=lpuglBucsWYRiDV/OnmxWeINhdtMYGc0NTEFlwikXxPSs0ejEd4LObkAP9Ac3BAHuc+Fvd Nztz/FLx82sK4xM2VUmg1+MA78XKQUDuQTQFd7WgwRQRM9JF5YL33GsHMO0B+BFsWDHuL3 ru71F8vValtJC/97v4Cc466P12Hpbzw= From: Shakeel Butt To: Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , SeongJae Park , Meta kernel team , linux-mm@kvack.org, cgroups@vger.kernel.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 6/8] mm/vmscan: use cgroup ID instead of private memcg ID in lru_gen interface Date: Thu, 25 Dec 2025 15:21:14 -0800 Message-ID: <20251225232116.294540-7-shakeel.butt@linux.dev> In-Reply-To: <20251225232116.294540-1-shakeel.butt@linux.dev> References: <20251225232116.294540-1-shakeel.butt@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" The LRU gen debugfs interface was using the internal private memcg ID which is meant for tracking kernel objects that outlive their cgroup. Switch to using the public cgroup ID instead. Signed-off-by: Shakeel Butt --- mm/vmscan.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index a4b308a2f9ad..d78043c7e4af 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -5426,7 +5426,7 @@ static int lru_gen_seq_show(struct seq_file *m, void = *v) if (memcg) cgroup_path(memcg->css.cgroup, m->private, PATH_MAX); #endif - seq_printf(m, "memcg %5hu %s\n", mem_cgroup_id(memcg), path); + seq_printf(m, "memcg %llu %s\n", mem_cgroup_ino(memcg), path); } =20 seq_printf(m, " node %5d\n", nid); @@ -5511,7 +5511,7 @@ static int run_eviction(struct lruvec *lruvec, unsign= ed long seq, struct scan_co return -EINTR; } =20 -static int run_cmd(char cmd, int memcg_id, int nid, unsigned long seq, +static int run_cmd(char cmd, u64 memcg_id, int nid, unsigned long seq, struct scan_control *sc, int swappiness, unsigned long opt) { struct lruvec *lruvec; @@ -5522,19 +5522,12 @@ static int run_cmd(char cmd, int memcg_id, int nid,= unsigned long seq, return -EINVAL; =20 if (!mem_cgroup_disabled()) { - rcu_read_lock(); - - memcg =3D mem_cgroup_from_id(memcg_id); - if (!mem_cgroup_tryget(memcg)) - memcg =3D NULL; - - rcu_read_unlock(); - + memcg =3D mem_cgroup_get_from_ino(memcg_id); if (!memcg) return -EINVAL; } =20 - if (memcg_id !=3D mem_cgroup_id(memcg)) + if (memcg_id !=3D mem_cgroup_ino(memcg)) goto done; =20 sc->target_mem_cgroup =3D memcg; @@ -5601,7 +5594,7 @@ static ssize_t lru_gen_seq_write(struct file *file, c= onst char __user *src, int n; int end; char cmd, swap_string[5]; - unsigned int memcg_id; + u64 memcg_id; unsigned int nid; unsigned long seq; unsigned int swappiness; @@ -5611,7 +5604,7 @@ static ssize_t lru_gen_seq_write(struct file *file, c= onst char __user *src, if (!*cur) continue; =20 - n =3D sscanf(cur, "%c %u %u %lu %n %4s %n %lu %n", &cmd, &memcg_id, &nid, + n =3D sscanf(cur, "%c %llu %u %lu %n %4s %n %lu %n", &cmd, &memcg_id, &n= id, &seq, &end, swap_string, &end, &opt, &end); if (n < 4 || cur[end]) { err =3D -EINVAL; --=20 2.47.3