From nobody Sun Feb 8 12:43:20 2026 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EF5B322B93 for ; Thu, 25 Dec 2025 12:49:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766666950; cv=none; b=fyGCVWBBFOSSoxcc27VvtnwLdcmkwoCJOtOXGeEjtX5cTB2TPqHwtUHRFvtDTTCXYpRL10t1sngBRmO+DwOZzOacI/wmqZenKwDU+SneYXXeUNHFW2HU6vB0vOVCjYGBQwHHvEn7Wv8tZkCApMnx95h9v/ekKewGXasvGEoNL3k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766666950; c=relaxed/simple; bh=YePUMBNrZCsU5RKsD2Wqc0t/oSpQ/4/97/Am0joKc0I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FxXU32D33XwKGDbRFPvzYQ2dAIbrFZozgu8JVB+G02afxmb3tq04Bd4uqL8WMM3QSFo3gO9WZltmwEMvAMTzwok3awkhAMxn3tThDdHA6pQYSZmsAyk1B4MJRjTF9kui27g7tnYTVwMjf9XBX5FDVraj/o4IrHr6v9LSxh/dMcU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=anQR++qs; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="anQR++qs" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-595825c8eb3so6887168e87.0 for ; Thu, 25 Dec 2025 04:49:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766666946; x=1767271746; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NwoWxi3H70epYfFagxA8U3mIGMpz/X/cHbS/M+glKnM=; b=anQR++qsnRDuYH+H6+mD71dfhNK6tz19mMUfsaNGqG6rO7e4gPPNBTFeYV5kn5GW0w UH4VdIvXCMklANgKZImY57YCcd3qecrqEqqnkwHEkeeLqKAQgOtojChR0QVAvMwj4tUK cCjNIATz35xcUFwMJnETEnGhdlKAlAzwoUwFN0RzbEh8scFJEH/wSBeCaf/fWBvtNc+R PHAs6y2ZOR38PLLhlxKmV0RvY2M9KY0SmgOyEejO5sFVBphqFJqZ8RAZNDVKYRTIi38q a8qLdMB1FUOgqE0uMQLB7+AH1TAeMhexwRBH6DC7klm+rHasljDIYTuBiDxSt05nsIxE g/cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766666946; x=1767271746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NwoWxi3H70epYfFagxA8U3mIGMpz/X/cHbS/M+glKnM=; b=m7juwPdvjlNln29Dy6PK4mcRHVWLUmjxR7fYKHEHKUVBwdXRV7rSOumCX+IaoGXAbG MyYiCfxfBUjbQPzzNMp6/0A47MaoTSETAQOsQCBx4zLO+ROVZGIaqsHa917YQaqbQaER s2cer5rI6lR0VYCt8srG2yg3O2lxBSh2c5aLAWacFMMZNE+FN0myor4SdlP6BAT76+xU a6JDx+F6AXiRA2PswLcVcFXbRy46/Ins6+WJWCm0anKwrlxfsuWIP22swHLtcVoRh89h VcU112BF447yGCN5LTy5rXZU7pYHOWb4eIWNucKM4IOa1pdlhkQOV8fiM6HBx2i6E/UG kwvw== X-Forwarded-Encrypted: i=1; AJvYcCW7sQAyTFTFKey7LotFH/oyQvSM5SIj5vtzTvw+urfPZwDWC8B/uKFG0nvKGgIbTIDjXzPk4oMcvp/MCAs=@vger.kernel.org X-Gm-Message-State: AOJu0YyWxHjTXfC7C/Uagdg3pDbH8SNITHh7dTc7BDctLMD5uxsxtmPS vo61LYQElK48+f8qxK15TN+YIDvphKk8G70JhpXida5KWn8GcxXh4bQ/ X-Gm-Gg: AY/fxX4X0KuuvcKEUHlsZTGN/FCoUr02wSUHvzfQWbYwut+DuQYFTGxr1BoKz5xEmRE cKDTf0najnaWiqk3o3m5uHsO1VPEHtanm4D3bsH0vm5D4ZDXLngsO3JwY87lIAZ62SSNsbIbDiv /ztf5L0hMX4Ek+Jy7vhGNGUyszKHQz04+uXhVeNxjOqgc6Eub6aQ7MfpFjz1AZszlO8fjS03dox mUl7qigNw6bybKOw6eT20k6PMKnoCcpsduFOeURK5cUU4V9RNtBmwO8lBjecsYtBxH/M8DggBCU F+rasjis4lCGqLiFtuRhvGTaVj4PyqYOPlwFP/zKoJ40UqQk5l4545Gy30GR4zOYzx0Ql91HFAl 0WGjrlvm3OxvI9E0cijS121Rim4FjIM5Nbe2brzYT8DIaZ7yIrnZ+YRkWUqdzuFN7I0PClG4J4F YE+Ny6pWMxQYHczw4tRuvbfGMoTg== X-Google-Smtp-Source: AGHT+IEiQu9Jeme2n/sQnm8JEFIGovo1Nv5GbwR60x6Ql/B+HpXcyqpKpHxuzv2uT51+js7NbV0xwg== X-Received: by 2002:a05:6512:33d0:b0:59a:10a1:19d4 with SMTP id 2adb3069b0e04-59a17d64ef5mr7348929e87.50.1766666946136; Thu, 25 Dec 2025 04:49:06 -0800 (PST) Received: from localhost.localdomain ([176.33.67.19]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a185dd90esm5902388e87.31.2025.12.25.04.49.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Dec 2025 04:49:05 -0800 (PST) From: Alper Ak To: peda@axentia.se Cc: Alper Ak , Krzysztof Kozlowski , Andrew Davis , Greg Kroah-Hartman , "Thomas Richard (TI.com)" , Thorsten Blum , linux-kernel@vger.kernel.org Subject: [PATCH v2] mux: mmio: fix IS_ERR() vs NULL check for mux_mmio_probe() Date: Thu, 25 Dec 2025 15:48:26 +0300 Message-ID: <20251225124828.346114-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <5e5d1d25-2e03-43fa-bbc6-8256f31a1000@kernel.org> References: <5e5d1d25-2e03-43fa-bbc6-8256f31a1000@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_kmalloc() returns NULL on failure, not an ERR_PTR value. The current IS_ERR() check will never catch allocation failures, which could lead to NULL pointer dereference. Fixes: 4863cb2b0f50 ("mux: mmio: Add suspend and resume support") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Alper Ak --- drivers/mux/mmio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c index e4ddb1e61923..3409af1ffb80 100644 --- a/drivers/mux/mmio.c +++ b/drivers/mux/mmio.c @@ -101,13 +101,13 @@ static int mux_mmio_probe(struct platform_device *pde= v) mux_mmio =3D mux_chip_priv(mux_chip); =20 mux_mmio->fields =3D devm_kmalloc(dev, num_fields * sizeof(*mux_mmio->fie= lds), GFP_KERNEL); - if (IS_ERR(mux_mmio->fields)) - return PTR_ERR(mux_mmio->fields); + if (!mux_mmio->fields) + return -ENOMEM; =20 mux_mmio->hardware_states =3D devm_kmalloc(dev, num_fields * sizeof(*mux_mmio->hardware_states), GFP_KERNEL); - if (IS_ERR(mux_mmio->hardware_states)) - return PTR_ERR(mux_mmio->hardware_states); + if (!mux_mmio->hardware_states) + return -ENOMEM; =20 for (i =3D 0; i < num_fields; i++) { struct mux_control *mux =3D &mux_chip->mux[i]; --=20 2.43.0