From nobody Sat Feb 7 07:10:14 2026 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F68131AAA2 for ; Thu, 25 Dec 2025 11:55:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766663703; cv=none; b=ajjpj103DtwC/tnWVFZKEG517EKB2ageWfPki0Rulp8zaD7mOTQgqVhSrRzvv8cACOqHc+oQczVq4h592Lsv9wXMo30xIMfzo15fHh56zxM6l1/3vE9w7UhsNhfIDX6Byk62TYIc5CwFyLL8Mtg3uREiR3U1y6MQYlCpYAyhh58= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766663703; c=relaxed/simple; bh=26jbtWO1gui1Tg4M2KXsYQt7Cc6dhgtAwRsKPEv+q0o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=daLQpebBz0lUnwXgybmB2SWWERn1wTDtsMjUSesWQAg2hxdo6iu3J2jehrYUHUXDJJvUxll9TIX6ztu9J3Mi7qvLRPMHyxqWZYVrsRVoWSJcviqyMmhiwhzQgfths2R/n3AaiMEl7hveR/k+s4lDwud+sQKilDoEhYaImAw3iE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UYrSDPsI; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UYrSDPsI" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-4775ae77516so60879815e9.1 for ; Thu, 25 Dec 2025 03:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766663700; x=1767268500; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/1F0wCtq3gcx/BwLH3t1r9Kcjr/HuK/9IXAdL1YRX6k=; b=UYrSDPsIOk2yH5GzSgPjaP0uWSExvmdA0BWj2gh4Ec06KVeGFvIwymW4GGRFKswncl 9/EbpMhn98fDPigNYKW8FDZYRuy2EIOpYYdtmhZFFvGgRRF1hyesMdfMquwlcslrNSZ4 Qan+knk8xzIeeXcXGtFzMcY4tmWjbc33spgn4h5ydzGrSgC+dwSgVMutqZitOlraSlio 7Faoi3XLXT+wPShtr2V84KGwE9RQglBAoJOWYkE4RIa8YzKj5+B4BH4x6tJ5IIj1ojk7 gl7vrx0jY5CnGJlyFypczi47dVdHioXWGFuTOdqmbvJy369mVRwOwMOyb1U+Jr9NUfHk MydA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766663700; x=1767268500; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/1F0wCtq3gcx/BwLH3t1r9Kcjr/HuK/9IXAdL1YRX6k=; b=NYi45xxpGyJrjPMfjQShKNH4XfkTXrzLAvzpOMlVei03D4qUjTIhEZwWF0ktljwrvZ cdzcqQWB17Q45UNqLjAjQKpy8x97H8mYH4ojvYwM1ciShCYBUVAO7wQ+GEsIvi/MODIX QYkooX3mImLDvxOl1CYbWSCQDlGVnTRJa083Jf5YFostrJhEchjbzcmTHaZ2ORY1r4YO iw2Doa5i8JzkdbFz59p1Dfw+Abqg/UIGL5HSSJUsDWPO2alFc+h2mcgdp6s+LimD16jd OyMpz19h7y7BReLBEGw0TkVc9J6pd960Frz/RBSITOksOnWXPMjoCiScEaprH5ySn/3f x7ag== X-Forwarded-Encrypted: i=1; AJvYcCV8kZXp7Rqc8fx/RDzP+HWdB2aDkwQ+q5Z5MZLAgrP4+B5lVkXrLJDnEOLS+Q9bSPuXsuVQ02xXMww+alY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywqpuqb4CiWpmirv17kJ07gqqyzvkrWJhTJp6VHRZDScnl63NC3 Y/xTtkmh/G6veHPbKmaJRLb8Xx5H9l+guM0TZZzW+i31fBmuR9WkpuT0 X-Gm-Gg: AY/fxX7stIZVbFGDfkvmxPDKego+gBumEhgLykh1dvLyl1n4YYWwRc5Qm6KLXnpxKyI PoTsfRoSZnJMiUwu83JK7nCJ5jdzgCR1+kD/7dNyGLC5KFlRGlaq6JRVhXczb+R4PPfFPi5k+QP cwR3HqU/3Zm5jUfPW2CNIB+yStY5zfA1pRQRW0qBYK0bktCXSUAAtRysVOvveYVmnJJqlDySV4v z2bnKH1D1N543AwYd/wakDrj3d19nL1Q+Ml5ERVUN8GShdWkKkYx//7vWC4vod4fpjMzT9x+B58 s2KWCrIWDyMUgvbnVC2XwZJzUHsgCTmYTxINPQqv9d3ZWyGzX5ciI3+KuufGXUsM59speT+2uZm eCk+KUUWKnxUs53+TtihKjV78pTHotuoIKBTT2rmHL+q3Sf+S/IepYKLb/3HP3AQqYbQkpMc= X-Google-Smtp-Source: AGHT+IHugqS8KlGEruk1RYHem/ONDjxOPQtNAOoiwifvCDUQycnoRBKbn+/i8CRTpf+IcmvGYK5Qyg== X-Received: by 2002:a5d:588c:0:b0:42b:2a09:2e55 with SMTP id ffacd0b85a97d-4324e45d3famr19833686f8f.0.1766663699468; Thu, 25 Dec 2025 03:54:59 -0800 (PST) Received: from ubuntu.. ([2400:adc5:19e:d700::3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa0908sm39022593f8f.31.2025.12.25.03.54.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Dec 2025 03:54:59 -0800 (PST) From: Ali Tariq To: Jes.Sorensen@gmail.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ali Tariq Subject: [PATCH] rtl8xxxu: fix slab-out-of-bounds in rtl8xxxu_sta_add Date: Thu, 25 Dec 2025 11:54:29 +0000 Message-ID: <20251225115430.13011-1-alitariq45892@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver does not set hw->sta_data_size, which causes mac80211 to allocate insufficient space for driver private station data in __sta_info_alloc(). When rtl8xxxu_sta_add() accesses members of struct rtl8xxxu_sta_info through sta->drv_priv, this results in a slab-out-of-bounds write. KASAN report on RISC-V (VisionFive 2) with RTL8192EU adapter: BUG: KASAN: slab-out-of-bounds in rtl8xxxu_sta_add+0x31c/0x346 Write of size 8 at addr ffffffd6d3e9ae88 by task kworker/u16:0/12 Set hw->sta_data_size to sizeof(struct rtl8xxxu_sta_info) during probe, similar to how hw->vif_data_size is configured. This ensures mac80211 allocates sufficient space for the driver's per-station private data. Tested on StarFive VisionFive 2 v1.2A board. Fixes: eef55f1545c9 ("wifi: rtl8xxxu: support multiple interfaces in {add,r= emove}_interface()") Cc: stable@vger.kernel.org Signed-off-by: Ali Tariq Reviewed-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtl8xxxu/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c b/drivers/net/wir= eless/realtek/rtl8xxxu/core.c index c06ad064f37c..f9a527f6a175 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c @@ -7826,6 +7826,7 @@ static int rtl8xxxu_probe(struct usb_interface *inter= face, goto err_set_intfdata; =20 hw->vif_data_size =3D sizeof(struct rtl8xxxu_vif); + hw->sta_data_size =3D sizeof(struct rtl8xxxu_sta_info); =20 hw->wiphy->max_scan_ssids =3D 1; hw->wiphy->max_scan_ie_len =3D IEEE80211_MAX_DATA_LEN; --=20 2.43.0