From nobody Sun Feb 8 13:17:13 2026 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38D44229B36 for ; Thu, 25 Dec 2025 11:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766662887; cv=none; b=lkteCHzLZa5d+HrAXDQzfhhAzrsVNYPDi7rY18LXOEbz3/9kQZMxs6n5OT6LRlRy+GPgrLKYER1Q1qoF7ldVKQGCdE1CSyhAeVYQ1L//azL0Gn6DqxIfy5qw3Yi6i0/lBUOQuWfaoim5I+3PKUS2qHi7IOnxbb+jgloycBxtJFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766662887; c=relaxed/simple; bh=Hq3Fki7M28im4c2dD5e3nAC3EXxMAOsaruZpZhU2A44=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bzTIRqtTltNmXNveavyjH1qIrnZzREmiIGS8IEyAmagdWLZz1cNY3k8B18pTpM+9xgySiIYbig86EvjD5kdBIyi3xSPcApYDTZvhtht3etcVhpv+iX7Od8VG/y8KPZJonQ5KTkLKtrf+zl54fUJuxSFnQx0RpBChmNO2b5KXy3Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jq+UYwh9; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jq+UYwh9" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-59584301f0cso7152395e87.0 for ; Thu, 25 Dec 2025 03:41:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766662884; x=1767267684; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yWJ/lbL9g/ITxgljOQ0iNVw5yEDd5W1KHRhMdXWsHKY=; b=Jq+UYwh9z1mckcnPWoPY1MUleNzxh4uGs9R+go73Jhz11bvSIoxp/qhD/FTIVPJpHU ywx0GTqfKQB+O49QOmXmC/Vq32tVNMECwkn56GNpdNKD+3KdXOKxnCX0g2nVUAadQLV3 n5yVFyHAB3AEW+2o6vb9YiMlM/+e8K7va5Jv5W/00n/50SM0ibDZnYc/eIAiybCTmYrK VAwJOqEVT5k7+zng4c5L/2g/We6jGp4sSYK+hlJvO1FfqVQHQgAXqrEWYrEE/Flk3nJ5 xzjjnKWfy2bMFbfcdxPpV79ASKgVLvnmaV5FZplcciMqhafX64IVaj5GH2FiFyuMkH/5 42TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766662884; x=1767267684; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yWJ/lbL9g/ITxgljOQ0iNVw5yEDd5W1KHRhMdXWsHKY=; b=PitKlC2vP2XQoq7WkqbaKWMl6liC+xMd2LLHSIJbzahLHjKLhQyzrZHUKoOELWh+og tuXq2ZODNQzkRsJClgsI8oEfGfJE+WRKPxyjiJaUIKhD4U6Iwd4InkbFVkKry1nGwBav pm6notQXhGMdZUavRkPdGUDrPxWCWcA+L1ZTWy3LHocnWJ8hABBdpJvJVVdoKum38GRm bD/jdQcO0IFloOJ4rSLUBmvuccMa7KEBd8Jh5AlDrTox2xtHWIgkGlrZ4HmWzcvlrM8f 4hDxepEfpejvMasnxCGVHvHII451G6ROusIZjog/mxKaT43T5y41NFipDBa/YBS/mrTe xxzQ== X-Forwarded-Encrypted: i=1; AJvYcCU8WzBpF1JFpmq3+uz1Y2hvfVOfEDHwJohacINWMFUgkzymMfc0HxZ7lzXsRepgtbUnF2dK2L6gRJ7Dzvs=@vger.kernel.org X-Gm-Message-State: AOJu0YzCWorTwjwzutkgB2M4Cd2t9iRsrLRWzeElNPjxS8OxMw/eLTPq JvpJg7q2HZMdtMYfFmcsk1YmNqJRj7Ju/Layy1MZ3hlO1QADZ95eEwfi X-Gm-Gg: AY/fxX5P01jnsYj28fxPW+Hd4LZaIr6ep37d8uyaajNuEc/eDvyBQR5aiq5JxMTMK3N EnIeZr1NSdsYlgMoBiOwiBvhbuwX1RnCcCLhnvKkTTUnmEVR9McwVdoejMTKINcL2tOo5XRob3O SyxcyLEgfh0Tc5nm/npJY8jsmgJuiB2vxZqztreA+AMsi2aMiOivit6fU4n3OdjU6jbgcHqfK2L nv4qmIvgyWL+1oQYBfLx72Er5iSrk50BKgSUJhavJK+SRppdsJaKAhqV6qrJxe4ZTzrGVSL6i+B O1XE9/3Z+3fkgH9Dwsf4iG9LTjQX14Tqnu4AT6PJ4SZZJV4ry4cOsVIbrgwFngubIwwYPrLykZZ NuTl+b49NS9HUP/8wgG6JLvX7NHcO/z38NlC+osTqH0puomnT0iQ7jBjzvqiHk4yrfuk5xABvvi WOe9MZZqVkHgg8fB/4tnk7R+81VA== X-Google-Smtp-Source: AGHT+IF+1H6YuEHxlklB0EW5ALFHpUHt6lvzJAChH7Ot8G3r7ehicMjHUO/7SEE+MKPGmOUdoQhaSQ== X-Received: by 2002:a05:6512:3d0b:b0:598:f1b5:ab9c with SMTP id 2adb3069b0e04-59a17d57640mr8912857e87.31.1766662883954; Thu, 25 Dec 2025 03:41:23 -0800 (PST) Received: from localhost.localdomain ([176.33.67.19]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a185d5e32sm5640449e87.8.2025.12.25.03.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Dec 2025 03:41:23 -0800 (PST) From: Alper Ak To: peda@axentia.se Cc: Alper Ak , Andrew Davis , Krzysztof Kozlowski , Greg Kroah-Hartman , "Thomas Richard (TI.com)" , Thorsten Blum , linux-kernel@vger.kernel.org Subject: [PATCH] mmux: mmio: fix IS_ERR() vs NULL check for mux_mmio_probe() Date: Thu, 25 Dec 2025 14:41:00 +0300 Message-ID: <20251225114102.337593-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_kmalloc() returns NULL on failure, not an ERR_PTR value. The current IS_ERR() check will never catch allocation failures, which could lead to NULL pointer dereference. Signed-off-by: Alper Ak Reviewed-by: Krzysztof Kozlowski --- drivers/mux/mmio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c index e4ddb1e61923..3409af1ffb80 100644 --- a/drivers/mux/mmio.c +++ b/drivers/mux/mmio.c @@ -101,13 +101,13 @@ static int mux_mmio_probe(struct platform_device *pde= v) mux_mmio =3D mux_chip_priv(mux_chip); =20 mux_mmio->fields =3D devm_kmalloc(dev, num_fields * sizeof(*mux_mmio->fie= lds), GFP_KERNEL); - if (IS_ERR(mux_mmio->fields)) - return PTR_ERR(mux_mmio->fields); + if (!mux_mmio->fields) + return -ENOMEM; =20 mux_mmio->hardware_states =3D devm_kmalloc(dev, num_fields * sizeof(*mux_mmio->hardware_states), GFP_KERNEL); - if (IS_ERR(mux_mmio->hardware_states)) - return PTR_ERR(mux_mmio->hardware_states); + if (!mux_mmio->hardware_states) + return -ENOMEM; =20 for (i =3D 0; i < num_fields; i++) { struct mux_control *mux =3D &mux_chip->mux[i]; --=20 2.43.0