From nobody Mon Feb 9 05:10:42 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ACC5247280 for ; Thu, 25 Dec 2025 11:12:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766661161; cv=none; b=L6lFG8jkWTnC5KsHY2bm8dMBVfKuFitLsyCbfzSzp8bGTPg/2zCApoHy9qa8SRex7/Ca7+KAD+m6vV0ybN+kQ8eKhsSbw1zi7fbvLpFkyWUYas5yM2edtLMHZoAujE38crKN7TLWWmistfI9XziuZYNX87uaiidiUM/DKCLEFSg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766661161; c=relaxed/simple; bh=fWih+GeN/btVtE3zzGc5QXGmWWS+93NnFRq28TrHLkc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cYr05XGxPN/ZfCHwpO8wgSrEfZW11CSpIvwzpeIhU8wEpYr16CzivfFanLstX03ZwFaPpkyvGT+ZsGKyTUxdRljvEyPTyXkN3xLr9I/2ZxPAD5X3H43HeMMKLYGZt/otamKO2pk1FmsZgrhu1BTOb3pENvXm3MIYmsrjxGkFD0s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=WwbGaJUw; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="WwbGaJUw" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a07fac8aa1so70295035ad.1 for ; Thu, 25 Dec 2025 03:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1766661158; x=1767265958; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=c8rC0NjEHEkMrOlMvUbyxEpQ8JhLWqfqRz2pCbhpo6A=; b=WwbGaJUwVZsOygU+AxrUALYdHyi3MXtmT2HFOZ2j1kPBab3QeMuD6Sror4sB/ARDV9 3Wz5m1RQ6ACK79wEx4RdTsZTZ73DcPccWKOOSRtEa0VEzWSPbDT7YJdw5OlIhlUz51wD rkNzuXmxGo2Ry2BLay/wIymxZqomIp0b47yEhk2eAiJmAv3pdAJOLH3IaKLzP8HaN8dr edYKxAQIZ7QLsMH6eM0sVD1f5/JuAPhmJGLKEwQy7rpHQklXeRYgdmX0/VslS1E67D+K eiuN4wWaMHdAp2dj5FKzsoVcan9E71nFNIGGyvYF8HpfaN8TV37nBqJGNvism/X+Hfon AGkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766661158; x=1767265958; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c8rC0NjEHEkMrOlMvUbyxEpQ8JhLWqfqRz2pCbhpo6A=; b=TK/Jx5v5Q/rUpn8hHz6Q7BA0cRDmWMGmBSPZ0Q95E1rbyYXEaBe0xTCMnFb0En9r4a X//DdAJUPvmSGn8C9+bWeiTqZotaPO4/SktI5i7Iyn62tjEImUYW2qaTMOTOtyMKLL/F peC8hON9SXhZLmUzRm2uZnRPBmOpY/EBOGq6zR8k4Et1l1ZuCDJtZh/nn/73ZzfqFs/p bOZ7arzAVCQXZo+NzAoHGQ6A1yMTTjb7b8vND/pFBQ5xucRNv55ZfJR03YbOkSn86xys ltvVnCgGiLByYLq+zrLRzqJHwighmk4xeTdtm1ehJlBevtvmR8W0uMJelzAwlIMwYUdu ovxA== X-Forwarded-Encrypted: i=1; AJvYcCWV2zGuvHupk6bSNbwt9ul5FtMy5ZSSsDcJkQMjvxDSuEswzDIJsa0U5okSksJyPONejFIMksQhaAgvSBI=@vger.kernel.org X-Gm-Message-State: AOJu0YwLsz08wpm8rmre0bQ1Um5X/vBwLMqDRTbxDhhPg+FWOByLZkLJ KPXRajMLVjVRdi91uXqfCGBKn0B2KJdhCBBD4CfBuhzMAac0v1NH81wL34yblxxOoF4= X-Gm-Gg: AY/fxX4LlatoPWpVB/qU1QvXu+DUOffpXGbDYoPjGr3kX5NsrSeU3brt2LuNSlXm+B/ YCh9XJclUqi4aK4vqyekObZcQ/7qilosrQ9aRFCsftz9TN1xHmapiGloNGg/VTUkNrdOGdF9X0o E0d4ZEqSOsVgX6LJ7NSqjx4+Pz+iuSnF9XZJ4q8Fw7HxlRJnPkJ+44WRyvKFgCyA4Ns6lij1t6J 5zxCquoROaF7vpdA+PyJxihoZw1nvHWyGE7VpoQ67bf5NmnEetUaDr/f9URVNDGd4Qb2D4Zg/CB tv4upPGDy4xSBq7aJvIDxETVh3LwKndZ6XQQTcCGq5xmLhoZE+mUyDPWIKC5mXVXzF5oxH5N7b+ 8oXAcA/YiCAs6LH9NzRerS7yfLmGh2U9gLvubxMb7KcRS+CXCfcOpeue8uBxEk6oUkuqqrGj90p NrOadoQAw8u+NKGT3pEmR6cQzOr5FLMNuq0vaWMaDuQyEdO2sQXg== X-Google-Smtp-Source: AGHT+IHEinazSAxloNFVF8ro+tQ1ra75Fqr+Ad6+Eap54YpbI8TnTg60lqIFc5WBC0cxES0ohWy8hQ== X-Received: by 2002:a17:903:298b:b0:2a1:5f23:7ddf with SMTP id d9443c01a7336-2a2f2202fb9mr216999835ad.6.1766661158409; Thu, 25 Dec 2025 03:12:38 -0800 (PST) Received: from tianci-mac.bytedance.net ([61.213.176.5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d4d36esm180734295ad.63.2025.12.25.03.12.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 25 Dec 2025 03:12:38 -0800 (PST) From: Zhang Tianci To: miklos@szeredi.hu Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, xieyongji@bytedance.com, Zhang Tianci , Li Yichao Subject: [PATCH] fuse: set ff->flock only on success Date: Thu, 25 Dec 2025 19:11:56 +0800 Message-ID: <20251225111156.47987-1-zhangtianci.1997@bytedance.com> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If FUSE_SETLK fails (e.g., due to EWOULDBLOCK), we shall not set FUSE_RELEASE_FLOCK_UNLOCK in fuse_file_release(). Reported-by: Li Yichao Signed-off-by: Zhang Tianci --- fs/fuse/file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 01bc894e9c2ba..d83ef81e3b9b3 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -2563,8 +2563,9 @@ static int fuse_file_flock(struct file *file, int cmd= , struct file_lock *fl) struct fuse_file *ff =3D file->private_data; =20 /* emulate flock with POSIX locks */ - ff->flock =3D true; err =3D fuse_setlk(file, fl, 1); + if (!err) + ff->flock =3D true; } =20 return err; --=20 2.39.5