From nobody Mon Feb 9 07:52:11 2026 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEB55313E1B for ; Wed, 24 Dec 2025 10:44:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766573089; cv=none; b=fduPxKbdgY/a3OagPbm1mvm4Z6N4bgzi0FhhKz+wIVGtb+JDlNjP9704cXte4AaL9uftubrHjS3CnhLuV7qPIBo3Pd7WtDaVXNGf+MJil7VTx1vkj8zcQPv/lUFz7TwpW3jfXXi/GwY1bqzN0PlkJ55uzmXRI69jqI1S51gxkes= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766573089; c=relaxed/simple; bh=Fp2FxcrKltPHhZfR2NOl3f3QWT704sWKyN7CUrRt3k0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=X1matesH06LDrxBWDIl2G9v2EtKLj/LYoYhXS56wGGvwAkT9bxLJgBmKSefGwuCyG7MtjfB9PAYHjIjn/ZlzVTrAcTFxaGdV3XrqEl/b2J/JxEw9eo6Smql++RA/cvxt0a/6YvkwH1Qp/JM3E6iFksqOW7btCZ0D0F7RbpKpYM0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.209]) by APP-03 (Coremail) with SMTP id rQCowAA3WeATxEtpyZ7TAQ--.6889S2; Wed, 24 Dec 2025 18:44:35 +0800 (CST) From: Haoxiang Li To: ioana.ciornei@nxp.com Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, chleroy@kernel.org, Haoxiang Li , Dan Carpenter , Su Hui Subject: [PATCH v2] bus: fsl-mc: fix an error handling in fsl_mc_device_add() Date: Wed, 24 Dec 2025 18:44:33 +0800 Message-Id: <20251224104433.1585576-1-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowAA3WeATxEtpyZ7TAQ--.6889S2 X-Coremail-Antispam: 1UD129KBjvJXoWrurykCrykJFyDKr4kJFWUurg_yoW8Jr43p3 W8Za4kArZ5Kr1jkw1kZrW7ua4YgayDK3y0kryFyw1fuw1rXFyFqrWSgw1YgF1UZFZ3Ca1Y qFnFy3WUGF1DJrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkG14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWUuVWrJwAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r1j6r1xM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r1j 6r4UM28EF7xvwVC2z280aVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4j6r 4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY1x0262kKe7AKxVWU AVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14 v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkG c2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUBVbkUUU UU= X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiBg0GE2lLmTyK3gAAsN Content-Type: text/plain; charset="utf-8" If device_add() fails, call put_device() to drop the device reference. And put_device() triggers fsl_mc_device_release() which does the free. Thus just return after call put_device(). Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/b767348e-d89c-416e-acea-1ebbff3bea20@st= anley.mountain/ Signed-off-by: Su Hui Signed-off-by: Haoxiang Li --- Changes in v2: - fix a patch error. Thanks, Christophe. - add specific changelog. Thanks, Dan. --- drivers/bus/fsl-mc/fsl-mc-bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bu= s.c index 25845c04e562..f976c5a24151 100644 --- a/drivers/bus/fsl-mc/fsl-mc-bus.c +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c @@ -896,7 +896,8 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc *obj_desc, dev_err(parent_dev, "device_add() failed for device %s: %d\n", dev_name(&mc_dev->dev), error); - goto error_cleanup_dev; + put_device(&mc_dev->dev); + return error; } =20 dev_dbg(parent_dev, "added %s\n", dev_name(&mc_dev->dev)); --=20 2.25.1