From nobody Sun Feb 8 16:11:46 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6693D319851 for ; Wed, 24 Dec 2025 10:53:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766573631; cv=none; b=owW1Pcx2XuN+9Wx+HDIUy2Cd0KDLAjLW1otU1Mcef5mQSvzjdhrcMlU/tG3EBJI7dCxUpDkfmLz/LBNl1Hd9KAJAodZd4tShy0JjtEe2yVaAEmM/CsIcpQwsMR3BSM4EkX789SFxlMb6qC0rjT1lNOuMzBiRQAFxrwdO18Uexwo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766573631; c=relaxed/simple; bh=2itzp5Me8KCm4wDk0c8WCgo+rJvV4Ir6J9SaNy5gByE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RSiCe6bIoz6jaa2zGbSlE5MxEYVAia7wVuYUbYJYrxPTlKjYBKnOoed/kil63iGk1mNwPgFRLEpjait4jUNghi2bcka1Bx+zDBBykBdMf0PNQrZ8Hcc6YRwtfkAZ+wcBIUnS8gGdpPtQLOddiJGXyzYEAgyvsE0H+JNrUZfMlio= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CgoaKCA9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kdJViQXm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CgoaKCA9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kdJViQXm" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO9WGvV700570 for ; Wed, 24 Dec 2025 10:53:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CUEk8+imaWpqVm7FWfHPYemNpfkMDwtBIiNTxavoxlE=; b=CgoaKCA94ePw+UKL myGNpF/1AJWyBIhgjY56YvHr1Lbup1cbeOprAmZ18owkeirocUlqnB+jk6qsYTGY mv1yQD1tUh+4maMpes0PMZNlCr2KR6eHq14Db4MCgLh2vBoaYr5OmmV2Ss+N9xln sv4oqBxfb6ncegvl40mphyGjFLnrTY19qlcGvsdAcnz1mGm5wXz0DFhQPaIfIgGu DNEcOLgYdOKJqbjyBlOb/gTghM8DEv2ZqpYQZkLY/nDz5xJSFZgxpXl1gdWwyIYA fqGe7ggq5z8eQ3aqPra/PQaa18P28fCzXg1P7wv42jrsFBylHpOfJO3o02nZ9xSc C5vozQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7t7jufy5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 10:53:49 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ee21a0d326so35093511cf.3 for ; Wed, 24 Dec 2025 02:53:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766573629; x=1767178429; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CUEk8+imaWpqVm7FWfHPYemNpfkMDwtBIiNTxavoxlE=; b=kdJViQXm4K5DVXazsm3a6e3ChKmUSy9F5yotnE+RejnW9+DYDnTTwyqrqRy8FSZMJr DQFK2zkyIQ42SX8rfRvpHiZabWWL98W2qKH6ATC+N7dF1UuUEulWZ7WNd9uLXStK+00j AoSBPrvHyqnA7hQEYbo8tm4A1yi1+ZCcsZ8ULKC8b0G+oACvyq2XpQ0ZW0YOUXMrSC+1 +25lQVolHwGZh0uNgzRVNa6qC7R+lkt7i3bC8PmmniiV6hYx0/oovilivb1SeeBuVdvw gIxB2dxeC7uEjFF4M6UrBbEXaLqMyOrzoAtMkv9e6G1cWK6E8Kyh/I1ICBkilNQpk4RZ F34Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766573629; x=1767178429; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CUEk8+imaWpqVm7FWfHPYemNpfkMDwtBIiNTxavoxlE=; b=tl/Cz5yo0o+7NA8Q0BrNZ2GIbQVFkeouCbp6b9Tsvecnff79HzwtZz2noSEGIF0VT9 FDR0JXKjVgxU9s+TMsTqCzsB5hQ2yNV+cCfpdMqhayz3YC5Pg+dRrDNbhcN6NHY1fFeh LrvbLkpMeK3dzYqV2aJeTh3Nxpys5PTJaWoWTVJ9T/2FzB5kxg/7UAz1bo+RKIOA715i 0RWtaZ4HUqbAhZIi4HSNNdVbvGlc2e96MAwtibEgvV9gDGFZMyb5bXVb7+oFH9zGSsr9 mnvCDQhDsfexlRlNNQfjbaNTVM2U7L0L5uC5Z+2UKQS056egAEJgr9zVnFPyX7QiarzZ 3X3w== X-Forwarded-Encrypted: i=1; AJvYcCXyBzDKW1haAAuImnfztIYrZ4Tmkx2bAfxJdCFlM4ineeqRxGkal1T13b2fjVqGUVLRzaW9Ye9UtzI7piQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwN5h5SHyKSMBjT+rq0EKrpuD7yZCToc5z1WwuHAhcfCm9KEwm3 0oi1sZ4GJPwMRVQj8I41DjwVd6EaEpN1YtsxcxXB6hiXZEU362QIIeMXE+sS7vbg50dw7236T4Q PLFN4Bn9w4wMZRkul46N4GCeS4FaJWkSsqQK1NlF3yP2BLKIhX/Hp24dJBxmPAQsBcwfS+/ZgW0 8= X-Gm-Gg: AY/fxX4r+oJsvSOReiuw/DhHZsLmd70E2qrnURv+UO9Qroah61jwiz5Sd7U/39bk9Ck NIXgDiurVlrahEiGIzfu58Iq/6S8Pe5BYhwsnninlvSBNE0YjqRm72TaFyVWUUhKmQFdTABUHhj mGC7R3lvPFq5R+Bvlx17gfgM499Oij1vnIF3JiQ4nMlqlHk1E6uVPIRvKXAtXWskYSxJEMD6Sfq BEbbUycTxdXUWp9zzEdTepHhPPDkaJDDUA5LRDzXmr9vlwZM4ANQRWmmEazIPWd+qWXBsm7iVBj ZYffeuKswLMwrsv8EG75f/XMfHsUMveBlscKq2zwus0zF53YFiFuAU/H40XNzyc6o+DbnRdTNMM t8Ef5kYfSdh9G8RM= X-Received: by 2002:a05:622a:190a:b0:4ee:4709:4c38 with SMTP id d75a77b69052e-4f4abdef53amr258485981cf.80.1766573628718; Wed, 24 Dec 2025 02:53:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IHOA2TrTt3Y5Yxhu2gzHGVIVp1sBaU/3OkerIWR4tWgNUNp5QoeJ798knCt9F7yBPv2aHBA7A== X-Received: by 2002:a05:622a:190a:b0:4ee:4709:4c38 with SMTP id d75a77b69052e-4f4abdef53amr258485851cf.80.1766573628268; Wed, 24 Dec 2025 02:53:48 -0800 (PST) Received: from hackbox.lan ([86.121.7.169]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ab86cesm1737562566b.19.2025.12.24.02.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 02:53:47 -0800 (PST) From: Abel Vesa Date: Wed, 24 Dec 2025 12:53:27 +0200 Subject: [PATCH RESEND v5 1/3] dt-bindings: phy: qcom-edp: Add missing clock for X Elite Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-phy-qcom-edp-add-missing-refclk-v5-1-3f45d349b5ac@oss.qualcomm.com> References: <20251224-phy-qcom-edp-add-missing-refclk-v5-0-3f45d349b5ac@oss.qualcomm.com> In-Reply-To: <20251224-phy-qcom-edp-add-missing-refclk-v5-0-3f45d349b5ac@oss.qualcomm.com> To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Dmitry Baryshkov , Konrad Dybcio , Sibi Sankar , Rajendra Nayak Cc: Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Abel Vesa , stable@vger.kernel.org X-Mailer: b4 0.15-dev-47773 X-Developer-Signature: v=1; a=openpgp-sha256; l=2068; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=QrTjRJ8nYr9W6PrQlc/hk+jiJqNSvuKkuj99rkGdvAk=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBpS8Y07FYpe5du9vHER+Ym7O1WVf4E+/pH9ssJe C592AUFTEKJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaUvGNAAKCRAbX0TJAJUV VvUsEACwiVci0YOxDy/aKhNSSkugMJ50g32aB3/YY75XR3PF9Ts7qM6Nox75klK/54Rblt5W/uh YlgZcdbn4bEk+OYaCuNtZFN4PnoJHRqWisLTp53jKDVKFQBTepE5BoU7IED/8V7QtCoYWEiSNVp 1XfjePDDG2Z1LwanG6NN3NqVXeS1cwAveOIR/fCH3ANx4+N8LVm5WTNvCxelf4pugpzfQn/Ksd5 EE5rkx/UNw74zMqk1xbd7T4VeWVhhV/QvnLHIYROp8cLEzX0zljRHdi2kEFSdyiLZH9FhIN9V3F VkHQfZeYuTVegHXZnikINHMl6dHQ9rl8qyMubsGqyYz6Ss1aOSMg1mMVA+nwYRKmpBDgVmJ4i4p BS/LuamWSOBlKeFsLCnG73WVwy7Ld856t7eVkLxaPYswyOrMBD6PBc0RdohtFvhn5x9l66m5ALn kGKyE1tz2KL8cagudV2tBvJaRg1b7NPUVGFAlcwmAza9EaSmLWCZ1aSI3sFwVBkjBndXRwwJCTM g3NCvPW9CEMjID4HuHHdYKSLfbougUg60iXPl2bkTon4SIAc+h9UsxOlaA0yvu5AiW0Ms7dcgGE c3+/H4nYN/wTVbyKOkgx7oOt4TzG5KCCKLxaLEe5eDbqe/XjPoAnEruskQmetsg6R+3FT50dXAr enAlRRk4ht4RhmA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDA5NCBTYWx0ZWRfX+fhuj6sbNrSR zXHOqfSlvTPTw00DAxCf+DHFsQZcqn8zWA3HG7/ApW1y3OTzQSMKA+4p3dT0ODLF4z626Zd3pfx ltE/1tSHuDt7aWC3lBFEYbwP+CrCCse8dAMEoKVdhqyYenwUFKZiAyvWH/qhqhfN3BYBJ3d6GRc FHKpgX1VOJmcfJPqbT1uvYzgVwqCr2yCkb7oWOkWQOlB14SvtW+yk+h2Ho4WV4sNGKVB4KsKjQg GyUFKZ4ioJjyq3yDNSDfv31IqgNXaj88SJnCeWk+uX+RA2z3ur9wsMiOZVQyi6GgQV1j8W8uKeW CVMb1Dhnq+ehGwUKN7bamFKj2JNgNrjKfHOLZ8ufWi9boWgvNRqDHbzult6Q2o+iqlS34CWcmlt 2AMNpcO8Hprsc+6iqOZkNejPFh5vS2ck0PRwqZRbad/X+h90wsMTseFAOofv6ZEiNYgZwBp6lj3 nBGNQsr9EPo+otDSeYA== X-Authority-Analysis: v=2.4 cv=IvATsb/g c=1 sm=1 tr=0 ts=694bc63d cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=DdBtMnqNxkYIvXj6ev4VzQ==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=VwQbUJbxAAAA:8 a=tBDzFmnqMxbdcKwNnfgA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: xpg3XJZTwwk16nNUHhf38H_FLcl2cV9a X-Proofpoint-ORIG-GUID: xpg3XJZTwwk16nNUHhf38H_FLcl2cV9a X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240094 From: Abel Vesa On X Elite platform, the eDP PHY uses one more clock called ref. The current X Elite devices supported upstream work fine without this clock, because the boot firmware leaves this clock enabled. But we should not rely on that. Also, even though this change breaks the ABI, it is needed in order to make the driver disables this clock along with the other ones, for a proper bring-down of the entire PHY. So attach the this ref clock to the PHY. Cc: stable@vger.kernel.org # v6.10 Fixes: 5d5607861350 ("dt-bindings: phy: qcom-edp: Add X1E80100 PHY compatib= les") Reviewed-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson Signed-off-by: Abel Vesa --- .../devicetree/bindings/phy/qcom,edp-phy.yaml | 28 ++++++++++++++++++= +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Docu= mentation/devicetree/bindings/phy/qcom,edp-phy.yaml index eb97181cbb95..bfc4d75f50ff 100644 --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml @@ -37,12 +37,15 @@ properties: - description: PLL register block =20 clocks: - maxItems: 2 + minItems: 2 + maxItems: 3 =20 clock-names: + minItems: 2 items: - const: aux - const: cfg_ahb + - const: ref =20 "#clock-cells": const: 1 @@ -64,6 +67,29 @@ required: - "#clock-cells" - "#phy-cells" =20 +allOf: + - if: + properties: + compatible: + enum: + - qcom,x1e80100-dp-phy + then: + properties: + clocks: + minItems: 3 + maxItems: 3 + clock-names: + minItems: 3 + maxItems: 3 + else: + properties: + clocks: + minItems: 2 + maxItems: 2 + clock-names: + minItems: 2 + maxItems: 2 + additionalProperties: false =20 examples: --=20 2.48.1 From nobody Sun Feb 8 16:11:46 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9894331AF1F for ; Wed, 24 Dec 2025 10:53:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766573634; cv=none; b=gc0Mz0/TIIm4cXWC/5FAooGlo+nyY9BOjppobIjZE+mS8DeArKN8Ng+LstSyWTFUS59TJv3HFQ1GlroVmHyFXczl0XB0DDoBQDeUGej9Cj/3+R/s9jeLphlLRn2ACqQb3UjXsk+J+o8V/HJw4tJ55/N+P+xA5bEo/8RbgVoPJcc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766573634; c=relaxed/simple; bh=bxYoB26qnmj1wJa8A52BhszHwAFpiIelHBfq+pQWPJA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uUm0g8OPbzqReUKBxa90hVYTGQxGOa7NBUuknVxnIi2qLZV4Vwb9C950So5VinoukzwVdh9YMCI8GoebyrflxkJ4JXwLmejR3CHB0p8L/XPk8LF5kXXChfhYr7vZPkbpnUNczUlpS7brH4+sSsmoBgGPYGj8qr9jo0iGsK5Thmg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aFoXftVK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dUgj3ByB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aFoXftVK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dUgj3ByB" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BOA58TJ559752 for ; Wed, 24 Dec 2025 10:53:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hr/7NsS1XQJHFC/38XgEfnNBmTNHIdsl1ejxyMyLWLE=; b=aFoXftVK8dqnB25s n3209ZWtG9xELZkESnJOgLQWwA4g9f6cbfQrD3tnQY5sYTKgl2yytQT2bd7YBVXP D3uh/jgu+Kq1hIwjvi4/QEH7dD7VR5F4tcO+KfXU8eNlwOnd9Mu1KJbXUXH7K6yr Jxae1zU9QIcPrgV2ajp1ODwvnChl29dhA2fnAkLBISUlQgM6dL3yK/pOZD5D+12o gfeV7qZDJrvFxHI2oWUP5kjiIjC1rCM9xA9podiRY5ySWPa0TJsaHQlpPpmE3pE9 VZhxY4VPqm7WwofuF2GElOkDU2MKjB36caUOYOznCsxh4+07y41Ajx2sg60mXbKN 2PdGag== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7u9cuajy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 10:53:51 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ed74ab4172so136545671cf.1 for ; Wed, 24 Dec 2025 02:53:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766573631; x=1767178431; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hr/7NsS1XQJHFC/38XgEfnNBmTNHIdsl1ejxyMyLWLE=; b=dUgj3ByBTUAI6SE7DLFNLTpyrGvZ0z/yaZNpu0tMdPUzhOi98abso9Rg8X9Gsk5VsM J+ahkM2q7SVO24kMcWcvUZwuoQhoRzaxa/bX86Q9EXzX1aFReG7bSGll/TY71TGHIX+W ALizbIU6Ei01lhryTOdm90YIRpm6qr4Bd310P7+0JVMcYMucdGjlHs6Qldvn2vyFXi3+ QnN4yLW5kGj0V/VHedtuKlVcRVb8Lj+tOiW+Ax5Xzp/3Gh4654xt7CKUpsoiFleU0SOg L/Ojc6thX4damytVsjDYLWHHad01TyrGLgxY/TWfjMSbN4iL4btLObhem4l6HKrtQ0Il tSGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766573631; x=1767178431; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hr/7NsS1XQJHFC/38XgEfnNBmTNHIdsl1ejxyMyLWLE=; b=mJ8LX8yynhR5PAuh1KhhAzAZDCMeDPUdQayeucIHr3HaswFk1txXshj+VA1eCqlO1i 56yoJ068E3gBYoTzNmUpOKyP/1FAineP68v6h48lrOVr50NhKhjny4RJi9Msd40QJaza TbkSN6K+MD+Zr+T4ZO20xSKlEhrYBsuSkj+xa6uQ74s2UD7P2odpzEFuMq4CnH9g+RHI delqVo+1NyHmgAV33oZTJdiPW/m9th2726x3W+wmHRuORJTSPeYWZQknDJ8XipYQMjv7 0MY9bnNMY46sx+yOXcEDV2tkqPoK+S44aryyarTp/6MPVFt14MYwOmZTAo9G2m+2qVAU vayw== X-Forwarded-Encrypted: i=1; AJvYcCVNsdmBW0wYP+zg2PNGX8HGCleuM3WrTIa0Cfg8cvQ5+78QQx3rS+OnCjl9RX9yDHKKilWs8sOTAcBU450=@vger.kernel.org X-Gm-Message-State: AOJu0YzhlKlQspWuwi6pz7mo9RS+dyyCnS/4iJkmNEBBbT478HqBpcmN Kpq3UTV63AWdVOwy0S0SLvhOu/b78Q5StrWT9/GuLMVfJ65gyZk8KfSzojxWzTXm9Xijsci4VHs QsSmBR+Jnm8zokme31R41k5NkRCH03om/FoHanjUpeXrFulSwumePP0qmoNcBaP6AuXU= X-Gm-Gg: AY/fxX4mIqysNI1qe1dgfj6v9dplGkLPcOdr5WLgZ0nL0FxY9mMaJh4Hk4kcvZtb08P eNfK+T+oyXUx6cMlan/yKy2jhItQKX3OYfqYegOkRhtUiMav4k5vaFSlcSd4M4nFbUNuFpcyy72 iZdlJf7i0+Uk+q7dVF0Wty7LD8xXg3jeCPHysNZzjY5uO6jPq6HhLME38cdrog8Dqv9bc9DxiCn /2Gjl0QMFYNbm5sFHqTf27nFEJbdnqXnf2nMPyzrCyYFqmzt2rLk0XHeqHbHyKWzlZ/eGJo75wN QVIpa0Xh/JLf2LeV27FzGhEoYm52FtmgQkvQUya3EQHyVRoslWDVkw5WyJNELBRCykDSZhA72Z9 yfSw2Hw8RI78JQ7A= X-Received: by 2002:ac8:5dc8:0:b0:4ed:a611:2da2 with SMTP id d75a77b69052e-4f4abdbc5a8mr227117761cf.68.1766573630702; Wed, 24 Dec 2025 02:53:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IEVBYCcLZ1f6Aw7cn/TjM2tmGLFQOnwpJLvg+fIhrlxkxbQOEzTY4C+8wmsA9u5pBmR/MOFSg== X-Received: by 2002:ac8:5dc8:0:b0:4ed:a611:2da2 with SMTP id d75a77b69052e-4f4abdbc5a8mr227117561cf.68.1766573630096; Wed, 24 Dec 2025 02:53:50 -0800 (PST) Received: from hackbox.lan ([86.121.7.169]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ab86cesm1737562566b.19.2025.12.24.02.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 02:53:49 -0800 (PST) From: Abel Vesa Date: Wed, 24 Dec 2025 12:53:28 +0200 Subject: [PATCH RESEND v5 2/3] phy: qcom: edp: Make the number of clocks flexible Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-phy-qcom-edp-add-missing-refclk-v5-2-3f45d349b5ac@oss.qualcomm.com> References: <20251224-phy-qcom-edp-add-missing-refclk-v5-0-3f45d349b5ac@oss.qualcomm.com> In-Reply-To: <20251224-phy-qcom-edp-add-missing-refclk-v5-0-3f45d349b5ac@oss.qualcomm.com> To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Dmitry Baryshkov , Konrad Dybcio , Sibi Sankar , Rajendra Nayak Cc: Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Abel Vesa , stable@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.15-dev-47773 X-Developer-Signature: v=1; a=openpgp-sha256; l=2595; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=D+lMLFKk1nDEVMn0lCuyYl8tvMI1zx20USHxDDW0D1w=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBpS8Y2tXYcDJK+hlLQR8UhnVojF4Lx+oV75nFVM ggGkCenkj2JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaUvGNgAKCRAbX0TJAJUV VkvUD/9vgZ5HFTV15ARXUJwDwnYBufZFHDSEdOlpvZOun72nqHtJyASuAcjDz3rRb4ffCwExYY7 utfqH0wVImOIg3MojYcAiC16GRnMSTY20hsYKtxLmoVbbbPef68GFwK4ig+xyw8x4l4/vx2dxyy YE/btlFfO2nh6ZnDm2zuO+xd5MHL6vtRx/L7ivrtZGEXzeJWoApFIOAqsHG2rpxop141muB6KUq ELt2flyJFeIipvDJaYwhHDGfcgP46r148BGb9UvbrqQovGHPeAIkcJA1PhFgxD4jtpGXnQLrnO2 VuYw4+g3lIcHpAA/yUZsVqHa0RDQ9sldDAp0kYr8T5LtmrI09whniNQAAlvFspDvCHdAnjgo9YT CvIDRYaCTh6cZz1xPMQ3A4j4obynNWZxoLCBdyBIqhv4hHeCQLhYN9rvPj8poXwudjZ47J3cZcw WFP+ED6HitXGRcg+7GyflPWfsPdG6hJwBEsyW7EysM05toy5tPFeXgcuOizPXU7gNgt1XtAZ1Wz S3F0GUzfsM4QvV4lwtNslRhga1g9pDp17X8L46oUHRgLQ8ZdysvebOjbFFNae1QIh4yUD7kDTjb 5pPAjQrmwTI8scnutRFX35ZjdL6FHLAAwArk6yYrrcgosk8B/202ztSCkowk4a+o0GyRZbHlR7d lWDqS+wE0ggWOeA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: JvDBZp8qT1euPovq1Z1SxFnIwc7NPY27 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDA5NCBTYWx0ZWRfX6noypuFHOpxm wT0ZmupDFeswWLcAm5RxhzJx4IbCWvhRE5ICZuBIdR5nFXno8Snr+ZNadAbkGy3p8FBOWOx4aB1 9Eog74KSAO1hhW2P1CeyHR7oiwXKedMbY3zS2eI0ltZwfeGCiiJX1R23NIWQHxGoTa9HxEjherF a2a2S0PpgQlsMxHl1EG9O7FqVxNpM9iDGK174icxm/DLtG6/zJlp9JuBBtFTDb+atmb95enG3+Y P3HQ2BoZYcgNudp9z+At/uJQCId6VsBEEsRctFz7FCii3xRO0m820fOdSUKPSKy4Pzi6+wD+3nF /UIVmdn8bBRU+gBcrhg2SqdcfDxmOhqTW2lRW1JsnooZuPOp2bpfx+OQLlosx5h5JPPc9HS/9N8 fMR6tbXOfhg0rvWbU6+UX3HaAoBgyPlsVyUqYlUTzzAcRBCIYSq044zlwqIweEc/qcxmJ9JDPBd 88Faijoxe47O+r7RWFA== X-Authority-Analysis: v=2.4 cv=HsN72kTS c=1 sm=1 tr=0 ts=694bc63f cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=DdBtMnqNxkYIvXj6ev4VzQ==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=J-Zs_ZfDLmX6yROVY6YA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: JvDBZp8qT1euPovq1Z1SxFnIwc7NPY27 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 clxscore=1015 adultscore=0 bulkscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240094 From: Abel Vesa On X Elite, the DP PHY needs another clock called ref, while all other platforms do not. The current X Elite devices supported upstream work fine without this clock, because the boot firmware leaves this clock enabled. But we should not rely on that. Also, even though this change breaks the ABI, it is needed in order to make the driver disables this clock along with the other ones, for a proper bring-down of the entire PHY. So in order to handle these clocks on different platforms, make the driver get all the clocks regardless of how many there are provided. Cc: stable@vger.kernel.org # v6.10 Fixes: db83c107dc29 ("phy: qcom: edp: Add v6 specific ops and X1E80100 plat= form support") Reviewed-by: Dmitry Baryshkov Reviewed-by: Bjorn Andersson Signed-off-by: Abel Vesa --- drivers/phy/qualcomm/phy-qcom-edp.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy= -qcom-edp.c index f1b51018683d..06a08c9ea0f7 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -103,7 +103,9 @@ struct qcom_edp { =20 struct phy_configure_opts_dp dp_opts; =20 - struct clk_bulk_data clks[2]; + struct clk_bulk_data *clks; + int num_clks; + struct regulator_bulk_data supplies[2]; =20 bool is_edp; @@ -218,7 +220,7 @@ static int qcom_edp_phy_init(struct phy *phy) if (ret) return ret; =20 - ret =3D clk_bulk_prepare_enable(ARRAY_SIZE(edp->clks), edp->clks); + ret =3D clk_bulk_prepare_enable(edp->num_clks, edp->clks); if (ret) goto out_disable_supplies; =20 @@ -885,7 +887,7 @@ static int qcom_edp_phy_exit(struct phy *phy) { struct qcom_edp *edp =3D phy_get_drvdata(phy); =20 - clk_bulk_disable_unprepare(ARRAY_SIZE(edp->clks), edp->clks); + clk_bulk_disable_unprepare(edp->num_clks, edp->clks); regulator_bulk_disable(ARRAY_SIZE(edp->supplies), edp->supplies); =20 return 0; @@ -1092,11 +1094,9 @@ static int qcom_edp_phy_probe(struct platform_device= *pdev) if (IS_ERR(edp->pll)) return PTR_ERR(edp->pll); =20 - edp->clks[0].id =3D "aux"; - edp->clks[1].id =3D "cfg_ahb"; - ret =3D devm_clk_bulk_get(dev, ARRAY_SIZE(edp->clks), edp->clks); - if (ret) - return ret; + edp->num_clks =3D devm_clk_bulk_get_all(dev, &edp->clks); + if (edp->num_clks < 0) + return dev_err_probe(dev, edp->num_clks, "failed to get clocks\n"); =20 edp->supplies[0].supply =3D "vdda-phy"; edp->supplies[1].supply =3D "vdda-pll"; --=20 2.48.1 From nobody Sun Feb 8 16:11:46 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A2F831AA8F for ; Wed, 24 Dec 2025 10:53:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766573636; cv=none; b=t8At+sc13idBlnMxs1YeFUwc0QdyCOIbnpJwbHvF3iv0WDyyK++3Nfh73rnHIxlrjWaet2whBbOR9i7wQgWr5itpMMzLIM8sqUnj42XyeiAThg6wKOGFi5o01xwWew6xUEsXgKGBk+woSi4Z2p+jFJInnyi5FOVuZrBX0Imgz2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766573636; c=relaxed/simple; bh=cPDoEfxg759WqZGAjy7ePjMCwqTiwM28X7LtdMqCAP0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UpMIBAS4ZcUGIOdvkuJ9Z2Bxm0hijP4JTpjQobA48P+ld5t+/ooOtGhzsU0VUzMDrWqH9UXhtMxBcmT9Tw7tg97Axr2P3Komgt9I9Y5yFqaVMNFptG6fmNwIYTNGERNPuqOVBp+50flsxf/+LJ6U9FMKJGPo9xInpowkAx7IH3Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XdwDREM+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cjWA56Xc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XdwDREM+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cjWA56Xc" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO8O2MJ721269 for ; Wed, 24 Dec 2025 10:53:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nWatTeODsCj9eCOPh6s/ONx5sdA0VSf8P0xfOcNmuC8=; b=XdwDREM+2/o3Gg8k tTVMFQsmDRiKhkn6SKQUHPmxHw+ZpQoZrLFzilhKiHcIMbOQA938/kH4o4HHf3rq RyT03iQlxDOvXRJBvP9jg+Lj5zcdEwqGOAxMUuol4my4h00PitymU+5aPRWeZwCJ xvYCBI0WIJzx8tYiMQNi1h6TyP8d6PkrdkRo9cW8Z2tKI+w+zGvqM5b6bP+ooDvK Qm/nnOF/yQe/4qV8aSvhnQT72vduYDi7LMVyucV9EBZe6bakSjZCOOEEjyZF9BuD PPB+nAEN+oXvCCeQ+TzUwKA3OUbuIJdEddnOGXSp02ALCeCgWKTV8duiePfQrUP3 4p4Wwg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b81mta0em-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 10:53:53 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ed79dd4a47so123670701cf.3 for ; Wed, 24 Dec 2025 02:53:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766573633; x=1767178433; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nWatTeODsCj9eCOPh6s/ONx5sdA0VSf8P0xfOcNmuC8=; b=cjWA56XcKmAis6U5gVKd4Z/UqJMpwC2B4x3V8iQ/AH/Db9RqLnKGDIhqQkDQ/DIXRr nqYLLQFPK9q5E1dW7Gw/s/MoxMGina6i7Bw4ILRRiKtzncZqNjM3r8yewFBsMINSIAhA kT1C3pFUmMS9/FDPk7aobngsFPMuCe+sILiRa/r8MQODuVlcBGIF2Od6JZqgzFyCFDBP b90B4vdEYh10xK7cdKTZuA0fugixWEgMiRvv+fnbS+E9sbgl/z2VicBQcrvSDF5zPqyF kUTUHYlSqwSh/Zzm8JdGZCUmXGfWY4GFcQ1q/E+wuzSM6P24ZV/N1NjFuRyss6nbzgcd tfMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766573633; x=1767178433; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nWatTeODsCj9eCOPh6s/ONx5sdA0VSf8P0xfOcNmuC8=; b=OIYomED0TOlKDC4+1U02uucV8AfqHoY4Xs3bYo4o5juIVXRkEj519+KBzhvnIkEFoC F9d18jxMHIDvS6+uMU4NeU2wChVy4D011Y4F1jTbHEBzaTJYr3YrTWbgcnTZBpJzPrqW k1KoTOQAz21JW+RLcLvyQ89bJg4YzJsWAU4xdOonezmbHseCT7h2qJObr+6lya9vSeVv ee2G1xqYxcortWY7jteIRorotLtPVg2E8cXGv7eqTepysfTh5tysT/E0RkUQN7b0Es6T Xnpi4r+G0HVmj4vmQZO1GSa61i+eKEKvHCdm6egS4GbTNjSX1Bcg3XZBlTzyzHHLIbkG 6SCA== X-Forwarded-Encrypted: i=1; AJvYcCW2QuiYTw63qG6GC4zirmTyn7M70SjfRlRAnewrIpqNWe+K4ad712A000RwlJlH24ZlT47S6nbwXzD1HKI=@vger.kernel.org X-Gm-Message-State: AOJu0YxC4C6KR3t3KplytRU0GVeNJgJH7t1/tOvcSOAwpsQawVKh+4e6 F9EoeAs2TJoMPcWs4DdH+ufZVvf8GCY4fd+hkZbWaUeF7UZPGDR3C1ScVLZf8WLC2NZ/nFVbwit fyRHm52aQUnEu57+tOjYEEKzpunjKUK70c2lIVXvgw/NVxmZdAHVQfQa3OlgR0xPQiR0= X-Gm-Gg: AY/fxX5EEBx9lsl/l8+eyo8/lLjDKSWYUKjrmrIiGiLvSKbuKmMzlUMmJKi8JyujMmA fXXM9pmd84bFntvBGJkrAFOx0wb8kPenEYH8abq3SaLHcMIGVnOvNO2Ckck9mG8vKyenp3TD7WA GMzNpRY4tp8Ht6CiPREKQ++qiMLdq6tPLk4Ku8TzLLLqnHYtkyWYQ/MMZAyMaRxO0eI7ZAh7uaD f5NJHlYKftygsU4ztURrrwvPxtOyWgrojlCL1GXGCyfYmAo2Ge7AnVwd3JcJy4YN/Z6wbVq/Zlo SvrSRsd8niPghoYvoPWj658ArCKMAABk5jNOfWYqbvXtJnPRcZM+knqAkgsh1ncFDttCPsBVS1B d77VxnQuNljTpCTU= X-Received: by 2002:a05:622a:5912:b0:4f1:c6b9:b1ec with SMTP id d75a77b69052e-4f4abcf4bc6mr238685041cf.28.1766573632430; Wed, 24 Dec 2025 02:53:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeAVgBMuu8KrPTONUD5DkcqKJ9tIQm6gGeqTc0K514xaUnwQGYKjP7mhCnGalBfQmljdi2Nw== X-Received: by 2002:a05:622a:5912:b0:4f1:c6b9:b1ec with SMTP id d75a77b69052e-4f4abcf4bc6mr238684801cf.28.1766573631897; Wed, 24 Dec 2025 02:53:51 -0800 (PST) Received: from hackbox.lan ([86.121.7.169]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ab86cesm1737562566b.19.2025.12.24.02.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 02:53:51 -0800 (PST) From: Abel Vesa Date: Wed, 24 Dec 2025 12:53:29 +0200 Subject: [PATCH RESEND v5 3/3] arm64: dts: qcom: x1e80100: Add missing TCSR ref clock to the DP PHYs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-phy-qcom-edp-add-missing-refclk-v5-3-3f45d349b5ac@oss.qualcomm.com> References: <20251224-phy-qcom-edp-add-missing-refclk-v5-0-3f45d349b5ac@oss.qualcomm.com> In-Reply-To: <20251224-phy-qcom-edp-add-missing-refclk-v5-0-3f45d349b5ac@oss.qualcomm.com> To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Dmitry Baryshkov , Konrad Dybcio , Sibi Sankar , Rajendra Nayak Cc: Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Abel Vesa , stable@vger.kernel.org X-Mailer: b4 0.15-dev-47773 X-Developer-Signature: v=1; a=openpgp-sha256; l=1831; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=5Xibk6A4j1wuysj5ojbntlDFb4byMzXKcnUoNHObZjw=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBpS8Y3/Vr6IAzv66eye1vfvavk7UaaAxU715ACh aUi2iBnE5yJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaUvGNwAKCRAbX0TJAJUV VhfnD/48ar5bzCyWjZ1O4avupmAUt4y+SBAWSMARAYBwa/0snPNJOaRs1Jhpe7JRDUUs75YwrBZ a5qA4nueyUSSvkvKbrZWuDAqexs/fp13+SuXiMdvTdT+KWxq9el2tXlxm8eso35sLTmYUitMtvt WFaGCvpSMfY7cb5qohomBJsdkuXozZ8tH2bCmEOpazZfLZVVnhuj9fRJyXSihKI6NG28UekUy1D H5G0dEaJfE2JKKBvZbebvOF8wbUJBVYg8QX1udtWN7g5Xau/H2scolUMj4yV/P46uUIiFEKOoh9 ou0gvy4Melg9qcMaKj9gLbBQNvqRMFKhiHpjO1X1y9xMvF8iYbVJFiKSzS+opX19E1ieUip7Sai FOyLUL6O4ba++eWEDYYhQozltPmJXynFVKXMb6EA3+KbygzLDV10JJe8IlBXuyDD4EkpZ5Z6Ltf B6g63aPt7WUbBstP4b/4L8WhIagfH7qjSYrswK19qDrmVZaVOpJmHGFSJT/bpNKalT/jyu0oMWt IIyEaHkSwm/qZVFjBgUl3BbBxpYvHa4UbRHRwSPgd0RS/k+1AJIdE1smJeFfvsyAzZZYN/b1eaw vqWbrbgiSXXIQTUb0bwbgh2ieL3GB1//+9LhZ+3XUhpY32NvQQ9Na7jtLSPcOgjvTPMigBbZ3RS 4RLICiLwUSzGpng== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=e/ILiKp/ c=1 sm=1 tr=0 ts=694bc641 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=DdBtMnqNxkYIvXj6ev4VzQ==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=VwQbUJbxAAAA:8 a=7z7RlTHwfbxsG2Z0DJwA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: B-cFWKsogztl4NUsPFItveKx7HIttHnJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDA5NCBTYWx0ZWRfX35YeEBk07iZH wXgtVSk37xnrgn/g/aAICIGTdBTnc5DZERENnFeuph9BtC7/J2ntYdrhoeOQM6YixzQZsHdjF8p MTDFXtqnCr36zWp/II1f3eDL/EV/cQQCFBBvMgEiIcib/fFUQ2emSe845/Mx2lfgXlrYd2re1de DVOBMYsCkgCaMmA/jw379qaUojORbNc5tUC3VoxIoPhQvv4TdxytXu/LJBMnKyLEDemNu9O9cdH VsS/aR6WK9Ml6SwOZsRdT3dmzslI9ZEHeyD8NeUY2gz0sB3wurr7NR9dwnqwrtHWCaV1iTg7ZbV rc4sUnHyPJcrewUKx40os+vK5snHsIKSQ50vtFTBhgW4L3iWe1zQGKypPIqSto3uiq5+O7wEadT +QK/T66CDFwdXlpmG0A9dm+qYJZo/UN0yyQx4ZFnGBdbulnxL3oQiofTl/VDb6uuz582FKzpDBq ffV1vBVEvDMGLw8RCdg== X-Proofpoint-ORIG-GUID: B-cFWKsogztl4NUsPFItveKx7HIttHnJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240094 From: Abel Vesa The DP PHYs on X1E80100 need the ref clock which is provided by the TCSR CC. The current X Elite devices supported upstream work fine without this clock, because the boot firmware leaves this clock enabled. But we should not rely on that. Also, even though this change breaks the ABI, it is needed in order to make the driver disables this clock along with the other ones, for a proper bring-down of the entire PHY. So lets attach it to each of the DP PHYs in order to do that. Cc: stable@vger.kernel.org # v6.9 Fixes: 1940c25eaa63 ("arm64: dts: qcom: x1e80100: Add display nodes") Reviewed-by: Bjorn Andersson Signed-off-by: Abel Vesa --- arch/arm64/boot/dts/qcom/hamoa.dtsi | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom= /hamoa.dtsi index a17900eacb20..59603616a3c2 100644 --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi @@ -5896,9 +5896,11 @@ mdss_dp2_phy: phy@aec2a00 { <0 0x0aec2000 0 0x1c8>; =20 clocks =3D <&dispcc DISP_CC_MDSS_DPTX2_AUX_CLK>, - <&dispcc DISP_CC_MDSS_AHB_CLK>; + <&dispcc DISP_CC_MDSS_AHB_CLK>, + <&tcsr TCSR_EDP_CLKREF_EN>; clock-names =3D "aux", - "cfg_ahb"; + "cfg_ahb", + "ref"; =20 power-domains =3D <&rpmhpd RPMHPD_MX>; =20 @@ -5916,9 +5918,11 @@ mdss_dp3_phy: phy@aec5a00 { <0 0x0aec5000 0 0x1c8>; =20 clocks =3D <&dispcc DISP_CC_MDSS_DPTX3_AUX_CLK>, - <&dispcc DISP_CC_MDSS_AHB_CLK>; + <&dispcc DISP_CC_MDSS_AHB_CLK>, + <&tcsr TCSR_EDP_CLKREF_EN>; clock-names =3D "aux", - "cfg_ahb"; + "cfg_ahb", + "ref"; =20 power-domains =3D <&rpmhpd RPMHPD_MX>; =20 --=20 2.48.1