From nobody Mon Feb 9 23:14:54 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E44DC336EEE for ; Wed, 24 Dec 2025 12:31:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579490; cv=none; b=WteLU3oJsX/3s/F2cdiJtszhoefNddX8zwwKzMUZ42JbHTIs1JQg3khybnfW8PetC1g7gCwDX+l1eJA60HOJ75uo4HHXY6IIIIWsYBFySdcAXzII1b3ntW4UV+UObbWaJeExe0XPZLkLql8aXjDcSkxbdqO02cvcVjDDFHGPYaw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579490; c=relaxed/simple; bh=GnUWOa3VBsR4gmkhJCVwGtjntBcK89nA7VAPyOK4F4g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rJQwdhitnzen9Wez1ETWZuact8cOowl6bB8MyR/za56coiJHPCReODk2JiDGWYccZjmOdH+7g6RZjRzvrlXXMzwOxfWrIgecqTTFoyI+1QYHV3M/Jkbwz1kQJ5GdHXbEM3CYgqpfrp+SXeuBAZhXwLe1j/ISjb6QnfsIRe0N/OE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jTJAkF5O; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=juZtziRe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jTJAkF5O"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="juZtziRe" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO8WWrh1206448 for ; Wed, 24 Dec 2025 12:31:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2OXQlRUL7AWs+8ZQ2sk6llVByOKJ9yUAc8MgYR01bWY=; b=jTJAkF5OmpnCMpkW i3+DhLHSrVzg1/E3f+MSvGR/Gxu4mgvGqgJBdVtT4rYFi6D4HIYAyKa6GeDocGh9 2BUf0Y/rXHpp92mW6YmvNcDo59Jpmn0vAON8J8Qsln0JkKV9er0iwqcTDH+6JFWw me+4CuvU7FnGsQvyl6BtmsQORaHmjZedlRAZavIxNmcSjfdpdifpYYP4wOg+bsD5 KpTFzWHAvovcgeOsO4NpCul0Jec7SNobTe6V3IOzGOSkDiOrDu0LX2JT4w6cy/2k 4kqajyXOQfBRrrXD1R5e55NGHyrmj67s1QocDxrLu0eraVKaD/3V8dJHmHnAk+m1 5nW8nw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b827r23nd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:27 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ee0488e746so127220291cf.0 for ; Wed, 24 Dec 2025 04:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579487; x=1767184287; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2OXQlRUL7AWs+8ZQ2sk6llVByOKJ9yUAc8MgYR01bWY=; b=juZtziReGJ/4HJ5JuzYtvD1qKIb52SONrNobjMH+a8sLJ9J9EGC3Ci8bw8nx1r8AoO vItxEDFwNO4doekG4kq7vnjJAGDPO8U+HQASGzOOl534BjwJePDiTVTSvUMcybFgN1TV jARbMcch9XeLbgdQz/4mFgp7kdASaQUSkxZ6jLYOtkvj7nruilQKALatEl9BSDH7MfAQ QMv6dLyKfYrkKUnrO2PCu1uM5b2ozhN6HDz97PitoWJYKTOCVIk6Awu+c+9At2uBtdqn xC1l5enuzHq2Ks84Q7zg/WWZ1Q/PrwcGhb7XId1if8W3lwCDC0thWNKuTBte2HxvjiyQ 9Q0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579487; x=1767184287; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2OXQlRUL7AWs+8ZQ2sk6llVByOKJ9yUAc8MgYR01bWY=; b=JeATkqkjy4p1Gogl2qvpJvaWzKEZi6VsDfnIvTSeOoB1WIHWhID6yyRlcZ/qShatFj NkGQOLr6qoetnMY8+UFGz7nt+Q716LeZcQEmu0JLyBvVJNA0n3JfY/nSGucDsuZjp/Pd /a0Z9lONniXw1fveZMtQdqBc02jcmKez+bec/JiXkF2Z8/hKgqbYUUS8KTYeUv1F1kfO q3S4Xc7wCP5vsCgYiV2aJqIzTWt9MA9e1YZWK5Or8ohKJnRRu7FaGYbey/pUWbQwCxgC 4cJBWrx9kDl/qLfMEr8NIAgkTVEAUk3nH9rLxmXvkaTxlQcStTk2hZKseosGgQfSF3Z9 22hw== X-Forwarded-Encrypted: i=1; AJvYcCVor1ir7cq95hISBuVWGk8K8Otc0eZSeaD7OizPMTAeYXPtgkBNuCQe4juhKs6+1Zfr1fbBt2KnD3tyh9w=@vger.kernel.org X-Gm-Message-State: AOJu0YwOhyFZBuPghoBYrEEc/eRCeCkZE6DFrHd0xY/pFa14hsiEU1ez BclQgFonkm6hUILgC+YaHjfTJ/mO3Z3aHfqeznP7obUM3fsa4sY8pdW+9NePPKa7OGX9e7DJmGt iF2LNUvOD13dIQF1g9AkUMRI1n4SEFNOxqT/sGzp91oj/5hD+K8YECzMdLqRRFQ2PAHs= X-Gm-Gg: AY/fxX5fHPaf70nRMepSMOiYcoX6L/DKKGiVgt4NkbhEnNIkYI5V6r0F1U+jy6kzeaU 11H45kDJNU4cHfOaoANscXhpwPd3szGd70qVD6IA4H7mmSyZMzQ9eQ3ggLCSxSsKxIpN+85KFTH yr6dSsMvw8rxpOnMGVBGxkyO7GGAz8IfgY1Dew8HvThrb/t9R/Zg//Y4vY3YxnRdRXgCgPBXtwg V35UGOJiJzBTSazD9yOQ579fqVUfOKozsuszwKFmZzasgFAatU3bnO7nrFnuQl8JK35B25pZWQM xc05Oyy95ea+qb+b2DDpaUxTH1+aVzevPlzeJRyAYEVD63jnCJ8ZOLmTH9IDZigdIz2HpOlbRnG jm6jGxhXGZJwdGwkdbeE8ZX2s6JAr/9vIXHqDnZfCTZes8EyQdWwbdE5YBCXRF2HTtfpvrR4Tuf dv5ZthTB/dKAWB2kBsuONHlqCo95R9kI7I4B/aCIro X-Received: by 2002:a05:622a:199d:b0:4ed:ae94:5f5b with SMTP id d75a77b69052e-4f35f3a046emr282722141cf.8.1766579486869; Wed, 24 Dec 2025 04:31:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IFlek0AVUOYek4yOEMcM/N3Qsy8A2nfqDeLRiVKPWR4TrVTPYIorwufCJ7RDA7tejl3X9wO2Q== X-Received: by 2002:a05:622a:199d:b0:4ed:ae94:5f5b with SMTP id d75a77b69052e-4f35f3a046emr282720781cf.8.1766579485526; Wed, 24 Dec 2025 04:31:25 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:24 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:18 +0100 Subject: [PATCH v4 09/15] media: mt9m114: Add and use mt9m114_ifp_get_border() helper function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-9-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: MPWnuxiBa3lmnHp5iByxZl7tOEHTcjYC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfX/+/uP80In6b2 cug7QXdrQzGFUVV6UptXmvSS+lGIwiXAslHRb0OrUvXYtdx8W3Tmk1iLhNNxYshDWmG9q4Tr6Gp RJSPoPVR/6xzSLwwWa3ZytZlrQ0+Z4+Dc7O/ypP0rwTwx9DgFWEJXOAc4lM/sjicvqy+TTbgYS7 j+wg/3eRDC8YmzbNxz6seP+zRNjHBlqa8kKwKVSm61ZV3hC+74QXIUwaVseeasUCCJqk0xKTZJ/ ouUVj5bvLg6wvXjmHxvrII42l6+RJtcon2CFNeNzTO5nS4WiLHSiHe/m2DKv4YBIfrTlqSzMXz/ H4pD8Qk1TBc3uBVQTtMC7DnYAUsuyKc+EIdG8TYwVvF4dATpj8O/S0RjYMSwk0XIXSl/6jzau3n 551YbFPiUqI5oZ4/1JCI0B+agCIoxd3bV5yP3BzMaJGRR3+62G2AAhjXK9iZBjmz0kUM2m5PdzT eVi7UD4C/22VmrryR0g== X-Proofpoint-GUID: MPWnuxiBa3lmnHp5iByxZl7tOEHTcjYC X-Authority-Analysis: v=2.4 cv=RbSdyltv c=1 sm=1 tr=0 ts=694bdd1f cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=i4UVPg6hQqdO0Jw5UB8A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 Normally the IFP removes a 4 pixel border all around its sink format size for demosaicing. But in RAW10 mode it does not do this. Add a new mt9m114_ifp_get_border() helper function to get the border size (4 or 0) and use this where applicable instead of hardcoding a border of 4 pixels everywhere. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- Changes in v4: - Address comments from Laurent about commit message and comment wording Changes in v3: - New patch in v3 of this patch-set --- drivers/media/i2c/mt9m114.c | 62 ++++++++++++++++++++++++++++++-----------= ---- 1 file changed, 42 insertions(+), 20 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 39f9d20221fee4f1d12c24a031d9f33c953b9a9c..c0710dbb670d4e40e13fc895cf8= c84219ea43bde 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -851,6 +851,18 @@ static int mt9m114_configure_pa(struct mt9m114 *sensor, return ret; } =20 +/* + * For source pad formats other then RAW10 the IFP removes a 4 pixel borde= r from + * its sink pad format size for demosaicing. + */ +static int mt9m114_ifp_get_border(struct v4l2_subdev_state *state) +{ + const struct v4l2_mbus_framefmt *format =3D + v4l2_subdev_state_get_format(state, 1); + + return format->code =3D=3D MEDIA_BUS_FMT_SGRBG10_1X10 ? 0 : 4; +} + static int mt9m114_configure_ifp(struct mt9m114 *sensor, struct v4l2_subdev_state *state) { @@ -858,6 +870,7 @@ static int mt9m114_configure_ifp(struct mt9m114 *sensor, const struct v4l2_mbus_framefmt *format; const struct v4l2_rect *crop; const struct v4l2_rect *compose; + unsigned int border; u64 output_format; int ret =3D 0; =20 @@ -872,15 +885,18 @@ static int mt9m114_configure_ifp(struct mt9m114 *sens= or, return ret; =20 /* - * Color pipeline (IFP) cropping and scaling. Subtract 4 from the left - * and top coordinates to compensate for the lines and columns removed - * by demosaicing that are taken into account in the crop rectangle but - * not in the hardware. + * Color pipeline (IFP) cropping and scaling. The crop window registers + * apply cropping after demosaicing, which itself consumes 4 pixels on + * each side of the image. The crop rectangle exposed to userspace + * includes that demosaicing border, subtract it from the left and top + * coordinates to configure the crop window. */ + border =3D mt9m114_ifp_get_border(state); + cci_write(sensor->regmap, MT9M114_CAM_CROP_WINDOW_XOFFSET, - crop->left - 4, &ret); + crop->left - border, &ret); cci_write(sensor->regmap, MT9M114_CAM_CROP_WINDOW_YOFFSET, - crop->top - 4, &ret); + crop->top - border, &ret); cci_write(sensor->regmap, MT9M114_CAM_CROP_WINDOW_WIDTH, crop->width, &ret); cci_write(sensor->regmap, MT9M114_CAM_CROP_WINDOW_HEIGHT, @@ -1865,6 +1881,7 @@ static int mt9m114_ifp_get_selection(struct v4l2_subd= ev *sd, { const struct v4l2_mbus_framefmt *format; const struct v4l2_rect *crop; + unsigned int border; int ret =3D 0; =20 /* Crop and compose are only supported on the sink pad. */ @@ -1879,15 +1896,17 @@ static int mt9m114_ifp_get_selection(struct v4l2_su= bdev *sd, case V4L2_SEL_TGT_CROP_DEFAULT: case V4L2_SEL_TGT_CROP_BOUNDS: /* - * The crop default and bounds are equal to the sink - * format size minus 4 pixels on each side for demosaicing. + * Crop defaults and bounds are equal to the sink format size. + * For source pad formats other then RAW10 this gets reduced + * by 4 pixels on each side for demosaicing. */ format =3D v4l2_subdev_state_get_format(state, 0); + border =3D mt9m114_ifp_get_border(state); =20 - sel->r.left =3D 4; - sel->r.top =3D 4; - sel->r.width =3D format->width - 8; - sel->r.height =3D format->height - 8; + sel->r.left =3D border; + sel->r.top =3D border; + sel->r.width =3D format->width - 2 * border; + sel->r.height =3D format->height - 2 * border; break; =20 case V4L2_SEL_TGT_COMPOSE: @@ -1922,6 +1941,7 @@ static int mt9m114_ifp_set_selection(struct v4l2_subd= ev *sd, struct v4l2_mbus_framefmt *format; struct v4l2_rect *crop; struct v4l2_rect *compose; + unsigned int border; =20 if (sel->target !=3D V4L2_SEL_TGT_CROP && sel->target !=3D V4L2_SEL_TGT_COMPOSE) @@ -1937,21 +1957,23 @@ static int mt9m114_ifp_set_selection(struct v4l2_su= bdev *sd, =20 if (sel->target =3D=3D V4L2_SEL_TGT_CROP) { /* - * Clamp the crop rectangle. Demosaicing removes 4 pixels on - * each side of the image. + * Clamp the crop rectangle. For source pad formats other then + * RAW10 demosaicing removes 4 pixels on each side of the image. */ - crop->left =3D clamp_t(unsigned int, ALIGN(sel->r.left, 2), 4, - format->width - 4 - + border =3D mt9m114_ifp_get_border(state); + + crop->left =3D clamp_t(unsigned int, ALIGN(sel->r.left, 2), border, + format->width - border - MT9M114_SCALER_CROPPED_INPUT_WIDTH); - crop->top =3D clamp_t(unsigned int, ALIGN(sel->r.top, 2), 4, - format->height - 4 - + crop->top =3D clamp_t(unsigned int, ALIGN(sel->r.top, 2), border, + format->height - border - MT9M114_SCALER_CROPPED_INPUT_HEIGHT); crop->width =3D clamp_t(unsigned int, ALIGN(sel->r.width, 2), MT9M114_SCALER_CROPPED_INPUT_WIDTH, - format->width - 4 - crop->left); + format->width - border - crop->left); crop->height =3D clamp_t(unsigned int, ALIGN(sel->r.height, 2), MT9M114_SCALER_CROPPED_INPUT_HEIGHT, - format->height - 4 - crop->top); + format->height - border - crop->top); =20 sel->r =3D *crop; =20 --=20 2.52.0