From nobody Mon Feb 9 13:57:21 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47EF0337BAD for ; Wed, 24 Dec 2025 12:31:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579487; cv=none; b=Ijm2l8dDGMssuHHjMnOMKu0V9gzs73upGfRSVkU8rX2tFt1M/z5JEFLKHxmspNefL6txW7JMkVMTbXWb2QlkVU67loSTLXZumdHVxOtpR3vIixy1SrvWo4GGD0zDEdKLBTvpBhbXHVgX2XfrpM64c1u7FdMry10KRHNlhecPJwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579487; c=relaxed/simple; bh=PcqEbDhwYqOzmIiok2Qn6+Jm/yIwV2Upm7KXVYVrG2Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C0DfQt1p7dkQ8wtuTEyU1uPAedxB+ZYErtkWxN49TqmzNPsOnr0L6A+NI7xqJY9bJPgu/XrRkpj2Qu+qO8xqddnhGYjX2mDUNoJ00g4ZV03SftTB6JQglpLw1BeJAxMGt/OktTqEAJPfYXTWatQ9x4DqnF/eZcU77XHZGRk6yW8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=l4atO4Uw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KZmegxPL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="l4atO4Uw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KZmegxPL" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO3iEh54134076 for ; Wed, 24 Dec 2025 12:31:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zOUl8Ahg4EnNMx+NAiYHHKYQZ589n34P2RtnbvljXcU=; b=l4atO4UwYIZmU+85 O0GlvKB3U5FZPYpETs3XdOBpsP5hqp5KNLfJ+ESzj8AP8yLDoV1asRGjuZRtxs1T eXMGSpSJ9OlXeBGfCTn45pRHWLrqNmXJCYGsESF4NGJ1gsPozb/ex9voBYli9hD2 6GjYFsCiFzf+sw9JZowzkb39rVoRlUhFB2gUsulEPvejPxY9WOA6BbNWsUs8cGnT EeBFx+Sa8SpZ8APAImNxkPGs3oLIVXLlMp4HC4QdM+KioSlXaLZGzYxsO8/2wiyY iKrZK2YxTXiBQbEa+q5W3UPY1HDXg64TZC9yYYxLIeel0M7sUFxsMzmhOKr+kYqU rs1pyA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7x46u1a7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:24 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ee1b7293e7so204870831cf.0 for ; Wed, 24 Dec 2025 04:31:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579483; x=1767184283; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zOUl8Ahg4EnNMx+NAiYHHKYQZ589n34P2RtnbvljXcU=; b=KZmegxPL5YIreSicBYZoWN6xwL8Vjy1ePiNGpbayFWSBVx4rTk589dUBmMyexaF7bv u8l7/mTyhIF5E52kJf4viJDtFDuKt9PMrjOX3x1G040/SroEElJKkCM4AY39oLTaz+wQ rF6zTDPeSDT8nH+qI4JHz+iMxF/K5XVhsPpaycnhzrV7JAM0IjC4M6bltRq5Y2X1Rjpo qIOBKzcrLFK3OK3VJaMK+ZV1qem2d+1agBk/UJZRBFu1aKnnCIqqkxIQ1lcG3KiZ6lT7 JiU0s02ZjXKpeXh7b63iTl/ZD9ap2FbVEKuWkfUcPDjKMKTy3BSdumKSDAtRfdHneWko dYaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579483; x=1767184283; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zOUl8Ahg4EnNMx+NAiYHHKYQZ589n34P2RtnbvljXcU=; b=ICopWFbAu9bijwmMtkJLce1pZClbIjQHtecOuyinL7rPQAz8+Ct+Rlet+FY9Nfh+nb blW82HeRVdhbuqn47xAX1pQelfAAOIwAARgBX5d78AWn4rpvdPEo3xVMZiJAzeQM344N qDXR6VrOQb4sqwtfoZIR7JnmlQUnoouPfEjm08gX6Bm5XdFGGu3UIjIF2P41Uk2+ZpWL GHN5TUplXHf++EFoIHomCjK01fg1QyO0r4oCmkbpAK810IxCnkiTe/YKEpeIae/LMpYo Q/DRjeUjjQiSou4mvbFNNabwfl7YqneH3mgSWvXQ3hlUH7teopWRYCWHLCi86Ck8mIYo mZDQ== X-Forwarded-Encrypted: i=1; AJvYcCUQXznqXEoslL8O/YhONI7sUgTruX0tvvhr/V14blCEw61qNCx4DZh4ygzdLUf6D+ozCNQvnhi78XKmfdA=@vger.kernel.org X-Gm-Message-State: AOJu0YyGqxI/v1iTHT+7SdFOXYvdUUhKDiTXHsD3R4wRGVF1XEMPQmqv Exzv/HfgY/k1NMZKyOEh6b+3Ao576zl4mVNJRaYtSwXZmoQmpbgKtfb7apCfA42vUCEtWuEL6Vd VEaN+z0K/lVAK9fInt9xj+D070uT0hvzojnZ6t0sSr14m3opAlAawZzIscR024S+knWs= X-Gm-Gg: AY/fxX6inODFlRq3zoO4Kr8zeCGqc9yxnk8oHynY5bkOEndF/ReyeTZvHSuQh1ovn3s 0SjGUar24kF4UAsR1fpv2DcY8EpYCMrHKxIGOPme8qxIMBF094CNn1Io7rupZTrmQj8yBAG5VBJ gquiSCrjImW6u/PXR2Ja3SlAr0IOVX06RS6lqo888eYUc8iaHyJhVEXVINaXpGTHdtFKSmprTyW MWUZDSmS+SN7jPjkKLPfDHsIcVsiDYTxc92oNzFzRBeze+nTELJzo1Ia3iWjeT5JggEKJS7UaJt fYYpMGNmeC3XHbJAw6//ZS7u9F0jOJxdkzQfK9lbrF6EesgcELtTuZ6VWv3lSbDVfPxlN1O7++z k3bZNrzi33MB4bIsoKJxrDK1sjvyWXnvosNwaMxJ9+Z3ezVD92t5Sx80PG+aPiR+J11frT9HWGO bh3PnxckefU12aRIVkS7nGyB6EcrPkQ3TiLzD4YTDi X-Received: by 2002:a05:622a:1aaa:b0:4ee:1227:479a with SMTP id d75a77b69052e-4f4abdd1c34mr255789231cf.84.1766579483491; Wed, 24 Dec 2025 04:31:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHJMqD0KLcylsKHMUZp+3fu2rjgJFkp1M+QUZi5VVzvpEMKi5CyGkdxLGsXfjb6XJmqSO1TGg== X-Received: by 2002:a05:622a:1aaa:b0:4ee:1227:479a with SMTP id d75a77b69052e-4f4abdd1c34mr255788891cf.84.1766579483117; Wed, 24 Dec 2025 04:31:23 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:21 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:16 +0100 Subject: [PATCH v4 07/15] media: mt9m114: Avoid a reset low spike during probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-7-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: fqKtBnNzrn3N7MjeSErnX0YT75dMtm6z X-Proofpoint-GUID: fqKtBnNzrn3N7MjeSErnX0YT75dMtm6z X-Authority-Analysis: v=2.4 cv=aOf9aL9m c=1 sm=1 tr=0 ts=694bdd1c cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=RFAlwJ6oiccnoQ4oFZsA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfX07/9YagcnjjC qZAgQADzWkbKQic7mTxe4wDIhMBZ81q4bwtF6/cEfMFiOjG1rcGS9AEG1fLC6vmMbdNFflgVrYq pYOvvLOntLRm5sdUlc4V8if9XGv9tbrBG+bYUrRrJKdcRkhyJ22Sze4AoUqkZafyPRVy1g5LeLX DpBJN4IRmpiWnM3J6OG2lrPgl7bTvqKyCC/OhHvuHls/Pk6oxcQVxCqgpEMoGrD8GJ8VT0VI64g UL6jvPQ1x8680rk0AOMMGMLhQ45nHqXerSukmRBco/P5RpGj0Y1Z5LSOxH48dufVpWzH0yx1AFR +GviP4vKLcEm6jW0pb3ejn1+so01xzWbLEjlgqhHJWnvhKteTLwGFeJoeevEByTLYHHqgLFCkQ3 POPQZpacQAIQa+km0FA6e7+PquuuKOrYfN07rPIGkHI+XEJ+LQDgi2sndhOi/jlLSUBHEK35xl9 mKODgi71QdElFBOl4nw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 mt9m114_probe() requests the reset GPIO in output low state: sensor->reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); and then almost immediately afterwards calls mt9m114_power_on() which does: gpiod_set_value(sensor->reset, 1); fsleep(duration); gpiod_set_value(sensor->reset, 0); which means that if the reset pin was high before this code runs that it will very briefly be driven low because of passing GPIOD_OUT_LOW when requesting the GPIO only to be driven high again possibly directly after that. Such a very brief driving low of the reset pin may put the chip in a confused state. Request the GPIO in high (reset the chip) state instead to avoid this, turning the initial gpiod_set_value() in mt9m114_power_on() into a no-op. and the fsleep() ensures that it will stay high long enough to properly reset the chip. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- drivers/media/i2c/mt9m114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index d58445826c090f377db473f7926c1b612874ff78..60afc32acee4df1e7d4f820838b= 72f6aa3506f8d 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -2455,7 +2455,7 @@ static int mt9m114_probe(struct i2c_client *client) goto error_ep_free; } =20 - sensor->reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); + sensor->reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(sensor->reset)) { ret =3D PTR_ERR(sensor->reset); dev_err_probe(dev, ret, "Failed to get reset GPIO\n"); --=20 2.52.0