From nobody Mon Feb 9 12:42:43 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEDDB336EF5 for ; Wed, 24 Dec 2025 12:31:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579484; cv=none; b=uAfItOOAwxNd4aVF38395+Myzp8S0HPSveS1C7PpOV8Cm3bUrWUEr68S/Fc7Y5n8N/kstv9LPjFjYXqkSnjhdUow4KCHpZmCU58lLiQvdQng0tuIkyEj5IpTwoH5F7DTizZRm8E2b7Oz/OsUBJY1f2MAo9lsJn2IFGhrk0WvLFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579484; c=relaxed/simple; bh=fR/JBGeUDY8L3uZkc7VehEJU2PSE9gi//wsklRHk5bY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uIsc43DHFRPzKHAG3Xao/rZDFD2+x0u9Bt86iBhJSfSFduKhvQUxOcpz/0MUC9w2SaD2kFd1X2nkHzmTIje6iNz3Jg+BXolxvLyF+T1drcf+tTFPiOE5AYU5acX241U6hr0v4AeNc1qBhF/j1B+wuMyy8h+AKYbr+/CfKsman9w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TYIGH32Z; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dAlwzIWK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TYIGH32Z"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dAlwzIWK" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO8dq9b1208041 for ; Wed, 24 Dec 2025 12:31:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4ZmW0JfzCy1J7ZjX2Z4M7feueyajCdPj/1Lchmmu0sQ=; b=TYIGH32ZiNRnXuiv S4NuXkUo2kU/sczIBovOeTXGFlWlL40ive+Dng5zDmS2FQ+c03wVyjPcRxOvqYfg Lf3SAYPpKwMwD0EGi4B/fiImnLAiRv+H7l0mI+BymkA48m7ZjeXhnQumDd509hQz dCotLKu+U0iTEAIGBtfy2BuHKf4KxuPZzw1eVUffo7gtgw44Z7h/0xK9vb173L7l Jk+xeFLH3HdjYdV4xdcgRkiQfegHYauaG7ir+0BDpQwxmI/lXY1u6L7yEmljpE2O 4L1HbslLFKIXTVm/vxvuND8L8yYCOuhRPaYTiN7eOGmZr0TKfuOq4XyzFSGZLDon Z3CyBw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b827r23n5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:20 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4f1f42515ffso141454911cf.0 for ; Wed, 24 Dec 2025 04:31:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579480; x=1767184280; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4ZmW0JfzCy1J7ZjX2Z4M7feueyajCdPj/1Lchmmu0sQ=; b=dAlwzIWKd5VaAwQxoDipfP721ih2JYgMajC6XaspuML2r/fiwe8pGKMxGe0wLd2Gta dRpohU3ukEcTqTyAHQMpm97KxFMvssVau25Oiko+ZPJSXp+e1HCNccwfoQu9u3K7ElWZ 978ogq/I5X0Mt39Lcjx0+7HXIX0E4p+1tP4kj0C1jp7AIbc66GNczZ4b0dKdvJ3O2nqt yRoxqXNm2jvibZX0sAssnGXsMoBfu7MxBRBU2Tj5kGABKsh4E9ijIC/tQ9/QOo/Oz6Fl v1kFiON8jtdkP/FuN2DCfkyRn9xfD+EpQny9Vg1aQobwtfpIpnvswbSojknzHsziGAX0 qPCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579480; x=1767184280; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4ZmW0JfzCy1J7ZjX2Z4M7feueyajCdPj/1Lchmmu0sQ=; b=D4gqXKU3T32JiNmT/bm+ci7KCtHsCVzuDXkSSryenzp8I5PtOHkiShyYXOUEvla4DM ccXV9nR2bfsUkxiCJS3iDWlLnf1wTFRBdkouxu51KodsJp67e3X36dVbqQ0FatoyY1Qt hafUX3NoNhQsSUI3XLlBm3LeHTCkL1NmwLjhBXayRGSdZnomFG1EksDDrtvH/uxyqBJb 1dqACXzanYh3rPFj5eqm1szRmAqdt1QgJLpL9bktD8VnXBtqt1UuDueh5aQRZiIh/HnH lv7I6CKaLN5m0+ZdNunMwqG0qcBfFSK2hSiw0/WAZcGfCKAhfR5e4bpdSNjq4KQ25RBZ X+Ww== X-Forwarded-Encrypted: i=1; AJvYcCXUS0xKttebbK+lP40uMpoK8lxIJJNz1eRT/vu5PO9/EZEsVqEgkUcZ0VMaTgBCqEtWybTeRb/JKgApyI8=@vger.kernel.org X-Gm-Message-State: AOJu0YwL9o2FVxWMjWWfYGTh+yLBm5VwxHThb5wLNWzkr6OvMB0l8t2d d1G4WQgO7qtHqLUCnMU4HkN/k5k2MmKST3rohL5oxqFKCOgyFxvYnLLSNf2Gkp41hEl0Lpcvq+X NBpnm8y75lkjp5lrXjnsxxvKc1Y+qfjR01hwmW3IC1sN0YUitPVWtKwFuFV0LeHyIgLk= X-Gm-Gg: AY/fxX60Zo7OzUowf3Z4BPQ83T1arrOn4VxuOLEwfiv9NHCcUxfowkerxG8aNpxKsvl /KEXBFCkBMlIwJJ8iBPVgMfnDNvaSPgr1yNMNrgqYGpW5e/7AJkptFz9L/UdJSPVgY9p/7Kx9yb IWFPZjliKyg5Oei2OTn2RRH64EV2tyzOv9MfY//ix3o6OfGrg9uNa81uz+wnhvcgAp+62xJ1rZr CEriX9U1ycyXcrPKCk+HJRIEE4cX20kaZQvKpEH3SaQAIRg0jHiE+aA3ieUfo/mf9mAG5cF8icz LXtc2khJVcatVZ+y9sDI26L9KpDnN8V9CO8tWRScjf1GPZtukhIp6tURh78dJUp3lNpjycW51Pr +DMUWcrpoFRDxzIxjtrPBCugnnYEws5Kw/ERoSULZ8onI5Grq/qR67jxYwG677dYVDuv5sKhlHn dr7Uhe75b+JwUJP9hJhocmtjG/tijgIqwq5xAr9yWT X-Received: by 2002:a05:622a:5c05:b0:4f0:153a:65ec with SMTP id d75a77b69052e-4f4abd78ea0mr254876361cf.40.1766579480263; Wed, 24 Dec 2025 04:31:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEe4VlcMJU9/78lQt8mav1vBOayjJg6SBN6pREq4nklWH4BBei3urptlUKobab8bG1z5DsSMA== X-Received: by 2002:a05:622a:5c05:b0:4f0:153a:65ec with SMTP id d75a77b69052e-4f4abd78ea0mr254875751cf.40.1766579479775; Wed, 24 Dec 2025 04:31:19 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:18 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:14 +0100 Subject: [PATCH v4 05/15] media: mt9m114: Fix default hblank and vblank values Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-5-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: 9elLSnR2MGyVXMnpW_LoAc4tnlvienB- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfX9CqqSaBu1EP0 2h9QqHJ/KeuVNnjkT7meSypaKzdNy0QGM8Ds1p/aR/0Il414TgDusgJ8bjdlthzQgRyItZOFqwN QJks7+P/XlCqcpu4utLuExXozDQmPO1vb6JZ0JaHCN8dl5cZ+UZsY67rauXZBY1ye4Zu7GxyRvF 3Cvt2Q1wIjjnEaD7O/2s8MygJRkodrvEqwKjzAobMF0amSEF8ylDYMfXrQtSIGLvu5Gv5a19i0K 55R6vXnuo961IOcxluLNidF2YWUA4N+Qh4zUgSihTUpshotVqRU6cwLigvEChe79TinPZfqXYOq PHk4aguns2FsWOem/ZRfBJU2EaAL5dXuHIPJ5BqJhdEaNKE3rycSndaiBzHamr3KoCEQGE5PiqK a9M3e5TXUeVe3zwd0cUA+QW2fHCMEZ8zKbs5C1mbfiql+tBW5dGftqL9c9Zyp4VeCTn+LliYwY8 GOh/G+ANUjvG2Yo/DkQ== X-Proofpoint-GUID: 9elLSnR2MGyVXMnpW_LoAc4tnlvienB- X-Authority-Analysis: v=2.4 cv=RbSdyltv c=1 sm=1 tr=0 ts=694bdd18 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=5Pw3dBPW34w_b6RJA_EA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 The current default hblank and vblank values are based on reaching 30 fps with the pixel-array outputting 1280x960, but the default format for the pixel-array source pad and the isp sink pad is 1296x976, correct the default hblank and vblank values to take this into account. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- Changes in v2: - Update comment about resolution / pixrate / FPS to: * Set the default to achieve full resolution (1296x976 analog crop * rectangle, 1280x960 output size) at 30fps with a 48 MHz pixclock. --- drivers/media/i2c/mt9m114.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index f63ab4bd040a4a62833d8bc716f94fc29aa03bd7..3fed509055142d7a134cae6caba= dde423743178c 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -332,12 +332,13 @@ * minimum values that have been seen in register lists are 303 and 21, use * them. * - * Set the default to achieve 1280x960 at 30fps with a 48 MHz pixclock. + * Set the default to achieve full resolution (1296x976 analog crop + * rectangle, 1280x960 output size) at 30fps with a 48 MHz pixclock. */ #define MT9M114_MIN_HBLANK 303 #define MT9M114_MIN_VBLANK 21 -#define MT9M114_DEF_HBLANK 323 -#define MT9M114_DEF_VBLANK 39 +#define MT9M114_DEF_HBLANK 307 +#define MT9M114_DEF_VBLANK 23 =20 #define MT9M114_DEF_FRAME_RATE 30 #define MT9M114_MAX_FRAME_RATE 120 --=20 2.52.0