From nobody Mon Feb 9 09:32:59 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 461DA315765 for ; Wed, 24 Dec 2025 12:31:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579479; cv=none; b=SwpeJhoSXEHgrJYRdJw20/xnFSJzMJyeMjYUq6VPhjYTvAZ3KP4RnVFDavOhXFE2DxnzQIkgdDrNtY1oDkBlQYvt/f7Hn9mwAC6n44uHOWya6A+rf66fqSmsjQo0mFKbE7wDP9yuZ9jmkD466wzA67iZuaXx/QjK7m4gv1yIgrE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579479; c=relaxed/simple; bh=zJcfKTtr2OUt1atKsnqHQ8YeTCDMJphSaZU5HYu0LZ4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UBwBll6LWSaur+M9aqZwppkTNmvsY35lJXJdY2yREAHBpSg43q/6+un0QSeulH4Friqz8m4Tb/WAo/jz6Or+7G3NGs589xBZiXCh/2xhGAgOf03KPTOyAOP8fmLMnFbLreCBZA+QsfhoGN9g3oPxaGQ4KlEgZW918t9QFmG4rig= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SY+DonnX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TrDSHt0X; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SY+DonnX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TrDSHt0X" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BOAR4WR1597720 for ; Wed, 24 Dec 2025 12:31:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 69LwN2GymV95gpb6upe2s92Dg5vXdcAsg/CyJzbONbU=; b=SY+DonnXVeKfnQT6 qCrpcSc4dnXez1igRkWJX5lMoXZwDBmgcVq0gMhpfzFqkI93r0DHW7QgHrNYf5Vr Y8D3gf7ZNhitc49WnioTerAdYQ9zmnNHbaRUlJhON/hhItUWsNCLJJN6OpYNuStD FyghPVHCIzifqW24dwY+1vx+dBkwn1O5cRk8duNLxtwi7zyJgEnsrtN4ms1IUtkq HBxLDLautqXnzSBwcBlUojwf/Yy6S5/Ik7OXR1bmYa3FFfT+hqu5Xbffxkbz8g9q U9meMADe13ps8cI3SdcQ9gcNNogE0VsYVKbLfDRTO3NoFxQ3LWNGxKKUxqSwq+0a MdADnw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b8683hjvt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:17 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4f4a92bf359so128563731cf.2 for ; Wed, 24 Dec 2025 04:31:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579476; x=1767184276; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=69LwN2GymV95gpb6upe2s92Dg5vXdcAsg/CyJzbONbU=; b=TrDSHt0XmQtkZxvtlO3UfcSPT59LRBsj70AkuWgA3Dmdu7hUM0UDyR+0yb6FTWniZD SeAPH2Pu5SX2E70bknGwtGEOyWDTiUCBvIVdOJgCeZ5CXy+lXAsV0YgsJFTZkLW5OlB/ PHps6Ja1dzNxi+Ui9wTnf8Ucl5TCbwgVcFKs5y2aTjJ0frYYqNFn5aIdcqADXSS+N3EH bS4wnLWExyTZoK3z4C8KKDSgzLYNupx6LE9zzvcIwLuQCsGE0a4HC/R3F1Y4n4uiug5e SObOp4cihiW4kGwzwGgAt09f52+IJqf6v8LqLDJZ4o/Gk6JX3+fIlhGpUwbISudS7RDV CW8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579476; x=1767184276; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=69LwN2GymV95gpb6upe2s92Dg5vXdcAsg/CyJzbONbU=; b=f40ouwd4v18IuwNlTVqCBfdAi5n7ngWyF5Le2g9xoa8hRtc5IQ9ViGzFnrGmUIW3/V AnZ3EBePk2o0vGam9BU31n86MVpZ6477zohZMGUxaBcyE1tApNesQnzXZco/9bFYTRa+ 1R9E19+1LoejlBCHr75UWrEpvbYgA/EWfC1s9siaYtQqgfE+NbrWQ8E5p4a+eBgkrQ1l /lIQIN9WCmvyi7wNLqlpKrWZUNe6birz25aMKqWSoggBc9moDoAUiG0wIcfXyNjnspBV F9pmbeVmNZH20fX3MUeT6ZUxJ6muqkeTsTQLVzIGWJ3QHtoowiODmbUt5HxTg12udjUV uwzg== X-Forwarded-Encrypted: i=1; AJvYcCVY9TI1s7VgfCw9Mm1cqF6FLlS7E4QfTyV9Qvc3DznVfDVlwjmNGIvw2gKt0/4zYwFAsqHhTwjb4bP74gA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx81owhINiqWv+Z5hgl7ZOOzWCDyWJndhTtRSWhOS4rM/3Rfb/Z 2xiFaLvZbwPwSQM3FHRaJ+iov6dPUTodrqwV4sEnrdmVE4i+1JK0dfXNJdbQQ2kOLiAiokGctaV SF0yT2OHlUSE1LMCySV2Spr7fOm4WMmePhfYa2fULV3QCMC5BxdKXP4STA45fsWG6/jmWfAcAqA E= X-Gm-Gg: AY/fxX6P6i9xyuYbpA/Kms4tWml0CTdKahGZOTNVJrjTj4v4vp5LkoD0qZtQBgZPXa1 VCpgXr5qZkzEHvcXTIQpi7cA0cbu2ZeCIZfe/5WRJrsPlUAwsRSYGJIDQoafwNQ3D+Ste+lGPdG ufyrlAdbXeZoBSBdQBG3R1KZX0P92Uw3tkVQwjkLW6g1ONEkxx7OmWxAECewaiW7VMyXkBgYZTn GUmDgZzpMpoGup20w8/zWpjLV6a2jowZ5YDzhlB9RzHRV77ns3aAKCtO/mst89q5HU8E0CaKGog tbUbdy2dJhfXcwO4XYSHOwW9H1IAGD8mA17BrREX5l1iMOxhHW2mne1XogrGyDgkzhclFfGp0xf /oFO3Q5UyPdWoMIcusqyBH5KMkPfBjzErzYVzLzHFUQ+kfqKRXJaU0LTTuFrCkcmn4d57XYG4ep g5i9NAphaQYR8AHNsh1PJF434PzXNjLY7aM2VPz/3S X-Received: by 2002:a05:622a:2505:b0:4ee:1e63:a4e0 with SMTP id d75a77b69052e-4f4abdd5bf0mr284304821cf.74.1766579476237; Wed, 24 Dec 2025 04:31:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqgmQEf9res857crOrJAdP6n2C6W3dZtLXr/MM3Vab2v4e67/gWNhXFq8iSj83KVLRHU754w== X-Received: by 2002:a05:622a:2505:b0:4ee:1e63:a4e0 with SMTP id d75a77b69052e-4f4abdd5bf0mr284304271cf.74.1766579475839; Wed, 24 Dec 2025 04:31:15 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:14 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:11 +0100 Subject: [PATCH v4 02/15] media: aptina-pll: Add comment documenting the PLL chain Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-2-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-GUID: IvrFmrto7ajLjoLMJ5xeBO_INd3HwT8K X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfXzVUdWBxXaa7i G8Rs6q8oKikpJa8cXiHmLpamT2Mx9+l5WqjJDfr1GZhsaO6F/mFv8V9Q/ByQFdU7Y3erzhaQklo A4nyAswPyJA6jvMkYlGtVcpQ5YW4G8NrnE/1ylMz50MfcmOqGa7KsiMXUXz7Bd9R9nEzP5lbSHj ZoLMQym1ExwUtLkhkyD5R4IpcUr1+L30NlWcmGR7icDlqRmTcfXACO0HTrWnkfvo2SMJJsUP7y3 0DEtiTEkjlEMLDQPhzRa4OcU51168ex0OPL/98ivD534jIbZ916h75wjyY+rDbHoEHzeNoB5YHI yNmhA4sZ7ByFrFrdiBOOlv4KuubCz+g2seu1FF6x670Mbh8Ow/3qffjX3Ptv2mq649EnpUQ4wKQ nl8K6qAPAYkTiZx0IRHNT/HlhQWFN1MszlebLTKV9HBvSiKXgWiRMITYI1Hod3rKEkS6sqXsbC3 MyQN+EUhkIXwCZwG+MQ== X-Authority-Analysis: v=2.4 cv=HqV72kTS c=1 sm=1 tr=0 ts=694bdd15 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=oOvwe9_kTgpR66QT4jQA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-ORIG-GUID: IvrFmrto7ajLjoLMJ5xeBO_INd3HwT8K X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 suspectscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 Add a code-comment documenting the PLL chain, this is a verbatim copy of Laurent's ASCII-art PLL chain from the mailinglist. Link: https://lore.kernel.org/linux-media/20250629204655.GA2059@pendragon.i= deasonboard.com/ Suggested-by: Laurent Pinchart Signed-off-by: Hans de Goede Suggested-by: should really be Co-authored-by since I just copy and --- Suggested-by: should really be Co-authored-by since I just copy and pasted Laurent's comment from the list, but that requires Laurent's S-o-B. Laurent can you give your S-o-B for adding a Co-authored-by ? --- Changes in v4: - New patch in v4 of this series --- drivers/media/i2c/aptina-pll.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/media/i2c/aptina-pll.c b/drivers/media/i2c/aptina-pll.c index cd2ed4583c97ec87e516acfd249fdccf2f9efbb8..4a519ab587ba4cfb9945a1bb05e= 87a3b5e6d28c9 100644 --- a/drivers/media/i2c/aptina-pll.c +++ b/drivers/media/i2c/aptina-pll.c @@ -12,6 +12,16 @@ =20 #include "aptina-pll.h" =20 +/* + * Based on the docs the PLL is believed to have the following setup: + * + * +-----+ +-----+ +-----+ +-----+ +-----+ + * Fin --> | / N | --> | x M | --> | x 2 | --> | / P | --> | / 2 | --> + * +-----+ +-----+ +-----+ +-----+ +-----+ + * fBit fWord fSensor + * ext_clock int_clock out_clock pix_clock + */ + int aptina_pll_calculate(struct device *dev, const struct aptina_pll_limits *limits, struct aptina_pll *pll) --=20 2.52.0