From nobody Mon Feb 9 12:09:46 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5952337BAD for ; Wed, 24 Dec 2025 12:31:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579495; cv=none; b=ljcxVwUCd1WCd/Z4xnZ9SoMeKAGa0ZcUkHR4qIanVjAAxNvGoVXgDGAtx/fGT+HyfaxofqkrKOvBLRmBYpWQAdj9Arf2gwAJPUfN1m7jhHHYdOrJIk08WpMx83U9JQcPRyQY3Z8rS2x+r3JFw7qNmyy3s83KasvSDUbeRs+O/4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579495; c=relaxed/simple; bh=IMLWnBpEdvmDo08jNk86LMqu+0sVPIzGgtm02Xt1+lk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=En9iq5YG1saAUkNf2vIUDuY8q/nr6IyIKHdK2525vjJGz6oeZDeEjiVGiJvdP+3ExbJBrPKYVOf8lRVptLzksSr3KocoxZ0423yPCg0dVJylnewKTs4tjYpFpytdht6mcXhzEGwKb9wukaHQx57wgFK784fRGA0OifPPXC9wENw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kKP+egiO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eCbC+XuG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kKP+egiO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eCbC+XuG" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO8p5Ko1206442 for ; Wed, 24 Dec 2025 12:31:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bEoBh9JKwu7r7A6P4EErTSOLtSnplstn9SiQ4qQUmE8=; b=kKP+egiOKgzx0nwi Ihz6XdWM4nTV1S7J3FchX5ktw6Fakrjx1GC+jvqnv2p7YSw/c+WHp/3sz59fiwaj RuEGLszP7RxxOrpM77b9mOiXezPqizX2giyCNtg9uNODB/J4Pg7PyYDznl2yMXWh OaWclwPTg4IzIlvY53w35S4u8JuKASS7jZCPMXDSWwRYd29eGwAad8PYp/YbcdBm QxdXHmCOFzVRd0zZPPSk2zx2pNtivLxsp78AMCX2mhn0uGyzFhh63U55+ZaXmOGq GornK1WbwiiYxfbBjewiU200R59zTGg2S/soOvIJjEdNWR4olj7bMsW/iOZHcWvo iN4isQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b827r23nr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:32 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4f1d2aa793fso150876551cf.3 for ; Wed, 24 Dec 2025 04:31:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579492; x=1767184292; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bEoBh9JKwu7r7A6P4EErTSOLtSnplstn9SiQ4qQUmE8=; b=eCbC+XuGgm2vapEw0UdbxujsjohKZLXHh9iauFcVykK7ShryOzMfFQ4SoMCsOiWgp6 WK+6Svfj71bh/rNl9nJmgMrx9PbJfagBfOEYdIKD/9dRSpkrdw8Fc/OJea26q9SI9wst 0ifL0z2GBjMmX3aywvX7uioVCBZuqahtnIy39vHF2DjIhqs3Q6LCOeSUoAs+nRRf4rcE PSBJihuXMlbEUWTVVCciCG5ovYtFtB/BAzF1EZVuQQknmQRx3WGaovq/0vymn3u53kyD K+4/kNER0IFnm2KbHdX2D2nXpynxmr8rXXineO40LC0t6NzadRt6bwWx533v3b7uGDFy xyuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579492; x=1767184292; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bEoBh9JKwu7r7A6P4EErTSOLtSnplstn9SiQ4qQUmE8=; b=rDaq3W2gDfU49Klsxrvn7ZpwcFlgvDymz9bsngjgEtJ/u0NPRrLVnfm3ZdojCWiaoa lD8zFlkpRkFYYVVB0072YmAvth8yxiL0MJM5NGMNi8MpsWvmSZCTyCLTNF9XUntXcsne o5tYkdeFUfzRobv84njS6Pl+XdliPCmJHezQKsPB1T1VcJbgl/wvwOEhQZOAxpPEREwb rGVdf7xjZ23cNr51PlzPrjQezm4irQS1sX7a1jL7zl5Ms4Ojw837axeSQm5b8J/9DMrs jcRgHZbxB7MutxbLnSKnbaVCwS3g4o6RxCcIFrEaVfiY96UUDg6JXu5s6dBnIfDAZDxb 6bhw== X-Forwarded-Encrypted: i=1; AJvYcCUjHfmTABBaM5WdtnSzVaIxXrPz+O66fCNZ9+UJFN5BWJ9JGkrpyIH8dxlDrdnBTkF1D0C74z6G+FysmNY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+3C6mhMDlIrI9rf5Glbp9L6IjgEF8OWLn43yXC9S2Py6n5Jj2 m2xZjR+asetcrh74iTDxGfmgR/ju0WiGEe+XtDSOiB722CDccgsZT9yXm1DBNQYarqoG1GT8iim HfBuET2hmt4LInVfCJ0D91OuP3x56+LoUA82PghOQ6/PSvW9Ednc6uoOuPLdi6PrEqFo= X-Gm-Gg: AY/fxX4dXQKhMsZvym8kCpCgZrFauJrEatsru4sbVuJiboTiH9IN/bajsDpbrPF1UZC CvwZ+W3OxhSMi2CCDe1OUwc9P1XAmN3p6x7SXV6sBk77rWVCXQ68IYOVkhVOIfT8jP1G/llDfnc JvAEL+Hlj0z/+Tgq4NlL/MZ+y5In82INNovBFrzOPgJrLapFxtgDG+/MCJgAGtrm4qj926UHSGn rRL6kzZGoGNq5M3zvul+pBJr1m2uSQ0OAzh9dZF+8P+DKaXXwOqwjUb1YK8jKczDLMGkZ9WiqH9 OF4bPosOmYpUGsVfeYPsnbIpwpViu1TOMflcQ+hieagnZahmwFTxURMvLpzpdq50YB9wehZYdKi xZouCSN6VtjiJUlrxYk+y2jc7VZ/kcBVVHlklwtqLMcXUb3eVm1p2BOXqI8kPg9QYdjxcqKVX+0 +i/s74FcFB/ge8PbZrqmrCth0EA+ABK1wtWXiZBurL X-Received: by 2002:a05:622a:8d07:b0:4ec:f05e:2e11 with SMTP id d75a77b69052e-4f4b43cbee7mr206714351cf.80.1766579491865; Wed, 24 Dec 2025 04:31:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwJCB8NRVia6NneXVnLVFWql85or5cinFqsljTxuShriyIXsSySNjTAIt+O+zfUO/rvvpTJQ== X-Received: by 2002:a05:622a:8d07:b0:4ec:f05e:2e11 with SMTP id d75a77b69052e-4f4b43cbee7mr206713981cf.80.1766579491466; Wed, 24 Dec 2025 04:31:31 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:30 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:22 +0100 Subject: [PATCH v4 13/15] media: mt9m114: Drop start-, stop-streaming sequence from initialize Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-13-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: QpyB17iAkg5d9QGoTLtmGT8RV6-lAN72 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfXz9mN129ZayO/ J2THnttXueb3onzK15u25xtsQwNZFDEvUKFWSbOf+r1GxvLXPZgelm8smAK7JUWpTXTTEPknuhw xdqljxkT8vQwlIDTF7Qf7n85xFeBIgmOw9rxnURT4OwTj8VRrNL6ywL1ZuYD/tnp2YxUNuNlmRu yFx+DZLKtTQ1BQ3mZjuiapJLYPIKTyLgnTMA05aYxnk8AKHwpdQbv0L0xOEysHqPkStKzWqKdXk sITJnXPnoFi5/Dr9v9UFdx1FSWc5dkt+Iw0+iPsVglNwKL2EMIGHYolmr2e75sW/w/oUqhoYQ6U nZW0CnWRAfWgjw0cZAZd9rhjuLstGGf1gCijj+E/6pnShDhBZgphxn0ArRJ39yqRQ0UPVJO8k7+ zt5NY/oPPZz3guOsVXGj/3hYAIvhfqTu5d06ycwXeKpp4mK+7uz7sJWt7L1tMuBIExS9Qz7OEaW 7QuIcEft3y9erPy7//w== X-Proofpoint-GUID: QpyB17iAkg5d9QGoTLtmGT8RV6-lAN72 X-Authority-Analysis: v=2.4 cv=RbSdyltv c=1 sm=1 tr=0 ts=694bdd24 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=hSCjdWxdfPpt4Nx0-uUA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 Drop the start-, stop-streaming sequence from initialize. When streaming is started with a runtime-suspended sensor, mt9m114_start_streaming() will runtime-resume the sensor which calls mt9m114_initialize() immediately followed by calling mt9m114_set_state(ENTER_CONFIG_CHANGE). This results in the following state changes in quick succession: mt9m114_set_state(ENTER_CONFIG_CHANGE) -> transitions to STREAMING mt9m114_set_state(ENTER_SUSPEND) -> transitions to SUSPENDED mt9m114_set_state(ENTER_CONFIG_CHANGE) -> transitions to STREAMING these quick state changes confuses the CSI receiver on atomisp devices causing streaming to not work. Drop the state changes from mt9m114_initialize() and move the mt9m114_initialize() call to mt9m114_start_streaming() so that only a single mt9m114_set_state(ENTER_CONFIG_CHANGE) call is made when streaming is started with a runtime-suspend sensor. Signed-off-by: Hans de Goede --- Changes in v4: - Move the mt9m114_initialize() call to mt9m114_start_streaming() and drop the config_change_pending flag --- drivers/media/i2c/mt9m114.c | 33 +++++++-------------------------- 1 file changed, 7 insertions(+), 26 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 447a5eb34a6137a8e87bd119401571b5592fc77d..41e98f719a23045293ee47d8980= 675510a142afa 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -789,14 +789,6 @@ static int mt9m114_initialize(struct mt9m114 *sensor) if (ret < 0) return ret; =20 - ret =3D mt9m114_set_state(sensor, MT9M114_SYS_STATE_ENTER_CONFIG_CHANGE); - if (ret < 0) - return ret; - - ret =3D mt9m114_set_state(sensor, MT9M114_SYS_STATE_ENTER_SUSPEND); - if (ret < 0) - return ret; - return 0; } =20 @@ -967,6 +959,10 @@ static int mt9m114_start_streaming(struct mt9m114 *sen= sor, if (ret) return ret; =20 + ret =3D mt9m114_initialize(sensor); + if (ret) + goto error; + ret =3D mt9m114_configure_ifp(sensor, ifp_state); if (ret) goto error; @@ -2318,19 +2314,8 @@ static int __maybe_unused mt9m114_runtime_resume(str= uct device *dev) { struct v4l2_subdev *sd =3D dev_get_drvdata(dev); struct mt9m114 *sensor =3D ifp_to_mt9m114(sd); - int ret; =20 - ret =3D mt9m114_power_on(sensor); - if (ret) - return ret; - - ret =3D mt9m114_initialize(sensor); - if (ret) { - mt9m114_power_off(sensor); - return ret; - } - - return 0; + return mt9m114_power_on(sensor); } =20 static int __maybe_unused mt9m114_runtime_suspend(struct device *dev) @@ -2562,8 +2547,8 @@ static int mt9m114_probe(struct i2c_client *client) /* * Identify the sensor. The driver supports runtime PM, but needs to * work when runtime PM is disabled in the kernel. To that end, power - * the sensor on manually here, and initialize it after identification - * to reach the same state as if resumed through runtime PM. + * the sensor on manually here and identify it to reach the same state + * as if resumed through runtime PM. */ ret =3D mt9m114_power_on(sensor); if (ret < 0) { @@ -2575,10 +2560,6 @@ static int mt9m114_probe(struct i2c_client *client) if (ret < 0) goto error_power_off; =20 - ret =3D mt9m114_initialize(sensor); - if (ret < 0) - goto error_power_off; - /* * Enable runtime PM with autosuspend. As the device has been powered * manually, mark it as active, and increase the usage count without --=20 2.52.0