From nobody Mon Feb 9 09:08:59 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1AF030DEBC for ; Wed, 24 Dec 2025 12:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579494; cv=none; b=YAO2wOlBWZtXZ2ptpm4gxhfPRGkPq5wJZjXo8rHUAZ5/ZyCxp91VBNXPJPDPVPwpFPG2vJQ7dOZRLCWpJ4H7/ggcaBDZRDZAxoI67BRovdNfJt5Bzxheqhhwh+DzKSZ4aYp7Sj75+pzDBRb3LFTM4/XJHFZjCdlsH7BLtD3AOVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579494; c=relaxed/simple; bh=cWVomP9zKRf6u0DWxVAunI1OwfFHHapDxWq5Lw22DN8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=X8/yVyqtGD+2ThRQErMhqsyviddS4JjeRNdn3gkbF4MFLnm9EDHzLkPdjQIrl7ITbpGfsHHGGFS4jrWAeJSZfWcCeWdxBBGa3pbyH/FTmbZEoUzi2K9lEqahti+EJmWnMvdM/C94vQeV0PfKgYouk9kkKq66/C5Dzm1MmrLZiXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Otxwk++T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MFac1s6M; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Otxwk++T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MFac1s6M" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BOBXtJE461408 for ; Wed, 24 Dec 2025 12:31:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= P63PUFn7+yRVOLLrjL3JxfKbtV0eP4+Vc+xT8X3UBss=; b=Otxwk++TAA+sVTek FNMwycbpOTmZUWltM+AV/+MrE31WIIiYQv+16QiYyT1Z9mEHt5Bfse034BrK8ZC4 JqLjuZtQ1pVituYoQ9uMjtix/dmxHGzYcne0uSw2nHwABjS9kDBBN+y4dYK8LjZu 4+trOs3v25jSdfKrDwvKq/R7a9RP5Ag2/4/BnNfDDfARXlBBIMU05YV0H6N6hZe9 6JiLs3hsH+4OxUSdhnKV47pLT8WO60ViGDvEmv4+zI3WKlNp3UUt/SRvvuFY4vma JYzeIS4Ec7nvjTM2z2Or6mFU1R5cOJn9NgKjgNPnMuEqxxhg+P6nqdcX+BZsTpu5 c4HIkg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7w8fu5sx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:31 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4f4d60d1fbdso91164741cf.3 for ; Wed, 24 Dec 2025 04:31:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579491; x=1767184291; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=P63PUFn7+yRVOLLrjL3JxfKbtV0eP4+Vc+xT8X3UBss=; b=MFac1s6MxQtd2v+d1ffb4sU/BMUVU+Ny8Om9uqeXiyigVDkMvLuf1UfNK96paRBQSH 38xBVHqZ7OPzMThVMAZhlaxJruBs65uPXrnqCV1WUSxCYfplGOfL3XrrtXfCIQNlGxkt tj8YoQyQWojS2mb+zc7wFCPp68cNhyv8HkB+jReFHfOY4uAL+LEO+BCaAwWZoDB/9M92 9ZlpL+rTMpMtOaM7XxuQyXwqIxD7ig/usmSdbgSqdq7/4rPRDDuU9tiFRxRGseL9Zk5Z jz2wUMt982td6qKUnBmW7VqQmpM4llZxvMJxBSc7j5TiUlQIVcoJc4hWfm0CcAtRpI6G pJZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579491; x=1767184291; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=P63PUFn7+yRVOLLrjL3JxfKbtV0eP4+Vc+xT8X3UBss=; b=S8abPdOxO8FMVNVzCAqdDRjelYd/CamFy07dlbgc549b8ApAVxm+zy/MBRf48KUQxv Y/4Ypoe4gt3J5WsoCqcswTLyDDYsKSXuFRdRXvddFKUa/Jgn4H4CwPMpT3oo/rX3UZvf mKSWPvEjYL4OkL8xNpxjEqeTG2z8aqE8aimeS8Qz3mpbRAxskmc6/f2xeLXZSt1jwKNj Gyosb+4g0/Su8nmdEdnkzCVgrjF9aE06vb0oHlh1iTMv2yJYukH9IYy2np33H7CM8Clv rW+CxFQ5BujrwFI1Ce2IBh6lEnXy8YcZIXMus5wIwme1DknvwfgxwS74FPhTrslxiW71 /13g== X-Forwarded-Encrypted: i=1; AJvYcCUogLkqBMvBXZ3o/elm0PqwXIvVVO/AxRHAnBrP9aJKbpTkGMYjkDvlwyrqd70gTzXfx1HgpWP0ICZK81w=@vger.kernel.org X-Gm-Message-State: AOJu0YyQ9lykxjbQK4Kbk1W6asQVWjIzCXSYjxh7qBS//H5PuQ1KcOuX 2VotJRyqtFrJJTpnM2rbWPtla8EEhc7pQLQw41DeUrK0zmNnQlrDLMAtTuPQO6f02f87G+X47sf L3W5VpvC3DYHU01JO0WC4x64NeRZYT7n9+A2pWME9E0/lD9dj3mWrTULtYYuYdeqJjQk= X-Gm-Gg: AY/fxX5IsNBe9iARZVmzLYIzADbsd/9s1CzlumWOHOffZGgiIuM4C/eIaVv2plHAtHh fLP0Xi1R4upqzbh7lm9MfV0IIS73df2Ywr9anmro75rhJmiz1nVh05Cxcy9H1LTIb5U0goyhpj4 Z7nZGrniUsvc6TWTCwWvbo0+395Pye1wpzguJDdcBTGBMiGhw4caL2VoyWhfnfU9+rt3WFGwl+z 6xX60fvPBJKHjXY3uuI7bdjfxNw6+9QHPfpU6KHSDylYal9M/JCoRnrnJ/SE2YHJ/l+MJrmaSLk KDioRstuwbajlcMv6qnIsFkRwu56mRpCP99Q654WCz/PMgKQwfg+AKsE8VmwUNx/LVZAzdC4CV8 KRFXUvrtqAwE1GNw5HyENrtDA74oOeBWl9U63hDS3/E14TYX9zcaLZEXrLY6k7Jj5mTZ8ssD0b2 JWafbA24VnaNpJOnum5qQoXb3ktK66x4GZyRnWVwtq X-Received: by 2002:a05:622a:28f:b0:4ee:1563:2829 with SMTP id d75a77b69052e-4f4abdaad3cmr242894261cf.72.1766579490903; Wed, 24 Dec 2025 04:31:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHVGi8qrNoMP9+F4grb10LDVDGsvOdEj/9cBMbDMcbw3OsAYgQqTLzm+ik5WDUgIS9C30NqGw== X-Received: by 2002:a05:622a:28f:b0:4ee:1563:2829 with SMTP id d75a77b69052e-4f4abdaad3cmr242893801cf.72.1766579490411; Wed, 24 Dec 2025 04:31:30 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:28 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:21 +0100 Subject: [PATCH v4 12/15] media: mt9m114: Don't allow changing the IFP crop/compose selections when bypassing the scaler Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-12-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-GUID: fETZs83tdscnKLowhY4rX8O_ZrER053E X-Proofpoint-ORIG-GUID: fETZs83tdscnKLowhY4rX8O_ZrER053E X-Authority-Analysis: v=2.4 cv=QutTHFyd c=1 sm=1 tr=0 ts=694bdd23 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=FI8FN61yIa-P2m5uk4AA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfXzDWAhDgvgPLu 30EWxfX3kri91vxQ0ExIw/07nXigdrEWCiPE+UScYIzxyJSALkWM+PlEU3DhQcIFWE7HMy+H4Re wGTTMsidO3LMd7qdn6PmlssYasOEtKzKlakdQO701HAUdrYY9jBHrIGv3BpVcMTUqagMa4arfIK Iz8S5B3CuIDvMcRcekd9E+cOGoIQ03f7efObynneHsrPWXIQqcQABF9urrp9wIjzl+SdG2t2/J+ kTt4LvkRiML6gFsttHQiArhwJ9F4KGjPTTKHEkoR+lmvqzRnwYBvyTe32FYc8AvOTeGNtxVTbZ9 7Vb7GJTAb4nEOzdCPKxo/ehJutMbCHxVwFAiuFy0ShNkpbqqYoJTAQrFh785IUSDQC6jq5HJB3j ML7UQYGCrwOkwcEay8/OrVZzf1wPDWG/F/XPtZnnifzB55TAHVvFk8DuuUAlaCdTMmQIsVjZyJA 8XI9oG/AFCQDBOmbmqw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 bulkscore=0 impostorscore=0 spamscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 The scaler is bypassed when the ISP source/output pad's pixel-format is set to MEDIA_BUS_FMT_SGRBG10_1X10. Don't allow changing the IFP crop and/or compose selections when in this mode. Instead of returning -EINVAL simply return the current (noop) crop and compose rectangles. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- Changes in v4: - Move crop =3D v4l2_subdev_state_get_crop(state, 0); up a couple of lines to avoid having to call it twice Changes in v3: - This is a new patch in v3 of this patch-set, which comes from splitting up "media: mt9m114: Fix scaler bypass mode" into multiple patches - Add src_format local variable --- drivers/media/i2c/mt9m114.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 8e0b5bf6db621d12b36f578b6374377c69503976..447a5eb34a6137a8e87bd119401= 571b5592fc77d 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -1984,7 +1984,7 @@ static int mt9m114_ifp_set_selection(struct v4l2_subd= ev *sd, struct v4l2_subdev_state *state, struct v4l2_subdev_selection *sel) { - struct v4l2_mbus_framefmt *format; + struct v4l2_mbus_framefmt *format, *src_format; struct v4l2_rect *crop; struct v4l2_rect *compose; unsigned int border; @@ -1997,8 +1997,16 @@ static int mt9m114_ifp_set_selection(struct v4l2_sub= dev *sd, if (sel->pad !=3D 0) return -EINVAL; =20 - format =3D v4l2_subdev_state_get_format(state, 0); crop =3D v4l2_subdev_state_get_crop(state, 0); + + /* Crop and compose cannot be changed when bypassing the scaler. */ + src_format =3D v4l2_subdev_state_get_format(state, 1); + if (src_format->code =3D=3D MEDIA_BUS_FMT_SGRBG10_1X10) { + sel->r =3D *crop; + return 0; + } + + format =3D v4l2_subdev_state_get_format(state, 0); compose =3D v4l2_subdev_state_get_compose(state, 0); =20 if (sel->target =3D=3D V4L2_SEL_TGT_CROP) { @@ -2043,9 +2051,8 @@ static int mt9m114_ifp_set_selection(struct v4l2_subd= ev *sd, } =20 /* Propagate the compose rectangle to the source format. */ - format =3D v4l2_subdev_state_get_format(state, 1); - format->width =3D compose->width; - format->height =3D compose->height; + src_format->width =3D compose->width; + src_format->height =3D compose->height; =20 return 0; } --=20 2.52.0