From nobody Sun Feb 8 10:33:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BD962F84F for ; Wed, 24 Dec 2025 12:31:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579477; cv=none; b=b97uBhfdMQafeBrbWTWrVSL2mddObK0jPke1/+t56EClJdW6cE448Gj++hCnBTCnjAi1tHupkiTtA7Oy5wMgqysEImK9iTmjldc2EnhUS6n/ePoDN8i/lozhv9afHy2Fy7FctvTK5qYIbB6ZPP398RO5MMUJV0Joym2vai3+zSg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579477; c=relaxed/simple; bh=QUXpcxV1k5QMZf+QaO2uJlP0NmXwPLJrLAyJVowOkB0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gHC4UrKLHGe+oiMjtzyv/FUHKSoTtkZ3Km1ucptNbUXq+NzpVjrdVjZf2MTewIPtjESJkkNWIBJpYSpL+j/var6NpdCA6ugesKgnBH1czXpIpj80PI0rx3XbymzYQE74US3RgIhB0xKCEb0XZZtPlsal2nf7RMicjf96T2PPYkg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I3VwW3a+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KOLWY4aF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I3VwW3a+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KOLWY4aF" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO8JK0T721758 for ; Wed, 24 Dec 2025 12:31:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PxeWmtW8IdrQ7Qfko3faPMcvx1IgxirxWZVDR5z3bR0=; b=I3VwW3a+re1+EgNI d/Bc3rsqDSLebs+X6r/6B4iyUVymL0fKEASUVnG13hZ5Twt+7vgUBK20WuSOZH9B QG4YVBdkNScY2osFINN6Mg/EJkoPEShsrgUm/hNfj5iR62QllKQZ1bmPNbmcIr6T HZTLpSLVTkDdmZuVDTuQWk+X7jTzSh8U3OemQpc1Go7gqOt/liWWNTmbC32w7rwB KoJYVJjWSbonB+2UhnzIOoS0BhJYKn/UjE484XK3IIwf2nIKP6xQGVPrHK5Si6SG epjw8dDS7o/seMh6PEEMBBEcpNiPhE/TpbpRQ6930Uton/UAc9t43VYW7za/fWwa uQ+xyw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b81mta743-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:15 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4f1d26abbd8so160547081cf.1 for ; Wed, 24 Dec 2025 04:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579475; x=1767184275; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PxeWmtW8IdrQ7Qfko3faPMcvx1IgxirxWZVDR5z3bR0=; b=KOLWY4aFOAUvmjS9xlnd6D20NKLWjyn99VVdMIOGr3kRhV2MXD/aZgyMWuEtx+ELbx Ubz0wme3F0WiAJsQe5MSd0arAf7eaGnUJo1ZsaTfYZsbxk3igtVt1GHTJeXHG266XNkB JX8laFGKssKZFewvFnNSFoMmyAIvmJ2h9CqtBpKz+kxxZ2iE98VYrzkUF0OG308A5NwD AGSWt5T+b0Uq0M9oIcUGW/efygV821TTFYeg1az1x+0RCOdZySJmSJM52sWUUXbzxx5a gKnUM8BtxkPXdebmCHKlqW5mtYhgtKSEtz+AEu+bTkDjlX0blznc4SaECzGbzEGrHbBy JgYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579475; x=1767184275; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PxeWmtW8IdrQ7Qfko3faPMcvx1IgxirxWZVDR5z3bR0=; b=kzfSAEvrtktUbIp4ektUP0l8uE4n961rxh4v4EPYSCzdL8Y2lS5uqDAZIKyM1cXd8/ 6+BEqEIdAFJuuSo/pBe8FGcDwqmWKhVf6oH8Ki9kcIY5lV1kQiTC3G33qY4j3sFFLKct 4haImi6OUbQm/JzvARkXGdVPfPp6/w6Ml0L7Sj86ZpTh2bnhT6MYHpNF/9FNypuZ+8UF qvxp6B001koM3+PdKeCi9ckQoPZ0fjiSsDa2GeAa0q1tmRRZqaRGBXVRsCNudVe1mdJD LgYHxgEx57hI0tabYJD77nOeXMMoURj8JHn3UAfZlU8qPdIXlnPbcxX2vAv5vLFLvh0y lipA== X-Forwarded-Encrypted: i=1; AJvYcCVZgvztB0T5bGXxmqOrFPBzwS81AsPGFm83Xd8/P1+0Xo4x1VF3NuUfLr6iwdKS61r9lmofdeU6huToyBs=@vger.kernel.org X-Gm-Message-State: AOJu0YwyNtmd3GTZvRa8eXzPHRWV77vKV0GHDHJQBRVFkr3fIKHvUhGp 9Do6U4hkA1mtvhxvXF4D/WC3TW1gkGEAp0GhaiKYPsN/y2nJVPEpjzj+pjUxPO5BsT7yy+RE0C7 XhqRKaPzjOG7tv2Bcg5gGx8Micgzwix/zZtbSm05Gi0p6fK3RJSYUmc0CbvpBP7OdHKg= X-Gm-Gg: AY/fxX6tzgrxJcBJLE9+nIF8l8Sio2C796Twh8CEVhEgNBc9MEAlu3B/5jsHNRFJ2bS 0+T4eRCgCPZ//wXdkDRSJbu9Wnt0hVq26G57fq6tvcS4Vtb5oKSGGXQfoFL3O4rqWUs0cDx9e/F p7+Ks8FQmdBSQ8oanUNIHbPRiR1450w67chvizoCYjt0F10//0lN0TGeho7F34T8qMKu2oamU5y 0vbLOjyVUHcc5jqjglW7OGvyqiZcUOdo+iGuifP5NynZZ+axoYrD7s1NKITT5LBq8xCkmAOSs2G bSONQblm4O5DqJdk+F7D57eTI2nuzGDpY9XP7nLe39/kiO4dz7fjW/JyrjkaxAlY707cS0lWgQO 36g3qHuyboHJ9KglCswi6fn1ONTzqo3tbggVhql/Dp7OmiNj7qZaxMvwbtLaaiam4QY5u1u56Gh 7MlFhZFVpvJ3Ga8+T+6nPhR+1IkhLvim2+5fa+gm+l X-Received: by 2002:ac8:5742:0:b0:4ed:66df:8023 with SMTP id d75a77b69052e-4f4abd06713mr256478891cf.30.1766579474625; Wed, 24 Dec 2025 04:31:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IG10MJnqbcNG2NynXrTi/3a8LLEiBdYSfOlbkKa1Enm743lN9701kxP4hriFYJGThDpB55cdg== X-Received: by 2002:ac8:5742:0:b0:4ed:66df:8023 with SMTP id d75a77b69052e-4f4abd06713mr256478451cf.30.1766579474195; Wed, 24 Dec 2025 04:31:14 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:13 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:10 +0100 Subject: [PATCH v4 01/15] media: aptina-pll: Debug log p1 min and max values Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-1-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Authority-Analysis: v=2.4 cv=e/ILiKp/ c=1 sm=1 tr=0 ts=694bdd13 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=ZdSappWxmhQcxru2t40A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-GUID: CjP9gPEG7ZVaZJKYP_qfnBU50BnFZQ2l X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfX1TEdjhGs/XD0 5SHqzy3k2iSfCOPm6fOrbDYA5+ImqUtUUwvvAYmn5Lm3Xp1DPufO4C+a1TGMqXYNAfjmNih0R/B uM192+QBZ+OZCh9Jsdk3giV1eK/8NZoD5TILDuMkS5ZNjlBxQ/zA/lB9DtLORXD1fvgYqOGBA+N 3sOTMVMwJXrJMyoX/XNqzoRuz0ob8L2FF8KqW91G5NWZSXu+zr+LiS0i7zR58MwmmVWPBvq2Pnr VQVVdk42hWaOv5APvxAQ5rVsOpiQiCApAA7oOLU3JJBUI6/TXBzJ1GCv20N7MNPFIa6dRZmW15V PmS0HCZagKbtIT2XjH24NGF7591KCC9ygP24gDZEEqN+joGf35GK1tqXfUjF4urbKiWJ2kMtxbX Fycd4OlDrnVZHxeLDQf841CD6hzOvuvVY3FjdCVORuG+CTiJ7f7S8hXd+6wd/KrG4A7rLyIc28k 6p+AXfPEfKSXPY1YqVQ== X-Proofpoint-ORIG-GUID: CjP9gPEG7ZVaZJKYP_qfnBU50BnFZQ2l X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 Make aptina_pll_calculate() debug log the calculated p1 min and max values, this makes it easier to see how the m, n and p1 values were chosen. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- drivers/media/i2c/aptina-pll.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/aptina-pll.c b/drivers/media/i2c/aptina-pll.c index b1f89bbf9d473f6ef00ebb8250405018d07e668b..cd2ed4583c97ec87e516acfd249= fdccf2f9efbb8 100644 --- a/drivers/media/i2c/aptina-pll.c +++ b/drivers/media/i2c/aptina-pll.c @@ -129,6 +129,8 @@ int aptina_pll_calculate(struct device *dev, p1_max =3D min(limits->p1_max, limits->out_clock_max * div / (pll->ext_clock * pll->m)); =20 + dev_dbg(dev, "pll: p1 min %u max %u\n", p1_min, p1_max); + for (p1 =3D p1_max & ~1; p1 >=3D p1_min; p1 -=3D 2) { unsigned int mf_inc =3D p1 / gcd(div, p1); unsigned int mf_high; --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 461DA315765 for ; Wed, 24 Dec 2025 12:31:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579479; cv=none; b=SwpeJhoSXEHgrJYRdJw20/xnFSJzMJyeMjYUq6VPhjYTvAZ3KP4RnVFDavOhXFE2DxnzQIkgdDrNtY1oDkBlQYvt/f7Hn9mwAC6n44uHOWya6A+rf66fqSmsjQo0mFKbE7wDP9yuZ9jmkD466wzA67iZuaXx/QjK7m4gv1yIgrE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579479; c=relaxed/simple; bh=zJcfKTtr2OUt1atKsnqHQ8YeTCDMJphSaZU5HYu0LZ4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UBwBll6LWSaur+M9aqZwppkTNmvsY35lJXJdY2yREAHBpSg43q/6+un0QSeulH4Friqz8m4Tb/WAo/jz6Or+7G3NGs589xBZiXCh/2xhGAgOf03KPTOyAOP8fmLMnFbLreCBZA+QsfhoGN9g3oPxaGQ4KlEgZW918t9QFmG4rig= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SY+DonnX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TrDSHt0X; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SY+DonnX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TrDSHt0X" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BOAR4WR1597720 for ; Wed, 24 Dec 2025 12:31:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 69LwN2GymV95gpb6upe2s92Dg5vXdcAsg/CyJzbONbU=; b=SY+DonnXVeKfnQT6 qCrpcSc4dnXez1igRkWJX5lMoXZwDBmgcVq0gMhpfzFqkI93r0DHW7QgHrNYf5Vr Y8D3gf7ZNhitc49WnioTerAdYQ9zmnNHbaRUlJhON/hhItUWsNCLJJN6OpYNuStD FyghPVHCIzifqW24dwY+1vx+dBkwn1O5cRk8duNLxtwi7zyJgEnsrtN4ms1IUtkq HBxLDLautqXnzSBwcBlUojwf/Yy6S5/Ik7OXR1bmYa3FFfT+hqu5Xbffxkbz8g9q U9meMADe13ps8cI3SdcQ9gcNNogE0VsYVKbLfDRTO3NoFxQ3LWNGxKKUxqSwq+0a MdADnw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b8683hjvt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:17 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4f4a92bf359so128563731cf.2 for ; Wed, 24 Dec 2025 04:31:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579476; x=1767184276; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=69LwN2GymV95gpb6upe2s92Dg5vXdcAsg/CyJzbONbU=; b=TrDSHt0XmQtkZxvtlO3UfcSPT59LRBsj70AkuWgA3Dmdu7hUM0UDyR+0yb6FTWniZD SeAPH2Pu5SX2E70bknGwtGEOyWDTiUCBvIVdOJgCeZ5CXy+lXAsV0YgsJFTZkLW5OlB/ PHps6Ja1dzNxi+Ui9wTnf8Ucl5TCbwgVcFKs5y2aTjJ0frYYqNFn5aIdcqADXSS+N3EH bS4wnLWExyTZoK3z4C8KKDSgzLYNupx6LE9zzvcIwLuQCsGE0a4HC/R3F1Y4n4uiug5e SObOp4cihiW4kGwzwGgAt09f52+IJqf6v8LqLDJZ4o/Gk6JX3+fIlhGpUwbISudS7RDV CW8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579476; x=1767184276; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=69LwN2GymV95gpb6upe2s92Dg5vXdcAsg/CyJzbONbU=; b=f40ouwd4v18IuwNlTVqCBfdAi5n7ngWyF5Le2g9xoa8hRtc5IQ9ViGzFnrGmUIW3/V AnZ3EBePk2o0vGam9BU31n86MVpZ6477zohZMGUxaBcyE1tApNesQnzXZco/9bFYTRa+ 1R9E19+1LoejlBCHr75UWrEpvbYgA/EWfC1s9siaYtQqgfE+NbrWQ8E5p4a+eBgkrQ1l /lIQIN9WCmvyi7wNLqlpKrWZUNe6birz25aMKqWSoggBc9moDoAUiG0wIcfXyNjnspBV F9pmbeVmNZH20fX3MUeT6ZUxJ6muqkeTsTQLVzIGWJ3QHtoowiODmbUt5HxTg12udjUV uwzg== X-Forwarded-Encrypted: i=1; AJvYcCVY9TI1s7VgfCw9Mm1cqF6FLlS7E4QfTyV9Qvc3DznVfDVlwjmNGIvw2gKt0/4zYwFAsqHhTwjb4bP74gA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx81owhINiqWv+Z5hgl7ZOOzWCDyWJndhTtRSWhOS4rM/3Rfb/Z 2xiFaLvZbwPwSQM3FHRaJ+iov6dPUTodrqwV4sEnrdmVE4i+1JK0dfXNJdbQQ2kOLiAiokGctaV SF0yT2OHlUSE1LMCySV2Spr7fOm4WMmePhfYa2fULV3QCMC5BxdKXP4STA45fsWG6/jmWfAcAqA E= X-Gm-Gg: AY/fxX6P6i9xyuYbpA/Kms4tWml0CTdKahGZOTNVJrjTj4v4vp5LkoD0qZtQBgZPXa1 VCpgXr5qZkzEHvcXTIQpi7cA0cbu2ZeCIZfe/5WRJrsPlUAwsRSYGJIDQoafwNQ3D+Ste+lGPdG ufyrlAdbXeZoBSBdQBG3R1KZX0P92Uw3tkVQwjkLW6g1ONEkxx7OmWxAECewaiW7VMyXkBgYZTn GUmDgZzpMpoGup20w8/zWpjLV6a2jowZ5YDzhlB9RzHRV77ns3aAKCtO/mst89q5HU8E0CaKGog tbUbdy2dJhfXcwO4XYSHOwW9H1IAGD8mA17BrREX5l1iMOxhHW2mne1XogrGyDgkzhclFfGp0xf /oFO3Q5UyPdWoMIcusqyBH5KMkPfBjzErzYVzLzHFUQ+kfqKRXJaU0LTTuFrCkcmn4d57XYG4ep g5i9NAphaQYR8AHNsh1PJF434PzXNjLY7aM2VPz/3S X-Received: by 2002:a05:622a:2505:b0:4ee:1e63:a4e0 with SMTP id d75a77b69052e-4f4abdd5bf0mr284304821cf.74.1766579476237; Wed, 24 Dec 2025 04:31:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqgmQEf9res857crOrJAdP6n2C6W3dZtLXr/MM3Vab2v4e67/gWNhXFq8iSj83KVLRHU754w== X-Received: by 2002:a05:622a:2505:b0:4ee:1e63:a4e0 with SMTP id d75a77b69052e-4f4abdd5bf0mr284304271cf.74.1766579475839; Wed, 24 Dec 2025 04:31:15 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:14 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:11 +0100 Subject: [PATCH v4 02/15] media: aptina-pll: Add comment documenting the PLL chain Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-2-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-GUID: IvrFmrto7ajLjoLMJ5xeBO_INd3HwT8K X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfXzVUdWBxXaa7i G8Rs6q8oKikpJa8cXiHmLpamT2Mx9+l5WqjJDfr1GZhsaO6F/mFv8V9Q/ByQFdU7Y3erzhaQklo A4nyAswPyJA6jvMkYlGtVcpQ5YW4G8NrnE/1ylMz50MfcmOqGa7KsiMXUXz7Bd9R9nEzP5lbSHj ZoLMQym1ExwUtLkhkyD5R4IpcUr1+L30NlWcmGR7icDlqRmTcfXACO0HTrWnkfvo2SMJJsUP7y3 0DEtiTEkjlEMLDQPhzRa4OcU51168ex0OPL/98ivD534jIbZ916h75wjyY+rDbHoEHzeNoB5YHI yNmhA4sZ7ByFrFrdiBOOlv4KuubCz+g2seu1FF6x670Mbh8Ow/3qffjX3Ptv2mq649EnpUQ4wKQ nl8K6qAPAYkTiZx0IRHNT/HlhQWFN1MszlebLTKV9HBvSiKXgWiRMITYI1Hod3rKEkS6sqXsbC3 MyQN+EUhkIXwCZwG+MQ== X-Authority-Analysis: v=2.4 cv=HqV72kTS c=1 sm=1 tr=0 ts=694bdd15 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=oOvwe9_kTgpR66QT4jQA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-ORIG-GUID: IvrFmrto7ajLjoLMJ5xeBO_INd3HwT8K X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 suspectscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 Add a code-comment documenting the PLL chain, this is a verbatim copy of Laurent's ASCII-art PLL chain from the mailinglist. Link: https://lore.kernel.org/linux-media/20250629204655.GA2059@pendragon.i= deasonboard.com/ Suggested-by: Laurent Pinchart Signed-off-by: Hans de Goede Suggested-by: should really be Co-authored-by since I just copy and --- Suggested-by: should really be Co-authored-by since I just copy and pasted Laurent's comment from the list, but that requires Laurent's S-o-B. Laurent can you give your S-o-B for adding a Co-authored-by ? --- Changes in v4: - New patch in v4 of this series --- drivers/media/i2c/aptina-pll.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/media/i2c/aptina-pll.c b/drivers/media/i2c/aptina-pll.c index cd2ed4583c97ec87e516acfd249fdccf2f9efbb8..4a519ab587ba4cfb9945a1bb05e= 87a3b5e6d28c9 100644 --- a/drivers/media/i2c/aptina-pll.c +++ b/drivers/media/i2c/aptina-pll.c @@ -12,6 +12,16 @@ =20 #include "aptina-pll.h" =20 +/* + * Based on the docs the PLL is believed to have the following setup: + * + * +-----+ +-----+ +-----+ +-----+ +-----+ + * Fin --> | / N | --> | x M | --> | x 2 | --> | / P | --> | / 2 | --> + * +-----+ +-----+ +-----+ +-----+ +-----+ + * fBit fWord fSensor + * ext_clock int_clock out_clock pix_clock + */ + int aptina_pll_calculate(struct device *dev, const struct aptina_pll_limits *limits, struct aptina_pll *pll) --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A53A53358BB for ; Wed, 24 Dec 2025 12:31:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579481; cv=none; b=cVv9K4/I9DMySC5XHIi/LAad01Geu8p++2k3GHATKKMs7y/tU+7g7n6Cd1EDsRFK5tqecY9VI6QltocsaZL8h1rwkoE9gUN5BFhfAHCa9lqHJPkDeGVcv5r6ryjo5qYmV5KY+H2nz4yIQJd6UKH5MlQa3435VrimkzKg+6mTWNc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579481; c=relaxed/simple; bh=V5hNscTUE9okWFBUacYTQQzzy81tL/hihVZt7dvwhIM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PYlo9bjGtLWgGQin0bwh7vySqNSHX7ABVQdLvfFCFzZy8fyOsVTNpPJES3w9XVVeK+6KX6u9y+xaTNS8ecxWzKAOK1kUd86C1YjNgdblJyDEfcluZ+sM8KGhwuxiYBtYcUIxCrlnnaE6vXa2wtKqAsM/bAbcCMHrzUTi6qmSV3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dYQIvOjf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=abNE08hw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dYQIvOjf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="abNE08hw" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO7kiVD1056400 for ; Wed, 24 Dec 2025 12:31:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V/pv9ikPnnH+8sOBCPbx5yFQw75cMwx+JPtiYG8MJH0=; b=dYQIvOjfjRFwjYcm dsImnJBnI8vAO6FG47XzUx/O9ue0aV4LY6I0VrYnYFVzNg1jVWwpkqo0Q90DRAxa 4xIwXkFwoA8dFs3AIJhEFN5tBowndzMhRZ59pHkmFtnBRr9nOgtHyaBWUnKkfd0Y kWyfFF+i+RrdCihTclHfVnIwrfRgL7bapgUti2rbyT4dWRIVQzYfX4ys/yObY6Sw qywi2JGDs675vVqAQXFfrV0IQrcqA6UpZsLzhnl0AVVJ5IE8jeRuAAdq/X43qeqT ovWpcMuq58IjriCB6ufVC5uyuX1DslCmSRvASI5IEjPMl2zltCLdPFI4xjFRpl97 6AXc+g== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b811v2e25-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:18 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ee0193a239so61467971cf.0 for ; Wed, 24 Dec 2025 04:31:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579477; x=1767184277; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=V/pv9ikPnnH+8sOBCPbx5yFQw75cMwx+JPtiYG8MJH0=; b=abNE08hwWYXh84a0ruGtX7iuIrYg1Tu8EEwPvNspIPvAnMqyNe3QPXzmrbvYDxkqm1 19tSIq7hdduvoWZW/TtinZIXU1GwYwwQUkPfR05RUpXLasjhltsk9tziDMHgvrftvz6o UrglFq0KsLlTSYfeEbSvqv02i7Qdj4TK7sfXmXXgsmgpaLGlxo9Fm1O2PRQAkecZo9rf r0X27Eaib3+NSHsS8LEdjU7UkFeKQWR0EsjL5FbaTrozZxLpGA4GS+qkC3mXK3oIOr2Q Fbnwem7Ghq5YM39zh8edpcPxQnsHZUUfvfcxV0FWIqpmoPYWVp+iJhlg6xta1GmfPUwn ItPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579477; x=1767184277; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=V/pv9ikPnnH+8sOBCPbx5yFQw75cMwx+JPtiYG8MJH0=; b=vZrZBVqW/cZ/RY2FFOK62WfRo6BpxGFOBT2EtXNKUjLc8UlVCPc7MJz4uW/uNu+OQ5 H32M/cQklU0v2G7nLFyrcwkkkrJX+68OkySG9kjbkXLxR7dx3/du2+MHh8SrEEiMgx+V Xgo2jBAV0jKnQx7HxvJZDTIiuTaUR1xllKrw+wStcnDaVY/GnrQGaY9sn5lfL7CC9j4Z +4GwogxisR0Z+uxG+fHmwSUaN1Tr4uZLfxexAlawJQz6XaG56iTzoy6Z2/bNuquLr/fK mL0myOu93mqB+kXF0hRJ8LhPL/QtPnmPgCxaWYPje4bjyqUtXrKsDiZN3zqrbblb+RfC 81SA== X-Forwarded-Encrypted: i=1; AJvYcCVEvNjWwqLznoKcIh9rFBMTGKHBGOL8ztSABjNCyZBiHJEYsyGfcH2mFxKfuplD1p/fa51lULCiFqGrzA8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyufdaf/7oJ2oqxr8h7HuZm/ExXghRpPloVkEfB2HMxuefzOK6F XJseUgjz19sHpQxnVaNuUXZmveasbrMUqphEIVfslda6XRcvVy2jRCIIwGvu3gMVAxVnRaClnUK URi3n/LXlsKlieIsHgv0grtP3UmqrhX6mkD+V+MZKwhxUuMggR/DVfz5PWJcEtkcRQ1c= X-Gm-Gg: AY/fxX4Twf/HGqcg4Nqr8xyNIf2Rtc8sm6nrfUdm1xhMYW6TDHk2aOImn1+CqjKfmq/ zwNJOTGE0Z/nAuJZJKf9gBzc+vlMj2VS55HtsvYGh+yxP5Pl6nVaUSVHOIJ8g/iZtbKnWWOxPjh Iz28+/mzVKvk9lznPslZ7FbN0Cj7Eqq2nxmwB63+diTBO7bnYxITRCSsulJNx3SwWVtBWGT/THT /TUPVV//MHtu64vvcNe4SqOVB5tp/bPk32kMfc5SmfIxnC8oiDo0ZaW6QLJlaxtS5Qmfwf9RVR0 bDBSCTAW2z0ud0+5y1Osle5KvmgnQxoDInLeWfd6xLtoQgsJ3od5u3Ho3QEmrEtFgjZNP4gHlna 1B7Jdd6WyuJRwMkGqR1NMnmGxa4NItpwBBk15Oh9EhZdRWdFh/lWO5zGads9lscbxnUysnzzkJR krB5RDf7u36CXPaRz4Cz261tN6djwKeILwwDnquSoz X-Received: by 2002:a05:622a:1c11:b0:4e8:83b8:9e7f with SMTP id d75a77b69052e-4f4abca8385mr261455371cf.14.1766579477445; Wed, 24 Dec 2025 04:31:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcAATliWOuWnTc0wzLxS5bMTB0MMxejjzqichEIc3ZG9mgaOdJPIvccBxwgX49TCv9tZcTJA== X-Received: by 2002:a05:622a:1c11:b0:4e8:83b8:9e7f with SMTP id d75a77b69052e-4f4abca8385mr261454661cf.14.1766579476828; Wed, 24 Dec 2025 04:31:16 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:16 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:12 +0100 Subject: [PATCH v4 03/15] media: mt9m114: Use aptina-PLL helper to get PLL values Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-3-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfX310IDDPjw+Rq 56nOc7tlZ5Hbp81M9yvSN9Y/iQy3p/+eXRtNZTnltOZ33sHzt1+u9XIx+ypTt7JbZLnIWKzGZiN k8ubJX2mCX88RuOvqo2E7B69EziYHVtgViw3VOSxMHeGxcm7Rie03H5p9booPboI4o93CSJwwTl 9i3JThdTzfsVLwkRmS0juUJmRZLAs1p2WT//g71u6lxgnq071VeJ7DnUpd1Nmf9yMnQtcUM5sT0 ZvbuaZqVbnioqNYOsP8ZVDX69yiL/Y4WA6dw0ZXuBhkGBsFs35SKFBo5wYrplqsJK5BN3gMUwgN FxDXNed1WZhtK2ZFUiKuSs0musBiN+3ZBM+FQXnpBpS2AlNfIqNlSvG8PvJ1Z5h1DLC7a04YrTP 9+fZu5AI4nUAM5BfIHkPGSWJINKaRacvurHxyW3Titmm7uArb3uJH5SWW5hINETGt5dD3+RnM0l YyPNDseqqyUQuw3kyJQ== X-Proofpoint-ORIG-GUID: OWyEcLqFN89k9vXuo9A-Y7red6szh3y_ X-Authority-Analysis: v=2.4 cv=WegBqkhX c=1 sm=1 tr=0 ts=694bdd16 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=HeJOk8pXgLY-FChRk_YA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-GUID: OWyEcLqFN89k9vXuo9A-Y7red6szh3y_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 bulkscore=0 adultscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 Before this change the driver used hardcoded PLL m, n and p values to achieve a 48MHz pixclock when used with an external clock with a frequency of 24 MHz. Use aptina_pll_calculate() to allow the driver to work with different external clock frequencies. The m, n, and p values will be unchanged with a 24 MHz extclk and this has also been tested with a 19.2 MHz clock where m gets increased from 32 to 40. Suggested-by: Laurent Pinchart Signed-off-by: Hans de Goede Reviewed-by: Laurent Pinchart --- Changes in v4: - After re-reading the docs out_clock_max should be 384MHz and P1 should always be 8, adjust the pll-limits accordingly and drop the comment about the out_clock_max from the documentation not working Changes in v3: - Document that using 768Mhz for out_clock_max does not work Changes in v2: - Add select VIDEO_APTINA_PLL to Kconfig - Use correct aptina_pll_limits --- drivers/media/i2c/Kconfig | 1 + drivers/media/i2c/mt9m114.c | 50 +++++++++++++++++++++++++++++++----------= ---- 2 files changed, 36 insertions(+), 15 deletions(-) diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 4b4db8c4f49657e19018535927eb41f7ad2a4f80..befea5952191184536ad7d7e5c8= 1f567826d8aa7 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -305,6 +305,7 @@ config VIDEO_MT9M111 config VIDEO_MT9M114 tristate "onsemi MT9M114 sensor support" select V4L2_CCI_I2C + select VIDEO_APTINA_PLL help This is a Video4Linux2 sensor-level driver for the onsemi MT9M114 camera. diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 51ebbe7ae996950a58f8fee30029e0a060feaf3f..d1635f49ee047ca696f6053f6c1= 7e30d736ab795 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -32,6 +32,8 @@ #include #include =20 +#include "aptina-pll.h" + /* Sysctl registers */ #define MT9M114_CHIP_ID CCI_REG16(0x0000) #define MT9M114_COMMAND_REGISTER CCI_REG16(0x0080) @@ -267,9 +269,9 @@ #define MT9M114_CAM_SYSCTL_PLL_ENABLE_VALUE BIT(0) #define MT9M114_CAM_SYSCTL_PLL_DISABLE_VALUE 0x00 #define MT9M114_CAM_SYSCTL_PLL_DIVIDER_M_N CCI_REG16(0xc980) -#define MT9M114_CAM_SYSCTL_PLL_DIVIDER_VALUE(m, n) (((n) << 8) | (m)) +#define MT9M114_CAM_SYSCTL_PLL_DIVIDER_VALUE(m, n) ((((n) - 1) << 8) | (m= )) #define MT9M114_CAM_SYSCTL_PLL_DIVIDER_P CCI_REG16(0xc982) -#define MT9M114_CAM_SYSCTL_PLL_DIVIDER_P_VALUE(p) ((p) << 8) +#define MT9M114_CAM_SYSCTL_PLL_DIVIDER_P_VALUE(p) (((p) - 1) << 8) #define MT9M114_CAM_PORT_OUTPUT_CONTROL CCI_REG16(0xc984) #define MT9M114_CAM_PORT_PORT_SELECT_PARALLEL (0 << 0) #define MT9M114_CAM_PORT_PORT_SELECT_MIPI (1 << 0) @@ -330,7 +332,7 @@ * minimum values that have been seen in register lists are 303 and 38, use * them. * - * Set the default to achieve 1280x960 at 30fps. + * Set the default to achieve 1280x960 at 30fps with a 48 MHz pixclock. */ #define MT9M114_MIN_HBLANK 303 #define MT9M114_MIN_VBLANK 38 @@ -340,6 +342,8 @@ #define MT9M114_DEF_FRAME_RATE 30 #define MT9M114_MAX_FRAME_RATE 120 =20 +#define MT9M114_DEF_PIXCLOCK 48000000 + #define MT9M114_PIXEL_ARRAY_WIDTH 1296U #define MT9M114_PIXEL_ARRAY_HEIGHT 976U =20 @@ -384,11 +388,7 @@ struct mt9m114 { struct v4l2_fwnode_endpoint bus_cfg; bool bypass_pll; =20 - struct { - unsigned int m; - unsigned int n; - unsigned int p; - } pll; + struct aptina_pll pll; =20 unsigned int pixrate; bool streaming; @@ -758,7 +758,7 @@ static int mt9m114_initialize(struct mt9m114 *sensor) sensor->pll.n), &ret); cci_write(sensor->regmap, MT9M114_CAM_SYSCTL_PLL_DIVIDER_P, - MT9M114_CAM_SYSCTL_PLL_DIVIDER_P_VALUE(sensor->pll.p), + MT9M114_CAM_SYSCTL_PLL_DIVIDER_P_VALUE(sensor->pll.p1), &ret); } =20 @@ -2283,12 +2283,25 @@ static int mt9m114_verify_link_frequency(struct mt9= m114 *sensor, =20 static int mt9m114_clk_init(struct mt9m114 *sensor) { + static const struct aptina_pll_limits limits =3D { + .ext_clock_min =3D 6000000, + .ext_clock_max =3D 54000000, + /* int_clock_* limits are not documented taken from mt9p031.c */ + .int_clock_min =3D 2000000, + .int_clock_max =3D 13500000, + /* out_clock_min is not documented, taken from mt9p031.c */ + .out_clock_min =3D 180000000, + .out_clock_max =3D 384000000, + .pix_clock_max =3D 48000000, + .n_min =3D 1, + .n_max =3D 64, + .m_min =3D 16, + .m_max =3D 192, + .p1_min =3D 8, + .p1_max =3D 8, + }; unsigned int pixrate; - - /* Hardcode the PLL multiplier and dividers to default settings. */ - sensor->pll.m =3D 32; - sensor->pll.n =3D 1; - sensor->pll.p =3D 7; + int ret; =20 /* * Calculate the pixel rate and link frequency. The CSI-2 bus is clocked @@ -2308,8 +2321,15 @@ static int mt9m114_clk_init(struct mt9m114 *sensor) } =20 /* Check if the PLL configuration fits the configured link frequency. */ + sensor->pll.ext_clock =3D clk_get_rate(sensor->clk); + sensor->pll.pix_clock =3D MT9M114_DEF_PIXCLOCK; + + ret =3D aptina_pll_calculate(&sensor->client->dev, &limits, &sensor->pll); + if (ret) + return ret; + pixrate =3D clk_get_rate(sensor->clk) * sensor->pll.m - / ((sensor->pll.n + 1) * (sensor->pll.p + 1)); + / (sensor->pll.n * sensor->pll.p1); if (mt9m114_verify_link_frequency(sensor, pixrate) =3D=3D 0) { sensor->pixrate =3D pixrate; sensor->bypass_pll =3D false; --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EF0F307AC7 for ; Wed, 24 Dec 2025 12:31:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579481; cv=none; b=kOfN/D43uOFL6y+ziwcJeutdDmCrKTu8CA4HsvqD3TEosCqEcKAKYG4Acd9sd1R/4wL0dbvWUjwKnyXwyWhWn+C8Mzuw46gVAtIWKg7Suq6+V7YeJOtIG9+vAaMhXswl6NLB2/C2IJDATtlFnqvVfe4BJuCoX8S0rGTe1ziw9Sc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579481; c=relaxed/simple; bh=uqO73ZGWqzC565cWgKi2KPT/lWMs6NNQozMKSSDkSCc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OwUpRykR4WB9lcse6J/BVzh/4C4ZoJU1RsWKXeHn48D3mog4AhDMmLo8QLpIjMOvDUpJVh4k83cBKAr7F2Sxczyh+tQL1m+q4eYstLxUlj1iAGLOz5W7aE6tesV+NiCdfkXL1fGSFnJyBEk66fYimden5KwA5jur5Ik6QtTJIf8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aJOLPXQa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hQiXfUbm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aJOLPXQa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hQiXfUbm" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BOBnhAD461728 for ; Wed, 24 Dec 2025 12:31:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gcszAlWNg2oajBi3uVozzWktKmaDL87ZWZrjHRl4rVU=; b=aJOLPXQaznnS8tA9 0nz/kJgg+cZymdUMuWgIWVSgpV6SGGTuO5QdtvYm0INungIlf3etuluUas26FZ1v lz+x/At8me0kN35iHslzqKwgNBQS9o2HJpvrPys9HxXcmwaABd+ypl4Hqc3Nfx9Q 9BDAX/X0xmuA/317ij2/lOKdMIXPccrpg4R686f3EHnhFAbIpresgmMVFsdIM8ki foZPPgF+1AlMnpDp0GGz9mdVKZEtWrdrUkQJTO0+hntYp7Z1jmlx0ERwggnkPwE+ 9nv0oZrcuO7KjI5AD1FL2zvlzwFwc5Sw7bBuS2rCU8MIzSBQTDXnV7QamU7qAPOl I4X1mw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7w8fu5sg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:19 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4f4d60d1fbdso91152441cf.3 for ; Wed, 24 Dec 2025 04:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579478; x=1767184278; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gcszAlWNg2oajBi3uVozzWktKmaDL87ZWZrjHRl4rVU=; b=hQiXfUbmvlwMUvzZi9k7+JlNM3nIIyXv7jXSpYMVdKL+FezDmKFG3gx0S+XhSQKjmG qNcyN1RkgWEJXDTk/BtrcHZQ5xBiAaGr/2p6/MTWaSBq1FxTs8Y1uCSccNqO3UQsFpMp 8f+7U+PCOW3qXCtRKDjT1BSDVqYAGVeFywsvgIy6QWi5jnVbAjm0k12128dV+sP81X54 p3j/kvWlMd/yXHi+boxf9xwptCSY6vIPqfGMOWK/9ug32bLGOnX3ccU3EenE1PDMLxL4 zuFUNaTxVXfQ0D+ZYDbShU7mqQMpSf+QVIKR008likYuTUcb1TbVHs5/hUgIrGJ/XU9w fKwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579478; x=1767184278; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gcszAlWNg2oajBi3uVozzWktKmaDL87ZWZrjHRl4rVU=; b=TkQy99PDy4gZE80LVspIG1t7CzFFhRae/gn/kd1M2PtxUrKz8shJTY5oYXJoHp5aec 1r3NQ3HZwA+E5pZ1nsnNus5LGKSWGI4FaIG/k89QGh+hWxSZW8yAWVL7w8RepsYRgKYB 5rxme8iovwEfWq6UUc94aqjBcMhW/sOzfM+qCyj0J4+kXB5rSNS1Xq1zlBOmDrloSOaO oPA23tf2QqU5V7XdAq+gVxcWgPZtLYvWQ04JvJF/t+XUO6sZfGIqnZv4mgZ5Xau3ZMcq P7BhJ6LKk/2nEe1MGq2Dha8IKanxdPb/rEE5L6Z5vtJ8Un4DBwAF6pMPcdbUUQKN9RU4 OhlA== X-Forwarded-Encrypted: i=1; AJvYcCXiMB5GuzCL1uz+9Qr+Ybv60X/Xn76hTvzWk3Nbjo+JYZg1jUbWAmTFxHC5zlGobA/URTj5yd2OOZSPBbU=@vger.kernel.org X-Gm-Message-State: AOJu0YzCj/fLGIJV3Rva7hUf9AxVBkagzGHCs1+nHjpkRJo/vA4prxBT TMTIo9EzfBkZGF1GbOhj7hTY47a9ZgmaS8k5smYJiEo4ZoeFNHWpkw52Xrq+SfUEqJDnDF7nuoB idkQXR09cA2Uv6UV6C8U69cWFpqK7j25nPmjXkL+CVAEBAo2DDMvsE4lBfiNPgpZ3OAE= X-Gm-Gg: AY/fxX6kdC6psdhNm6jwpZA6AXlOA5qoDeMYaMap2gpse7afy/A1ZpEm9jK6HGzZtky 3eo68RnwGMra0iQEvKqTqyDm14KovnXyXxTQsuD8cMkHPbAl9iheGrEyGaOpqCO0o19y+rjo3mb bGkpXW0x48Kg1GtuLM3BxNAbnr6Nbp/SmZ4IXAKQqaFm5fw6V/xOxrj1uUXQWe1+K3+HHG/fpfT M6mXzi7dRrWcammfJT+DsQxm5aqIXKFQcaPw14NDpqniw0HHaRFh+OZXUbSYyeMV32WD6PprpRN KPbOTIYOO26BiRk1Jpl9iSceTSxfwBfas9EDtz4Np0tqWYMv3BaxzsYK0fJRsbfbou8zdP+LR1Y IdYuOwbYlSkEKl5eGqlR72ll+pDBUPIvpOZ007ZuV3D6X2Cwe9+BIUtZL0JV4oFwoi4cixh2Onz +x9/ANuEnyQ9WT9ncQeoL8j5YHrWBwkh2OZ9VjbQmQ X-Received: by 2002:a05:622a:4106:b0:4ee:1913:9616 with SMTP id d75a77b69052e-4f4abd6e3camr274204151cf.51.1766579478371; Wed, 24 Dec 2025 04:31:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IH1kke9MZ8as/ZFSCGVjzCSIL3m4LQO+hjMndFmOH9EQEu0hc7VGZWNWpxiaGSc9Nne0Wkmpg== X-Received: by 2002:a05:622a:4106:b0:4ee:1913:9616 with SMTP id d75a77b69052e-4f4abd6e3camr274203661cf.51.1766579477861; Wed, 24 Dec 2025 04:31:17 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:17 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:13 +0100 Subject: [PATCH v4 04/15] media: mt9m114: Lower minimum vblank value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-4-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-GUID: okeF6awSuPhslLPR3p5POYkiCf6DkqYv X-Proofpoint-ORIG-GUID: okeF6awSuPhslLPR3p5POYkiCf6DkqYv X-Authority-Analysis: v=2.4 cv=QutTHFyd c=1 sm=1 tr=0 ts=694bdd17 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=qoDHQqv3VgfKNNLz41EA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfXys6zLOjTb2q5 wQlglTzzhJ0J83ZnlNmu4rpGvIJg2Mvq0+8U2jg4JCgjZ+nA2e13N7TA87s8DrJxWlJ+413hP+K 005Ap13G/TZHh4VPABB+BplzCUReEcTG/Cw4w4vfNK+bsh3X4RO4hTQubWn5SGcvfD1mL1S4uXd Cpn/JKhQVSWZTVjrzyG+pcC/ju+gwCICrXJU6OzbTjD0A7XuuWnaq57WUFqcTep94sJMJMqQHkR yqJmtqOAr/BEmtGZVXYLbI2wjXYeBJHFBnkULO1liBjzi3fJ0aY3FeEGexduFLIUFQI1kCQ+pz7 rcZeP6we2gqkZxmoX+D0OdIf7Oz1FbI3AHH6Lan0mIcvRvhu4iE0dSiRNz+r8JRybSdjlhmrfZA 8f+ixWBhPFYl1f9B1S3/FN+zxcFZZQriYFJQ8MQkUjO8mE7oZEHYCik5nAbc0vjamOIUcqwZNe0 vkG/IR/5TYZYsPIQe0A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 bulkscore=0 impostorscore=0 spamscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 As the comment above the defines says, the minimum values are undocumented so the lowest values seen in register lists are used. The version of the mt9m114 driver shipped together with the atomisp code uses 21 for vblank in its register lists, lower MT9M114_MIN_VBLANK accordingly. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- drivers/media/i2c/mt9m114.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index d1635f49ee047ca696f6053f6c17e30d736ab795..f63ab4bd040a4a62833d8bc716f= 94fc29aa03bd7 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -329,13 +329,13 @@ =20 /* * The minimum amount of horizontal and vertical blanking is undocumented.= The - * minimum values that have been seen in register lists are 303 and 38, use + * minimum values that have been seen in register lists are 303 and 21, use * them. * * Set the default to achieve 1280x960 at 30fps with a 48 MHz pixclock. */ #define MT9M114_MIN_HBLANK 303 -#define MT9M114_MIN_VBLANK 38 +#define MT9M114_MIN_VBLANK 21 #define MT9M114_DEF_HBLANK 323 #define MT9M114_DEF_VBLANK 39 =20 --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEDDB336EF5 for ; Wed, 24 Dec 2025 12:31:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579484; cv=none; b=uAfItOOAwxNd4aVF38395+Myzp8S0HPSveS1C7PpOV8Cm3bUrWUEr68S/Fc7Y5n8N/kstv9LPjFjYXqkSnjhdUow4KCHpZmCU58lLiQvdQng0tuIkyEj5IpTwoH5F7DTizZRm8E2b7Oz/OsUBJY1f2MAo9lsJn2IFGhrk0WvLFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579484; c=relaxed/simple; bh=fR/JBGeUDY8L3uZkc7VehEJU2PSE9gi//wsklRHk5bY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uIsc43DHFRPzKHAG3Xao/rZDFD2+x0u9Bt86iBhJSfSFduKhvQUxOcpz/0MUC9w2SaD2kFd1X2nkHzmTIje6iNz3Jg+BXolxvLyF+T1drcf+tTFPiOE5AYU5acX241U6hr0v4AeNc1qBhF/j1B+wuMyy8h+AKYbr+/CfKsman9w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TYIGH32Z; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dAlwzIWK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TYIGH32Z"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dAlwzIWK" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO8dq9b1208041 for ; Wed, 24 Dec 2025 12:31:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4ZmW0JfzCy1J7ZjX2Z4M7feueyajCdPj/1Lchmmu0sQ=; b=TYIGH32ZiNRnXuiv S4NuXkUo2kU/sczIBovOeTXGFlWlL40ive+Dng5zDmS2FQ+c03wVyjPcRxOvqYfg Lf3SAYPpKwMwD0EGi4B/fiImnLAiRv+H7l0mI+BymkA48m7ZjeXhnQumDd509hQz dCotLKu+U0iTEAIGBtfy2BuHKf4KxuPZzw1eVUffo7gtgw44Z7h/0xK9vb173L7l Jk+xeFLH3HdjYdV4xdcgRkiQfegHYauaG7ir+0BDpQwxmI/lXY1u6L7yEmljpE2O 4L1HbslLFKIXTVm/vxvuND8L8yYCOuhRPaYTiN7eOGmZr0TKfuOq4XyzFSGZLDon Z3CyBw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b827r23n5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:20 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4f1f42515ffso141454911cf.0 for ; Wed, 24 Dec 2025 04:31:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579480; x=1767184280; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4ZmW0JfzCy1J7ZjX2Z4M7feueyajCdPj/1Lchmmu0sQ=; b=dAlwzIWKd5VaAwQxoDipfP721ih2JYgMajC6XaspuML2r/fiwe8pGKMxGe0wLd2Gta dRpohU3ukEcTqTyAHQMpm97KxFMvssVau25Oiko+ZPJSXp+e1HCNccwfoQu9u3K7ElWZ 978ogq/I5X0Mt39Lcjx0+7HXIX0E4p+1tP4kj0C1jp7AIbc66GNczZ4b0dKdvJ3O2nqt yRoxqXNm2jvibZX0sAssnGXsMoBfu7MxBRBU2Tj5kGABKsh4E9ijIC/tQ9/QOo/Oz6Fl v1kFiON8jtdkP/FuN2DCfkyRn9xfD+EpQny9Vg1aQobwtfpIpnvswbSojknzHsziGAX0 qPCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579480; x=1767184280; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4ZmW0JfzCy1J7ZjX2Z4M7feueyajCdPj/1Lchmmu0sQ=; b=D4gqXKU3T32JiNmT/bm+ci7KCtHsCVzuDXkSSryenzp8I5PtOHkiShyYXOUEvla4DM ccXV9nR2bfsUkxiCJS3iDWlLnf1wTFRBdkouxu51KodsJp67e3X36dVbqQ0FatoyY1Qt hafUX3NoNhQsSUI3XLlBm3LeHTCkL1NmwLjhBXayRGSdZnomFG1EksDDrtvH/uxyqBJb 1dqACXzanYh3rPFj5eqm1szRmAqdt1QgJLpL9bktD8VnXBtqt1UuDueh5aQRZiIh/HnH lv7I6CKaLN5m0+ZdNunMwqG0qcBfFSK2hSiw0/WAZcGfCKAhfR5e4bpdSNjq4KQ25RBZ X+Ww== X-Forwarded-Encrypted: i=1; AJvYcCXUS0xKttebbK+lP40uMpoK8lxIJJNz1eRT/vu5PO9/EZEsVqEgkUcZ0VMaTgBCqEtWybTeRb/JKgApyI8=@vger.kernel.org X-Gm-Message-State: AOJu0YwL9o2FVxWMjWWfYGTh+yLBm5VwxHThb5wLNWzkr6OvMB0l8t2d d1G4WQgO7qtHqLUCnMU4HkN/k5k2MmKST3rohL5oxqFKCOgyFxvYnLLSNf2Gkp41hEl0Lpcvq+X NBpnm8y75lkjp5lrXjnsxxvKc1Y+qfjR01hwmW3IC1sN0YUitPVWtKwFuFV0LeHyIgLk= X-Gm-Gg: AY/fxX60Zo7OzUowf3Z4BPQ83T1arrOn4VxuOLEwfiv9NHCcUxfowkerxG8aNpxKsvl /KEXBFCkBMlIwJJ8iBPVgMfnDNvaSPgr1yNMNrgqYGpW5e/7AJkptFz9L/UdJSPVgY9p/7Kx9yb IWFPZjliKyg5Oei2OTn2RRH64EV2tyzOv9MfY//ix3o6OfGrg9uNa81uz+wnhvcgAp+62xJ1rZr CEriX9U1ycyXcrPKCk+HJRIEE4cX20kaZQvKpEH3SaQAIRg0jHiE+aA3ieUfo/mf9mAG5cF8icz LXtc2khJVcatVZ+y9sDI26L9KpDnN8V9CO8tWRScjf1GPZtukhIp6tURh78dJUp3lNpjycW51Pr +DMUWcrpoFRDxzIxjtrPBCugnnYEws5Kw/ERoSULZ8onI5Grq/qR67jxYwG677dYVDuv5sKhlHn dr7Uhe75b+JwUJP9hJhocmtjG/tijgIqwq5xAr9yWT X-Received: by 2002:a05:622a:5c05:b0:4f0:153a:65ec with SMTP id d75a77b69052e-4f4abd78ea0mr254876361cf.40.1766579480263; Wed, 24 Dec 2025 04:31:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEe4VlcMJU9/78lQt8mav1vBOayjJg6SBN6pREq4nklWH4BBei3urptlUKobab8bG1z5DsSMA== X-Received: by 2002:a05:622a:5c05:b0:4f0:153a:65ec with SMTP id d75a77b69052e-4f4abd78ea0mr254875751cf.40.1766579479775; Wed, 24 Dec 2025 04:31:19 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:18 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:14 +0100 Subject: [PATCH v4 05/15] media: mt9m114: Fix default hblank and vblank values Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-5-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: 9elLSnR2MGyVXMnpW_LoAc4tnlvienB- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfX9CqqSaBu1EP0 2h9QqHJ/KeuVNnjkT7meSypaKzdNy0QGM8Ds1p/aR/0Il414TgDusgJ8bjdlthzQgRyItZOFqwN QJks7+P/XlCqcpu4utLuExXozDQmPO1vb6JZ0JaHCN8dl5cZ+UZsY67rauXZBY1ye4Zu7GxyRvF 3Cvt2Q1wIjjnEaD7O/2s8MygJRkodrvEqwKjzAobMF0amSEF8ylDYMfXrQtSIGLvu5Gv5a19i0K 55R6vXnuo961IOcxluLNidF2YWUA4N+Qh4zUgSihTUpshotVqRU6cwLigvEChe79TinPZfqXYOq PHk4aguns2FsWOem/ZRfBJU2EaAL5dXuHIPJ5BqJhdEaNKE3rycSndaiBzHamr3KoCEQGE5PiqK a9M3e5TXUeVe3zwd0cUA+QW2fHCMEZ8zKbs5C1mbfiql+tBW5dGftqL9c9Zyp4VeCTn+LliYwY8 GOh/G+ANUjvG2Yo/DkQ== X-Proofpoint-GUID: 9elLSnR2MGyVXMnpW_LoAc4tnlvienB- X-Authority-Analysis: v=2.4 cv=RbSdyltv c=1 sm=1 tr=0 ts=694bdd18 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=5Pw3dBPW34w_b6RJA_EA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 The current default hblank and vblank values are based on reaching 30 fps with the pixel-array outputting 1280x960, but the default format for the pixel-array source pad and the isp sink pad is 1296x976, correct the default hblank and vblank values to take this into account. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- Changes in v2: - Update comment about resolution / pixrate / FPS to: * Set the default to achieve full resolution (1296x976 analog crop * rectangle, 1280x960 output size) at 30fps with a 48 MHz pixclock. --- drivers/media/i2c/mt9m114.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index f63ab4bd040a4a62833d8bc716f94fc29aa03bd7..3fed509055142d7a134cae6caba= dde423743178c 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -332,12 +332,13 @@ * minimum values that have been seen in register lists are 303 and 21, use * them. * - * Set the default to achieve 1280x960 at 30fps with a 48 MHz pixclock. + * Set the default to achieve full resolution (1296x976 analog crop + * rectangle, 1280x960 output size) at 30fps with a 48 MHz pixclock. */ #define MT9M114_MIN_HBLANK 303 #define MT9M114_MIN_VBLANK 21 -#define MT9M114_DEF_HBLANK 323 -#define MT9M114_DEF_VBLANK 39 +#define MT9M114_DEF_HBLANK 307 +#define MT9M114_DEF_VBLANK 23 =20 #define MT9M114_DEF_FRAME_RATE 30 #define MT9M114_MAX_FRAME_RATE 120 --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AFC03375AE for ; Wed, 24 Dec 2025 12:31:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579485; cv=none; b=dnVmdyPZP5j3uXKBFsAF5oPL5AJ0s7+WDdnr+C41rO4b2lHCWI1hSJIZuHKV0KQS3tt1VS6XtapC6K166etas0Ama1mC9aGlTkYPSBTj2HZt7m/VQWCH/gpUO7VgR3XgrXp+vgvg6VitrkNf4UyTdD59WRxBQe4aME62lUfKUTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579485; c=relaxed/simple; bh=b2c7aSXIBFANsOsl3sWyp6Krl6PwUCB1Ergo9aqsMhM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IU5m3rIGIKm9q8w6WNEoixJ9sRrhVuGKeyWdyI1XR9H8whMU7FidMuXDVYsn7yMnb4odVDw/RDE+P6iSiKO/LJypMr4vnxW9JyrfbX3wnfVxe3nmk7jxLCxIOGWN0J3VJxW/xAHyBH1lDJj2npWda7wKYh8YiYQuWiKwGctqO+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RbtQqxcB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YIOPb0Uj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RbtQqxcB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YIOPb0Uj" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BOAFF4O1597861 for ; Wed, 24 Dec 2025 12:31:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sB2XKaAMBemaHGY+Hx2NVmlhFiJWnpVmNC7a9z7vO4A=; b=RbtQqxcBz5VeD4WT xJJ6yGzSOYv/r6HN22Qxl1pi8g/OD88Opo6DiQvU8P+vS/D1YR8jhcdEu/GN8JO7 3kMcBxKbgp09tk/WWfOtRslc7zoVzXwgsGmXc6oXztyZfpd9B/I0bQE+JmGo4aaa rRSazLD+9mfkHWHTDLbueyQJVU6TmRUo9cqCYaPN8HgXCRs7q65AEmNP9PvAzQK3 gCwMzvb35ChYVIP3OAguksSPr6X6t7QR6rW9GZg7th9igTv6JD4Xt/LKhWKJHuo5 Cui8iWbeEhXuYz2CnGu2RTFTH69zCfOWdG1P0O6vQt3X1wkahRgN596Dh3d7Zn1M WR86Fw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b8683hjw2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:22 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8bb0ae16a63so662683685a.3 for ; Wed, 24 Dec 2025 04:31:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579482; x=1767184282; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sB2XKaAMBemaHGY+Hx2NVmlhFiJWnpVmNC7a9z7vO4A=; b=YIOPb0UjjbmmIz6+FBCf6/p7ZQ6JF6BFjhM080VL2EY/DzZAXOdx+v44Y+SeLuVdDF C4ofO/hLLd5le/I8t5hZMepvSzfwaTE/W0OWtCtQT/eQnK4cQ/JGmzzCDofI5x5ZnQDt X1+VfMuPNnIBRT0LvWmev5nbdyqRleunWQWqOg7VRIuQKBvMP33IoNQVPx0BMFL+8YVC QR+p5tR1Q6x4D0kuUK3qSt1pp0uVtiv1v8vG4PtOCwInZShjCpMAsUrbBJdFn/OdQLuy LDwJmoFs9TBFXZR+b2kAUoIjYqPqdynWtD930n8yK6qv+YJbT/iUYQHwW0O6dtH2Suwy 77Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579482; x=1767184282; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sB2XKaAMBemaHGY+Hx2NVmlhFiJWnpVmNC7a9z7vO4A=; b=UZ/BLps0gKLsKIEG3zGI2WouPAV1QydBj0sp6hLUQXnCb4rH+4VZvVnSxSV4TvuAkV puQMxaqyWC8yBgHeg+nrbEZsXhosaaIiuzUMO9tEe3PTEJZmjoxI5xuUgOqbY5bWMnBs 68n5gMnu1B4Q9DGKaP2QebQscwq/DZzyp5POpHBbtveydD10cp5/PeiA26gN9trtZmuU 1t2eVswIPYxEYP7I3vdFMhGWX9t1opxUSCM1vXXVi7T7b4qBDgwDwhM9Y4PR3dJtf6Zm FSanYoj9eFF7+bWpSeEsyFBul9ITGWbhBd6lWmteeaPFnRGETAjP/P7XjU+3F4rZR5UY Ot3Q== X-Forwarded-Encrypted: i=1; AJvYcCVsce6VKcKg+lKhP5yoHa9hPf47xINVUVb6NvwJZug29gt/sc2uqPiS6vM5lIOpe9faVw4WRyk/urIXNcw=@vger.kernel.org X-Gm-Message-State: AOJu0YwRm1hXQes+QisD9k1IhW43j3+ZdgRk3ECNDnXwr0i8d3dIpRPk fhKfRXVd9Vz7ZS7b1ObJ7H9AT1aiwK2UqPJc2ufGiNeDDUfXKS53r8oRwynRL5FNl7G0aQVDDm8 /F/+JP2zCCAk0RzpRBCNnT6x4R9bbwv4xVMyJJ7LnYyA9/bxXL/Q8IDi5P5j7pVR1B6c= X-Gm-Gg: AY/fxX6x+Cu2HP3uvAX+dyXxpDTmyTnzi6dMcEvWYRnwecwHh6yQ9O5dPng3qTQkx58 B5KZeaKOCwZpN1NYabjBq6VZ1wQeO6NrOqzE02yNMXWpZ1iEdprDXNejBAW+4oAESqn2uj/Ofb1 9V4bvddBZpGnVMF+nFU/r7vNQ/bNyjzwOfPaiyG2Y/9f9EWq8CfvoUc+5o/WAUGnx6Ra8mxhdaP IIIH9RgGIcfJQBnh4FTAMQHe9C3PyEH5KQrDmyVICWPZ1bqknrzS7EphCQGvcg4c1jnnnTvxHuk TUEZLeiFoqT1/eTDfhDgf3rSMmpVwr1RDt9S2KZ4R3DDq9DjXDdC8nUyHljnOW/WPrqkkaTd0On rkz1p9odg/XkOvcrg8UU9U2nD3DfL1mE7Ye38tblIwudYbQu2AeswDT538qPE78XyU4e0mJu4TX hlRgqxrgARdlFQVICmSFoS2xYC8Ux1OA8uGXlY3FeA X-Received: by 2002:ac8:7e8c:0:b0:4ed:e337:2e68 with SMTP id d75a77b69052e-4f4e18edb62mr57508801cf.81.1766579481737; Wed, 24 Dec 2025 04:31:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFB++obDSGwhONkEH9QP/sY16TRHTTvZpxUmaU7LrmZqOB2z/I+DQ60Sl2yUqGaSwoKu9i3Tw== X-Received: by 2002:ac8:7e8c:0:b0:4ed:e337:2e68 with SMTP id d75a77b69052e-4f4e18edb62mr57508301cf.81.1766579481262; Wed, 24 Dec 2025 04:31:21 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:20 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:15 +0100 Subject: [PATCH v4 06/15] media: mt9m114: Tweak default hblank and vblank for more accurate fps Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-6-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-GUID: vMLj7teQideZfR5XTuaDy8PX3gdmNXWH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfX5JyrCRs4vsGS iYo0FiXYtWNbvmP/ZHKx4AZWj/ROJHrH/AaQcp0JnmbMS2tDuLd1wVtzXgsCFZNQaL0CD0etXaM s174NDfXh4q/P+jvMXwHvaFREqQNirZxYp2n4xAIKTfUuNdfXzqkA+yb+W3zAjQr3SJLuyRho+V i48QQ5EfT7K3LaTp0iFtYXM5lsTi2EaFhsqegoftcw/Zvi+/5gX/NrY29212+AGREPSbLkke+kF 5reTTCxci6oxf/K6zb0YPnqAfpeoeafFuzmIB6AgTyncbZ+F2VUKYCT0eihz1YdmhIUSSEdedFm kQpoFz2Gks3JTAvTABDrBGuH6X8YtGhz5pfzjQa+0cDcE0vGmvSy8clXcq6ShHkUrEm1x5SINCU E9MXq1W/CtxLYcwyRYayUapemVGYsXTP2i3SeucN46k4kuEo1drlY9xd21fvranW1aFpWHpALr1 4hpFPhFOli/S6I07l0Q== X-Authority-Analysis: v=2.4 cv=HqV72kTS c=1 sm=1 tr=0 ts=694bdd1a cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=ukL-QT8NHvV3VPxu6cQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-ORIG-GUID: vMLj7teQideZfR5XTuaDy8PX3gdmNXWH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 suspectscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 The PLL gets programmed to achieve a 48 MHz pixelclock, with the current vblank + hblank defaults this results in a fps of: 48000000 / ((1296 + 307) * (976 + 23) =3D 29.974 fps Tweak the defaults to get closer to 30 fps: 48000000 / ((1296 + 308) * (976 + 21) =3D 30.015 fps This improves things from being 0.026 fps too low to=C2=A00.015 fps too hig= h. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- drivers/media/i2c/mt9m114.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 3fed509055142d7a134cae6cabadde423743178c..d58445826c090f377db473f7926= c1b612874ff78 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -337,8 +337,8 @@ */ #define MT9M114_MIN_HBLANK 303 #define MT9M114_MIN_VBLANK 21 -#define MT9M114_DEF_HBLANK 307 -#define MT9M114_DEF_VBLANK 23 +#define MT9M114_DEF_HBLANK 308 +#define MT9M114_DEF_VBLANK 21 =20 #define MT9M114_DEF_FRAME_RATE 30 #define MT9M114_MAX_FRAME_RATE 120 --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47EF0337BAD for ; Wed, 24 Dec 2025 12:31:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579487; cv=none; b=Ijm2l8dDGMssuHHjMnOMKu0V9gzs73upGfRSVkU8rX2tFt1M/z5JEFLKHxmspNefL6txW7JMkVMTbXWb2QlkVU67loSTLXZumdHVxOtpR3vIixy1SrvWo4GGD0zDEdKLBTvpBhbXHVgX2XfrpM64c1u7FdMry10KRHNlhecPJwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579487; c=relaxed/simple; bh=PcqEbDhwYqOzmIiok2Qn6+Jm/yIwV2Upm7KXVYVrG2Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C0DfQt1p7dkQ8wtuTEyU1uPAedxB+ZYErtkWxN49TqmzNPsOnr0L6A+NI7xqJY9bJPgu/XrRkpj2Qu+qO8xqddnhGYjX2mDUNoJ00g4ZV03SftTB6JQglpLw1BeJAxMGt/OktTqEAJPfYXTWatQ9x4DqnF/eZcU77XHZGRk6yW8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=l4atO4Uw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KZmegxPL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="l4atO4Uw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KZmegxPL" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO3iEh54134076 for ; Wed, 24 Dec 2025 12:31:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zOUl8Ahg4EnNMx+NAiYHHKYQZ589n34P2RtnbvljXcU=; b=l4atO4UwYIZmU+85 O0GlvKB3U5FZPYpETs3XdOBpsP5hqp5KNLfJ+ESzj8AP8yLDoV1asRGjuZRtxs1T eXMGSpSJ9OlXeBGfCTn45pRHWLrqNmXJCYGsESF4NGJ1gsPozb/ex9voBYli9hD2 6GjYFsCiFzf+sw9JZowzkb39rVoRlUhFB2gUsulEPvejPxY9WOA6BbNWsUs8cGnT EeBFx+Sa8SpZ8APAImNxkPGs3oLIVXLlMp4HC4QdM+KioSlXaLZGzYxsO8/2wiyY iKrZK2YxTXiBQbEa+q5W3UPY1HDXg64TZC9yYYxLIeel0M7sUFxsMzmhOKr+kYqU rs1pyA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7x46u1a7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:24 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ee1b7293e7so204870831cf.0 for ; Wed, 24 Dec 2025 04:31:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579483; x=1767184283; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zOUl8Ahg4EnNMx+NAiYHHKYQZ589n34P2RtnbvljXcU=; b=KZmegxPL5YIreSicBYZoWN6xwL8Vjy1ePiNGpbayFWSBVx4rTk589dUBmMyexaF7bv u8l7/mTyhIF5E52kJf4viJDtFDuKt9PMrjOX3x1G040/SroEElJKkCM4AY39oLTaz+wQ rF6zTDPeSDT8nH+qI4JHz+iMxF/K5XVhsPpaycnhzrV7JAM0IjC4M6bltRq5Y2X1Rjpo qIOBKzcrLFK3OK3VJaMK+ZV1qem2d+1agBk/UJZRBFu1aKnnCIqqkxIQ1lcG3KiZ6lT7 JiU0s02ZjXKpeXh7b63iTl/ZD9ap2FbVEKuWkfUcPDjKMKTy3BSdumKSDAtRfdHneWko dYaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579483; x=1767184283; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zOUl8Ahg4EnNMx+NAiYHHKYQZ589n34P2RtnbvljXcU=; b=ICopWFbAu9bijwmMtkJLce1pZClbIjQHtecOuyinL7rPQAz8+Ct+Rlet+FY9Nfh+nb blW82HeRVdhbuqn47xAX1pQelfAAOIwAARgBX5d78AWn4rpvdPEo3xVMZiJAzeQM344N qDXR6VrOQb4sqwtfoZIR7JnmlQUnoouPfEjm08gX6Bm5XdFGGu3UIjIF2P41Uk2+ZpWL GHN5TUplXHf++EFoIHomCjK01fg1QyO0r4oCmkbpAK810IxCnkiTe/YKEpeIae/LMpYo Q/DRjeUjjQiSou4mvbFNNabwfl7YqneH3mgSWvXQ3hlUH7teopWRYCWHLCi86Ck8mIYo mZDQ== X-Forwarded-Encrypted: i=1; AJvYcCUQXznqXEoslL8O/YhONI7sUgTruX0tvvhr/V14blCEw61qNCx4DZh4ygzdLUf6D+ozCNQvnhi78XKmfdA=@vger.kernel.org X-Gm-Message-State: AOJu0YyGqxI/v1iTHT+7SdFOXYvdUUhKDiTXHsD3R4wRGVF1XEMPQmqv Exzv/HfgY/k1NMZKyOEh6b+3Ao576zl4mVNJRaYtSwXZmoQmpbgKtfb7apCfA42vUCEtWuEL6Vd VEaN+z0K/lVAK9fInt9xj+D070uT0hvzojnZ6t0sSr14m3opAlAawZzIscR024S+knWs= X-Gm-Gg: AY/fxX6inODFlRq3zoO4Kr8zeCGqc9yxnk8oHynY5bkOEndF/ReyeTZvHSuQh1ovn3s 0SjGUar24kF4UAsR1fpv2DcY8EpYCMrHKxIGOPme8qxIMBF094CNn1Io7rupZTrmQj8yBAG5VBJ gquiSCrjImW6u/PXR2Ja3SlAr0IOVX06RS6lqo888eYUc8iaHyJhVEXVINaXpGTHdtFKSmprTyW MWUZDSmS+SN7jPjkKLPfDHsIcVsiDYTxc92oNzFzRBeze+nTELJzo1Ia3iWjeT5JggEKJS7UaJt fYYpMGNmeC3XHbJAw6//ZS7u9F0jOJxdkzQfK9lbrF6EesgcELtTuZ6VWv3lSbDVfPxlN1O7++z k3bZNrzi33MB4bIsoKJxrDK1sjvyWXnvosNwaMxJ9+Z3ezVD92t5Sx80PG+aPiR+J11frT9HWGO bh3PnxckefU12aRIVkS7nGyB6EcrPkQ3TiLzD4YTDi X-Received: by 2002:a05:622a:1aaa:b0:4ee:1227:479a with SMTP id d75a77b69052e-4f4abdd1c34mr255789231cf.84.1766579483491; Wed, 24 Dec 2025 04:31:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHJMqD0KLcylsKHMUZp+3fu2rjgJFkp1M+QUZi5VVzvpEMKi5CyGkdxLGsXfjb6XJmqSO1TGg== X-Received: by 2002:a05:622a:1aaa:b0:4ee:1227:479a with SMTP id d75a77b69052e-4f4abdd1c34mr255788891cf.84.1766579483117; Wed, 24 Dec 2025 04:31:23 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:21 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:16 +0100 Subject: [PATCH v4 07/15] media: mt9m114: Avoid a reset low spike during probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-7-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: fqKtBnNzrn3N7MjeSErnX0YT75dMtm6z X-Proofpoint-GUID: fqKtBnNzrn3N7MjeSErnX0YT75dMtm6z X-Authority-Analysis: v=2.4 cv=aOf9aL9m c=1 sm=1 tr=0 ts=694bdd1c cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=RFAlwJ6oiccnoQ4oFZsA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfX07/9YagcnjjC qZAgQADzWkbKQic7mTxe4wDIhMBZ81q4bwtF6/cEfMFiOjG1rcGS9AEG1fLC6vmMbdNFflgVrYq pYOvvLOntLRm5sdUlc4V8if9XGv9tbrBG+bYUrRrJKdcRkhyJ22Sze4AoUqkZafyPRVy1g5LeLX DpBJN4IRmpiWnM3J6OG2lrPgl7bTvqKyCC/OhHvuHls/Pk6oxcQVxCqgpEMoGrD8GJ8VT0VI64g UL6jvPQ1x8680rk0AOMMGMLhQ45nHqXerSukmRBco/P5RpGj0Y1Z5LSOxH48dufVpWzH0yx1AFR +GviP4vKLcEm6jW0pb3ejn1+so01xzWbLEjlgqhHJWnvhKteTLwGFeJoeevEByTLYHHqgLFCkQ3 POPQZpacQAIQa+km0FA6e7+PquuuKOrYfN07rPIGkHI+XEJ+LQDgi2sndhOi/jlLSUBHEK35xl9 mKODgi71QdElFBOl4nw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 mt9m114_probe() requests the reset GPIO in output low state: sensor->reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); and then almost immediately afterwards calls mt9m114_power_on() which does: gpiod_set_value(sensor->reset, 1); fsleep(duration); gpiod_set_value(sensor->reset, 0); which means that if the reset pin was high before this code runs that it will very briefly be driven low because of passing GPIOD_OUT_LOW when requesting the GPIO only to be driven high again possibly directly after that. Such a very brief driving low of the reset pin may put the chip in a confused state. Request the GPIO in high (reset the chip) state instead to avoid this, turning the initial gpiod_set_value() in mt9m114_power_on() into a no-op. and the fsleep() ensures that it will stay high long enough to properly reset the chip. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- drivers/media/i2c/mt9m114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index d58445826c090f377db473f7926c1b612874ff78..60afc32acee4df1e7d4f820838b= 72f6aa3506f8d 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -2455,7 +2455,7 @@ static int mt9m114_probe(struct i2c_client *client) goto error_ep_free; } =20 - sensor->reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); + sensor->reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(sensor->reset)) { ret =3D PTR_ERR(sensor->reset); dev_err_probe(dev, ret, "Failed to get reset GPIO\n"); --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 939F4335077 for ; Wed, 24 Dec 2025 12:31:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579488; cv=none; b=Clfd3NurXdA3z2w33DGJe/e9og89m+ppBs2h7WXpbXthxPPD4rHoB6UBYAOYPxewUAnrXp4IfzBFVa6+dBjf5FZhkkH4ZsE7AOy3ubbH9pOSfdByn36Lfe6ZxytFo1njNpeQ1BnLeMup/ChFh24xxbGUCsfoy9ZKdzzTFakFyOE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579488; c=relaxed/simple; bh=snUVeDs23rzIxWCmdG5/hLGG1imrxP4F4RXFGT7/ovo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=P6IExGnd0jsnz6B+dhsAscPpJ4aK2dByuhdSizFy8wMq1gamnPM2JTVmRaBBzuj+9nYZAybtsMlyeuNbxccUCkGKCj9ShR2k97C7aVQvqKLalsHgekEuYqqhaesiiq8qebsmKSqXZ4i17repelzV+nM+s67Ea6QeucsD13+MEHg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TASAy82e; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BYJPXWXT; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TASAy82e"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BYJPXWXT" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO6AIox1018504 for ; Wed, 24 Dec 2025 12:31:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= r7uNVIk/zN3/ta92Xgm1panDdfQVE1f+kEt/PLhrFlY=; b=TASAy82e5rB70/eH X6KO0EEU1wpOQuJg5aZnyIk/FmUw5GfVAtxrE5uZL2QWcu9j88E+5sNoLDNq1bxc y3bnuijyuXs3g3LygniBC+XsV8B29qKHyWZATucfxcaThoedCTv+CKANog0kO/ET sOpUhe33/USnJofcsTsoe6q4z6rBtDb5rc4jVuqoKg76CguCXXdKcGQavBVk3ZU9 iDROqy0pfYJm5SY9T4Oi13gmo/P23VO9nNrNLALOon+aILRvLLf+kLMvlRh0Ifg4 Dvw0JN/iGwZQW8W8KmKGVdMFCS4NQCtjF2qgNzccrrkz+dlzEGoIIp45ZnR5c+dJ GmS8gg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7xjsaurn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:25 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4f4a5dba954so139533521cf.0 for ; Wed, 24 Dec 2025 04:31:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579484; x=1767184284; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=r7uNVIk/zN3/ta92Xgm1panDdfQVE1f+kEt/PLhrFlY=; b=BYJPXWXT7Ha9AZxRwrDaPotJJT74X2mb1Htvp+/lEloNlTnmAlq1QJgp9tX1zGxiYo 5ZwhdUkRFDx+rME4uLgyIOm4ClWjnNl41wcQaI98IqvMvt8RkCMhRJzFjFTadpygorTx 1+oZKP0Za9eJV5sSkFad6xQnqB5KPwlxdL5OCxINv8HzliaBfQ5tbc2VlhI9cbV68G0u ulxidE1rqoAohNaGXf3LacuuC11t42U2SQMmlEem3rtlEyORaVwXgCG3nbfbz1OKY7c/ ykU5a0A2Um5QMsIIpw93roA05PMDK0z7UtGMtRKZJXyzYFF4Wf0SlhUOoSshgv/0V/e/ UUgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579484; x=1767184284; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=r7uNVIk/zN3/ta92Xgm1panDdfQVE1f+kEt/PLhrFlY=; b=pBlyljzmcOA5iKdgTkUENZjKzMCaEUMhphVNo1zrfLluIX/4qYeGxEorj6b8/xxQ9n knssXiFY6yEdDhjWWh3jaZMqFCWr9tlm9jYbUD2zacYOp2NO+NaENa7r1cnNUuWIZAuw CFzAFEtzrxS21bDWv18DBfUkljMk0Bj+jSW8MS+A2cdm4+pOGZw699hCX3EC9drjOrqT JaTlCixWmb8h+YI6LaVdm6kVThbL5Rd09OQuUK6CtNQYIWGBoMQ6HoM5PBlXzusYoO/Z inpr+aqygXcKzzhQUTBXGYJC5jE9OQGW4UI+ruR7DQa6nZ3HaWyzBcR6EP9MOfdGS+di dWsQ== X-Forwarded-Encrypted: i=1; AJvYcCV2ESHsKBVttfkwN3nxn+bXenoZMb3F0izmepmZwrkRo4Ag+Fc221uc3gflLygnMUDb12o7V6FJCXxAZt0=@vger.kernel.org X-Gm-Message-State: AOJu0YxrA/FbGQZtrJxI/zm58kckrNiFPWcNpajoAXYjFmVNonHRinnb tSrCKAoujbnZ99ZaxZm0rt4V257sSxYnTWAdCuEnmZsPXqWcfK8ixmIBx681mtjMZ0DvjRozZIu hdHQJlI5yHlNZP+4t1hUrL3yiqTGxAPYWCemU+qe8r61e0CpASYdMXb2Px4nRMD7WO8oLxqW75n 4= X-Gm-Gg: AY/fxX4ZW49W+Ky06sjS1ohyoACCDmyDTPnTSGgqx4GZbDvjfga0tmMyex6XjofU/WU e2qqgYUaBYr1qDnWtpjAkkHCK1rp/ohg5g9z9tVAFUj9K16FANuytQdJTxpSRCPTs+1Z+bQawX8 zIk3Qih9UHhWwnysaArafOo+Wnfa1XRSNhxdtNWp4v61TK5MyhPZ+wzF8f9Ya8H2D+W7NjV2Lxv NNqacgIRWyr9sH9ISW1ccecAnQUieho/8DSPUTgKZVVenIqQMRqTUe0pNCxJRiHMuelvT5VVNAr 6gzOQjVXbs3Fr6fxz1f4eroPZakJuuVDJxmYX9myTlfiMZcD+k88JZDBw+h+9adGahyeRwZloIZ QjROoFraj7Tz+AehboF5KcYAE4H1rMP9SoCCAA+dx7/4i96wGiNQ2SNfzOk/Z1i68gUEmleDC/e s92KEgj2Zerg4BaixvGTZH0KUr58XM6KDxjmQI+xkS X-Received: by 2002:ac8:59cc:0:b0:4ee:1ee2:f94d with SMTP id d75a77b69052e-4f4abcd0a56mr279202871cf.6.1766579484540; Wed, 24 Dec 2025 04:31:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IF5akLlgQGbgu/sBROmwJf/24Z+8Z5WpbSc+Yw9Og3V8Q1ApGGxQwIwG6yhTF9bMvS9kMMBJQ== X-Received: by 2002:ac8:59cc:0:b0:4ee:1ee2:f94d with SMTP id d75a77b69052e-4f4abcd0a56mr279202381cf.6.1766579484146; Wed, 24 Dec 2025 04:31:24 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:23 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:17 +0100 Subject: [PATCH v4 08/15] media: mt9m114: Put sensor in reset on power down Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-8-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfXyp8AFjTN8555 U60e3Yh7taTFyG/cSb2deQIVphwsZD2UuBwq5QNb5KgkxbtFyin975FRzgdNMob5cxc2Ts1xCr0 POyZcleokJ9HpgJ1YvnEjppSyJsqgmsRVqenrvL3MUgfoFYkwHDSGLsAqegqtXUDnDzE+cQbM0f cNp0GHQbsaC6MmyzBmEw7xmfX0e6vM6j9yl5jNO5em0kw3hR6dzsRAvzTSYH8xxvHiPIZt2mF0B dmxlMxgfOa52JnLcefE7WYZJfBjf3CBXH3MLKMduZIq8/BXvDk16MahkV+VTUEEHesP6B6pLjuW AtZghBdD6j6EjIo07bROx8y7M3UmYWSbearQ4H38BdR699qgdzLCGtsi962FKzz9tB+qvaLzPd6 1QWBpQTbvAcwX6D+EcRZrjBAh8TjnMPA3B8mU3pCE+8DCyzddDR+QUJUOzgIkFbV45YahjXriwr wVTmxxIx1UzRlY34tqQ== X-Proofpoint-ORIG-GUID: YtfiTF4E_vqwOBbv02nsRy8J0Ho9WVMv X-Authority-Analysis: v=2.4 cv=YcqwJgRf c=1 sm=1 tr=0 ts=694bdd1d cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=8zVg_k_I0LZdQ-rHxRQA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-GUID: YtfiTF4E_vqwOBbv02nsRy8J0Ho9WVMv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 Put the sensor back in reset on power down. Putting the sensor in reset reduces power-consumption by putting all the data / ctrl pins in High-Z mode. This helps save power on designs where the regulators may need to stay on while the sensor is powered down. This also ensures that the sensor is properly reset on power up, since now the sensor will see a reset high to low transition after the regulators have been turned on. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- Changes in v3: - Improve commit message Changes in v2 - After setting reset high wait 20 clk cycles before disabling the clk and regulators --- drivers/media/i2c/mt9m114.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 60afc32acee4df1e7d4f820838b72f6aa3506f8d..39f9d20221fee4f1d12c24a031d= 9f33c953b9a9c 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -2228,6 +2228,13 @@ static int mt9m114_power_on(struct mt9m114 *sensor) =20 static void mt9m114_power_off(struct mt9m114 *sensor) { + unsigned int duration; + + gpiod_set_value(sensor->reset, 1); + /* Power off takes 10 clock cycles. Double it to be safe. */ + duration =3D DIV_ROUND_UP(2 * 10 * 1000000, clk_get_rate(sensor->clk)); + fsleep(duration); + clk_disable_unprepare(sensor->clk); regulator_bulk_disable(ARRAY_SIZE(sensor->supplies), sensor->supplies); } --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E44DC336EEE for ; Wed, 24 Dec 2025 12:31:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579490; cv=none; b=WteLU3oJsX/3s/F2cdiJtszhoefNddX8zwwKzMUZ42JbHTIs1JQg3khybnfW8PetC1g7gCwDX+l1eJA60HOJ75uo4HHXY6IIIIWsYBFySdcAXzII1b3ntW4UV+UObbWaJeExe0XPZLkLql8aXjDcSkxbdqO02cvcVjDDFHGPYaw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579490; c=relaxed/simple; bh=GnUWOa3VBsR4gmkhJCVwGtjntBcK89nA7VAPyOK4F4g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rJQwdhitnzen9Wez1ETWZuact8cOowl6bB8MyR/za56coiJHPCReODk2JiDGWYccZjmOdH+7g6RZjRzvrlXXMzwOxfWrIgecqTTFoyI+1QYHV3M/Jkbwz1kQJ5GdHXbEM3CYgqpfrp+SXeuBAZhXwLe1j/ISjb6QnfsIRe0N/OE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jTJAkF5O; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=juZtziRe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jTJAkF5O"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="juZtziRe" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO8WWrh1206448 for ; Wed, 24 Dec 2025 12:31:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2OXQlRUL7AWs+8ZQ2sk6llVByOKJ9yUAc8MgYR01bWY=; b=jTJAkF5OmpnCMpkW i3+DhLHSrVzg1/E3f+MSvGR/Gxu4mgvGqgJBdVtT4rYFi6D4HIYAyKa6GeDocGh9 2BUf0Y/rXHpp92mW6YmvNcDo59Jpmn0vAON8J8Qsln0JkKV9er0iwqcTDH+6JFWw me+4CuvU7FnGsQvyl6BtmsQORaHmjZedlRAZavIxNmcSjfdpdifpYYP4wOg+bsD5 KpTFzWHAvovcgeOsO4NpCul0Jec7SNobTe6V3IOzGOSkDiOrDu0LX2JT4w6cy/2k 4kqajyXOQfBRrrXD1R5e55NGHyrmj67s1QocDxrLu0eraVKaD/3V8dJHmHnAk+m1 5nW8nw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b827r23nd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:27 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ee0488e746so127220291cf.0 for ; Wed, 24 Dec 2025 04:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579487; x=1767184287; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2OXQlRUL7AWs+8ZQ2sk6llVByOKJ9yUAc8MgYR01bWY=; b=juZtziReGJ/4HJ5JuzYtvD1qKIb52SONrNobjMH+a8sLJ9J9EGC3Ci8bw8nx1r8AoO vItxEDFwNO4doekG4kq7vnjJAGDPO8U+HQASGzOOl534BjwJePDiTVTSvUMcybFgN1TV jARbMcch9XeLbgdQz/4mFgp7kdASaQUSkxZ6jLYOtkvj7nruilQKALatEl9BSDH7MfAQ QMv6dLyKfYrkKUnrO2PCu1uM5b2ozhN6HDz97PitoWJYKTOCVIk6Awu+c+9At2uBtdqn xC1l5enuzHq2Ks84Q7zg/WWZ1Q/PrwcGhb7XId1if8W3lwCDC0thWNKuTBte2HxvjiyQ 9Q0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579487; x=1767184287; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2OXQlRUL7AWs+8ZQ2sk6llVByOKJ9yUAc8MgYR01bWY=; b=JeATkqkjy4p1Gogl2qvpJvaWzKEZi6VsDfnIvTSeOoB1WIHWhID6yyRlcZ/qShatFj NkGQOLr6qoetnMY8+UFGz7nt+Q716LeZcQEmu0JLyBvVJNA0n3JfY/nSGucDsuZjp/Pd /a0Z9lONniXw1fveZMtQdqBc02jcmKez+bec/JiXkF2Z8/hKgqbYUUS8KTYeUv1F1kfO q3S4Xc7wCP5vsCgYiV2aJqIzTWt9MA9e1YZWK5Or8ohKJnRRu7FaGYbey/pUWbQwCxgC 4cJBWrx9kDl/qLfMEr8NIAgkTVEAUk3nH9rLxmXvkaTxlQcStTk2hZKseosGgQfSF3Z9 22hw== X-Forwarded-Encrypted: i=1; AJvYcCVor1ir7cq95hISBuVWGk8K8Otc0eZSeaD7OizPMTAeYXPtgkBNuCQe4juhKs6+1Zfr1fbBt2KnD3tyh9w=@vger.kernel.org X-Gm-Message-State: AOJu0YwOhyFZBuPghoBYrEEc/eRCeCkZE6DFrHd0xY/pFa14hsiEU1ez BclQgFonkm6hUILgC+YaHjfTJ/mO3Z3aHfqeznP7obUM3fsa4sY8pdW+9NePPKa7OGX9e7DJmGt iF2LNUvOD13dIQF1g9AkUMRI1n4SEFNOxqT/sGzp91oj/5hD+K8YECzMdLqRRFQ2PAHs= X-Gm-Gg: AY/fxX5fHPaf70nRMepSMOiYcoX6L/DKKGiVgt4NkbhEnNIkYI5V6r0F1U+jy6kzeaU 11H45kDJNU4cHfOaoANscXhpwPd3szGd70qVD6IA4H7mmSyZMzQ9eQ3ggLCSxSsKxIpN+85KFTH yr6dSsMvw8rxpOnMGVBGxkyO7GGAz8IfgY1Dew8HvThrb/t9R/Zg//Y4vY3YxnRdRXgCgPBXtwg V35UGOJiJzBTSazD9yOQ579fqVUfOKozsuszwKFmZzasgFAatU3bnO7nrFnuQl8JK35B25pZWQM xc05Oyy95ea+qb+b2DDpaUxTH1+aVzevPlzeJRyAYEVD63jnCJ8ZOLmTH9IDZigdIz2HpOlbRnG jm6jGxhXGZJwdGwkdbeE8ZX2s6JAr/9vIXHqDnZfCTZes8EyQdWwbdE5YBCXRF2HTtfpvrR4Tuf dv5ZthTB/dKAWB2kBsuONHlqCo95R9kI7I4B/aCIro X-Received: by 2002:a05:622a:199d:b0:4ed:ae94:5f5b with SMTP id d75a77b69052e-4f35f3a046emr282722141cf.8.1766579486869; Wed, 24 Dec 2025 04:31:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IFlek0AVUOYek4yOEMcM/N3Qsy8A2nfqDeLRiVKPWR4TrVTPYIorwufCJ7RDA7tejl3X9wO2Q== X-Received: by 2002:a05:622a:199d:b0:4ed:ae94:5f5b with SMTP id d75a77b69052e-4f35f3a046emr282720781cf.8.1766579485526; Wed, 24 Dec 2025 04:31:25 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:24 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:18 +0100 Subject: [PATCH v4 09/15] media: mt9m114: Add and use mt9m114_ifp_get_border() helper function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-9-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: MPWnuxiBa3lmnHp5iByxZl7tOEHTcjYC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfX/+/uP80In6b2 cug7QXdrQzGFUVV6UptXmvSS+lGIwiXAslHRb0OrUvXYtdx8W3Tmk1iLhNNxYshDWmG9q4Tr6Gp RJSPoPVR/6xzSLwwWa3ZytZlrQ0+Z4+Dc7O/ypP0rwTwx9DgFWEJXOAc4lM/sjicvqy+TTbgYS7 j+wg/3eRDC8YmzbNxz6seP+zRNjHBlqa8kKwKVSm61ZV3hC+74QXIUwaVseeasUCCJqk0xKTZJ/ ouUVj5bvLg6wvXjmHxvrII42l6+RJtcon2CFNeNzTO5nS4WiLHSiHe/m2DKv4YBIfrTlqSzMXz/ H4pD8Qk1TBc3uBVQTtMC7DnYAUsuyKc+EIdG8TYwVvF4dATpj8O/S0RjYMSwk0XIXSl/6jzau3n 551YbFPiUqI5oZ4/1JCI0B+agCIoxd3bV5yP3BzMaJGRR3+62G2AAhjXK9iZBjmz0kUM2m5PdzT eVi7UD4C/22VmrryR0g== X-Proofpoint-GUID: MPWnuxiBa3lmnHp5iByxZl7tOEHTcjYC X-Authority-Analysis: v=2.4 cv=RbSdyltv c=1 sm=1 tr=0 ts=694bdd1f cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=i4UVPg6hQqdO0Jw5UB8A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 Normally the IFP removes a 4 pixel border all around its sink format size for demosaicing. But in RAW10 mode it does not do this. Add a new mt9m114_ifp_get_border() helper function to get the border size (4 or 0) and use this where applicable instead of hardcoding a border of 4 pixels everywhere. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- Changes in v4: - Address comments from Laurent about commit message and comment wording Changes in v3: - New patch in v3 of this patch-set --- drivers/media/i2c/mt9m114.c | 62 ++++++++++++++++++++++++++++++-----------= ---- 1 file changed, 42 insertions(+), 20 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 39f9d20221fee4f1d12c24a031d9f33c953b9a9c..c0710dbb670d4e40e13fc895cf8= c84219ea43bde 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -851,6 +851,18 @@ static int mt9m114_configure_pa(struct mt9m114 *sensor, return ret; } =20 +/* + * For source pad formats other then RAW10 the IFP removes a 4 pixel borde= r from + * its sink pad format size for demosaicing. + */ +static int mt9m114_ifp_get_border(struct v4l2_subdev_state *state) +{ + const struct v4l2_mbus_framefmt *format =3D + v4l2_subdev_state_get_format(state, 1); + + return format->code =3D=3D MEDIA_BUS_FMT_SGRBG10_1X10 ? 0 : 4; +} + static int mt9m114_configure_ifp(struct mt9m114 *sensor, struct v4l2_subdev_state *state) { @@ -858,6 +870,7 @@ static int mt9m114_configure_ifp(struct mt9m114 *sensor, const struct v4l2_mbus_framefmt *format; const struct v4l2_rect *crop; const struct v4l2_rect *compose; + unsigned int border; u64 output_format; int ret =3D 0; =20 @@ -872,15 +885,18 @@ static int mt9m114_configure_ifp(struct mt9m114 *sens= or, return ret; =20 /* - * Color pipeline (IFP) cropping and scaling. Subtract 4 from the left - * and top coordinates to compensate for the lines and columns removed - * by demosaicing that are taken into account in the crop rectangle but - * not in the hardware. + * Color pipeline (IFP) cropping and scaling. The crop window registers + * apply cropping after demosaicing, which itself consumes 4 pixels on + * each side of the image. The crop rectangle exposed to userspace + * includes that demosaicing border, subtract it from the left and top + * coordinates to configure the crop window. */ + border =3D mt9m114_ifp_get_border(state); + cci_write(sensor->regmap, MT9M114_CAM_CROP_WINDOW_XOFFSET, - crop->left - 4, &ret); + crop->left - border, &ret); cci_write(sensor->regmap, MT9M114_CAM_CROP_WINDOW_YOFFSET, - crop->top - 4, &ret); + crop->top - border, &ret); cci_write(sensor->regmap, MT9M114_CAM_CROP_WINDOW_WIDTH, crop->width, &ret); cci_write(sensor->regmap, MT9M114_CAM_CROP_WINDOW_HEIGHT, @@ -1865,6 +1881,7 @@ static int mt9m114_ifp_get_selection(struct v4l2_subd= ev *sd, { const struct v4l2_mbus_framefmt *format; const struct v4l2_rect *crop; + unsigned int border; int ret =3D 0; =20 /* Crop and compose are only supported on the sink pad. */ @@ -1879,15 +1896,17 @@ static int mt9m114_ifp_get_selection(struct v4l2_su= bdev *sd, case V4L2_SEL_TGT_CROP_DEFAULT: case V4L2_SEL_TGT_CROP_BOUNDS: /* - * The crop default and bounds are equal to the sink - * format size minus 4 pixels on each side for demosaicing. + * Crop defaults and bounds are equal to the sink format size. + * For source pad formats other then RAW10 this gets reduced + * by 4 pixels on each side for demosaicing. */ format =3D v4l2_subdev_state_get_format(state, 0); + border =3D mt9m114_ifp_get_border(state); =20 - sel->r.left =3D 4; - sel->r.top =3D 4; - sel->r.width =3D format->width - 8; - sel->r.height =3D format->height - 8; + sel->r.left =3D border; + sel->r.top =3D border; + sel->r.width =3D format->width - 2 * border; + sel->r.height =3D format->height - 2 * border; break; =20 case V4L2_SEL_TGT_COMPOSE: @@ -1922,6 +1941,7 @@ static int mt9m114_ifp_set_selection(struct v4l2_subd= ev *sd, struct v4l2_mbus_framefmt *format; struct v4l2_rect *crop; struct v4l2_rect *compose; + unsigned int border; =20 if (sel->target !=3D V4L2_SEL_TGT_CROP && sel->target !=3D V4L2_SEL_TGT_COMPOSE) @@ -1937,21 +1957,23 @@ static int mt9m114_ifp_set_selection(struct v4l2_su= bdev *sd, =20 if (sel->target =3D=3D V4L2_SEL_TGT_CROP) { /* - * Clamp the crop rectangle. Demosaicing removes 4 pixels on - * each side of the image. + * Clamp the crop rectangle. For source pad formats other then + * RAW10 demosaicing removes 4 pixels on each side of the image. */ - crop->left =3D clamp_t(unsigned int, ALIGN(sel->r.left, 2), 4, - format->width - 4 - + border =3D mt9m114_ifp_get_border(state); + + crop->left =3D clamp_t(unsigned int, ALIGN(sel->r.left, 2), border, + format->width - border - MT9M114_SCALER_CROPPED_INPUT_WIDTH); - crop->top =3D clamp_t(unsigned int, ALIGN(sel->r.top, 2), 4, - format->height - 4 - + crop->top =3D clamp_t(unsigned int, ALIGN(sel->r.top, 2), border, + format->height - border - MT9M114_SCALER_CROPPED_INPUT_HEIGHT); crop->width =3D clamp_t(unsigned int, ALIGN(sel->r.width, 2), MT9M114_SCALER_CROPPED_INPUT_WIDTH, - format->width - 4 - crop->left); + format->width - border - crop->left); crop->height =3D clamp_t(unsigned int, ALIGN(sel->r.height, 2), MT9M114_SCALER_CROPPED_INPUT_HEIGHT, - format->height - 4 - crop->top); + format->height - border - crop->top); =20 sel->r =3D *crop; =20 --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D36430DD1F for ; Wed, 24 Dec 2025 12:31:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579491; cv=none; b=NQyJOr/4tVkSQyA5P3i5JFA3B9Pvwd4Un9EnaWD/pkiOGuNnKAmX9DJhXeQEdPpesx0fLMt9a5xmr/bqKPVyHAMrbYBRfFL3nB+Ae2FwndSa+x3PtqtXnaefD5BZ7+4T1qdADHNXF45cTOazUZfeQB2lLu/xjTqfk0TS/YGe7K4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579491; c=relaxed/simple; bh=ICATXnY8OUn+EYLLDMbD26cRJdbw0LYk2Tn53ySJtys=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FH+gQKy6oltpcO5BtzsGiGywghV+4dPcZfcx35sJuRY+0JxdZxhCrwiPYbrd4ImHtKEmAKCOy47OCncgD+PJ9CSdHUIMcANjQzhGn5ZMe5vpk8GARwYlBzYw32g6GAAHjc7Mez75R8sAAOq7ZY1MnQ5jq8I8DbKSPhCw/58M2A8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OO/kKzQd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MAQW88Wr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OO/kKzQd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MAQW88Wr" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO9XTlm700449 for ; Wed, 24 Dec 2025 12:31:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Q67QdQGLjQghzeJzftBRQzEPwwok8C7+UkPXfDPo1U8=; b=OO/kKzQdTh8B7tb1 q0cGE5FdB3JCrznyoE2U8lgQhI6Xuj8yNYHALYtzkf2R9eQuGLilHHAxUch52Zzp q3QYwhgZfyt1UjxutYsg9WtDuoOLzRXuto7m52SpiuV3AnzW8qKw8uJXll5EflBd UBLrlc+CgDGfKXTbVezuWYmNjD5XC+u43sc/oIYTvdpy/05LqhxsQTXsZd1mScV3 Ri8en0yg9xGNWWIFS7eJkANh+bi1vrk2+boewpH12soQiL4Q+JbV/lVfGFIwvxhA 6g+K0W1aO9iPoXRosGH7JOKdzxkWPjTCmXrnTAQia0s7MEEBsceMGoutLjOQ7eCF Izi80Q== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7t7jupsd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:28 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4edb6a94873so114616731cf.0 for ; Wed, 24 Dec 2025 04:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579487; x=1767184287; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Q67QdQGLjQghzeJzftBRQzEPwwok8C7+UkPXfDPo1U8=; b=MAQW88WrWVNSRBpa86ZWUCwXPnBngMDmP1s/wc23Iar1N7RBaXPYk0zR/OT8W31G9u pq4Ag5rOk91YwB2/xb6WI+PBaucq9n7MjbbO4NQM4uDZvYHoYhTUEyODjf+fR1bq69J8 C/iZYuwPko+6j/SwUUuR2diBZUsTPfHfYOqQ2yG3zHQCkbtD92hw16UcM7yI0e58i0dz mCytEb96luRmBuh3YxDNwOLZFk7ksyzoEFXatzDjmpkXiAoQ7v9jV3iEm/AzEMBY+em0 yaiwduTsEhro9dNJwgb/85jNiyixXxT2rjxvruBQk8CAb04xRKDO7WAE5L1mfXMfdnmB v6ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579487; x=1767184287; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Q67QdQGLjQghzeJzftBRQzEPwwok8C7+UkPXfDPo1U8=; b=RSCmhNyedROuqpJw9m2D+89PeuoAItbuaP1RlazrJyu+anyPP2gyf3TUJuvQbvdro+ gLc46L3n+hgT50DQ9/RExLiqAxHbfi2Ki66ayaUxlUPSC4n5nFKs96ZOo8QKCCyWwYOz Jyx5kn3sMKR7Zq40AxwWkzoB3bbXCDCfYamGwLSG4gWbVdY8iRMR6q+FF8aVXhmcjdyw whCF9UkiCOgy44SyPmnCjY62vUNiC/X4GCy2c1Ji0uK5ARnGB7LRr0gFkh1vOAl3/X12 69466OHnwq23RLfhcEJUdi/lMckx9rIv3CrrMdccWZyAgkR2m55SK1qUBRbpyy0Yc8Ta TClA== X-Forwarded-Encrypted: i=1; AJvYcCVVdqpnsXAPjfSs3oihQXIdAYTyMpXIbxHjEKZ0FhE6uZOKoZTIZl8QmZjrAeXc4U/LtI2dIz2u+7e2Gpc=@vger.kernel.org X-Gm-Message-State: AOJu0YxpmRHhaaNytWOTKH4s9RHerVeVv/xRbGEOeOpWOaHuUIKXs7Vi 06Xjid3+KhF25qmva4xMnueI2fKeQrfffZ3cnsCwJlg++QsrPipUByA2CUCu9noL/ILfsyQeRpg DhKCJPrfVEtXTPSQxOy2YXRkxmkFD+0FgpqRv7FaXofR07cE41Csvil9DAwr4ibrvSds= X-Gm-Gg: AY/fxX6CdIDz0Yyoy2nqWf2ln7L+SFP+5AN4KnSYmU4ovsEv72CuoOnU2R8ggrM7NYB 0YbHCn9DFX+F6P590fcLhoUObQc2EvVS6CVA3zMdSmOOGxaOrWI8GjNqjvXtJRoatcfH50ZwOTq qdB9m2MSiB5iH871z9dHQAgfnJh1M3evTCLbB1Bx6IFXhZ8I8snA64k3Uq0yBqP4qa0ehYCdmcH xFfqVewReafN4gSiOUOdMvascJsi+o5N6CXDMAeGckgtMV68PfebglaT9yPft6s6BeMxfOfvPOC 9K/gBKWg0mXL/WnyMqmbJf9H2r6APnFq6Y2vRV6DuIhXtdOktRRpBE/o32eCJdXjeVtIfFaRqVp 7XJ6DicDYK7oMxtovA9Q45oyEM6H2dppuefqYzJIr6BNglhgNqUW+r3u2NqTMvQ5c3mpX19i+Om lZdnZ9jy4LRbJyB/HGVWORo1AEu5ZTIxX9RM3B4t/x X-Received: by 2002:a05:622a:5a13:b0:4f0:131f:66fe with SMTP id d75a77b69052e-4f4abdb3a07mr234223531cf.59.1766579487068; Wed, 24 Dec 2025 04:31:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IHRT/MedxaEXpVi/eXyGCoyB4VSkFskbjX16VocUoouWVGYhnr15rPblB+vvr/Qz+yCNBWukQ== X-Received: by 2002:a05:622a:5a13:b0:4f0:131f:66fe with SMTP id d75a77b69052e-4f4abdb3a07mr234223101cf.59.1766579486591; Wed, 24 Dec 2025 04:31:26 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:25 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:19 +0100 Subject: [PATCH v4 10/15] media: mt9m114: Adjust IFP selections and source format when source format changes to/from RAW10 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-10-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfX7MCoy8tkOCda LaTGduTV8hYU78s3kNdjNUXhn+JAnZYKEUwPCeIW9RU7iNwRM017lw+x+o/fGdPF6b9m8r6cOBx cyZ1onIDAVOloLumErOzjQbf/Umk+sV8lxH+r+U3D44DO0siFm8AQRXoAkl9+dOW4eSNT5hE6ub LRQBWb4qlcfPDLVyHEAHreLLl8uiWVsA678DbCGZKy2U3E0w0gE5mDZgyxnNZmerKVDAKwm5WyI tiuP72fIPHUCHAnbzDuN/kMNS9lpVSh/qM7s4oS5GSL1UnKeocxFoBaFqWOfmMihY6Htak/61L9 phgOpE9fmI92RNxA73uzrs4Skx62DrUu5tUxm0xjz1U+jb9qYuNCWz/HqPF+w4wn14A7j+HJECU XRrlsNbKgJkwfWe/EdNALnjnDtsO9/SgfD7jlKfiLo5SZqbszZejl1H424zxSHmjqUmljr4LnS1 O4XWpUovv+FkkfJiNXw== X-Authority-Analysis: v=2.4 cv=IvATsb/g c=1 sm=1 tr=0 ts=694bdd20 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=m-OQgdKteQAIafo4PngA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-GUID: xccHNVvP-a9htZ6pXjjM3AJMVa1vXbN7 X-Proofpoint-ORIG-GUID: xccHNVvP-a9htZ6pXjjM3AJMVa1vXbN7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 Changing the IFP source pad format to RAW10 means disabling the scaler, which means that the crop and compose rectangles must be reset to match the sink format size with no border. And when changing the source pad format back from RAW10 to another format which require demosaicing the crop and compose rectangles must be reset to the sink format size minus a 4 pixels border all around it. Also when changing the source pad format back from RAW10 to another format the colorspace, ycbcr_enc and quantization need to be updated too. Add a new mt9m114_ifp_update_sel_and_src_fmt() helper which resets all these taking the bordersize for the new source format into account and call this helper whenever the source pad format changes to/from RAW10. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- Changes in v4: - Address comments from Laurent about commit message and comment wording - Use simpler code to test when source pad format changes to/from RAW10 Changes in v3: - This is a new patch in v3 of this patch-set, which comes from splitting up "media: mt9m114: Fix scaler bypass mode" into multiple patches --- drivers/media/i2c/mt9m114.c | 53 ++++++++++++++++++++++++++++++++++++++++-= ---- 1 file changed, 48 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index c0710dbb670d4e40e13fc895cf8c84219ea43bde..a9162457bf649404ac205732879= 9f1be61558481 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -1840,6 +1840,41 @@ static int mt9m114_ifp_enum_frameintervals(struct v4= l2_subdev *sd, return 0; } =20 +/* + * Helper function to update IFP crop, compose rectangles and source format + * when the pixel border size changes, which requires resetting these. + */ +static void mt9m114_ifp_update_sel_and_src_fmt(struct v4l2_subdev_state *s= tate) +{ + struct v4l2_mbus_framefmt *src_format, *sink_format; + struct v4l2_rect *crop; + unsigned int border; + + sink_format =3D v4l2_subdev_state_get_format(state, 0); + src_format =3D v4l2_subdev_state_get_format(state, 1); + crop =3D v4l2_subdev_state_get_crop(state, 0); + border =3D mt9m114_ifp_get_border(state); + + crop->left =3D border; + crop->top =3D border; + crop->width =3D sink_format->width - 2 * border; + crop->height =3D sink_format->height - 2 * border; + *v4l2_subdev_state_get_compose(state, 0) =3D *crop; + + src_format->width =3D crop->width; + src_format->height =3D crop->height; + + if (src_format->code =3D=3D MEDIA_BUS_FMT_SGRBG10_1X10) { + src_format->colorspace =3D V4L2_COLORSPACE_RAW; + src_format->ycbcr_enc =3D V4L2_YCBCR_ENC_601; + src_format->quantization =3D V4L2_QUANTIZATION_FULL_RANGE; + } else { + src_format->colorspace =3D V4L2_COLORSPACE_SRGB; + src_format->ycbcr_enc =3D V4L2_YCBCR_ENC_DEFAULT; + src_format->quantization =3D V4L2_QUANTIZATION_DEFAULT; + } +} + static int mt9m114_ifp_set_fmt(struct v4l2_subdev *sd, struct v4l2_subdev_state *state, struct v4l2_subdev_format *fmt) @@ -1863,11 +1898,19 @@ static int mt9m114_ifp_set_fmt(struct v4l2_subdev *= sd, /* Only the media bus code can be changed on the source pad. */ info =3D mt9m114_format_info(sensor, 1, fmt->format.code); =20 - format->code =3D info->code; - - /* If the output format is RAW10, bypass the scaler. */ - if (format->code =3D=3D MEDIA_BUS_FMT_SGRBG10_1X10) - *format =3D *v4l2_subdev_state_get_format(state, 0); + /* + * If the output format changes from/to RAW10 then the crop + * rectangle needs to be adjusted to add / remove the 4 pixel + * border used for demosaicing. And these changes then need to + * be propagated to the compose rectangle and source format. + */ + if ((format->code =3D=3D MEDIA_BUS_FMT_SGRBG10_1X10) !=3D + (info->code =3D=3D MEDIA_BUS_FMT_SGRBG10_1X10)) { + format->code =3D info->code; + mt9m114_ifp_update_sel_and_src_fmt(state); + } else { + format->code =3D info->code; + } } =20 fmt->format =3D *format; --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94503337681 for ; Wed, 24 Dec 2025 12:31:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579493; cv=none; b=DOhUXxsAuLHiQan5Cffz4TtKtr5XFMXCKyk4utlQkoZOY6RNADZbXA6dAwXHaGS1+VV3+iMDTIozNHG3r/nK4XnOsbMpzLgJNFfTctlVCu2Eo+6dv/cpPa4CVeWPelxT6fJtYNgM4AHfPnp6GBHSv/h69R9j8sMo3X6yP0oJXjo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579493; c=relaxed/simple; bh=QAx3poxdMUITbrtSuAqOQy/O/3u18zPYCjsBTeYAFHo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aN2fpoAmxHLdkCruZrPIF18P1lD8ysFW10OVCJ/XXW0osOw1a7La4fppBIWQhCG4UKzU7/0YnUWZDFF3Po8+dEPHXOEQe0l5RSfvkzwmjVODd2EZcUsW+cXBiXuNH6wATmdj3U5ES9/AQzxuPQAxLNgn6atrgW6oaVjaEzZZZLM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VSxX6ete; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SL2+eCDr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VSxX6ete"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SL2+eCDr" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO527br1018084 for ; Wed, 24 Dec 2025 12:31:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hxCA5guvFG8bf+IQ3INazgaPv4GRqjUZtzXSsG34vBQ=; b=VSxX6etepuqqHilZ pop1CRtGYdSGpZ1O37WLxS4uEEgx/UMJBx8tDqiyOybsG3duDbnrzGV7qI4HRP2I U60o8rDJTPnnr3L2GAoSyrl8ixbbsFFP/qGRUiZ/CWQZ6GmhjijsJ5eApQm6K7no xYBgGI9ADXhOy/fWd7vfG28vx0OCFiU6R5C9fZLZCRGSqrha/+3Ew9sEwNjeRkub cS6osyhxvZ7tEOKTh7nmRSRV5nUstiIdh+njGihYFPeNX+18ZoKuKzsCdBlLo7CF f1H9xXnxjL0OyBIdyD0np+pcvyDbVBLI9WG3Q7OUG9VksDIt56vKC0Kjp9gxHU/L chbozg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7xjsauru-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:30 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4f183e4cc7bso105728721cf.0 for ; Wed, 24 Dec 2025 04:31:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579488; x=1767184288; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hxCA5guvFG8bf+IQ3INazgaPv4GRqjUZtzXSsG34vBQ=; b=SL2+eCDrCnG10tFRIXCckVJ8zmZUjLbk4r+Z3/IvXxX2xrYFidM2Kmvp4etgQF/pcj W1ftSrNZW9nxeEsSfGcoa//gGlt/5IznwVlwEXNej3rMluUv9jodeulFau/EnaEmbRrM MA2uOBQ9DnjVPaOnPlYTLkM855KUiTqKEC8ZpUlow9YoeuCttlChaRlfW9aZfOACgonk SV4HaPvN6upyaUg8JKs3vaXOErIUENNEkWszAwrIYEDr+9JJEEsRtfcDn92mGsbkJlLU LLkTb+s7JKBGn26hiHF/OHJ+Qe1AP5SN7jppBRonIR7ARdmwd6mQhKBJbRLHGU9jx1p9 ejbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579488; x=1767184288; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hxCA5guvFG8bf+IQ3INazgaPv4GRqjUZtzXSsG34vBQ=; b=jwD0zO/VamIqBtfsqC8sIZcJIqe104osua+3K5i0dZlQzreIxyYcXXHQApw/FB+NvW whnQzXL2f3sjRs/1y9Ar6GFWE1ZCQNFWkUICj7f6oqj/7Quul+yRZHjb/dX7U0sF9dBc qUtBr25iPJUHvNw8jiLdsThoJD/dR15TTs6y8FgxtLqj1smL0dyxFp6XWlORI21wx06u +pSgJgOKIlviteeG5yWIn1ekKwWDl6vXktO2dKZ6G5igZywbszA5SjGKTeOCODqke49l Zzl1+aUE7T2Bde/jSxUIjCCyN4Gq9GTTGbQf607Mmf6vwfLvvszdAydpnUMXWuL+PCiO VOyg== X-Forwarded-Encrypted: i=1; AJvYcCW8Wq/VJ9K50cWLNC32GgIcZgEKi16SuaG++Dm3nkU3DvaawGC+EYO7fMVJ/yV4AS2wMRaAKKQ/27zAsxU=@vger.kernel.org X-Gm-Message-State: AOJu0YwvN/+uvS4owspkaU/+YhMfiXkCHvB6tKqFfmqmkHGedrP11+6j vx0d6st9kZT4Gv1uQXVaPpS6siJ4Tz5y2+L8iWFCamIcug2Ng7RBfMhcqH5fESJZisBZan3fE5J B5zk/9U+zgGcnTxe1OSrf6i2E82ZJdBmTDT4dSjpxjBXfUhA3muhozVGsx/s1WPDKwHA= X-Gm-Gg: AY/fxX4cII5+jP5MkzftU/dYRNR+sWuVMRqaJE11g072KEjI3FAq3uTSAkFLk1HVSDi uDFfAJmNPFN0PoD8XRBxUBwtgyeQbfUR8lhhsyXPwwAeCQkUslZ/hzNA/5QGX5HZ6Oxec/d0jfW i0baXTVE0CAM/09gLuw9H4Ipstfm4dCZAqWbHKI6QIf/hljDIkaKwNuEyLEBiJQzXStL6cMy/gb bRyYhpm5xF3bmRypouqnPXabSRHooDvUsARb8r2zAmLaNuGDWtWlg/gwi8BgLqdlAxaVsp+u9/G 3WyHP4hXcNcRiuxPzNeSQc+eiVxb83KEAkrV/C6T9wHP6WpkBIawZ2AtfMMfk8ZhdAS4qswuhN1 ZodewA9FyEfgB2jgtPi6gdVePABz6onC0qgnTrSWOta+q4iJEYaLdN7QaU5fSemc9BfB0OJZ68X XeMpH0DefMqGZ/VdUPhL+uBg3J4/chbjvRDJR/WeB/ X-Received: by 2002:a05:622a:1650:b0:4f1:b9e8:1d34 with SMTP id d75a77b69052e-4f4abd9e891mr232625201cf.61.1766579488022; Wed, 24 Dec 2025 04:31:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGmfwU+Vw9reRepTpr2BZ/gSShpDjlNKsHiR9ZBc4KGg+QFVNxgALBWUcu4ARxcxHI1Uxzk5g== X-Received: by 2002:a05:622a:1650:b0:4f1:b9e8:1d34 with SMTP id d75a77b69052e-4f4abd9e891mr232624791cf.61.1766579487550; Wed, 24 Dec 2025 04:31:27 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:27 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:20 +0100 Subject: [PATCH v4 11/15] media: mt9m114: Update source pad selection and format when sink pad format changes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-11-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfX5tH5/qZtzXtT 2x65ZUIzQKjPhijgy0MhHXT9IyrDDbhaNNMBo3h65buL3R9oGk+ATNYrJwXMoD97uA8qSCxUdiz yDo9U65WSSAnlyZK9g/FVu0EJrspZLbm9eSwugvK2p5SZbznXMxq8ihJiZbi+2ffLz9VCL1h+Ml 85dkUD0tTU13VYYG4ScB/ORky9ymLUTPAfJ8QcKxO9u23Jg7uuNhgOS7/wHj0QyQj/RzxfSX+BL NJdFFa5JRhrQVcLSLcyFA+9wb6vKsQ1AEaIjBvudnLVfI5CDRMwRnWNdDqF8npLZxaPBqjfGFYt hjOxFsy5GiHa7GosUQcpXnK6/rCzij31VXT8oaTJKRLIjyurhfJ+cRAZj8FS6xR0CoJfAmqMlt4 Q9UTLUnljxSoP43YVcDzodta6zKEvD2d8z/cMAdRitTUh+KpUtnrYfwu/eNYHIzPQBVdcqkCuhg rrxe9PFDqf1RvI1YASg== X-Proofpoint-ORIG-GUID: Ei-AUs2oAHSe2GasQQHjZ2Z10zAx87CV X-Authority-Analysis: v=2.4 cv=YcqwJgRf c=1 sm=1 tr=0 ts=694bdd22 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=4fCGRzqWpDqLba0_WKEA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-GUID: Ei-AUs2oAHSe2GasQQHjZ2Z10zAx87CV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 Call mt9m114_ifp_update_sel_and_src_fmt() on sink pad format changes to propagate these downstream. This is necessary in 2 different scenarios: 1. When passing through RAW10 bypassing the scaler then any sink pad format changes must be propagated to the crop/compose selections and to the source pad format. 2. When the scaler is active, then the crop-rectangle cannot be bigger then the sink pad format minus a 4 pixel border all around. If the sink format change reduces the size then things also needs to be propagated downstream. Rather then adding extra code to check for these conditions, simply always propagate sink pad format changes downstream. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- Changes in v4: - Address comments from Laurent about commit message and comment wording --- drivers/media/i2c/mt9m114.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index a9162457bf649404ac2057328799f1be61558481..8e0b5bf6db621d12b36f578b637= 4377c69503976 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -1892,6 +1892,9 @@ static int mt9m114_ifp_set_fmt(struct v4l2_subdev *sd, format->height =3D clamp(ALIGN(fmt->format.height, 8), MT9M114_PIXEL_ARRAY_MIN_OUTPUT_HEIGHT, MT9M114_PIXEL_ARRAY_HEIGHT); + + /* Propagate changes downstream. */ + mt9m114_ifp_update_sel_and_src_fmt(state); } else { const struct mt9m114_format_info *info; =20 --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1AF030DEBC for ; Wed, 24 Dec 2025 12:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579494; cv=none; b=YAO2wOlBWZtXZ2ptpm4gxhfPRGkPq5wJZjXo8rHUAZ5/ZyCxp91VBNXPJPDPVPwpFPG2vJQ7dOZRLCWpJ4H7/ggcaBDZRDZAxoI67BRovdNfJt5Bzxheqhhwh+DzKSZ4aYp7Sj75+pzDBRb3LFTM4/XJHFZjCdlsH7BLtD3AOVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579494; c=relaxed/simple; bh=cWVomP9zKRf6u0DWxVAunI1OwfFHHapDxWq5Lw22DN8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=X8/yVyqtGD+2ThRQErMhqsyviddS4JjeRNdn3gkbF4MFLnm9EDHzLkPdjQIrl7ITbpGfsHHGGFS4jrWAeJSZfWcCeWdxBBGa3pbyH/FTmbZEoUzi2K9lEqahti+EJmWnMvdM/C94vQeV0PfKgYouk9kkKq66/C5Dzm1MmrLZiXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Otxwk++T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MFac1s6M; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Otxwk++T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MFac1s6M" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BOBXtJE461408 for ; Wed, 24 Dec 2025 12:31:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= P63PUFn7+yRVOLLrjL3JxfKbtV0eP4+Vc+xT8X3UBss=; b=Otxwk++TAA+sVTek FNMwycbpOTmZUWltM+AV/+MrE31WIIiYQv+16QiYyT1Z9mEHt5Bfse034BrK8ZC4 JqLjuZtQ1pVituYoQ9uMjtix/dmxHGzYcne0uSw2nHwABjS9kDBBN+y4dYK8LjZu 4+trOs3v25jSdfKrDwvKq/R7a9RP5Ag2/4/BnNfDDfARXlBBIMU05YV0H6N6hZe9 6JiLs3hsH+4OxUSdhnKV47pLT8WO60ViGDvEmv4+zI3WKlNp3UUt/SRvvuFY4vma JYzeIS4Ec7nvjTM2z2Or6mFU1R5cOJn9NgKjgNPnMuEqxxhg+P6nqdcX+BZsTpu5 c4HIkg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7w8fu5sx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:31 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4f4d60d1fbdso91164741cf.3 for ; Wed, 24 Dec 2025 04:31:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579491; x=1767184291; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=P63PUFn7+yRVOLLrjL3JxfKbtV0eP4+Vc+xT8X3UBss=; b=MFac1s6MxQtd2v+d1ffb4sU/BMUVU+Ny8Om9uqeXiyigVDkMvLuf1UfNK96paRBQSH 38xBVHqZ7OPzMThVMAZhlaxJruBs65uPXrnqCV1WUSxCYfplGOfL3XrrtXfCIQNlGxkt tj8YoQyQWojS2mb+zc7wFCPp68cNhyv8HkB+jReFHfOY4uAL+LEO+BCaAwWZoDB/9M92 9ZlpL+rTMpMtOaM7XxuQyXwqIxD7ig/usmSdbgSqdq7/4rPRDDuU9tiFRxRGseL9Zk5Z jz2wUMt982td6qKUnBmW7VqQmpM4llZxvMJxBSc7j5TiUlQIVcoJc4hWfm0CcAtRpI6G pJZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579491; x=1767184291; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=P63PUFn7+yRVOLLrjL3JxfKbtV0eP4+Vc+xT8X3UBss=; b=S8abPdOxO8FMVNVzCAqdDRjelYd/CamFy07dlbgc549b8ApAVxm+zy/MBRf48KUQxv Y/4Ypoe4gt3J5WsoCqcswTLyDDYsKSXuFRdRXvddFKUa/Jgn4H4CwPMpT3oo/rX3UZvf mKSWPvEjYL4OkL8xNpxjEqeTG2z8aqE8aimeS8Qz3mpbRAxskmc6/f2xeLXZSt1jwKNj Gyosb+4g0/Su8nmdEdnkzCVgrjF9aE06vb0oHlh1iTMv2yJYukH9IYy2np33H7CM8Clv rW+CxFQ5BujrwFI1Ce2IBh6lEnXy8YcZIXMus5wIwme1DknvwfgxwS74FPhTrslxiW71 /13g== X-Forwarded-Encrypted: i=1; AJvYcCUogLkqBMvBXZ3o/elm0PqwXIvVVO/AxRHAnBrP9aJKbpTkGMYjkDvlwyrqd70gTzXfx1HgpWP0ICZK81w=@vger.kernel.org X-Gm-Message-State: AOJu0YyQ9lykxjbQK4Kbk1W6asQVWjIzCXSYjxh7qBS//H5PuQ1KcOuX 2VotJRyqtFrJJTpnM2rbWPtla8EEhc7pQLQw41DeUrK0zmNnQlrDLMAtTuPQO6f02f87G+X47sf L3W5VpvC3DYHU01JO0WC4x64NeRZYT7n9+A2pWME9E0/lD9dj3mWrTULtYYuYdeqJjQk= X-Gm-Gg: AY/fxX5IsNBe9iARZVmzLYIzADbsd/9s1CzlumWOHOffZGgiIuM4C/eIaVv2plHAtHh fLP0Xi1R4upqzbh7lm9MfV0IIS73df2Ywr9anmro75rhJmiz1nVh05Cxcy9H1LTIb5U0goyhpj4 Z7nZGrniUsvc6TWTCwWvbo0+395Pye1wpzguJDdcBTGBMiGhw4caL2VoyWhfnfU9+rt3WFGwl+z 6xX60fvPBJKHjXY3uuI7bdjfxNw6+9QHPfpU6KHSDylYal9M/JCoRnrnJ/SE2YHJ/l+MJrmaSLk KDioRstuwbajlcMv6qnIsFkRwu56mRpCP99Q654WCz/PMgKQwfg+AKsE8VmwUNx/LVZAzdC4CV8 KRFXUvrtqAwE1GNw5HyENrtDA74oOeBWl9U63hDS3/E14TYX9zcaLZEXrLY6k7Jj5mTZ8ssD0b2 JWafbA24VnaNpJOnum5qQoXb3ktK66x4GZyRnWVwtq X-Received: by 2002:a05:622a:28f:b0:4ee:1563:2829 with SMTP id d75a77b69052e-4f4abdaad3cmr242894261cf.72.1766579490903; Wed, 24 Dec 2025 04:31:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHVGi8qrNoMP9+F4grb10LDVDGsvOdEj/9cBMbDMcbw3OsAYgQqTLzm+ik5WDUgIS9C30NqGw== X-Received: by 2002:a05:622a:28f:b0:4ee:1563:2829 with SMTP id d75a77b69052e-4f4abdaad3cmr242893801cf.72.1766579490411; Wed, 24 Dec 2025 04:31:30 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:28 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:21 +0100 Subject: [PATCH v4 12/15] media: mt9m114: Don't allow changing the IFP crop/compose selections when bypassing the scaler Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-12-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-GUID: fETZs83tdscnKLowhY4rX8O_ZrER053E X-Proofpoint-ORIG-GUID: fETZs83tdscnKLowhY4rX8O_ZrER053E X-Authority-Analysis: v=2.4 cv=QutTHFyd c=1 sm=1 tr=0 ts=694bdd23 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=FI8FN61yIa-P2m5uk4AA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfXzDWAhDgvgPLu 30EWxfX3kri91vxQ0ExIw/07nXigdrEWCiPE+UScYIzxyJSALkWM+PlEU3DhQcIFWE7HMy+H4Re wGTTMsidO3LMd7qdn6PmlssYasOEtKzKlakdQO701HAUdrYY9jBHrIGv3BpVcMTUqagMa4arfIK Iz8S5B3CuIDvMcRcekd9E+cOGoIQ03f7efObynneHsrPWXIQqcQABF9urrp9wIjzl+SdG2t2/J+ kTt4LvkRiML6gFsttHQiArhwJ9F4KGjPTTKHEkoR+lmvqzRnwYBvyTe32FYc8AvOTeGNtxVTbZ9 7Vb7GJTAb4nEOzdCPKxo/ehJutMbCHxVwFAiuFy0ShNkpbqqYoJTAQrFh785IUSDQC6jq5HJB3j ML7UQYGCrwOkwcEay8/OrVZzf1wPDWG/F/XPtZnnifzB55TAHVvFk8DuuUAlaCdTMmQIsVjZyJA 8XI9oG/AFCQDBOmbmqw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 bulkscore=0 impostorscore=0 spamscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 The scaler is bypassed when the ISP source/output pad's pixel-format is set to MEDIA_BUS_FMT_SGRBG10_1X10. Don't allow changing the IFP crop and/or compose selections when in this mode. Instead of returning -EINVAL simply return the current (noop) crop and compose rectangles. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- Changes in v4: - Move crop =3D v4l2_subdev_state_get_crop(state, 0); up a couple of lines to avoid having to call it twice Changes in v3: - This is a new patch in v3 of this patch-set, which comes from splitting up "media: mt9m114: Fix scaler bypass mode" into multiple patches - Add src_format local variable --- drivers/media/i2c/mt9m114.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 8e0b5bf6db621d12b36f578b6374377c69503976..447a5eb34a6137a8e87bd119401= 571b5592fc77d 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -1984,7 +1984,7 @@ static int mt9m114_ifp_set_selection(struct v4l2_subd= ev *sd, struct v4l2_subdev_state *state, struct v4l2_subdev_selection *sel) { - struct v4l2_mbus_framefmt *format; + struct v4l2_mbus_framefmt *format, *src_format; struct v4l2_rect *crop; struct v4l2_rect *compose; unsigned int border; @@ -1997,8 +1997,16 @@ static int mt9m114_ifp_set_selection(struct v4l2_sub= dev *sd, if (sel->pad !=3D 0) return -EINVAL; =20 - format =3D v4l2_subdev_state_get_format(state, 0); crop =3D v4l2_subdev_state_get_crop(state, 0); + + /* Crop and compose cannot be changed when bypassing the scaler. */ + src_format =3D v4l2_subdev_state_get_format(state, 1); + if (src_format->code =3D=3D MEDIA_BUS_FMT_SGRBG10_1X10) { + sel->r =3D *crop; + return 0; + } + + format =3D v4l2_subdev_state_get_format(state, 0); compose =3D v4l2_subdev_state_get_compose(state, 0); =20 if (sel->target =3D=3D V4L2_SEL_TGT_CROP) { @@ -2043,9 +2051,8 @@ static int mt9m114_ifp_set_selection(struct v4l2_subd= ev *sd, } =20 /* Propagate the compose rectangle to the source format. */ - format =3D v4l2_subdev_state_get_format(state, 1); - format->width =3D compose->width; - format->height =3D compose->height; + src_format->width =3D compose->width; + src_format->height =3D compose->height; =20 return 0; } --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5952337BAD for ; Wed, 24 Dec 2025 12:31:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579495; cv=none; b=ljcxVwUCd1WCd/Z4xnZ9SoMeKAGa0ZcUkHR4qIanVjAAxNvGoVXgDGAtx/fGT+HyfaxofqkrKOvBLRmBYpWQAdj9Arf2gwAJPUfN1m7jhHHYdOrJIk08WpMx83U9JQcPRyQY3Z8rS2x+r3JFw7qNmyy3s83KasvSDUbeRs+O/4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579495; c=relaxed/simple; bh=IMLWnBpEdvmDo08jNk86LMqu+0sVPIzGgtm02Xt1+lk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=En9iq5YG1saAUkNf2vIUDuY8q/nr6IyIKHdK2525vjJGz6oeZDeEjiVGiJvdP+3ExbJBrPKYVOf8lRVptLzksSr3KocoxZ0423yPCg0dVJylnewKTs4tjYpFpytdht6mcXhzEGwKb9wukaHQx57wgFK784fRGA0OifPPXC9wENw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kKP+egiO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eCbC+XuG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kKP+egiO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eCbC+XuG" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO8p5Ko1206442 for ; Wed, 24 Dec 2025 12:31:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bEoBh9JKwu7r7A6P4EErTSOLtSnplstn9SiQ4qQUmE8=; b=kKP+egiOKgzx0nwi Ihz6XdWM4nTV1S7J3FchX5ktw6Fakrjx1GC+jvqnv2p7YSw/c+WHp/3sz59fiwaj RuEGLszP7RxxOrpM77b9mOiXezPqizX2giyCNtg9uNODB/J4Pg7PyYDznl2yMXWh OaWclwPTg4IzIlvY53w35S4u8JuKASS7jZCPMXDSWwRYd29eGwAad8PYp/YbcdBm QxdXHmCOFzVRd0zZPPSk2zx2pNtivLxsp78AMCX2mhn0uGyzFhh63U55+ZaXmOGq GornK1WbwiiYxfbBjewiU200R59zTGg2S/soOvIJjEdNWR4olj7bMsW/iOZHcWvo iN4isQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b827r23nr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:32 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4f1d2aa793fso150876551cf.3 for ; Wed, 24 Dec 2025 04:31:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579492; x=1767184292; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bEoBh9JKwu7r7A6P4EErTSOLtSnplstn9SiQ4qQUmE8=; b=eCbC+XuGgm2vapEw0UdbxujsjohKZLXHh9iauFcVykK7ShryOzMfFQ4SoMCsOiWgp6 WK+6Svfj71bh/rNl9nJmgMrx9PbJfagBfOEYdIKD/9dRSpkrdw8Fc/OJea26q9SI9wst 0ifL0z2GBjMmX3aywvX7uioVCBZuqahtnIy39vHF2DjIhqs3Q6LCOeSUoAs+nRRf4rcE PSBJihuXMlbEUWTVVCciCG5ovYtFtB/BAzF1EZVuQQknmQRx3WGaovq/0vymn3u53kyD K+4/kNER0IFnm2KbHdX2D2nXpynxmr8rXXineO40LC0t6NzadRt6bwWx533v3b7uGDFy xyuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579492; x=1767184292; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bEoBh9JKwu7r7A6P4EErTSOLtSnplstn9SiQ4qQUmE8=; b=rDaq3W2gDfU49Klsxrvn7ZpwcFlgvDymz9bsngjgEtJ/u0NPRrLVnfm3ZdojCWiaoa lD8zFlkpRkFYYVVB0072YmAvth8yxiL0MJM5NGMNi8MpsWvmSZCTyCLTNF9XUntXcsne o5tYkdeFUfzRobv84njS6Pl+XdliPCmJHezQKsPB1T1VcJbgl/wvwOEhQZOAxpPEREwb rGVdf7xjZ23cNr51PlzPrjQezm4irQS1sX7a1jL7zl5Ms4Ojw837axeSQm5b8J/9DMrs jcRgHZbxB7MutxbLnSKnbaVCwS3g4o6RxCcIFrEaVfiY96UUDg6JXu5s6dBnIfDAZDxb 6bhw== X-Forwarded-Encrypted: i=1; AJvYcCUjHfmTABBaM5WdtnSzVaIxXrPz+O66fCNZ9+UJFN5BWJ9JGkrpyIH8dxlDrdnBTkF1D0C74z6G+FysmNY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+3C6mhMDlIrI9rf5Glbp9L6IjgEF8OWLn43yXC9S2Py6n5Jj2 m2xZjR+asetcrh74iTDxGfmgR/ju0WiGEe+XtDSOiB722CDccgsZT9yXm1DBNQYarqoG1GT8iim HfBuET2hmt4LInVfCJ0D91OuP3x56+LoUA82PghOQ6/PSvW9Ednc6uoOuPLdi6PrEqFo= X-Gm-Gg: AY/fxX4dXQKhMsZvym8kCpCgZrFauJrEatsru4sbVuJiboTiH9IN/bajsDpbrPF1UZC CvwZ+W3OxhSMi2CCDe1OUwc9P1XAmN3p6x7SXV6sBk77rWVCXQ68IYOVkhVOIfT8jP1G/llDfnc JvAEL+Hlj0z/+Tgq4NlL/MZ+y5In82INNovBFrzOPgJrLapFxtgDG+/MCJgAGtrm4qj926UHSGn rRL6kzZGoGNq5M3zvul+pBJr1m2uSQ0OAzh9dZF+8P+DKaXXwOqwjUb1YK8jKczDLMGkZ9WiqH9 OF4bPosOmYpUGsVfeYPsnbIpwpViu1TOMflcQ+hieagnZahmwFTxURMvLpzpdq50YB9wehZYdKi xZouCSN6VtjiJUlrxYk+y2jc7VZ/kcBVVHlklwtqLMcXUb3eVm1p2BOXqI8kPg9QYdjxcqKVX+0 +i/s74FcFB/ge8PbZrqmrCth0EA+ABK1wtWXiZBurL X-Received: by 2002:a05:622a:8d07:b0:4ec:f05e:2e11 with SMTP id d75a77b69052e-4f4b43cbee7mr206714351cf.80.1766579491865; Wed, 24 Dec 2025 04:31:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwJCB8NRVia6NneXVnLVFWql85or5cinFqsljTxuShriyIXsSySNjTAIt+O+zfUO/rvvpTJQ== X-Received: by 2002:a05:622a:8d07:b0:4ec:f05e:2e11 with SMTP id d75a77b69052e-4f4b43cbee7mr206713981cf.80.1766579491466; Wed, 24 Dec 2025 04:31:31 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:30 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:22 +0100 Subject: [PATCH v4 13/15] media: mt9m114: Drop start-, stop-streaming sequence from initialize Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-13-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: QpyB17iAkg5d9QGoTLtmGT8RV6-lAN72 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfXz9mN129ZayO/ J2THnttXueb3onzK15u25xtsQwNZFDEvUKFWSbOf+r1GxvLXPZgelm8smAK7JUWpTXTTEPknuhw xdqljxkT8vQwlIDTF7Qf7n85xFeBIgmOw9rxnURT4OwTj8VRrNL6ywL1ZuYD/tnp2YxUNuNlmRu yFx+DZLKtTQ1BQ3mZjuiapJLYPIKTyLgnTMA05aYxnk8AKHwpdQbv0L0xOEysHqPkStKzWqKdXk sITJnXPnoFi5/Dr9v9UFdx1FSWc5dkt+Iw0+iPsVglNwKL2EMIGHYolmr2e75sW/w/oUqhoYQ6U nZW0CnWRAfWgjw0cZAZd9rhjuLstGGf1gCijj+E/6pnShDhBZgphxn0ArRJ39yqRQ0UPVJO8k7+ zt5NY/oPPZz3guOsVXGj/3hYAIvhfqTu5d06ycwXeKpp4mK+7uz7sJWt7L1tMuBIExS9Qz7OEaW 7QuIcEft3y9erPy7//w== X-Proofpoint-GUID: QpyB17iAkg5d9QGoTLtmGT8RV6-lAN72 X-Authority-Analysis: v=2.4 cv=RbSdyltv c=1 sm=1 tr=0 ts=694bdd24 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=hSCjdWxdfPpt4Nx0-uUA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 Drop the start-, stop-streaming sequence from initialize. When streaming is started with a runtime-suspended sensor, mt9m114_start_streaming() will runtime-resume the sensor which calls mt9m114_initialize() immediately followed by calling mt9m114_set_state(ENTER_CONFIG_CHANGE). This results in the following state changes in quick succession: mt9m114_set_state(ENTER_CONFIG_CHANGE) -> transitions to STREAMING mt9m114_set_state(ENTER_SUSPEND) -> transitions to SUSPENDED mt9m114_set_state(ENTER_CONFIG_CHANGE) -> transitions to STREAMING these quick state changes confuses the CSI receiver on atomisp devices causing streaming to not work. Drop the state changes from mt9m114_initialize() and move the mt9m114_initialize() call to mt9m114_start_streaming() so that only a single mt9m114_set_state(ENTER_CONFIG_CHANGE) call is made when streaming is started with a runtime-suspend sensor. Signed-off-by: Hans de Goede --- Changes in v4: - Move the mt9m114_initialize() call to mt9m114_start_streaming() and drop the config_change_pending flag --- drivers/media/i2c/mt9m114.c | 33 +++++++-------------------------- 1 file changed, 7 insertions(+), 26 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 447a5eb34a6137a8e87bd119401571b5592fc77d..41e98f719a23045293ee47d8980= 675510a142afa 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -789,14 +789,6 @@ static int mt9m114_initialize(struct mt9m114 *sensor) if (ret < 0) return ret; =20 - ret =3D mt9m114_set_state(sensor, MT9M114_SYS_STATE_ENTER_CONFIG_CHANGE); - if (ret < 0) - return ret; - - ret =3D mt9m114_set_state(sensor, MT9M114_SYS_STATE_ENTER_SUSPEND); - if (ret < 0) - return ret; - return 0; } =20 @@ -967,6 +959,10 @@ static int mt9m114_start_streaming(struct mt9m114 *sen= sor, if (ret) return ret; =20 + ret =3D mt9m114_initialize(sensor); + if (ret) + goto error; + ret =3D mt9m114_configure_ifp(sensor, ifp_state); if (ret) goto error; @@ -2318,19 +2314,8 @@ static int __maybe_unused mt9m114_runtime_resume(str= uct device *dev) { struct v4l2_subdev *sd =3D dev_get_drvdata(dev); struct mt9m114 *sensor =3D ifp_to_mt9m114(sd); - int ret; =20 - ret =3D mt9m114_power_on(sensor); - if (ret) - return ret; - - ret =3D mt9m114_initialize(sensor); - if (ret) { - mt9m114_power_off(sensor); - return ret; - } - - return 0; + return mt9m114_power_on(sensor); } =20 static int __maybe_unused mt9m114_runtime_suspend(struct device *dev) @@ -2562,8 +2547,8 @@ static int mt9m114_probe(struct i2c_client *client) /* * Identify the sensor. The driver supports runtime PM, but needs to * work when runtime PM is disabled in the kernel. To that end, power - * the sensor on manually here, and initialize it after identification - * to reach the same state as if resumed through runtime PM. + * the sensor on manually here and identify it to reach the same state + * as if resumed through runtime PM. */ ret =3D mt9m114_power_on(sensor); if (ret < 0) { @@ -2575,10 +2560,6 @@ static int mt9m114_probe(struct i2c_client *client) if (ret < 0) goto error_power_off; =20 - ret =3D mt9m114_initialize(sensor); - if (ret < 0) - goto error_power_off; - /* * Enable runtime PM with autosuspend. As the device has been powered * manually, mark it as active, and increase the usage count without --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 049933376A2 for ; Wed, 24 Dec 2025 12:31:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579496; cv=none; b=UTGegHoRTBisZu7G5uHWPZ3BA3tpFy6vucK49Gjsz8FHNMWTaMVvr8OO5iixbdJVNwngoCweoxdx1WxWCwdNYBD2UWacQoEsRi4RW5mfvjJsKOwJJJhIGu/Rxiw2s0ez53d4KGv5XR6U2eniytFRsOc9yo3P2TXjDl32kX8z7sE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579496; c=relaxed/simple; bh=qbaO+KrUPkeZLb1naR+flBVDrDLzeyBSpG8VDc83sSM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NWKSCm6/V7J+9pZrKUXIcMdunnDCpW7Hyz50aDZL9HC+USOPr/319vivO6SZAZ7sFFL5/Rf1q7RQ0uCcZMbUA9TUqxKX+MKk9d7TST7woNOy2/Wnx4Kn3iy3gfniEAyd2HX6HMxN6LP9hey6YSqoozJChn3/4ZMiIeEhkRK6CMw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K6Jhg4dV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XKacysIF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K6Jhg4dV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XKacysIF" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO5ouvT1018493 for ; Wed, 24 Dec 2025 12:31:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mNSm0Tp99qqt/QbO3b1dRlo0T+eYUgGNVkcwCnYUCWA=; b=K6Jhg4dVwB2UkEKy YQeaDeJ4zYxPlg5I/bhPOjIpJNQo0DHWvbFuhw5RnhdoxL+UqSVBSb2YXZ4NGbXq S/H/UO/BR66mrVr+lB3hn8CYscFnTxGN1TluD6q44Z3DkNiU/LrQ+SPr5fOJ1XyS stm4+A8ufLSBimegQo8M3DC+B/tFYRf4rd5NVxkKpX2bx50Kc9iDBtfHF+S+m58D FFQNpa98bYhnHc07w5IxYPFP8ogVSkWjyw2GTKzrUW/m7R7f0c1Dn7h1pKbefk5E uLEcYTmCo6//9tUYfU9kDxXd+8BIPOnv7FTtifXmXcewWcwO0x1S94hEZVi6NFP+ /LPnOA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7xjsaus0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:33 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ed7591799eso142489501cf.0 for ; Wed, 24 Dec 2025 04:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579493; x=1767184293; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mNSm0Tp99qqt/QbO3b1dRlo0T+eYUgGNVkcwCnYUCWA=; b=XKacysIFA+pPCKmsnHU+Z01+0e7qmhXlbcoE9WyEk2+QoiHzOtnvLBKOAfI00gWclM qbZkd1I/j9SeV/F24oTaYzqxom/SYWbZWYOM3wUKJ+thdVAzsGkB03GL+y7Dp2rnzAzc Tc9a2iK6rpBL+w7f1WCXVVcgTotAELsjmMywhs3F10h4dxM7II9paSSHszRp4DnJpD2f WuJ+nmT7fbaPyCXJt9vqktjkAR2HOc1Kt7HNwyaUAymp3HO8fb3z7aI8Juk/Tg0QcVDN 6/L3dqAfkiUI8Tp980Z/ETZFwXI/sK9+eFJ/3TLJJIsaJdB3xrUnR/4tklNKRsfx4a8/ SDMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579493; x=1767184293; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mNSm0Tp99qqt/QbO3b1dRlo0T+eYUgGNVkcwCnYUCWA=; b=Vq7+SRVLSazEHBwndb6qQnXb8xGrwgj9o/HT/us3nfQpr9a9LdjSUcx26x7NUfWOhh LFvthCOF8jacoSG1wc6ITZgICwmcdmyC4Pp5Yn6Pzz+Lwwkdu9E4J1hk4T0YKWPQL8ke 3BbT2x3yjbIIxydOqb8a94/icp3yHtbZN7q1/r9aXLGATy/iKtTGFhUIZ4F14Kg0sptM XlQ9CpoMfboFigQa0/9LNRjhHo1XXftruB/NCw5BN5cFqhDPdBETQ26hEDQsEjoqL70j JLKZC7PGRMd/yQX2F32hKu+ixXNOGthLDtSyRxlen6mIyWI4LEgQNAOkKq+/nXuUNHpf IfnQ== X-Forwarded-Encrypted: i=1; AJvYcCViPZxmxHe5Yx68KNtWiDFfaBuTOSyaHD+hXt7hY82pXOw/sbde9Lj4eZZhjI0rFzo1tMji+MOHAfJlaOw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx07VuJnkZc5gy+KlTrfJVgSO93JVaOg4QRo7M43rZuZ/NUp6he qnaS9lJusN9Ez7iPkk6lx/DKpl0SWaRLymECn9gmNXc1rCjgqA138qO3cDXM3FjLUJfR6UkkBV9 H3gndHy5br4ePDzfhAezNf9J1chUyz7PU7pBQZQzEO79iD2nnlyxm1yIpu9Ljfu0KTkUc5m3SZD s= X-Gm-Gg: AY/fxX5lIGVGWpQuDyybmlQKItyktHJBgwER+lDjbNyHKT0Nt5GJM0R5udwSptB/tgf N4th0d+ay03Nzol6OGqoN/NbEyCQkJBC+rMQmATc5rpMDd/9+NcHPy0IPpqQ+tkxoiVqrOlktTy TPCKIsZ1BWfXMxw/n/b0nGi0f7NrJqmp1ZCpa8ew8Naf0Bj3e+BDce+rOgKvMG1HbESjq9XSUHK KtEZQWBzYAaTkKgZ19/j0AF0SBri2mMwQ34MXpDuxjqPwRG2WWHQ71GAsWQc4YhFOzR+IEF2Un+ GSyS7KTQ5RFhppRJTWDxPRhlvUxYpNtKzFcc7qZbU2r606g4/7RPuEPGK0iSKWbrISdPCxwr1rM ArLvWpPPzQr6ZUleVZyMJg/xOe1BLTEgCZjarWDzqHey9/6LmxiNguDbEalgSqIb/hIe3ImzM+9 WsX37VC8AKTfSxSlW/1Gal+UCUI+oUkCGldYqe8qus X-Received: by 2002:a05:622a:14d2:b0:4ee:739:142 with SMTP id d75a77b69052e-4f4abd9950cmr250542311cf.51.1766579492880; Wed, 24 Dec 2025 04:31:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IGPfq+1lAS3Zg7DMYsp3u6LwyxjpY85e8gp5rXL8GOrBoGfda0utAkjjBd8oBQvZKn8ZMi3cw== X-Received: by 2002:a05:622a:14d2:b0:4ee:739:142 with SMTP id d75a77b69052e-4f4abd9950cmr250541961cf.51.1766579492426; Wed, 24 Dec 2025 04:31:32 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:31 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:23 +0100 Subject: [PATCH v4 14/15] media: mt9m114: Return -EPROBE_DEFER if no endpoint is found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-14-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfX4KJR/UZb8xEC Lvaq+wQMEMMT34VzKU+2ZGt3Nl3jt1Ntk7H4zAuR7phs/JGwwt7o/habXsjTNhbLfsrWthUlEqt ohhorR9XZAschn7nOBKm42sAQ69vlPs9rONqrYwW8UrZtDKIkSA1BXMX8/pp7k84i8YpFuzNvrO cqLDEz2xgTPgX1jwygbp7Fd/hQgSHoabI8Jk7TK1zfwf2/mg4uK9Q8PpZjXDWsNI9Y3L3ShkcNB eravQuKzfieRMStMWItTwBrtbKp3F/xCq6tUSfkOrlrEpv9+pw0Rd0XIRyoRb0LMivpkYTi6RWU C83uw+jBBaqKEh3lkEXr/uoSFv5ffsli+IxSyf05qshZZzf5h7IBz+B3NEDjiMmLZ4b6VUTRi4k WnMgR+1x3p9QATWR5ypurMXZnxNMVh+1MCo1liRF/mmjUTZcMsaboG1OvuSDMv3T+SEwP4uCVW4 YFrd6Ms09KKNrHne6WA== X-Proofpoint-ORIG-GUID: YzR-QYmoe19d7-HOPQgL9Go4kP5c9g0H X-Authority-Analysis: v=2.4 cv=YcqwJgRf c=1 sm=1 tr=0 ts=694bdd25 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=tX04M20y6pLIItW2OsUA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-GUID: YzR-QYmoe19d7-HOPQgL9Go4kP5c9g0H X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 With IPU# bridges, endpoints may only be created when the IPU bridge is initialized. This may happen after the sensor driver's first probe(). Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- Changes in v4: - Update comment about why EPROBE_DEFER handling is necessary --- drivers/media/i2c/mt9m114.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 41e98f719a23045293ee47d8980675510a142afa..9bf900095515447d22265521349= cce1d7892e9b8 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -2448,11 +2448,17 @@ static int mt9m114_parse_dt(struct mt9m114 *sensor) struct fwnode_handle *ep; int ret; =20 + /* + * On ACPI systems the fwnode graph can be initialized by a bridge + * driver, which may not have probed yet. Wait for this. + * + * TODO: Return an error once bridge driver code will have moved + * to the ACPI core. + */ ep =3D fwnode_graph_get_next_endpoint(fwnode, NULL); - if (!ep) { - dev_err(&sensor->client->dev, "No endpoint found\n"); - return -EINVAL; - } + if (!ep) + return dev_err_probe(&sensor->client->dev, -EPROBE_DEFER, + "waiting for fwnode graph endpoint\n"); =20 sensor->bus_cfg.bus_type =3D V4L2_MBUS_UNKNOWN; ret =3D v4l2_fwnode_endpoint_alloc_parse(ep, &sensor->bus_cfg); --=20 2.52.0 From nobody Sun Feb 8 10:33:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CE4333BBC0 for ; Wed, 24 Dec 2025 12:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579497; cv=none; b=HONAl0C+xWrExraVqWDJPPWgq6CgX+hPTijz+wUCQOKcyKfzGfQ1tzlP1UgBIh9pHJDzg1zWPXs4KemMnBYpwLssc+azT1LmT16Ow495kgMDJt/s3uV8BcJjs0YZrBDkxSwrmAPZOu7OoZgJiTPGEPd8lK/1m5VjA3EmZ2Q9/4Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766579497; c=relaxed/simple; bh=hloPmS/gU0jIzAKeFmhUtGJfp/7uHpLhIe0ol+k4rWg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AX9KEZ1vT4DP4pXZHnwsaZI2wmPVRKVayamfxviqYEJgT1o4E04v1JNsZhD7xw6C9XNUXA+qfcK/7fIIX2O4c2dSrN9QaIUIumSe/UX6SXkNc0iC8ZXtA5cBPG4Fo4Xs2sKIzJKnpv4VqTKwu0qMkjQT2xNvv04q58tqSAP7KbE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jetu+itw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GCnp4RiZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jetu+itw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GCnp4RiZ" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO87e5o721508 for ; Wed, 24 Dec 2025 12:31:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WKN4rmMuNZjMAPske/u/qV1QPc+BO+zGVACsa/L8Cyc=; b=Jetu+itwEs21hM1o ppjaL+WyLdzyKwO086z8ia+hJw4gFLss3hmqElAKHRfIrK5say3giRS9g7/Ja4BF M+GBYkBOG2bzD0JjPsDA+ecRd0DoTwSFWnApdt6vbkb4tP8XBZ2GELq8cCFuwelo iyOvYkSUXucb9NByavG3v7m0jCwtwFrXVI3ovltnEG+fJaRokRoUPK5+6VB6IZYW ljOFY/0kmpsz2oL/qQ0OJJ90CGT7VHnj1Vn05NWEQF0fBD6Kwgu7pH0SI3p4vnO4 1IG3K5eXMngy3tfcU3QH5iezeVClxOvRTocyFAyrExOAho9iizMEakvcRu0w8MZF v0dCSg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b81mta755-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 12:31:34 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ee0c1d1b36so149781931cf.0 for ; Wed, 24 Dec 2025 04:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766579494; x=1767184294; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WKN4rmMuNZjMAPske/u/qV1QPc+BO+zGVACsa/L8Cyc=; b=GCnp4RiZySuELms8Pz/zh1nTx+PtPSDSjs7x9dXMS5Tb8v1uhs3ZxT9XSDSB4518xG /xf37cmeC+ymSieLCJYMpMpIS5+R5JWKMC+2Bf2A+IbR8qVyXjKu0Igb5L0tGVnNmJ/j enkN04hF4/mGJiTMX0EdVepMi6BnZTO+w5HBzBR1PrnRhyv2TbkuHjm7It5VXHp/BRSU 5Kw/rL8ZD2dmcPSBotchazirzYj3wOa5tMPUAyVHlOR+jjJ7OjPyj6UE0Sdmm2bJxAGM ZeOeWAZ+H4DXErEP8H6xCTsc3wXsEyYUcgkrWlVs9sAWX+4xOfKlpWJdnvKONvEc8Rrz FEBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766579494; x=1767184294; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WKN4rmMuNZjMAPske/u/qV1QPc+BO+zGVACsa/L8Cyc=; b=JvIEiBLFZZwVzBhXNkjzboqak6KrD3euZmLHPMvMsHyuPq/UDAhr4GLEYV600pjPts zO0fY3xtGDSgxUhDO90zBQwnqRFtffLg18+ac6JAIj6w8M8r4pea5aEqtmzPHKR2uagP wzfZ/t/hjegO4UJUuokr9UYOWOahTVFvoPTz/+duIAhQb6GmLfHy1iYN+PkOQgeBl8PF eJxPeAr0IVoKENqqcovinz8X5vcUKEKOVHO/HYs8e78kfFTNxwYTEKCgTzO2OgHvOLv0 KWhjg7douL6XWUyPo+BI4LcRZZWFt7evodb/7TRjtJYaV65tAianpvWNjXFsL4utn/YA +8dw== X-Forwarded-Encrypted: i=1; AJvYcCXRUrXqjB/D8JD76sj9yU+eR43h5VnmqTIerAY1/l7Z4gWxTUVJ40VSA+X33fEa6TVRnDtAi1ttNNhzgbo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzct6lH9cFm3y3npOEyY94iY8mNTFnpzbpbtEFGGc8IvINP6eSp oUibQOaqLQUGCBOlgpM9jg5eaU0uCH5ECCPLY7KEb0u6T/McTUsVxXVzYR25RAJ9ZJxnkHfxXFd ggGbNQ9UnJZ1npwN2RhDpQkjMnYcB6L5Ayw2K3kDHZEfjvH4ERkeXYCDflcGv9H4goUU= X-Gm-Gg: AY/fxX53DqrK6M5Ta4GEkRubiGYJwhTulqQSg2EKkVRUYWcx5wZ2DXgKu8BVgdfpIjy /5VHWBvgnWEz4iUN6qfClcAH3e+jetGqpS60U1iaORT+dE4IQeALpggw7cvWwyD7B+CG/B9+TDG bpMoDZURGgy+9fhgfyl+kmH25mdAcYvAFDXq3WM688IxXu9xC/qndPVA577a7g9dR0B6cC21e8D 5JTgfYfmq5iCQE56W+Z96Xgz1EGq/wS+TTqfDqwEltJJShsKqoeoBWCd0iri3iZ2Pc7VzFlU3vU J6RQCzOSY2yKbMmUbPGsUU9Oi+iecAxnyMYmHVoE/BHruvDmzkNM6LGqmOzNugIA2+B0sE0EoAv flKCX//tm6uzncNcUcknPeVS/9LhAv/7e7lgsghbVBob+b0m6NzMEWnlw+rSI8PUE4NvzmWdrDw tDQhdtQq1twyml3ZwmnDwKhxnf94RQJbrKmdCVPnw7 X-Received: by 2002:ac8:5f8c:0:b0:4ee:bac:e3aa with SMTP id d75a77b69052e-4f35f46d1ddmr317594091cf.35.1766579493898; Wed, 24 Dec 2025 04:31:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGIsZkGfhFcDEW3nArahjqs2pVGrQ6BHEQvjRiT7Tqzwb/XjrW/z34m/OteKuyL0bYQQbwRUQ== X-Received: by 2002:ac8:5f8c:0:b0:4ee:bac:e3aa with SMTP id d75a77b69052e-4f35f46d1ddmr317593741cf.35.1766579493531; Wed, 24 Dec 2025 04:31:33 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0b12dsm1750304066b.48.2025.12.24.04.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:31:32 -0800 (PST) From: Hans de Goede Date: Wed, 24 Dec 2025 13:31:24 +0100 Subject: [PATCH v4 15/15] media: mt9m114: Add ACPI enumeration support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-mt9m114-atomisp-v4-15-60b25da7a1bc@oss.qualcomm.com> References: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Authority-Analysis: v=2.4 cv=e/ILiKp/ c=1 sm=1 tr=0 ts=694bdd26 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=5YKaq-4ml3F4CIf4D4IA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-GUID: CCMPZDdbyIvWiGMoIm7Ee3y67Qiph3Dc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDEwOSBTYWx0ZWRfX3UTK97DjzOiR 7w7Mz54Wcj0Dv9NruV5POS8v1Q5FhiseF9/z86QZnglXFpdTYaksfkD2Hh/PmMfj7Hx0VNIZ6oy /A2FzK+3GEGtqotmU0817LFOEkwzcgD+YZxmfN/Xt4WuS7XzburUipoVOxXfarHShsDVC1p7jBF erg7mZ7jm+SMZz+HIvR9zBBZUVt+6jUUBNn11Mh0lIHWvq0vrqVQ9eH7qnSuxHCJaQnlURsHCCI qM1JvftJvQoixcmV6gRZZSQyDihkWPvNxBd2e5hxagp3l8UD9oADHSOwqS+ciRrO5wWmW9PoEp+ ddDkdq0D4H1bBPPeJ+lafTJTggcz6HrtmvrMn7LN5+Wa2xxzWQ80yeHNTyDh/R4H9Qn8bdO5TqJ 8WcDpcV18KNqqEOyMPDH+k3rJItoahHk1K40gGu+WlptACEKtD9GqehgZKjUzofPIhVvTYt2ZcE 7Yu6GOZlWKu6Bti267g== X-Proofpoint-ORIG-GUID: CCMPZDdbyIvWiGMoIm7Ee3y67Qiph3Dc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240109 Add support for the mt9m114 sensor being enumerated through ACPI using the INT33F0 HID as found on the Asus T100TA. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- drivers/media/i2c/mt9m114.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 9bf900095515447d22265521349cce1d7892e9b8..836ba16d1accbfc1a6b8878ba8d= 3806ef7a1caa1 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -2640,11 +2640,18 @@ static const struct of_device_id mt9m114_of_ids[] = =3D { }; MODULE_DEVICE_TABLE(of, mt9m114_of_ids); =20 +static const struct acpi_device_id mt9m114_acpi_ids[] =3D { + { "INT33F0" }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(acpi, mt9m114_acpi_ids); + static struct i2c_driver mt9m114_driver =3D { .driver =3D { .name =3D "mt9m114", .pm =3D &mt9m114_pm_ops, .of_match_table =3D mt9m114_of_ids, + .acpi_match_table =3D mt9m114_acpi_ids, }, .probe =3D mt9m114_probe, .remove =3D mt9m114_remove, --=20 2.52.0