From nobody Mon Feb 9 08:56:49 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C69DC12E1E9 for ; Wed, 24 Dec 2025 01:03:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766538227; cv=none; b=FmkVrdcmhYzO1ILEH7sG/d6P3JlqrtuVkgxODYocj12uWyOUnfBVtvnKq7vn4OfZM1G82ajf+Ldkbtpwp0g0j3wesCGcfge9cTwaOccjmJTRSN2e4lBZxx/OTjlK4p7E4qw5tTK/kPnC+GEx9OARQWLRbWh7WgWqiYG9jB7ColE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766538227; c=relaxed/simple; bh=nzElO3qrN1ngMVHhZahBd7pKCsEHzR84mn0cPkFgNGc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hyOcE3AuxMysWmWLd1BZUtaZCDOyWcyUxjc+uGJU+pZwBcg9HDyQJCyXEkUSH8P2IAA4PoJyjr8F/pDwyERucYHqWTJYorx3o9xN1XHuoSARCy8VjWFsE3uXiqWFXpkNKLXuMcBB/jxGsnFF/VPS4tyy1ACxEE3nYPPm3TkAJQc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Esi0DjvA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IZ5FEz3+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Esi0DjvA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IZ5FEz3+" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BNKWNna700762 for ; Wed, 24 Dec 2025 01:03:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= P+SBTDTtGkE8RnKwaj4dcEp5VbeaO6x7ZVfHg3H5ESs=; b=Esi0DjvAzJhxorsi g/+0CqqpWMMGETBCdKGbWAK6+wNpcpUgTsjDU9DlpBhFnx5A2q/r6vi44H6iJUXd rPPoPBKv2ob/TY6coqKmULhrTq2Ws6j+f1M5oSTqqnWsgVyacZy7WUZUBsb+QMhe sVf7WTTTDaZPKrSeFvRIcvrsmY9LL6x5U1DHtvybghVoCFvFFqxVCZzkgRnOiIYx H35A0mjZyRosZPZTj7L+ZI3MajMOghue3ZY7KIoamPv5jAAt1K1TE602mnIix5mB USOF+TIqUZJyVRx1gM9WdnGaDLRzkPzwjk6ea6N96EV/KiLzbxuB8eejkGQj0J+I X+d4Eg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7t7jt5qk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 01:03:44 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4f1d2aa793fso140168161cf.3 for ; Tue, 23 Dec 2025 17:03:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766538224; x=1767143024; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=P+SBTDTtGkE8RnKwaj4dcEp5VbeaO6x7ZVfHg3H5ESs=; b=IZ5FEz3+0DPobY1v/khXC56u1loAmRl5Fmxl5I/+nVdExSaMWyhdMvaYRu0+qBykG/ Lzb7txIlgdvPOFr+rn1NKnJVr0eyVPPY+j1FTYuOucCPlYOnCc3ooWI1p5FOHx2VQejG /JO2iDSCx+5d9/TsK9T0ryJ4Lc1pJfNuclqmUSCqhK+IayRxDzN0jJlK9uY9U51sKIOS vE7AixroICSwORJyOc4a/Gxd9BM+8eYvXrYgHDi7wz1Tol2aA2DgEV3mCozKgA/KXpsQ 3rnx6Ul3itNYvGc/rPUsl2XZ121IFaYQ/xW9nF6LZ7ASOWDI/VWBHZyUs/pMTkLnSAa6 I2Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766538224; x=1767143024; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=P+SBTDTtGkE8RnKwaj4dcEp5VbeaO6x7ZVfHg3H5ESs=; b=Zc7xmGxVXeTR4B1btmmTBN77dFM5KLjBBqkVMX//ulNrVrT4hZyQ5cBB3x6XArm+Qn u9toZCR3ysnSRPMZmPaVukjfBHB9jCb3B23+YNaCx14zgoqf2Jojt/7c28eyNKd9j8GK M4ut/w/EKFxhCh2TDonxaQhriGqQoLW9WOKmGE9WG1btmCaIEUj0dRDK5AkB5y5C/Dmw 2gFhNVCFLrCCDDO97eqOzq4w0X6zeHn1JIXINviQXUZoJ1fBAFMtD07kNmYlqA/pDfkP UiFFZ4vSn18wdCbNHAIeXW2GUQ5/6KBD7rHTNARh038XUhc/cAWkITkEOREMdLb9X3Df 7AEA== X-Forwarded-Encrypted: i=1; AJvYcCX+dHgloZTUicgj562sMRDWg66blzJUJzn+MzIm8kfofp/PDl2Joy+cvE/Qit2Ufi8XT/7Ch8KGURwSdgg=@vger.kernel.org X-Gm-Message-State: AOJu0YxAlwbGDmJFZZRtlgKTN1ZEcCrTlwrEinlgEmOiTAFHgbEOB3Sw +WHXMiUEixTeD6ktt3nN3uzgcDeIjCkonLwJwVtnLUO58Uc6JZojrqig6nW6zlMKCc09FjR2NXL dZxaFI3Q7SkkkYO5Ne+c6ELd1S/+k0pWUbqCixU6yKqY2VZlJnNsJD2eZrc/DRS9iTOw= X-Gm-Gg: AY/fxX63ZhVuLWexjrw93hPwT1RnHJFTta22bR/uO+IFXox1kmwXPMpZkuGYDSCdgjb Vop9JfKC9wbh5T3+dHXWXo2xJCxrtb8T9TG3+PLpcDn2mHhJ2z/OgvGZUFRW1FxMdcA4QlLSYxF CtUuMDALu+L0Xci3rPUbPbjqi3w0avb6fGtOApMsQgHNSrfvrT2nGDYeXv/20J2qq800sOLNzGR OHrX8FfhhwUmuGP2U1UsWWZQWpgZqsLM5vliqD1YTIQLNdHINCuspEDr+pzbTm29pO7yHBNpwgX dSlbTufo3Hv3EcWmBQOozvNO2KleEZrgR/hjpTGTgr3wzfQ66VcIOZmXmTPZjhCBcRXAo3oPxbG YUUgKN1PodQ8bjORGUwbw/Oi3Kg9tz112gNN5o+zYZFvVkHKcT68uAkwo4kRbOEVWZt37kMBoW1 zdwDH/oG4PBw1picIXdwTjPGI= X-Received: by 2002:ac8:5714:0:b0:4ed:b06b:d67d with SMTP id d75a77b69052e-4f4abd79a65mr200344511cf.45.1766538223845; Tue, 23 Dec 2025 17:03:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3FPxruJlcg4sByZJPHlC6i+AJRJP3LWX/PRkxW+hSkPSJ4R06usLW/tOcstjoguUC6XxUXg== X-Received: by 2002:ac8:5714:0:b0:4ed:b06b:d67d with SMTP id d75a77b69052e-4f4abd79a65mr200343621cf.45.1766538223198; Tue, 23 Dec 2025 17:03:43 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a18628284sm4545268e87.93.2025.12.23.17.03.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 17:03:40 -0800 (PST) From: Dmitry Baryshkov Date: Wed, 24 Dec 2025 03:02:53 +0200 Subject: [PATCH v3 04/10] drm/connector: make clear_infoframe callback mandatory for HDMI connectors Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-limit-infoframes-2-v3-4-7fd3cacfefed@oss.qualcomm.com> References: <20251224-limit-infoframes-2-v3-0-7fd3cacfefed@oss.qualcomm.com> In-Reply-To: <20251224-limit-infoframes-2-v3-0-7fd3cacfefed@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Liu Ying , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5379; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=nzElO3qrN1ngMVHhZahBd7pKCsEHzR84mn0cPkFgNGc=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpSzvY4okwjZ995SvLTt2suiGbzvPytcBxbUZoJ IPFjD2XFqiJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaUs72AAKCRCLPIo+Aiko 1VbaB/9msli7nDTqX+64qChKWsJQHzLJSmqJubE1UJ2Nf5Hi/AwpsU7hfYtfCl3WwKKmKfuuu8Q Lnl1Ig4EyHgBKD8apvy+9QiFbhlYaqL42IMOn+b4fFQG+1HPmsw4bhcy1pYeNPK2nWrNf4Iot+s sd3Qh5XwmI66qB1NAgelgo+ogMATAG/krn39azAVbzRMw8HrEzuws07zAM9ceLRCB1ggf6IEBFQ TFqvoA7DhLiuf8z1XlDYFdpss+zjWGa6X0rgks+Jb7dLupcHZqGP6X4NiZ6MxeJ8PeusTd6aEyy LwfXlcUtR0hby0mDACU1DWxjeEkPR22us8arufoAaAdFAFeo X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDAwNyBTYWx0ZWRfXxPzcLjfrgtne Slbt52UTajXaVNXTNY9/naeLCLZQrf44Xc71xoIGBUQIL+ay6Ti6uU5Zaj7/XQgdPOW4/YlOwRx wuQ7KwQ0GKJ2Hxqs/T03kbFFZw2dnuPgc51960WJGrZ2tiBZ02Im8pxln6KEgGBskM4BEELZaQS 16tGdNnNbSyvgeyDSkl1C3/2DDEuHTppUcvsJT5NNgZzE0UuPRD1921eLmRgAHeJiXm6YrXggUJ a5EbQe5IjFpF4Jc6XFltwBxJK4E86mXTZyirKF69SS529D4X354uyklq1MgeQbf4GseMUJqeRMC eTuZXPe3oRk2NPEDNu15yWgQ9bMtLgw0hJ0O7anpS1Wvq9zHpgJARfZRxlWJu0PFCFjwnvsETfr 5JGVomwhKatc9Z154DLkGo4W6KU+XAPJNeTjy1hGTFkOV+K3qILMCF/41B/WTvj/QrIJPeCWuTn kTXGBntAUs8QXf8l+4Q== X-Authority-Analysis: v=2.4 cv=IvATsb/g c=1 sm=1 tr=0 ts=694b3bf0 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=9fyoTQa5ixSHU3Y6h0oA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: p2vfFUc4flGIbveyyz13P0TMjPBbni73 X-Proofpoint-ORIG-GUID: p2vfFUc4flGIbveyyz13P0TMjPBbni73 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-23_05,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240007 We already require both hdmi_write_infoframe and hdmi_clear_infoframe for bridges implementing DRM_BRIDGE_OP_HDMI. It makes sense to require the clear_infoframes callback for HDMI connectors utilizing drmm_connector_hdmi_init(). Signed-off-by: Dmitry Baryshkov Acked-by: Maxime Ripard --- drivers/gpu/drm/drm_connector.c | 4 ++++ drivers/gpu/drm/tests/drm_connector_test.c | 15 +++++++++++++++ drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 22 ++++++++++++++++++= ++++ include/drm/drm_connector.h | 2 +- 4 files changed, 42 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connecto= r.c index 4d6dc9ebfdb5..40e025712c9b 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -600,6 +600,10 @@ int drmm_connector_hdmi_init(struct drm_device *dev, if (!(max_bpc =3D=3D 8 || max_bpc =3D=3D 10 || max_bpc =3D=3D 12)) return -EINVAL; =20 + if (!hdmi_funcs->clear_infoframe || + !hdmi_funcs->write_infoframe) + return -EINVAL; + ret =3D drmm_connector_init(dev, connector, funcs, connector_type, ddc); if (ret) return ret; diff --git a/drivers/gpu/drm/tests/drm_connector_test.c b/drivers/gpu/drm/t= ests/drm_connector_test.c index 22e2d959eb31..f356ea695ae7 100644 --- a/drivers/gpu/drm/tests/drm_connector_test.c +++ b/drivers/gpu/drm/tests/drm_connector_test.c @@ -25,7 +25,22 @@ struct drm_connector_init_priv { struct i2c_adapter ddc; }; =20 +static int accept_infoframe_clear_infoframe(struct drm_connector *connecto= r, + enum hdmi_infoframe_type type) +{ + return 0; +} + +static int accept_infoframe_write_infoframe(struct drm_connector *connecto= r, + enum hdmi_infoframe_type type, + const u8 *buffer, size_t len) +{ + return 0; +} + static const struct drm_connector_hdmi_funcs dummy_hdmi_funcs =3D { + .clear_infoframe =3D accept_infoframe_clear_infoframe, + .write_infoframe =3D accept_infoframe_write_infoframe, }; =20 static const struct drm_connector_funcs dummy_funcs =3D { diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c b/drivers/g= pu/drm/tests/drm_hdmi_state_helper_test.c index bdf14a0623b2..915dcd106703 100644 --- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c +++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c @@ -76,7 +76,22 @@ static int set_connector_edid(struct kunit *test, struct= drm_connector *connecto return ret; } =20 +static int accept_infoframe_clear_infoframe(struct drm_connector *connecto= r, + enum hdmi_infoframe_type type) +{ + return 0; +} + +static int accept_infoframe_write_infoframe(struct drm_connector *connecto= r, + enum hdmi_infoframe_type type, + const u8 *buffer, size_t len) +{ + return 0; +} + static const struct drm_connector_hdmi_funcs dummy_connector_hdmi_funcs = =3D { + .clear_infoframe =3D accept_infoframe_clear_infoframe, + .write_infoframe =3D accept_infoframe_write_infoframe, }; =20 static enum drm_mode_status @@ -89,6 +104,8 @@ reject_connector_tmds_char_rate_valid(const struct drm_c= onnector *connector, =20 static const struct drm_connector_hdmi_funcs reject_connector_hdmi_funcs = =3D { .tmds_char_rate_valid =3D reject_connector_tmds_char_rate_valid, + .clear_infoframe =3D accept_infoframe_clear_infoframe, + .write_infoframe =3D accept_infoframe_write_infoframe, }; =20 static enum drm_mode_status @@ -101,6 +118,8 @@ reject_100mhz_connector_tmds_char_rate_valid(const stru= ct drm_connector *connect =20 static const struct drm_connector_hdmi_funcs reject_100mhz_connector_hdmi_= funcs =3D { .tmds_char_rate_valid =3D reject_100mhz_connector_tmds_char_rate_valid, + .clear_infoframe =3D accept_infoframe_clear_infoframe, + .write_infoframe =3D accept_infoframe_write_infoframe, }; =20 static int dummy_connector_get_modes(struct drm_connector *connector) @@ -2419,6 +2438,7 @@ static int reject_avi_infoframe_write_infoframe(struc= t drm_connector *connector, } =20 static const struct drm_connector_hdmi_funcs reject_avi_infoframe_hdmi_fun= cs =3D { + .clear_infoframe =3D accept_infoframe_clear_infoframe, .write_infoframe =3D reject_avi_infoframe_write_infoframe, }; =20 @@ -2500,6 +2520,7 @@ static int reject_hdr_infoframe_write_infoframe(struc= t drm_connector *connector, } =20 static const struct drm_connector_hdmi_funcs reject_hdr_infoframe_hdmi_fun= cs =3D { + .clear_infoframe =3D accept_infoframe_clear_infoframe, .write_infoframe =3D reject_hdr_infoframe_write_infoframe, }; =20 @@ -2685,6 +2706,7 @@ static int reject_audio_infoframe_write_infoframe(str= uct drm_connector *connecto } =20 static const struct drm_connector_hdmi_funcs reject_audio_infoframe_hdmi_f= uncs =3D { + .clear_infoframe =3D accept_infoframe_clear_infoframe, .write_infoframe =3D reject_audio_infoframe_write_infoframe, }; =20 diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 8f34f4b8183d..4543833acdec 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -1253,7 +1253,7 @@ struct drm_connector_hdmi_funcs { * called multiple times, once for every disabled infoframe * type. * - * The @clear_infoframe callback is optional. + * The @clear_infoframe callback is mandatory. * * Returns: * 0 on success, a negative error code otherwise --=20 2.47.3