From nobody Tue Feb 10 06:07:50 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92A34311C1B for ; Wed, 24 Dec 2025 09:07:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766567244; cv=none; b=aWBQKK12/mR1ej4u2LjHUrSqCP5Qntv+5Kuy0enmeJ4WJ7ZAtgw1NGhr2wv72/zHFTZTulPHN+meo2T+LN+oveyKU6jsDo85O5aZLMagrwG9lDem2ehWni4MEF8NaNr5SBu1MUd3hkkmzL2Cc1GHXuuToIlVrYckVgDh/Oggz8s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766567244; c=relaxed/simple; bh=E+ppFBcrIJvAdTSLfg3aWv6Te2yyYQtt5h1yCZRSC90=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hXJsHeJEm/5Df7qcun0mzQneynP5dlDKCnIu3Oq76lMCQh7fmQ9BhG0ZwW2iiY5uERiVjgU58wt4Qp0lXgrAmqXGJmRA1/6q5s22ISZWxvrLkSFaExZxTCnf/dbbMJCqeyimpV/kWGFd3pKjSFpSeKCcW/A2ODpoOHN9HMictuM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DxuAf/zB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VmpG5h0z; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DxuAf/zB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VmpG5h0z" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO6egrY1245990 for ; Wed, 24 Dec 2025 09:07:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1fOi2vF66t90yroTgrkpJuJ7GaS3pPHt+cx2IRW7gGE=; b=DxuAf/zBg3i59ppl k+V8egBVcJ6GOb65OtIfFKMeFt4llm2xa4RcDA/zhOWZ//fZFZaebx8+HAfeuJw9 Mvrz6Hxq9numQ31355LhdDPD6xpJW0M0EOFS1OkOwko4fbIsFjaIVUFe8X9mAnz+ MBIMKUoPUm22xzgD2VjM93/ChNIsiMI5ksSCdvWE5euGhFpfHFMUS4EpEsSDNan9 06kTje54gZ/YdRvkjToZWXtQfnbjAh19d+/q41g0Z2pYoNaNhrDP9XQs9JxvPSIM y6OdOPBMnM62i6v6saYOqpAGP5XJy/KxXfCBKdzg74zrXiCJ1Ny8JVgoPgXvcfVa kDGziw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7u9cu2k0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 09:07:21 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-29f2b45ecffso94855945ad.2 for ; Wed, 24 Dec 2025 01:07:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766567241; x=1767172041; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1fOi2vF66t90yroTgrkpJuJ7GaS3pPHt+cx2IRW7gGE=; b=VmpG5h0zR9kW6UNS5y7A4pnbjGJXloBm1drNyYn0LcRZZgP+OowhEE0ubkj+7Rb3Bz bvlGVK5ieZHZHZaXQ2AvbVWrX9Y5YGSWOpI9+ssLvKGrPQoEVnCpmdTwhoPPGiWkyl4b k5N2srJ5hgViaE5B/oFPQzuus7WvEdz/cBsabtttdqjS+7VxPaD0Pf44FZSzMKzZAo7g k9/adPMJeQTCOhpmLPKwVUXMCXkbgk4lih/LqyW9aC63VbXExdBJUAVyaRSN8wgk+IA2 Ds9tGt43IUFq2lF7TDI+hzUyaBQIW3q9xRBgj+UuCIKUMVslmCMmj7O/xX7ZASRMNZj1 vfzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766567241; x=1767172041; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1fOi2vF66t90yroTgrkpJuJ7GaS3pPHt+cx2IRW7gGE=; b=ndqf0nW1NFs17VqQ75AahnXEGcyhGkfPI7nZbuqIetgu1G9CCm+ZcACh3XDDe3xNOu EG9WNS9dstO+LdZDRd9sJ0QrD2nrD8fFAkq7hwCsq5WIjERJ+gMkDRBE9Tt6bHOFeGiA JTjwhn/Ef4gRdB3JND5eSDLbCJlmzKmCNr/Zt8isjocRqIQC9hGJIPsdW9m4aT+qY4D9 BQBvSOJGRym9tRKezmj8pYdL/HvM7CoGQN8lYH446Uf8K4Z9NTRwCK1FAGfx5tfE/lDV 6St6XW7T2SOZPeVY1dDHx/don3HmH8geHRQ3C8Ri/3rcV+Xz6ACe6dkfBvn7D3AxI3kH +ALw== X-Forwarded-Encrypted: i=1; AJvYcCVv+lO/P4HdSnHhP2S0iDzk2bY7UVbuHk+WsrTm3kmM4l7PN8D7yf8jc7YnqQk70CKx9npbBUHAgokOX3Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzwZ8C6oIxS+tTyesLP27XEA6yGHm5IouJahgobk6loccSb6CMg ItXWHF2crlxOYwvYCXtPFkErm32l6ReG1Uq2m06rn+GXcIbLZxnJYGHxqG2zAbhff5GGAePLA0d 8++WwaFbg/hWjC+jMgpBAQ2bjXJQ8nw0DIBgFUSqDpYBBA2GJUgfh6qaq2h/70qqJnYU= X-Gm-Gg: AY/fxX4Exwa36xEXTB55C4NZjo4iVUxkdq7lz1uzGPvAFhMJJLf8hCTl+8FacSYn/A9 xJmAoVLktt/SnGFYztQ9uWz8e6GUBr4tIso2VUgiT2RIbwN51qByb2KRxCmBQylKfRxmUclY8cM 6BTwnh6mAxrBx0hpvDv3nmH726+34X+q/N5Q2W2X4i1i6IH6M9RBbZ6156boo3vGk4ZMA1VjC5b o4T3NLeXdpzNiqaM7690I6OW1C95YkEeHUFxmHaAFp9SuZm1x9sXy3obRENBIpT9SZ+cCzWv3BI KWja/IY7gEumyfL8btolJCvHlZ6hTY65TgTTs/AvzHoFKWktlrJ1ZJBLTyV2QL2XDHYgfLuJJzS OcxtmWvxkVW6U2M3iNjqltxTRMcg5UalHgezDZJYJzW5PH0ybY/Zxb4FPN5uX4TNu43dl5EUl X-Received: by 2002:a17:903:249:b0:2a0:de4f:c9b with SMTP id d9443c01a7336-2a2f222b700mr179027085ad.4.1766567240662; Wed, 24 Dec 2025 01:07:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IFQC2XxAia4EX4NnIXvKYIkoEvVHiwnA8mWK4j1DSqVZwUZZzFNed1w6NIHIhhDYYgcHL8Lnw== X-Received: by 2002:a17:903:249:b0:2a0:de4f:c9b with SMTP id d9443c01a7336-2a2f222b700mr179026685ad.4.1766567240214; Wed, 24 Dec 2025 01:07:20 -0800 (PST) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c666d5sm148418095ad.21.2025.12.24.01.07.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 01:07:19 -0800 (PST) From: Jie Gan Date: Wed, 24 Dec 2025 17:06:14 +0800 Subject: [PATCH v9 4/8] coresight: etr: refactor the tmc_etr_get_catu_device function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-enable-byte-cntr-for-ctcu-v9-4-886c4496fed4@oss.qualcomm.com> References: <20251224-enable-byte-cntr-for-ctcu-v9-0-886c4496fed4@oss.qualcomm.com> In-Reply-To: <20251224-enable-byte-cntr-for-ctcu-v9-0-886c4496fed4@oss.qualcomm.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Mao Jinlong , Bjorn Andersson , Konrad Dybcio Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jie Gan X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766567216; l=4412; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=E+ppFBcrIJvAdTSLfg3aWv6Te2yyYQtt5h1yCZRSC90=; b=JorYpjDt+HQSZZ4cqDjMRyi2/w/tKFXOb4XpusXf/jp/55B0wZHXDs+JaucpIRzl28QKDlkgG cMNvERbaINXDNbFhJsuUGl2JFNVE9P6C7AWXC4/+2+DZtP4iH/FsDSx X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-GUID: rPFcUyjOz6F-XOGmeaKeXg2mssVsbbz9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDA3OCBTYWx0ZWRfX1sPHuXWb5PcY fB7dXMrhfdhp8atwqMeC/MkOH3w65n+LV2i2tNGxT4R7HGqwhRcWYV6CPmN9d6C1g8NEWCwsujB mXXbpfzwj2VYH3ltNIaiSoSJYefnSQOJdnNHi1c3sJOIosKbkOcvwbsO/JLvvIOtuKxs1f9jRz4 ej+Akf7limCPZ6Fj6acj+dgBQICGDvmRdUiWUj8pI0GY6JySr0yVQRcpFp3gQl5EWDRdqdFlE7x 2DtcJUqvMvGAr04JPLzO9eoh8OR+w7NKwJTVLdRJ6plSnPReyPEwyYVPejdxnorJhinbodwTojH qZCm8Qv1ZktJLPYs0xm51oqMZY+3UlSuPPcj0o7TnocJQoLeKCyddNsDAL9NLljjB4mVL7o4X4O Jp/xB7TJnG3l7wHSLkHYuUsCGc9YLIybfNrch9A+JyEKVEStfUc3aMqtYTupnt09BY9JxaUBYLT mjzKFO6nniKm54/ITGA== X-Authority-Analysis: v=2.4 cv=HsN72kTS c=1 sm=1 tr=0 ts=694bad49 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=-ozbsww5GKt6_lkPIaMA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: rPFcUyjOz6F-XOGmeaKeXg2mssVsbbz9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_02,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 clxscore=1015 adultscore=0 bulkscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240078 Refactor tmc_etr_get_catu_device to retrieve the helper device connected to the TMC ETR based on helper_subtype. Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-catu.c | 3 ++- drivers/hwtracing/coresight/coresight-tmc-etr.c | 32 ++++++++++++++++-----= ---- drivers/hwtracing/coresight/coresight-tmc.h | 3 ++- 3 files changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtraci= ng/coresight/coresight-catu.c index 69b36bae97ab..d3972619cc96 100644 --- a/drivers/hwtracing/coresight/coresight-catu.c +++ b/drivers/hwtracing/coresight/coresight-catu.c @@ -334,7 +334,8 @@ static int catu_alloc_etr_buf(struct tmc_drvdata *tmc_d= rvdata, struct tmc_sg_table *catu_table; struct catu_etr_buf *catu_buf; =20 - csdev =3D tmc_etr_get_catu_device(tmc_drvdata); + csdev =3D tmc_etr_get_helper_device(tmc_drvdata, + CORESIGHT_DEV_SUBTYPE_HELPER_CATU); if (!csdev) return -ENODEV; catu_buf =3D kzalloc(sizeof(*catu_buf), GFP_KERNEL); diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtr= acing/coresight/coresight-tmc-etr.c index 2b6ca1f8bed2..18981b6cc172 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -844,28 +844,37 @@ static const struct etr_buf_operations etr_sg_buf_ops= =3D { }; =20 /* - * TMC ETR could be connected to a CATU device, which can provide address - * translation service. This is represented by the Output port of the TMC - * (ETR) connected to the input port of the CATU. + * TMC ETR could be connected to the helper device, which can provide addr= ess + * translation service(CATU) or data filter function(CTCU). This is repres= ented + * by the Output port of the TMC (ETR) connected to the input port of the = helper. * - * Returns : coresight_device ptr for the CATU device if a CATU is found. + * @drvdata : drvdata of the TMC device + * @subtype : helper_subtype of the helper device + * + * Returns : coresight_device ptr for the helper device if a helper is fou= nd. * : NULL otherwise. */ struct coresight_device * -tmc_etr_get_catu_device(struct tmc_drvdata *drvdata) +tmc_etr_get_helper_device(struct tmc_drvdata *drvdata, + enum coresight_dev_subtype_helper subtype) { struct coresight_device *etr =3D drvdata->csdev; - union coresight_dev_subtype catu_subtype =3D { - .helper_subtype =3D CORESIGHT_DEV_SUBTYPE_HELPER_CATU + union coresight_dev_subtype helper_subtype =3D { + .helper_subtype =3D subtype }; =20 - if (!IS_ENABLED(CONFIG_CORESIGHT_CATU)) + + if (subtype =3D=3D CORESIGHT_DEV_SUBTYPE_HELPER_CATU && + !IS_ENABLED(CONFIG_CORESIGHT_CATU)) + return NULL; + else if (subtype =3D=3D CORESIGHT_DEV_SUBTYPE_HELPER_CTCU && + !IS_ENABLED(CONFIG_CORESIGHT_CTCU)) return NULL; =20 return coresight_find_output_type(etr->pdata, CORESIGHT_DEV_TYPE_HELPER, - catu_subtype); + helper_subtype); } -EXPORT_SYMBOL_GPL(tmc_etr_get_catu_device); +EXPORT_SYMBOL_GPL(tmc_etr_get_helper_device); =20 static const struct etr_buf_operations *etr_buf_ops[] =3D { [ETR_MODE_FLAT] =3D &etr_flat_buf_ops, @@ -913,7 +922,8 @@ static void get_etr_buf_hw(struct device *dev, struct e= tr_buf_hw *buf_hw) =20 buf_hw->has_iommu =3D iommu_get_domain_for_dev(dev->parent); buf_hw->has_etr_sg =3D tmc_etr_has_cap(drvdata, TMC_ETR_SG); - buf_hw->has_catu =3D !!tmc_etr_get_catu_device(drvdata); + buf_hw->has_catu =3D !!tmc_etr_get_helper_device(drvdata, + CORESIGHT_DEV_SUBTYPE_HELPER_CATU); buf_hw->has_resrv =3D tmc_has_reserved_buffer(drvdata); } =20 diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracin= g/coresight/coresight-tmc.h index c9a82ff6cd00..7690a70069da 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -471,7 +471,8 @@ static inline uint32_t find_crash_tracedata_crc(struct = tmc_drvdata *drvdata, return crc32_le(0, (void *)drvdata->resrv_buf.vaddr, crc_size); } =20 -struct coresight_device *tmc_etr_get_catu_device(struct tmc_drvdata *drvda= ta); +struct coresight_device *tmc_etr_get_helper_device(struct tmc_drvdata *drv= data, + enum coresight_dev_subtype_helper subtype); =20 void tmc_etr_set_catu_ops(const struct etr_buf_operations *catu); void tmc_etr_remove_catu_ops(void); --=20 2.34.1