From nobody Tue Feb 10 06:07:42 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB1C52744F for ; Wed, 24 Dec 2025 09:07:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766567240; cv=none; b=ZbuomdrVxIq5lZ3mZhiTJ3wwVh0ZxpvJPBbcaGPm6RB9SnXVayf49Sk3H5Oy41hyZc4WywTICuYnUHsvB+goLsCYPFlWmKHPKhriK+9LM1ZlD5ixGGQ84t+ygrNAGFN/iz4563YS4kX3Nwy7daxfKEOGlDiSb7kTW3PQD3n1z14= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766567240; c=relaxed/simple; bh=adb+NstK0OrGdQHboby6lmZs7rWs2zBc775hVSg6Ay8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tYFT172fbEdtQFhPiTMf2U5g1LAGMijpnRS64eKHPfrLMgmwYj2AB52uQik7X1tTJ+iVXx+h2etrlZxOQDEEayrRKOP9oO/QXOUjEg/lgcyosYzuZjrP267KVReUOWFggKKzVf9jkDjVx+0BSzD/T8TQoI7yvpCdXMOsOC1zXtQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YOBUPMmM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IiO/Mw06; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YOBUPMmM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IiO/Mw06" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO2ga3Q913433 for ; Wed, 24 Dec 2025 09:07:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lrMZyOpw/ZRelpfuA7qROurtddaj0sg5lOXpksKz24E=; b=YOBUPMmMdrDmeAIx Huv1FMsfe4YCuYUYWjRNLI1S7ntZ22ELjQ3MckP4EgYL9z21DlhTwaVHWF014DTu 4lDLayaKTXKzv1sZMCx+NiQNAHASjD6LlcT5DYgRli6raS29BmBwa/7THC2Sjqdd 4dNFknNfqrommWeiboRHuQmSAgPPGz2UnxDA3DbxwSs3oG2WBn/XA7naTRkPrTQ6 LzjihxAA3K+CQOeU0fK+2+Wx/WwjXOQUEEMUILCHNorecrPQ8OrVDBHEv7Z7ChNt 6lWQaI6TUgplNeU7SsT0w7IPHGDXenPCxqTMbY9mrRv/ui2nxDvdEk2XqOA4QwzP ClCVYw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7vt2jqnk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 09:07:17 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2a0bb1192cbso116862905ad.1 for ; Wed, 24 Dec 2025 01:07:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766567236; x=1767172036; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lrMZyOpw/ZRelpfuA7qROurtddaj0sg5lOXpksKz24E=; b=IiO/Mw065efPTMCFpu12JhhCjilarF3wGucTrEqW3t/pbzV0fHzjPQZHtwYtZj545p xsYW95/jaoGyXO3Qcj3CPwGIQNigQ/B0hKQ66u2INBjSqkGs8gcEVbpa937yrKF1ter4 xSxpd8wIyaVH+VPVhTh52/sWGGEx8+Ax0cnWFF1VdojCrex+YumVjEqYXpHvDUT3QOUy W3zSYhi7g9LoETi+jLhDMyFe4S8gwM1uekENihxzstc7uPxA1z4D0IkSFJ9U8vMZTDyI hZr1hpVd/6q+RDzLPhJl0ujowZlkMxkwFGT/Eo5UTwQ6aVjQTCzaKCU0+XPWHit4j6/g gB1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766567236; x=1767172036; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lrMZyOpw/ZRelpfuA7qROurtddaj0sg5lOXpksKz24E=; b=FV7BS1PvCmXmjSW8ySmruQZkkKWX3ynQdtb45lEqpD/ywYmf9jAZNyBTHw5iK/FLbF Aje/fCb7kKNn8wzFcokdhMD11tS337xXh8YwQ/sjWC0QQSCVPOCd6ONb3C4WaOj/rXgn crlP6cdOGfbTbofMz0wqwrS4YDCA1KCtxHrzSbZRAP3gxQK5F9zbOPz0QqXUcvzPd012 sg09STrON+ZlyGqvUfG5X6jEbTfD3ePpJkopZcag94ewNCcHhgSBKCmRoM6Ms7LYvOkA 0ONd5MWzYjwMdtbAn4MddabPaiyvZNbOuXvR/x4jqbBO9DodAMp/g4uBhzzYzJ6neZe6 dmtg== X-Forwarded-Encrypted: i=1; AJvYcCX8jxnj0zgxPQsz9gSsK5VKpHYziDOOVbQ7M0lm77HHzHiwYKdS53KReuTqs/fa+xvi2RbW4pd4iHiFRrI=@vger.kernel.org X-Gm-Message-State: AOJu0YwVToZpYG3kFlxE3l08QvOexWWog217P7XPCZAy9r6bzm0WQ1tw dYqSQbkdfJVT49pO6OGNQwL6M8iHMj7mfqZEr4pns6N8+suKaRbgMrTgFhlyBVhmInIdAPwBa7U 0ROCGTqY4rm33XNICjkJ2CrGWIH+CcWrmolxjRdzIIMNBqs1eDlOOecc8X6FMfxyLERg= X-Gm-Gg: AY/fxX5oBHh1m593/EIP2aXnbk6S8fiWu6JH0vv/wWVRTnfPSCbiumehoUTMXUdRdMH jAzBuQzEPByPKuONt+F2vBj6OoG7J1ayrk5h7H0eQSpipBXA8tJHmQd5ulpQovKLMooOOOiGxY2 TrGnjucmyWMM6OGS140Cx1SfkGFDV0etMHDujNvws89XD7vWldlSUv8okUh5OE+Xhc1h6cPUpof 0PRiGoYqgA6/N9GyKO+tFy43rlI3ELLWub0AliB2sDhe0sUpyblbkSDGVmV0n+csNXFX4ZBrGcw fMKsWODeuWcLEnoFihcAAGQzDbLT8970BhR5BiE77G7PxKKtVKSk6sxtHScMATZ8BD0WFvOSXpq zoig9CHu5R8wdbbsj6lnnmni/D1G0N5Xp0QpvBhdYx37PdTa84jZ0qnbqWBAMkmHfctcRkCwW X-Received: by 2002:a17:902:c40b:b0:295:7b89:cb8f with SMTP id d9443c01a7336-2a2f1f78d07mr184952165ad.0.1766567236202; Wed, 24 Dec 2025 01:07:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IG9Hm3W3DFtHwdujiHhNesaWsev04lu15VpbBPkpdmQV4QFHQ8NusHUQeuYpvBKkLyYCjutdg== X-Received: by 2002:a17:902:c40b:b0:295:7b89:cb8f with SMTP id d9443c01a7336-2a2f1f78d07mr184951915ad.0.1766567235667; Wed, 24 Dec 2025 01:07:15 -0800 (PST) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c666d5sm148418095ad.21.2025.12.24.01.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 01:07:15 -0800 (PST) From: Jie Gan Date: Wed, 24 Dec 2025 17:06:13 +0800 Subject: [PATCH v9 3/8] coresight: tmc: Introduce sysfs_read_ops to wrap sysfs read operations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-enable-byte-cntr-for-ctcu-v9-3-886c4496fed4@oss.qualcomm.com> References: <20251224-enable-byte-cntr-for-ctcu-v9-0-886c4496fed4@oss.qualcomm.com> In-Reply-To: <20251224-enable-byte-cntr-for-ctcu-v9-0-886c4496fed4@oss.qualcomm.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Mao Jinlong , Bjorn Andersson , Konrad Dybcio Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jie Gan X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766567215; l=5450; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=adb+NstK0OrGdQHboby6lmZs7rWs2zBc775hVSg6Ay8=; b=VCt4oiunM/XKuGR5ta/0wbou/1Ac6C8/Ako/ofvneEGNiOTCJzogA5q3kT1UhQ6oYti6pYWxo ueKG62Fh/mUDwZNVX1f/tUbvKvhVSVDe3VbYOgM3/0XwxcQQJmxX+1E X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDA3OCBTYWx0ZWRfX79T/wcY6K5sr 4nXT46EZFY3zTlMBZHYBK+a2DidV3H9pbmtbeuM23imhpYUwtnr865Q63JzpG/3DEHzMjaWgHTN 7fpDtffzRbp9JBZ17S2bAfsnBVzLJuOWMcXpfjr3g/txpv0dKnTjEXP5wurhooeyNrbV4Al8QZM HRp0sv//5EZ1FxurOb5YoilJvtkida2MAI1H/fnspcmG2ofKaqulD6LrW/q+Y4Oc16BUBVDYajG aJ5TMyYh8PK2eU7SD1mzyW/5XUvpJxKkxr0cth+V10ibUAh9l0n27bfzXxOFu/dwx+Q3PUwkm8x 2ZmbYLWT619Sy85QFS5qe6i4mCu1ZWcYNv/Nr1KjtfnlYwkc4S2U7IWCb47RSvdByzIy1OJp/vz yOgMIMMmgjZrjLeftUfomwCi3MWo97xmlKgVqFwCXkP1IW3e0NI+ddmfuJhtevJ80jm1vHUaSa1 7VSsCWMZz6zR77JK4cg== X-Proofpoint-GUID: I9ENiA84IIOGw2SGetQZ1tKafCrMNzhd X-Proofpoint-ORIG-GUID: I9ENiA84IIOGw2SGetQZ1tKafCrMNzhd X-Authority-Analysis: v=2.4 cv=brtBxUai c=1 sm=1 tr=0 ts=694bad45 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=JzqEjpkVlBH90HjAhVoA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_02,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 priorityscore=1501 malwarescore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240078 Introduce sysfs_read_ops as a wrapper, wrap sysfs read operations, for read= ing trace data from the TMC buffer. Reviewed-by: Mike Leach Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-tmc-core.c | 50 +++++++++++---------= ---- drivers/hwtracing/coresight/coresight-tmc.h | 17 ++++++++ 2 files changed, 40 insertions(+), 27 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwt= racing/coresight/coresight-tmc-core.c index 1ea255ffa67c..8b0397a77e57 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -232,17 +232,10 @@ static int tmc_read_prepare(struct tmc_drvdata *drvda= ta) { int ret =3D 0; =20 - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret =3D tmc_read_prepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_prepare_etr(drvdata); - break; - default: + if (drvdata->sysfs_ops) + ret =3D drvdata->sysfs_ops->read_prepare(drvdata); + else ret =3D -EINVAL; - } =20 if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read start\n"); @@ -254,17 +247,10 @@ static int tmc_read_unprepare(struct tmc_drvdata *drv= data) { int ret =3D 0; =20 - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret =3D tmc_read_unprepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_unprepare_etr(drvdata); - break; - default: + if (drvdata->sysfs_ops) + ret =3D drvdata->sysfs_ops->read_unprepare(drvdata); + else ret =3D -EINVAL; - } =20 if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read end\n"); @@ -291,13 +277,8 @@ static int tmc_open(struct inode *inode, struct file *= file) static ssize_t tmc_get_sysfs_trace(struct tmc_drvdata *drvdata, loff_t pos= , size_t len, char **bufpp) { - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - return tmc_etb_get_sysfs_trace(drvdata, pos, len, bufpp); - case TMC_CONFIG_TYPE_ETR: - return tmc_etr_get_sysfs_trace(drvdata, pos, len, bufpp); - } + if (drvdata->sysfs_ops) + return drvdata->sysfs_ops->get_trace_data(drvdata, pos, len, bufpp); =20 return -EINVAL; } @@ -769,6 +750,18 @@ static void register_crash_dev_interface(struct tmc_dr= vdata *drvdata, "Valid crash tracedata found\n"); } =20 +static const struct sysfs_read_ops tmc_etb_sysfs_read_ops =3D { + .read_prepare =3D tmc_read_prepare_etb, + .read_unprepare =3D tmc_read_unprepare_etb, + .get_trace_data =3D tmc_etb_get_sysfs_trace, +}; + +static const struct sysfs_read_ops tmc_etr_sysfs_read_ops =3D { + .read_prepare =3D tmc_read_prepare_etr, + .read_unprepare =3D tmc_read_unprepare_etr, + .get_trace_data =3D tmc_etr_get_sysfs_trace, +}; + static int __tmc_probe(struct device *dev, struct resource *res) { int ret =3D 0; @@ -828,6 +821,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) desc.subtype.sink_subtype =3D CORESIGHT_DEV_SUBTYPE_SINK_BUFFER; desc.ops =3D &tmc_etb_cs_ops; dev_list =3D &etb_devs; + drvdata->sysfs_ops =3D &tmc_etb_sysfs_read_ops; break; case TMC_CONFIG_TYPE_ETR: desc.groups =3D coresight_etr_groups; @@ -841,6 +835,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) mutex_init(&drvdata->idr_mutex); dev_list =3D &etr_devs; INIT_LIST_HEAD(&drvdata->etr_buf_list); + drvdata->sysfs_ops =3D &tmc_etr_sysfs_read_ops; break; case TMC_CONFIG_TYPE_ETF: desc.groups =3D coresight_etf_groups; @@ -849,6 +844,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) desc.subtype.link_subtype =3D CORESIGHT_DEV_SUBTYPE_LINK_FIFO; desc.ops =3D &tmc_etf_cs_ops; dev_list =3D &etf_devs; + drvdata->sysfs_ops =3D &tmc_etb_sysfs_read_ops; break; default: pr_err("%s: Unsupported TMC config\n", desc.name); diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracin= g/coresight/coresight-tmc.h index 9b3c4e6f0a5e..c9a82ff6cd00 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -221,6 +221,8 @@ struct etr_buf_node { struct list_head node; }; =20 +struct sysfs_read_ops; + /** * struct tmc_drvdata - specifics associated to an TMC component * @atclk: optional clock for the core parts of the TMC. @@ -258,6 +260,7 @@ struct etr_buf_node { * Used by ETR/ETF. * @etr_buf_list: List that is used to manage allocated etr_buf. * @reading_node: Available buffer_node for byte-cntr reading. + * @sysfs_ops: Read operations for sysfs mode. */ struct tmc_drvdata { struct clk *atclk; @@ -290,6 +293,20 @@ struct tmc_drvdata { struct tmc_resrv_buf crash_mdata; struct list_head etr_buf_list; struct etr_buf_node *reading_node; + const struct sysfs_read_ops *sysfs_ops; +}; + +/** + * struct sysfs_read_ops - read operations for TMC and its helper devices + * @read_prepare: prepare operation. + * @read_unprepare: unprepare operation. + * @get_trace_data: read operation. + */ +struct sysfs_read_ops { + int (*read_prepare)(struct tmc_drvdata *drvdata); + int (*read_unprepare)(struct tmc_drvdata *drvdata); + ssize_t (*get_trace_data)(struct tmc_drvdata *drvdata, loff_t pos, + size_t len, char **bufpp); }; =20 struct etr_buf_operations { --=20 2.34.1