From nobody Sun Feb 8 18:30:45 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1C8E212560 for ; Thu, 25 Dec 2025 01:41:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766626883; cv=none; b=VGfZcsz2+oSBL3egnzE7bOMMdWgwkcEcU50YelQCoLDS3BH/WBOASXomsm8F0anTMKJvqz3Pk1ZRAgB3sPfJ+fEB7+dHXGlaQVER1xvvK325Dxy/xz+I+Z/+ZBolHbnNbKcC6j0tEVE5PNK3TOLjzyaknd4PaIzZjwO5+N+I084= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766626883; c=relaxed/simple; bh=fmZZjnle7z96+ERvAJvwVIt7062Bn5oc70wBxCRkzEA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=kaqWpIXmtphoYByuRPompX+Tum/7QVt3lAE73kxyBNOCJzc3hnAFo48OChz34RaWcwBKWJN6eJk581ZvPo501gfbn2a88Ynj+Ja1RSZRFOOr0yyx3V5opS/aPvG4nyYhseXUKd6owkA0iFsYPlheQXzIW1RSDo726gC67Jw4dZQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RKPY8s0A; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RKPY8s0A" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-34c27d14559so5004503a91.2 for ; Wed, 24 Dec 2025 17:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766626881; x=1767231681; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=1QREB/SckZv/nFOW3Os/q9A2SOtRB9uexmle2+ha5fU=; b=RKPY8s0AmW56+oTQ1gq+4eMoLwjuUUn6JyrzyO2rWO+APPc1k80KbyOsetB1cDBr8n zy97MAjh8nmV9tGo8ABbJ9WFx4/Vlzbz8S4ctMbpRSUmWl4bq0/yk99jH4zU6DoOiJ8L IuFWtylfQe79pDaiGubGCW7nyh5SUZT32LORdOulYo3qlWQpGa5QicQrQ80BJFS/nD9m MgCLL1iLbRy3FJIaS9sAXGiVY60BZaqW3OLFA8EaaWf+Tzid98yHIqyNKhoQ3VK0J4LT Rl7WUzceXY66WPLaDxVLtdq0+vCckVUqeWlVg9rztQbp5Zg7KYA2YSg80dR6Edzotqw1 UB3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766626881; x=1767231681; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1QREB/SckZv/nFOW3Os/q9A2SOtRB9uexmle2+ha5fU=; b=nppXeg0ZQcYIjveeCqM3IB13QzqJ7RA4J453wVfRqA8DlilReNVNOjk7ThUJtZGKf1 seguWxjL10arV+q8FR1sbKPYx6e07CAab2f40miZ13OCNcx8GYoN1ryhwpwh3mQ6Drnv kxrUYVmfTykYmHqd6FfnUDc06Qpf4VqFCWZBe+dA4CbN8wSSKrFU1j3R41DOv1HPN037 URzA+vclUrHs0gD22bJGW5zTagwndWlj0uVx1+c3czZJZBQMx5ky4jCavPC7CtDCoRL8 ir6grNKd/haSxuxDiLYBG9UR0RxsVC+lkf05MQ+t2dutz78OOYMj0XoQ/KDXF6QCI+RQ aOAg== X-Gm-Message-State: AOJu0YwJyRex6Ur4/g2Xsuqx/ieXbZ3lQXtnnPxevavO4UVoqtHu3dxU D9YMWPRa4nSyF2WUvwgKUxQfjvx6++bfJk0cCNZO6NiqWTboZhEYsu81 X-Gm-Gg: AY/fxX7Qnxo51FDnwEKYjBod2iJ2it1v8yBOTw6Kz3vxuwDptOGXOu2wOVBqjLeISP3 6MX76yp7IKMktFVFM5unWsxZ4SYQAaMWKLf7Rc0QJ3xkTwacvBCyObuv4B5p/fLHtKmlVjumP7H ompY1MqZXBq0mr2G9u8NRSqKSkTQRLYLRcgTEYJwkZTXe2PjGUsWA3xuvYBLdm91O8bWpGNJenV kUpAwTqp1fqHID5RQ2xtTa0GMLSlFCrv3Jm7NYPs/kXBUx5yLRxYnFUkQEMHRqIQ15rHGYgV1aw yh6keQSIv/63HdV2TSHKWAywVJL6EPqoXw9SNdbFjmFtH2Fw0MAZ9TCcv1Kpo6LZZLzx4INEGBn tIT5f4EaupKunprM1zXFnJG5cxTxrhuMTpAY/HllzqmG4Yta6FM+He1eoKD9rfE2YHB+h1wHptf /iU7BGSwzL809vrrs5CBA2vOPWXeuYuURY X-Google-Smtp-Source: AGHT+IGNDA/3MZQtsM6C517w8yTmUmqJ48ojXTSZOxEtzaqQea/b9VG0w9jOR6Z9JBjI01VmkiFOVw== X-Received: by 2002:a05:7022:3a08:b0:11b:9386:826d with SMTP id a92af1059eb24-121723036a9mr21952206c88.42.1766626880644; Wed, 24 Dec 2025 17:41:20 -0800 (PST) Received: from [192.168.5.77] ([172.59.162.202]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121724de25dsm52916709c88.7.2025.12.24.17.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 17:41:20 -0800 (PST) From: Alex Tran Date: Wed, 24 Dec 2025 17:41:17 -0800 Subject: [PATCH] checkpatch: Fix false positive check for dt-binding docs and include Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251224-checkscript_dt_bindings_fp-v1-1-0e18877ced62@gmail.com> X-B4-Tracking: v=1; b=H4sIADyWTGkC/x3MQQqDMBAAwK/Ing3oarT6FZHQJhtdCjFkRQTJ3 xt6nMs8IJSYBObqgUQXCx+hoK0rsPs7bKTYFQM2qFvEXtmd7Fds4ngad5oPB8dhE+OjakhP3cs PDsceShATeb7/+bLm/AOSnhJvbAAAAA== X-Change-ID: 20251224-checkscript_dt_bindings_fp-0e5938f6d274 To: Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn Cc: linux-kernel@vger.kernel.org, Alex Tran X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2527; i=alex.t.tran@gmail.com; h=from:subject:message-id; bh=fmZZjnle7z96+ERvAJvwVIt7062Bn5oc70wBxCRkzEA=; b=owEBbQKS/ZANAwAKAXT5fTREJs3IAcsmYgBpTJY/cqOgqjoAOXAo/PxWYrBLZQ6Meo1HokeBw WDc37dwVV2JAjMEAAEKAB0WIQQAohViG04SVxUVrcd0+X00RCbNyAUCaUyWPwAKCRB0+X00RCbN yJUJD/9qhkkCpQ9R6liktlttfoRjeIzg1c+oB3LgdMSb2Ff1wZi90G0o2Va56Q/Ejgw2ePFMRmO MkAosYi8jSo9YSIUjnmErHl6+rM1BOq44keCuMBIb1usEKq2/9j3Yn6DjVZSw8QKzbElm5nE/TH DfxmcbDhweLjVccZuK/VLv6LDmGL/Q9Tc5ePsSsi9bxBjwvXLDQXgF4gd1nZd8AcOjXdSzkXt8o xsg6R1AHcaGGexv9mE6ZdFynEpXthjNCVpZqXlAe49UN/e0fLCsNiGodvlfx60459tPWITl7VX9 BSDJkggwnWuTVRxwgw2YtdQFgYQ6wklfREeofrHZCWGT3wA/DTKEG1XrXerO/mZIqzC6e6g/7+q 8qm+j3G+PqSJFRmHWQwK+YhfFSkU20ZgjHhucqKjxMjno+6TyCA1aUWsmsAfdgIb2JeaYKbke09 yWgEnei1YDJIwdDa6bxjQvuGTaz3vceBLXq766o12m+j4feACURwA20sQMDy38gcG17snOexO++ +bHwVkDHmBeZflUlnh7RVnQM99dzwjKg/IwQSjtdp5rTZIXZOUH8f4boNCH7pmCKn8EZs7iUT2Z bFp06UKal5M6Oa7Bh5VthK0YYpE/FXIscmmcd35W2nn1C4kN6DwS9OeGvjZ0JV+B0oLN/IF1aZ4 xm8k06eUm3qVBxg== X-Developer-Key: i=alex.t.tran@gmail.com; a=openpgp; fpr=00A215621B4E12571515ADC774F97D344426CDC8 The check for when to display a DT_SPLIT_BINDING_PATCH warning is performed on all files that are not MAINTAINERS files. This causes issues, specifically when checking against a patch that only touches docs/dt-bindings or a patch that only touches include/dt-bindings. The warning is still displayed when it should not be, giving false positives. The check for when to issue a DT_SPLIT_BINDING_PATCH warning is currently too pervasive and should only be performed when a change under docs/dt-bindings is detected or include/dt-bindings. If the current changed file is under include/dt-bindings or docs/dt-bindings then it is compared to the last file detected under include/dt-bindings or docs/dt-bindings. If there is a difference then a warning is issued. Signed-off-by: Alex Tran --- scripts/checkpatch.pl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c0250244cf7a3cb5e289b04fa4a9f644692dc278..fe3499bc9adda158c88231b48b3= b0100f3af0ee1 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2668,7 +2668,7 @@ sub process { my $authorsignoff =3D 0; my $author_sob =3D ''; my $is_patch =3D 0; - my $is_binding_patch =3D -1; + my $is_doc_binding_patch =3D -1; my $in_header_lines =3D $file ? 0 : 1; my $in_commit_log =3D 0; #Scanning lines before patch my $has_patch_separator =3D 0; #Found a --- line @@ -2924,13 +2924,13 @@ sub process { } $checklicenseline =3D 1; =20 - if ($realfile !~ /^MAINTAINERS/) { - my $last_binding_patch =3D $is_binding_patch; + if ($realfile =3D~ m@^(?:Documentation/devicetree/|include/dt-bindings/= )@) { + my $last_binding_patch_is_doc =3D $is_doc_binding_patch; =20 - $is_binding_patch =3D () =3D $realfile =3D~ m@^(?:Documentation/device= tree/|include/dt-bindings/)@; + $is_doc_binding_patch =3D () =3D $realfile =3D~ m@^(?:Documentation/de= vicetree/)@; =20 - if (($last_binding_patch !=3D -1) && - ($last_binding_patch ^ $is_binding_patch)) { + if (($last_binding_patch_is_doc !=3D -1) && + ($last_binding_patch_is_doc ^ $is_doc_binding_patch)) { WARN("DT_SPLIT_BINDING_PATCH", "DT binding docs and includes should be a separate patch. See: D= ocumentation/devicetree/bindings/submitting-patches.rst\n"); } --- base-commit: fa084c35afa13ab07a860ef0936cd987f9aa0460 change-id: 20251224-checkscript_dt_bindings_fp-0e5938f6d274 Best regards, --=20 Alex Tran