From nobody Tue Feb 10 13:17:57 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69D2C2989B4 for ; Tue, 23 Dec 2025 13:50:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766497850; cv=none; b=eMhDPtLGWk15Sjb1/RDNXW9oPuycsi2wFQ7drvS7LXs61Fxh0793U0ehkHJ0Kpi+oe1Xp8I+Wfkg7b3a7Bo9FvqBIvM+Vn0ps0qgam9XWYB8p11WTB3GqkfXjSRilCRp2xLXf2sOV1Efldp1FE2ySqgqG8dRcoz916WZLviOK3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766497850; c=relaxed/simple; bh=Km1aZNVXUokGZG+Hi3ebns4lEQqHpnqjkOASGrRxGsQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iRozbdb1RZa/qopp0uIs6fC6M4EpuetECBhlHvIL+FiZOiLhvofLlm6bNDedDT9Y80bcaZnwHGc9e4MsPy/qtV2cPwJZgfutJ9Itx3/uuf1w2ISxGcgrbX/iXc3c3T2Dm4jbrg0AByXh9eAaqECC5cx2Quc+n9yg+tNtHMFVpCo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=Ls9qBBIA; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="Ls9qBBIA" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-477a1c28778so57505635e9.3 for ; Tue, 23 Dec 2025 05:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1766497847; x=1767102647; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1Kc5eyb/iSkZT0bPBeQBdO3AtAfI/oXN1kmysUx4qCE=; b=Ls9qBBIA9EBJHuMbc90vpQVDt8CG7u6wfE48DnHEZ2dkDbUd1pZ+p2CF/XjdACDAcq 2N8aqwCuSqg6SdNALnz9JDRyKcPzH8OZhg+C5Fr4valnI57OF3gk3OJBrVfsGNhyoWO+ jzTa3WScoBI05q7QQ/IGK+7Mnol08DJ1JpIabzSvtbqlrRkXa8GPDQOWPSsfShvGX7zs tyWhNfdWSXHUKyCYX1X5IEGbKk4QU6PokaP/siqIwmkNJP/qAxJev7Mpgo9yZ9ELRFqa RJTx5OslcdOpd4CfJvk8kiodGOfaGfod+mFAlPUZiiJUqJCuLv0rBHskMQ3iCbhqDUgb RoRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766497847; x=1767102647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1Kc5eyb/iSkZT0bPBeQBdO3AtAfI/oXN1kmysUx4qCE=; b=pXBiJocBlapj416kjlyoSywo0qq5LeAR2zDCMfMidbKVbUChny/gdfQ/U7syvMjZWn 7kYE6XRuRVZzN2aAVZvwEUzQqmPRMpcVDIF29RuS2HZjWCAD4B0FsHADYuY+tqXjAiU5 ewqC4+UfgdP2HDtVWvBRTPEtWEFwCmyqcejHKLVuFzfu6DxaWZf4A9P60WUDueW+RVKh SG4iC/+c1yHGQJzyMesfMHNlcD7023zrsdkRKqf1d1f3r2GdCbzOo1ASM9CS8cKiVke4 8opxbXceUSggdEo7Geve54c/n22H3DMzN1bWEvY7uNqR2K552jMcq0Ep6hwMMsl7euRx jhXQ== X-Forwarded-Encrypted: i=1; AJvYcCWS3vEVeDkJIlnwat76J7JOhoedbUSxqtRpOgEqrzioVvdF1zX6oJ3CrOZqVY3RtCboCJH/rPqxIlUtrSQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyGo+DJ5J8Y2AiIyZD7CNpjQZqy92re1EzVlLCLdlSXBXY4pHC/ VQJpRfY3KB6+sqPwOhqENDlQtWHX+RgEpOsurBIoUYo+17ARy786RJqKAhfU2kyTCbE= X-Gm-Gg: AY/fxX5DY4X8Ylwnw11zQHUbZKaPc4b577s8XLYt49qoZT1vnO7y9myn03xJaB0awWc oTIuEq+paFDdG6OeJxe14GfjDZmuFKwAgEVEPSyzUGYGd/H6ZRlhWl6HuUnPleqhJETOaqdnzTG 2BHIU7n7shOetWiExdSIwdOw7IbsmUXnJ1cSPadJoh8U2O9VNB6qxe4Ca6W85DDNmHskPbQteaC owvuLjgfEqxsr8xYL8wY7jJAJy0LuesJJu0OaRSvs6Mv02s/XWSHRkhTto587RoTMhEduhCxQq4 PjK45W2apyj+1b+q9wkV99Hh0yYipPp60SCwvjEkxvdldxDPazdsHYWaD3RAKipDt/DnD6tVliH nQb2dK9SHQnsMZLofm7jK9QUksPp4prBPwOnA27A2qzoPwcCiBtfZjFshYOYax3yA3PEpcdAY21 0ME9heoVhlbEco1HplefwJDOf2XtF6jFHiuKpMTOwJ//NR7JTm0vYSTRs7wIRO+hmQJG5MRL4= X-Google-Smtp-Source: AGHT+IGuFz7Ozy02JtIIyMczbxKNk13M+AOoYfGj2cgq2MPwqq4wKAu3fvsA2DoiHSohIMc2z2Wxuw== X-Received: by 2002:a05:600c:524f:b0:477:b642:9dc1 with SMTP id 5b1f17b1804b1-47d19594b2emr132953945e9.20.1766497846787; Tue, 23 Dec 2025 05:50:46 -0800 (PST) Received: from claudiu-TUXEDO-InfinityBook-Pro-AMD-Gen9.. ([2a02:2f04:620a:8300:4258:c40f:5faf:7af5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d192e88f5sm237921025e9.0.2025.12.23.05.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 05:50:46 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, biju.das.jz@bp.renesas.com, fabrizio.castro.jz@renesas.com, geert+renesas@glider.be, prabhakar.mahadev-lad.rj@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea Subject: [PATCH v6 5/8] dmaengine: sh: rz-dmac: Drop unnecessary local_irq_save() call Date: Tue, 23 Dec 2025 15:49:49 +0200 Message-ID: <20251223134952.460284-6-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251223134952.460284-1-claudiu.beznea.uj@bp.renesas.com> References: <20251223134952.460284-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea rz_dmac_enable_hw() calls local_irq_save()/local_irq_restore(), but this is not needed because the callers of rz_dmac_enable_hw() already protect the critical section using spin_lock_irqsave()/spin_lock_irqrestore(). Remove the local_irq_save()/local_irq_restore() calls. Signed-off-by: Claudiu Beznea --- Changes in v6: - none Changes in v5: - none, this patch is new drivers/dma/sh/rz-dmac.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index a2e16b52efe8..72ec42fedac6 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -267,15 +267,12 @@ static void rz_dmac_enable_hw(struct rz_dmac_chan *ch= annel) { struct dma_chan *chan =3D &channel->vc.chan; struct rz_dmac *dmac =3D to_rz_dmac(chan->device); - unsigned long flags; u32 nxla; u32 chctrl; u32 chstat; =20 dev_dbg(dmac->dev, "%s channel %d\n", __func__, channel->index); =20 - local_irq_save(flags); - rz_dmac_lmdesc_recycle(channel); =20 nxla =3D channel->lmdesc.base_dma + @@ -290,8 +287,6 @@ static void rz_dmac_enable_hw(struct rz_dmac_chan *chan= nel) rz_dmac_ch_writel(channel, CHCTRL_SWRST, CHCTRL, 1); rz_dmac_ch_writel(channel, chctrl, CHCTRL, 1); } - - local_irq_restore(flags); } =20 static void rz_dmac_disable_hw(struct rz_dmac_chan *channel) --=20 2.43.0