From nobody Sun Feb 8 06:22:04 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E94A32AAAE for ; Tue, 23 Dec 2025 09:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766483706; cv=none; b=VGJhKjk7JxOziDDUrzS/oqziUExvosHS06E6ShursYSkgAVLalC9L/2Byw3s/i/et1HuyF7nqYfdUk4dxjSX1SxRkuljAh2VOf7jH+TshvRQPiNAk2RVU+wESxVdGw7hOPodcZ3ruRGkYh5thpDQVkSo6ImDuXi21P3hyyLHw8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766483706; c=relaxed/simple; bh=cKQbVVJ3vyC69sgRx7ESOWa6IzIE7GxVYJs/ub6SKQA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iupd6GXlB83mfL+HmqXSY5BQ6urHAj3lxLjKOr5qFJPP/6E6L1tJd9NUrZwuYN+465tc0L78wCKTjcEjCgv7XNVEs2XtHrC005Wg5pSFZbMmXVEczSOMKQrZb34Rg4+FQHPQ/wc4V9ir8KJfKodTtwoyXKB2zqSvqYcSm8em+SQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KZ0JOSYd; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KZ0JOSYd" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-bfb84c2fe5eso2119318a12.1 for ; Tue, 23 Dec 2025 01:55:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766483705; x=1767088505; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IPXyR+DtSHvjmSw63vey96VhbW0eHbWu1L3mVM+HHkU=; b=KZ0JOSYdC2sjIaAJNYwj4vRa1RViaqmKEq0hHsbwiG5uT2AvJgcjL2XZ3gUX8nLa8e zByizgMz1/2qQ6NAxc4pAi6Xo9P9ZP+UB971ljs/M4vGRS0M2g0dto/b/PFQsMw0BpKj 7s/hzIWCbbwAHrZLFKwbo6dgNENdPR48uYvIsZCAJhz8f9FxalBuwHwRhA8wH46M2ZnJ CgK9LqlH3Qar/3Qx1oM3l01OmKs078cwOurS2pTHOW3H19YvAi+82xXuOAhhVUOFkgZU vuwRMvQb4474/d/C9y8LHWMndsY+jj60NGBnuXgfpYAvtztSjH07wA1DzhErTfzxxRJb gL3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766483705; x=1767088505; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IPXyR+DtSHvjmSw63vey96VhbW0eHbWu1L3mVM+HHkU=; b=iWTLe9hkRqF2YJ3jajt98pl3bDJRFOtzXCIlz7iBG1fxd2EwWp9eOWP7xrtT5cgaHz 8t/Vp9rm9m7tAUPWmiEkWW0OCufUTuO96UQ+Ee56V6b0IJxRVTS3cDXCn8TZmXETMgxz 3C/Es8pSGIBNFrE6ussGykkHCioVBd49e/XWbJ2pkjBiWO4EZ041cqqI3oSmaOj6FxmS su4YS2rbPllr3ourO6CLypS5InjXvqoW9P63GiWKpg3M6D2paIFGhdVQfwmk4KunjTPi DL9mojMOr17QjM7h9wzZZ+W+O35V+soxHHj3aPNsVeI4S0vLxsBzS4VzK6dO6qGWQckQ RwNg== X-Forwarded-Encrypted: i=1; AJvYcCX4uCzb8CcRBTcvZzBFyRPmNzFbhGK5UgFCdypCRpuiWAGDJktbQPgWaF3pztXGRiykgPUak+3CeVLZQds=@vger.kernel.org X-Gm-Message-State: AOJu0YzOrFN6g9BCcwkgIZde8rCbumUciYRgNh+4PDYHKFvu7ZpLowG+ RxY0wLMfL3IBSFfkFJjJhBEuJR1AWZ5OoiY2QloZUhqCfOs8anv/vYEl2WIPNuKt X-Gm-Gg: AY/fxX5zhuDTQaq56bwFvMvWs3m8HpYtFrEyj/d6EjhNqVSATMoWAa3IMU+5tVN0Nlf 3fRlI4JsmRCxVrloREdGFKMko4dCZ8UQCfHABcCH88ql5OWyh8H2615uet8pWnGADAt0uP0Gba9 bQIned/cu+Thd5Z9CWZdDxEEJRFllX3YBR09j5zoUE0EJ/KxPzOdY+84oJnZMRX4r7bvmv7QwiX ykRhc58Gl7Q9TinrZ/8UhpIHiyWlsSAqkCvjW9Z/mPlbpQs8OnGKWwz0cYfPlwRQBbR11s3J+bs qC9zbdkVHnYTjKCIHklFSRw1PXcoU4vb7eWRpu4S7rZQXea5BKgHDl5oDCjNKOxoO2FM5kZWRRa Rk+QCidlCY65hbUp7kVdoF2aXkPJgpj+yfYbzmUo1twGz1Gkmo0K3w8/Ye4b58Vi6xyP9CmUsP+ HxOmYIPMoa74ttMfnV5SuK0ZM0tUkA X-Google-Smtp-Source: AGHT+IEdzNfnqNUJyDypKzn3dPYc29vkogAq63TVtVQNeWPmClzH/fQB7OhCe8Q/j5leeIRr37dB1w== X-Received: by 2002:a05:6a20:6a07:b0:371:7666:648c with SMTP id adf61e73a8af0-3769f3351f4mr13306712637.24.1766483704666; Tue, 23 Dec 2025 01:55:04 -0800 (PST) Received: from rahul-mintos.ban-spse ([165.204.156.251]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d776ebsm124413885ad.99.2025.12.23.01.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 01:55:04 -0800 (PST) From: Abhishek Rajput To: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lkp@intel.com, abhiraj21put@gmail.com Subject: [PATCH v2] drm/mediatek: Convert legacy DRM logging to drm_* helpers in mtk_crtc.c Date: Tue, 23 Dec 2025 15:24:34 +0530 Message-ID: <20251223095434.492041-1-abhiraj21put@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace DRM_ERROR() and DRM_DEBUG_DRIVER() calls in drivers/gpu/drm/mediatek/mtk_crtc.c with the corresponding drm__err() and drm_dbg_driver() helpers. The drm_*() logging helpers take a struct drm_device * argument, allowing the DRM core to prefix log messages with the correct device name and instance. This is required to correctly distinguish log messages on systems with multiple GPUs. This change aligns the Mediatek DRM driver with the DRM TODO item: "Convert logging to drm_* functions with drm_device parameter". Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202512220515.z3QybJ8I-lkp@intel.com/ Signed-off-by: Abhishek Rajput Reviewed-by: CK Hu --- v2: - Fix unused variable warning when CONFIG_MTK_CMDQ is disabled - Added Reported-by and Closes tags Link to v1: https://lore.kernel.org/all/20251217070303.689913-1-abhiraj21put@gmail.com/ drivers/gpu/drm/mediatek/mtk_crtc.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_crtc.c b/drivers/gpu/drm/mediatek= /mtk_crtc.c index 991cdb3d7d5f..bca2e40bca54 100644 --- a/drivers/gpu/drm/mediatek/mtk_crtc.c +++ b/drivers/gpu/drm/mediatek/mtk_crtc.c @@ -227,11 +227,12 @@ static int mtk_crtc_ddp_clk_enable(struct mtk_crtc *m= tk_crtc) { int ret; int i; + struct drm_device *dev =3D mtk_crtc->base.dev; =20 for (i =3D 0; i < mtk_crtc->ddp_comp_nr; i++) { ret =3D mtk_ddp_comp_clk_enable(mtk_crtc->ddp_comp[i]); if (ret) { - DRM_ERROR("Failed to enable clock %d: %d\n", i, ret); + drm_err(dev, "Failed to enable clock %d: %d\n", i, ret); goto err; } } @@ -343,6 +344,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_crtc *mtk_cr= tc) struct drm_connector *connector; struct drm_encoder *encoder; struct drm_connector_list_iter conn_iter; + struct drm_device *dev =3D mtk_crtc->base.dev; unsigned int width, height, vrefresh, bpc =3D MTK_MAX_BPC; int ret; int i; @@ -371,19 +373,19 @@ static int mtk_crtc_ddp_hw_init(struct mtk_crtc *mtk_= crtc) =20 ret =3D pm_runtime_resume_and_get(crtc->dev->dev); if (ret < 0) { - DRM_ERROR("Failed to enable power domain: %d\n", ret); + drm_err(dev, "Failed to enable power domain: %d\n", ret); return ret; } =20 ret =3D mtk_mutex_prepare(mtk_crtc->mutex); if (ret < 0) { - DRM_ERROR("Failed to enable mutex clock: %d\n", ret); + drm_err(dev, "Failed to enable mutex clock: %d\n", ret); goto err_pm_runtime_put; } =20 ret =3D mtk_crtc_ddp_clk_enable(mtk_crtc); if (ret < 0) { - DRM_ERROR("Failed to enable component clocks: %d\n", ret); + drm_err(dev, "Failed to enable component clocks: %d\n", ret); goto err_mutex_unprepare; } =20 @@ -648,10 +650,11 @@ static void mtk_crtc_ddp_irq(void *data) struct mtk_drm_private *priv =3D crtc->dev->dev_private; =20 #if IS_REACHABLE(CONFIG_MTK_CMDQ) + struct drm_device *dev =3D mtk_crtc->base.dev; if (!priv->data->shadow_register && !mtk_crtc->cmdq_client.chan) mtk_crtc_ddp_config(crtc, NULL); else if (mtk_crtc->cmdq_vblank_cnt > 0 && --mtk_crtc->cmdq_vblank_cnt =3D= =3D 0) - DRM_ERROR("mtk_crtc %d CMDQ execute command timeout!\n", + drm_err(dev, "mtk_crtc %d CMDQ execute command timeout!\n", drm_crtc_index(&mtk_crtc->base)); #else if (!priv->data->shadow_register) @@ -776,9 +779,10 @@ static void mtk_crtc_atomic_enable(struct drm_crtc *cr= tc, { struct mtk_crtc *mtk_crtc =3D to_mtk_crtc(crtc); struct mtk_ddp_comp *comp =3D mtk_crtc->ddp_comp[0]; + struct drm_device *dev =3D mtk_crtc->base.dev; int ret; =20 - DRM_DEBUG_DRIVER("%s %d\n", __func__, crtc->base.id); + drm_dbg_driver(dev, "%s %d\n", __func__, crtc->base.id); =20 ret =3D mtk_ddp_comp_power_on(comp); if (ret < 0) { @@ -803,9 +807,10 @@ static void mtk_crtc_atomic_disable(struct drm_crtc *c= rtc, { struct mtk_crtc *mtk_crtc =3D to_mtk_crtc(crtc); struct mtk_ddp_comp *comp =3D mtk_crtc->ddp_comp[0]; + struct drm_device *dev =3D mtk_crtc->base.dev; int i; =20 - DRM_DEBUG_DRIVER("%s %d\n", __func__, crtc->base.id); + drm_dbg_driver(dev, "%s %d\n", __func__, crtc->base.id); if (!mtk_crtc->enabled) return; =20 @@ -845,10 +850,11 @@ static void mtk_crtc_atomic_begin(struct drm_crtc *cr= tc, crtc); struct mtk_crtc_state *mtk_crtc_state =3D to_mtk_crtc_state(crtc_state); struct mtk_crtc *mtk_crtc =3D to_mtk_crtc(crtc); + struct drm_device *dev =3D mtk_crtc->base.dev; unsigned long flags; =20 if (mtk_crtc->event && mtk_crtc_state->base.event) - DRM_ERROR("new event while there is still a pending event\n"); + drm_err(dev, "new event while there is still a pending event\n"); =20 if (mtk_crtc_state->base.event) { mtk_crtc_state->base.event->pipe =3D drm_crtc_index(crtc); --=20 2.34.1