From nobody Mon Feb 9 11:22:48 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCE2A2F0C48 for ; Tue, 23 Dec 2025 06:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766472801; cv=none; b=ndN0dHfiHYKTWyzlqCVP/DLZXWs/zUcDzsDRWwPGjgMpK1ogR0/gHvoT/zQH3uZ8DxE1NidYyonnNccV4pA8LhEeVCfheNaFJcmfRqWmvPgkH/NahH5fjZ7FjhEt/PczuPu8/duXX2t5onuEWRvC24Ez51s02ecARlgOlIUnCvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766472801; c=relaxed/simple; bh=0Mqi7dBywdOuhuH+YUhkuktsUNLkUWukjoOq8PzZrdg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oXAZH6s8u2KYB3Z2xeSFh87pMOA1h/v0iqSS1ABI2gj9Dn5CyxgsN+an/rRSkyXy+dnD500jQsIcKgXP0OksEBHEAbvAZXB8f7CPXeXJUPYMVqH+AwrsITH87u2ecqVGmCrpKDHbg5V56+0RsA9Yk5OTxRIM2UIVp+1WksAGA5c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b=0qdA4Jzd; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b="0qdA4Jzd" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-7b6dd81e2d4so4927057b3a.0 for ; Mon, 22 Dec 2025 22:53:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20230601.gappssmtp.com; s=20230601; t=1766472798; x=1767077598; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Omie+aIP/M9di46gB5qUKmryRAwukobUHm+cdMjFh30=; b=0qdA4Jzdc+fKSRdy9TJZObD43qatIQhLMCEbM45NgduJGfImP5MOwRAtJkghXEwsvU tTdGHQTKKBLjHwwLCCnsx7/OqQziim02gjeDQgI854S+jHJmZ+NXwSApqm+RY9chkl6d MH2g/Jqk93NrIPJmbuY47PilblKYf8epFS+sDuvswyXPkgZqQFGN8KSYbhi8y/q1Y3iw VhSIB4KccCmG2HXGVP6VlBtqbCgD/fIexHIK0RRIvhbVQ93NzPDD2eRnfSbuuLSboCA1 dAGKGtGTQ7E3sjgPR4DqT/DwjChSF6WM97DpT+HlMuM/xGcGx9iRm7Vk/1gQaILtJViK xUQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766472798; x=1767077598; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Omie+aIP/M9di46gB5qUKmryRAwukobUHm+cdMjFh30=; b=fQDtxdJ2LFBZ17uzwNFqMtSSQG9HM7ika1DkTqQVl2vfyZY4CZmcxR0DrCyWJiWj06 aZB6au6oB6tt/cuknd2m+gqel3QmUGICUdm8Ef1USHc5PNH8wn4FGIiFYsTY0hckgKld dr5CIxu620fAGpUB0eOSeq8djoDdxDW9PxgGJbLxuohJX7op2JJM7m1UZDuZ1vvhvTvp QiFN/teUFI0530IcGsG3hJEH3MwfjgleRMrM/RxuLPbcTPzLww2YVRshOLRRvdgVAk1u dLJ+rLZKOaHOMBlO2vct4wMoRS0pz7ZbKR4VGYwHjZSjXOlgw1fI7DoRbr+0pxHC6IH2 1FZw== X-Forwarded-Encrypted: i=1; AJvYcCXGUZmX4nHsPjzEsZOM2HdhJOfbkytVHAcKA7R2MtXM5HeUKDPoaxsMqb3/tDfpEW+efUMmvnjCDfuuR7U=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1yab91utCUNLk18FflNJG0PAzmBp65pDgr258UGQHXGWBUD9K 95j9MDYphyfsEeGqyySlpkAxGlC9VBahqddG/9jjBoeR19eFgC/hl9FBb0tzGTfgIMc= X-Gm-Gg: AY/fxX53Q3Qul5LV7+Ip+fLOntEKYAV1dprf1iDLYzHQKH2EeNu5LN66nKej9VoFHgV oObha0+8I8Hx1FjKIuSdDYhkiyWbIcnq66I/s0/b0fApLneLi+rhZx5Oe5fmdp46cRLXasUk8VD 0bRXxlI+XxKnxjRF1pwiPQCohoYXZub4ca3Xt52AR4vCF/+YtK6Vijus+/L6NsdcdaqKMQWe6dp hg5JTMnzzLIxVQpA4yvro0gJHBCAy/m3UDFCsiCwawczj5obFtCN2vF7exjWdGidrUM9K5ORDC2 Qk+vl20QjlSLLjNcqj3St14jo8S6W5EVzEzpmAtcTGXSivfYxoVQrHv5xBKKZGvBAX5kqjl7RKn qXg/5PfCJxVg/k8LllYGIWnkJGI5xVz56ficg3bxughppp/ElV1bZPqa+l2pIOJkYsJv10YuwvC Za+JExs3fbRw4GyxX/jd7Mlz6u X-Google-Smtp-Source: AGHT+IE9aDkJ4ZmTo42FTF2x3yvPVHXivvnWkrQMedEhpuyk1W6PnwRGT+VNRs55UHHmOHVjeO6dlQ== X-Received: by 2002:a05:6a20:6a09:b0:371:d67d:e56a with SMTP id adf61e73a8af0-376a9ae2989mr13490259637.57.1766472797865; Mon, 22 Dec 2025 22:53:17 -0800 (PST) Received: from localhost.localdomain ([103.158.43.19]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2a2f3d4cbb7sm118295755ad.59.2025.12.22.22.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 22:53:17 -0800 (PST) From: Abdun Nihaal To: linusw@kernel.org Cc: Abdun Nihaal , brgl@kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] gpio: mpsse: fix reference leak in gpio_mpsse_probe() error paths Date: Tue, 23 Dec 2025 12:23:05 +0530 Message-ID: <20251223065306.131008-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The reference obtained by calling usb_get_dev() is not released in the gpio_mpsse_probe() error paths. Fix that by calling usb_put_dev(). Cc: stable@vger.kernel.org Fixes: c46a74ff05c0 ("gpio: add support for FTDI's MPSSE as GPIO") Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/gpio/gpio-mpsse.c | 37 +++++++++++++++++++++++-------------- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/drivers/gpio/gpio-mpsse.c b/drivers/gpio/gpio-mpsse.c index ace652ba4df1..b473db9c3c4d 100644 --- a/drivers/gpio/gpio-mpsse.c +++ b/drivers/gpio/gpio-mpsse.c @@ -596,24 +596,26 @@ static int gpio_mpsse_probe(struct usb_interface *int= erface, priv->intf_id =3D interface->cur_altsetting->desc.bInterfaceNumber; =20 priv->id =3D ida_alloc(&gpio_mpsse_ida, GFP_KERNEL); - if (priv->id < 0) - return priv->id; + if (priv->id < 0) { + err =3D priv->id; + goto error; + } =20 err =3D devm_add_action_or_reset(dev, gpio_mpsse_ida_remove, priv); if (err) - return err; + goto error; =20 err =3D devm_mutex_init(dev, &priv->io_mutex); if (err) - return err; + goto error; =20 err =3D devm_mutex_init(dev, &priv->irq_mutex); if (err) - return err; + goto error; =20 err =3D devm_mutex_init(dev, &priv->irq_race); if (err) - return err; + goto error; =20 raw_spin_lock_init(&priv->irq_spin); =20 @@ -626,8 +628,10 @@ static int gpio_mpsse_probe(struct usb_interface *inte= rface, id->idVendor, id->idProduct, priv->intf_id, priv->id, serial); - if (!priv->gpio.label) - return -ENOMEM; + if (!priv->gpio.label) { + err =3D -ENOMEM; + goto error; + } =20 priv->gpio.owner =3D THIS_MODULE; priv->gpio.parent =3D interface->usb_dev; @@ -657,12 +661,14 @@ static int gpio_mpsse_probe(struct usb_interface *int= erface, &priv->bulk_in, &priv->bulk_out, NULL, NULL); if (err) - return err; + goto error; =20 priv->bulk_in_buf =3D devm_kmalloc(dev, usb_endpoint_maxp(priv->bulk_in), GFP_KERNEL); - if (!priv->bulk_in_buf) - return -ENOMEM; + if (!priv->bulk_in_buf) { + err =3D -ENOMEM; + goto error; + } =20 usb_set_intfdata(interface, priv); =20 @@ -673,7 +679,7 @@ static int gpio_mpsse_probe(struct usb_interface *inter= face, MODE_RESET, priv->intf_id + 1, NULL, 0, USB_CTRL_SET_TIMEOUT); if (err) - return err; + goto error; =20 /* Enter MPSSE mode */ err =3D usb_control_msg(priv->udev, usb_sndctrlpipe(priv->udev, 0), @@ -682,7 +688,7 @@ static int gpio_mpsse_probe(struct usb_interface *inter= face, MODE_MPSSE, priv->intf_id + 1, NULL, 0, USB_CTRL_SET_TIMEOUT); if (err) - return err; + goto error; =20 gpio_irq_chip_set_chip(&priv->gpio.irq, &gpio_mpsse_irq_chip); =20 @@ -695,9 +701,12 @@ static int gpio_mpsse_probe(struct usb_interface *inte= rface, =20 err =3D devm_gpiochip_add_data(dev, &priv->gpio, priv); if (err) - return err; + goto error; =20 return 0; +error: + usb_put_dev(priv->udev); + return err; } =20 static void gpio_mpsse_disconnect(struct usb_interface *intf) --=20 2.43.0