From nobody Mon Feb 9 08:50:47 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33B3526E6F0 for ; Tue, 23 Dec 2025 05:49:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766468960; cv=none; b=Lh/Spd8spNvXGuqc24NOJQuNN8XXdj0ElGOFgTne2je0hts+v/OTcMwp7inocRTJzESQ34+8qjmM7S+NRlHrGyiCVBDLraLgTZQ/sOLjN8aswLsvyEAYJdbva24HmfUFr+K2g/2SWcKgOT6L0r4ye8g/2yKQ/5R2Snq/XWWMvsM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766468960; c=relaxed/simple; bh=xY8s6ztPgI0v3eE5F9o/RQZ+CCnOvINklT570r72Aho=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GWiub92kfCQjh6LHZz3L1Hxaz8ihfw/ztREvVNCZ54MrQkdBVAI+nbtcNuKXSQCOHDUGkmzXOND1gpLYkUMZYuU+kIbiutBnPRBs5AK/BmTdnza8SCyUegZ8ZstsZ8Dy1fczRt2CWwbwi3FgegPjBoLj/kiIwGPGtkOBwtE14Fw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b=ZIY9rLj3; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b="ZIY9rLj3" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7b6dd81e2d4so4885950b3a.0 for ; Mon, 22 Dec 2025 21:49:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20230601.gappssmtp.com; s=20230601; t=1766468956; x=1767073756; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ghnk27Lh375IVPczUN98HcLESFSEZJiCHxM52A0wZU8=; b=ZIY9rLj3RneCyEkq0PyYBRJLRQxlOQaeHcMBbQBCoky7Oks1vxhaRnqVJp6BV86DkR KM0bXXvmJVufvCsc9b6X16CwxNfhnJOKC5BingKtfUrcP8n52S9LItFQDiFpomjZzaPu yTo5jqW8rG8kNPPykLhiFAj71NfCx0cnWRbd6aP5wwXp5a5PC2M0hljzY3eQsmWTwbff fSo2VILb1FFCu5yp7ItdSUy6vgvry6Wnhbs6yCQVxMHhYFQm4eP+i6KNcrqxHr2l7xW2 PdQX8WTKQT2tIgyb6IlwuPDI1dsgfGSb1m2SF7M7yttaIgvCGFgk3zYD/ktGzFgeoe3Y lKzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766468956; x=1767073756; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ghnk27Lh375IVPczUN98HcLESFSEZJiCHxM52A0wZU8=; b=gYOrK/DfrNIPPIZIvKenHLWoxGiNb7//Mnn8e73P0X2ex7XGSSXVXLYjU20o7U4Tk6 xAymiBsv2W+36LLdt+erdWTtzQjhhJgAqsBKpnHSsd2Iq0IyusdCjXO4ARFiu8UPmeFv 8M1kNJUPM3ZP/nea+JwgJF+kX4Mn8lp47nnK4jPwpbkrjFjvI0Paz4vTXHc0q7XHqEZm 5PETn6IqO4LMrh2Tix7MvNXFPVfj468xAMpwK1qFSRPg2JYnr8gCou+tb2FiUtw6WS36 YOT3KdUb1gUrkq1aXEXEtmMS3nvvniwypXv4Q/HYJqlEuPmlfgGj29Lc8L17xguxwT4P r+hw== X-Forwarded-Encrypted: i=1; AJvYcCXKmDSTh8gCiH6+LoiwcYTTdiYODx+6LaBDBLjArmuBpe8gdcAGt3IsJr/DE94kl9gXVtKWcLG4sUqbpFM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxr8Hri+r/OOCD55RhfoOHSK4PZ5P8hPiiefqgjsQibQch5TwXl FbVpQ1zzl6R7etNexpk4FjiUgECpPQudnlOTCKD8dTrYLN2Ogze3iZ6gQCeJ7CiXz7E= X-Gm-Gg: AY/fxX6m11VKnyxckmpjDRM/bmSQFHrUYqc6kd3ohOCddfvnC/IffxzVFbmNa7r+kXX /G8IWvdvqjiS2O0clViK72rdIiweLxlWc47TsJtwus8mlRdTptPs3eoHBJMXJA2SN7cdb7WRDoa 0n5+3g2ffyRdy0zeO0ddbU/0nU2aMT4Gc+jxSV2wbNBge6BJErA228kwTIMEy8909cHkCubEJ+Y EqtSeWST5BaXM6wtEGkI17VLGg512Qxbl1mXFry9Q+K4DLLH+87qDDc/QweTKxZ222Myx8GLzF6 KNTpV0hRbrkPlO+1ej8/mZ50HN7+8EegY3ykeiWmWTZ0aQDNLk5553gAyFN75fcmOd8OeWZ+dSw C+vFfOLmL6UF0l7daJQV/2RmGN8T8PbqGx0EdS3XYnJgKiFctT+JOXBJL15K/UjSVsHC7c/pgLa JY5CIdlFd1sUYJ51mhf/Ohb/ci X-Google-Smtp-Source: AGHT+IESOyjjQEV9cmHpzOZNpIr+8MrRuRllRcSqhZYjGKbchs0xAx7vP4yzg/aNsBH7TSdefCA1sg== X-Received: by 2002:a05:6a20:244c:b0:361:3bdd:65f7 with SMTP id adf61e73a8af0-376a75ef393mr13550597637.13.1766468956481; Mon, 22 Dec 2025 21:49:16 -0800 (PST) Received: from localhost.localdomain ([103.158.43.19]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2a2f3d5d3fasm115282995ad.69.2025.12.22.21.49.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 21:49:16 -0800 (PST) From: Abdun Nihaal To: mchehab@kernel.org Cc: Abdun Nihaal , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] media: i2c/tw9906: Fix potential memory leak in tw9906_probe() Date: Tue, 23 Dec 2025 11:19:01 +0530 Message-ID: <20251223054903.69043-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In one of the error paths in tw9906_probe(), the memory allocated in v4l2_ctrl_handler_init() and v4l2_ctrl_new_std() is not freed. Fix that by calling v4l2_ctrl_handler_free() on the handler in that error path. Cc: stable@vger.kernel.org Fixes: a000e9a02b58 ("[media] tw9906: add Techwell tw9906 video decoder") Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/media/i2c/tw9906.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/tw9906.c b/drivers/media/i2c/tw9906.c index 6220f4fddbab..0ab43fe42d7f 100644 --- a/drivers/media/i2c/tw9906.c +++ b/drivers/media/i2c/tw9906.c @@ -196,6 +196,7 @@ static int tw9906_probe(struct i2c_client *client) =20 if (write_regs(sd, initial_registers) < 0) { v4l2_err(client, "error initializing TW9906\n"); + v4l2_ctrl_handler_free(hdl); return -EINVAL; } =20 --=20 2.43.0