From nobody Mon Feb 9 19:09:51 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B643F17A303 for ; Tue, 23 Dec 2025 05:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766468913; cv=none; b=fc7KIGHcny1yubqC+7vslvzvl8R6J5nUtZZ7YC9XgKExIcWzwnfV4JVRCTNdrB+sTCisb1BbK7hyaXieEFjJ4AOoSv5i91K2bS6lYDtCaMiloydO8Xo7KLwged4w2qbgTOx4VRu0I7I9aoQPzYbGRZwvkvTJwuOLn+94uDW7Yuw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766468913; c=relaxed/simple; bh=RPpkS1QuyFFtxTsDVMkWej7l2G7Y6oeqyI5L1QR3FHI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RpX4OYLcJ0h1XTqwsXgIXWZGUEe5tF7CLKhaTMp9GvFdSjp8AsSInC/uZnVhGT46fbjQCPPtLG9Xqw8tLvE+7vTXOBSOxUlVXlVjw6f5hNrvp2sjJimNHfXPL6bEskXTGh/vqHrmuGyI9dSPc4B3zLDKRZxQ3Y7qaE5yc43TYQk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b=czBtDdGS; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b="czBtDdGS" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7b8eff36e3bso7271767b3a.2 for ; Mon, 22 Dec 2025 21:48:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20230601.gappssmtp.com; s=20230601; t=1766468910; x=1767073710; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/jlHTkGTlLd5I0Fc+k21AUFih0xaPy2p6vqpjRhpFjs=; b=czBtDdGS5hnEvNVsOoXU+17XTIRcWVn0ro0tVUqEos0m/F3z2/1497uWgiOURw5nUQ mLZABxLHgTtmFO7g6f0MrEvl1scvfcpeWuGQ6yFl4mwXm9asafcSUAYu0fFHuRLo6ZT3 sea4EGBqRKdoHWRdF5yrz9UlN3L9nuREt/XzjlSCNGZEo7LbNbMPEg/mT9X7ZH3Jrnx/ yzkfp80HJ9IC9j2gcBgCIHV7GpYxFwPTH8xvzoquAXsasoOjUC8mrP+PnTRZ5KU4K9xc QgHUoR55yyXnKlE9wCF2BVUDGXsmBRwUyjDjOSQLIrWozmgO5d+x2ojrjyG5CF+B0Cys WRQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766468910; x=1767073710; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/jlHTkGTlLd5I0Fc+k21AUFih0xaPy2p6vqpjRhpFjs=; b=H3PQCk4RMBo+dHHJua936USliBQP9ctlSA1l/ljFGRlQmcSuZ+4i2TroJxs7Or2qVT 6Z2aVCN0qSWJHj3E4I+nZOLLMo8sbUF6YcvDI7DJeD3aDvoQ6vHip+GNkegTQz1qrvpZ IJPL/32B8UxQDmpqyHbs0KnBxN4lKDTrqXcraC67J3vcpmNDSdvSUl9t+3YU8SP1s1yx yaeev8P7oCd0RAz5Sq9LqE02RMIhnGhCuAAKmj2hCNI3gUfEfGSoWOQ3O4a+iUFyrRkt lUNSTazN1K6gPsuW/OJW07CObfPQOnWeDkQN/Sad/uXdiWoO7GcVtLz4VJ11J+UAJQ1A lFZQ== X-Forwarded-Encrypted: i=1; AJvYcCXs7JAMTJCQ7u7S3t+TA6/kC11yqOHKOC4tfLv7Htk6/msg9yYePUmHdJ/lR0mtNfTXeWJdipj4Ors5uRE=@vger.kernel.org X-Gm-Message-State: AOJu0YznMTyvVEHUi58C7a9pEyPD42wTOp8PlZx1NIqwQmrALMFG0xAQ mP3TQHPowOzml0jhMlig1O/1idDII8neNd8b4g7K+niCpFtloEm1YYjtns+QgrEVhqPUH4f0G20 jclG6 X-Gm-Gg: AY/fxX5Tgf/HzpJC1lbaLZYR8I1fxrEIb8yc9Ouhlw6JA1PPrePC4hMVMABYvu4Q34/ Q/dyBFps7DMjIaD15p9IwwdqZkM0JZh2P+P4mlOsDDYmVVN+jurZItAogoxtGtwQOguBnFWJtqH GzdPfCXsVx19aMQS81C7Z+QsZUN2nq8HYMR/iVBhfFVoCl0gzu7FmNXYKfZipeE+cBuDa3EJFOW LvFX3MoIdgqRV7vIVa7XRHKuLdaF1sMfwGfskMXkmvvfeOJmlSojeB6iQ1QIGWaQSFj9PkgekY2 qdD7VJiIfV62e5wHghQwhKO6GoN4F4fZdGMWAoKMK1i5xXCJWQTLjX9SF+XyH5P0AEuNuNHKEo4 gCByfJxQJm7FY198LQMsEGQ1jHv1yBUhVaja1eYn6XydoUmbxav7nT6uKKfkwx0s3bx8m6WB0mg N8ALog/X2Q7NJMDJm8uazo76TN X-Google-Smtp-Source: AGHT+IEmBnCEvZ4KcsGUP2OBZ3PJxb3lPfUs8yKwN7nmXuTr/Mr71NH3RlybylhUYq9H/FqrLtaMBQ== X-Received: by 2002:a05:6a00:808c:b0:7e8:450c:61a1 with SMTP id d2e1a72fcca58-7ff66a6d896mr12891880b3a.56.1766468909846; Mon, 22 Dec 2025 21:48:29 -0800 (PST) Received: from localhost.localdomain ([103.158.43.19]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7ff7dfac28fsm12287026b3a.32.2025.12.22.21.48.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 21:48:29 -0800 (PST) From: Abdun Nihaal To: mchehab@kernel.org Cc: Abdun Nihaal , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] media: i2c/tw9903: Fix potential memory leak in tw9903_probe() Date: Tue, 23 Dec 2025 11:18:13 +0530 Message-ID: <20251223054816.68912-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In one of the error paths in tw9903_probe(), the memory allocated in v4l2_ctrl_handler_init() and v4l2_ctrl_new_std() is not freed. Fix that by calling v4l2_ctrl_handler_free() on the handler in that error path. Cc: stable@vger.kernel.org Fixes: 0890ec19c65d ("[media] tw9903: add new tw9903 video decoder") Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/media/i2c/tw9903.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/tw9903.c b/drivers/media/i2c/tw9903.c index b996a05e56f2..c3eafd5d5dc8 100644 --- a/drivers/media/i2c/tw9903.c +++ b/drivers/media/i2c/tw9903.c @@ -228,6 +228,7 @@ static int tw9903_probe(struct i2c_client *client) =20 if (write_regs(sd, initial_registers) < 0) { v4l2_err(client, "error initializing TW9903\n"); + v4l2_ctrl_handler_free(hdl); return -EINVAL; } =20 --=20 2.43.0