From nobody Sat Feb 7 17:20:52 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D798AF507 for ; Tue, 23 Dec 2025 00:10:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766448620; cv=none; b=ahcQW5PDUsQ/iNKCnYIzZhnpZkp1tclc/HAoBnM1OXMMu+u9XChG9u1PGBNw9sReRpRqj39+kxHQ/S6UJ5cicnLIObblfSzjbYruYQ4VUQd8ewPaqC5dU/r9NyAgkXUv/wc6OpqtedIM0ozHMC70CnLVNLIC96JPVqpBbMNwqqU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766448620; c=relaxed/simple; bh=OoME8HiCOB2QSAwB6oNTCZhOVoVCLIefUmn/xAE5kFQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D3hvXQvycn+7f03kBOl0M7kndRkygK8TZk2lKfc0JLOVJ/5dqJJioduVcnw57sV9bicroPUnr/0RYFFaumYa53c7zBYeMakpOHe4agwGWvDnCsBU3dBuLGUatA9kPtfYcHrwogezc9kCxbCU0c/5ipSfCEPaMZG2XdKl9bZruh0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kNe8+ptv; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kNe8+ptv" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2a0b4320665so67930695ad.1 for ; Mon, 22 Dec 2025 16:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766448618; x=1767053418; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6rg7xoTVJaIOPNc99KtvennzHNvfp2dvdfE5QIWA/J8=; b=kNe8+ptvbfEMKvQBP7xvIpS6AYDOlX172CjTebZBBAISK9CSKtoguPNnqgTb1VdMCC XGn4TAWCs7XXzeglGGQPrQnzqePdLrOrZgBSt5bvwSUp/r8cN74FtX8vwDANLVXe92FU 2i8vQjIn2mf2gSS7Uyu1BPdglRD+4GdWoRCeH8l55kWa798mds1ZdB5MM1csvxvKLcYW Oc6tel+jp83S112yCwj4n4cJybwwEnGt2TM6fttIXAD8Mq7ickZEorD1Tw5caND211lO 8FQoIIqalcTQAhjzPwFuagSTfhVqLzfcqgXLbQR5QmxBbCeH2zqvWekSVjq/xo/RDJFg HsGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766448618; x=1767053418; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6rg7xoTVJaIOPNc99KtvennzHNvfp2dvdfE5QIWA/J8=; b=YGWFAxlb1EC8PH6jj6UQbg/8jWPd0nt6fQgfSRb341A96bAkDhUytnN6YQ1Kn0WUk1 FPYblJZd39qqKbsTVYqpySvHPBmb1BqerCzBQKzDWIsGmjGoBGOxEzT6jAI03BQFHhzu UdD+rEn/yerpwsjWzAEp3Zwxg8Uq1RCMeL4aVuo2cGKBGtNfcgEHre2dqhs0S9C2bmFz TFJk9xPwV8Kw3iVgztaEPWFFfzieuFNm+/2Lsdu5V2jk+lGM11hvOdcNzuGHvStpq6LP ZAlpw5Xbzh9kyxqhbkf0v9t19Dh15F0EtAvYrLvWn1TEI6bGqOueJYQHL0o6C+QRNeYX fLsg== X-Forwarded-Encrypted: i=1; AJvYcCXuUNyToC/Oyi/R3pJo0ZQ3jorjc9+Tdt/i+0/2N1P/fjoVwWq+HCC3Pje49bt0sOZtTwUroOtzS4SvBXU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn1+L/lw4lXLXmPhepfldWYIoCVL9BdBr3MsH1WUjssXZm/Wv4 p4brC4dcBt3rtwh+nDEMRaw3qfYXz10HWFm5pzXJ+pXW82SqNCJKk5pw X-Gm-Gg: AY/fxX7bVMjoqZUeWqUcIAaNAFNA1AQdTorXt4KqrNavjCQXEUiSb+kRUO9wJTqiltF 4jbzs8GdG/uDjGAj7ONOQttrouteqq2ruc9RJ8T46Nqvda8b0JXBDrxDVw17gw8bIYmhLcZCBJB PdLtjjVvwPdlgUzpu6+a5emEi1wu2JKDN6sGxt0IxjzbpYIG7kNGavykQbXmdiNzFP2nI7QI7QR 580426Uq8TSJt8WJIpAjiJpztgv1P12PimabCpxaS7/pCXa1A4OsndjXB+85Ed0gtN0gazACvdb sQOuqt6+alrdkkZekpE0cQsxEn6N+FoO+ZUBwTkomZ2xPD57Q1GqMLkI+cjogE9abVohNAG11wr GVp2HC2KrzWgpBC5HbfV4yUiswQ6jdF4g/ueRn4UGR1nvn9RWubJIVsaUifSt23ioVb/tb0I2cK m9W8no36tysoK07z8/Wg8= X-Google-Smtp-Source: AGHT+IEKGii1/n0GFocrwp24FZsJSynKEYdhUfonNSCQoPQjwvdqwur2opQDFyHVcrg6Wugb5nuaZw== X-Received: by 2002:a17:902:fc4f:b0:2a0:d59e:ff67 with SMTP id d9443c01a7336-2a2f2a355e3mr138303165ad.38.1766448617900; Mon, 22 Dec 2025 16:10:17 -0800 (PST) Received: from mythos-cloud ([61.82.116.93]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34eacbca905sm3884167a91.5.2025.12.22.16.10.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 16:10:17 -0800 (PST) From: Yeounsu Moon To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yeounsu Moon Subject: [PATCH net] net: dlink: mask rx_coalesce/rx_timeout before writing RxDMAIntCtrl Date: Tue, 23 Dec 2025 09:10:06 +0900 Message-ID: <20251223001006.17285-1-yyyynoom@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" RxDMAIntCtrl encodes rx_coalesce in the low 16 bits and rx_timeout in the high 16 bits. If either value exceeds the field width, the current code may truncate the value and/or corrupt adjacent bits when programming the register. Mask both values to 16 bits and cast to u32 before shifting so only the intended fields are written. Found by inspection. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Tested-on: D-Link DGE-550T Rev-A3 Signed-off-by: Yeounsu Moon --- drivers/net/ethernet/dlink/dl2k.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethernet/dlink= /dl2k.c index 846d58c769ea..f6ec0e4689f7 100644 --- a/drivers/net/ethernet/dlink/dl2k.c +++ b/drivers/net/ethernet/dlink/dl2k.c @@ -590,7 +590,8 @@ static void rio_hw_init(struct net_device *dev) =20 set_multicast (dev); if (np->coalesce) { - dw32(RxDMAIntCtrl, np->rx_coalesce | np->rx_timeout << 16); + dw32(RxDMAIntCtrl, ((u32)np->rx_coalesce & 0x0000ffff) | + (((u32)np->rx_timeout & 0x0000ffff) << 16)); } /* Set RIO to poll every N*320nsec. */ dw8(RxDMAPollPeriod, 0x20); --=20 2.52.0