From nobody Tue Feb 10 11:32:52 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB8AA33FE34 for ; Tue, 23 Dec 2025 18:03:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766513004; cv=pass; b=PlU+f6AA4j0444U0hEoNW6RjwbamOCBGzKF1wFC5RIumh3xwfPPxA1CoEKChIap9c9T2perpbkdug5XDyD7LzFDFesNBXSOLTmRFgQF52lSfiIpYUYy8liWOnbwQF/V7WU/uaS6zHp5StpT/6rND3tyoq6U0BCxQxEtTMPsMtKA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766513004; c=relaxed/simple; bh=b7LagNqBbXanSEDwQt0S2XmlslHFAyjpTH6VRnZzlV4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=deKJhOg0kh7afl7SwRO0n2D4jCcLZ2VjWdCapKsAurgPCqwYyDy/zbKxXDLvn2xki3lGfBI/nVveIHDdb8qvIwME43bCYF8QC1gc8Mm4JDv72Dy5K4SVucxAKTRIula3LOknqXC7pOC96UriMIpxEDo4Q3Ift74JcSWTKMA/Jgs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=ariel.dalessandro@collabora.com header.b=K1S+pPTI; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=ariel.dalessandro@collabora.com header.b="K1S+pPTI" ARC-Seal: i=1; a=rsa-sha256; t=1766512974; cv=none; d=zohomail.com; s=zohoarc; b=j65QkHGkCi1yf1rp0cJBQyT9hS83xTAkAimDBp1QSS/x6guhzqQ+T4Qsbb3Ydgf87AVVHnUUxajKyA3Kp1nMOCL6CitPrFvEaTickHhDzZM1HmsaijWZgrL7KQOJV2Z8xl64zq6kDd4kbiCzrVxG3HrtreK1JweaavhQK1PgD1Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766512974; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=yjFBKvqKqJM0baDbHeDEe97KrUvnWCeBaCOr3ku/1w0=; b=fsHE46Xfe9adAO8wINX2MtxQLI9dUzOBF4B507e5ElNxx0fKaKkwnmN0WMQshonpI0SK9m8oroC6iIqjWSXx72e4+zHOQRnVZoNqJOViM+Zwqxn+px9QQt2bsmglgJta2xamIeRGeCOzRE1sOB8hYEYYd08ZuG7Xtd5xHkL35MU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=ariel.dalessandro@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1766512974; s=zohomail; d=collabora.com; i=ariel.dalessandro@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=yjFBKvqKqJM0baDbHeDEe97KrUvnWCeBaCOr3ku/1w0=; b=K1S+pPTIctrLP5I7DGOX81hwKzRdzoI6Un1VsoAFB8M1t/RxCO3L/lWbqECRPNsg poKM7NAiviNWUJMnpTdIjPhtSPaUxNCoy+ruoNaukaxGgw0nM66A6jOs4agQvK1SUX9 P6gjNhgDxnAc90jr0lMtgWJEwWEkO4HBL3X3Rzv4= Received: by mx.zohomail.com with SMTPS id 1766512972595326.53151661966547; Tue, 23 Dec 2025 10:02:52 -0800 (PST) From: Ariel D'Alessandro Date: Tue, 23 Dec 2025 15:01:30 -0300 Subject: [PATCH v3 10/21] drm/colorop: Introduce colorop helpers for crtc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251223-mtk-post-blend-color-pipeline-v3-10-7d969f9a37a0@collabora.com> References: <20251223-mtk-post-blend-color-pipeline-v3-0-7d969f9a37a0@collabora.com> In-Reply-To: <20251223-mtk-post-blend-color-pipeline-v3-0-7d969f9a37a0@collabora.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Louis Chauvet , Haneen Mohammed , Melissa Wen Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= , Ariel D'Alessandro , Harry Wentland X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766512902; l=5692; i=ariel.dalessandro@collabora.com; s=20251223; h=from:subject:message-id; bh=v0EzVWC7HEgCjd42dLnml/cxbQFKAH2Q9oqX72sE3fA=; b=kWReBGXutszJ7qMtObxq1/TFBTxud2uZa8rd5ksSCLzA9UbuQs2UQvbLg8S1VWV6ky6VvK/tI P+kPxlBuHMgB6iWgALXCYyLYOxH30Lk6g/eQkDSb2IskJWDT2YCCjFQ X-Developer-Key: i=ariel.dalessandro@collabora.com; a=ed25519; pk=QZRL9EsSBV3/FhDHi9L/7ZTz2dwa7iyqgl+y1UYaQXQ= X-ZohoMailClient: External From: "N=C3=ADcolas F. R. A. Prado" Introduce colorop helper counterparts for post-blend color pipelines that take a CRTC instead of a plane. Signed-off-by: N=C3=ADcolas F. R. A. Prado Co-developed-by: Ariel D'Alessandro Signed-off-by: Ariel D'Alessandro Reviewed-by: Louis Chauvet Reviewed-by: Harry Wentland --- drivers/gpu/drm/drm_colorop.c | 73 +++++++++++++++++++++++++++++++++++++++= ++++ include/drm/drm_colorop.h | 8 +++++ 2 files changed, 81 insertions(+) diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c index 6a285cdb0a354..4ce93807ea565 100644 --- a/drivers/gpu/drm/drm_colorop.c +++ b/drivers/gpu/drm/drm_colorop.c @@ -170,6 +170,20 @@ static int drm_plane_colorop_init(struct drm_device *d= ev, return ret; } =20 +static int drm_crtc_colorop_init(struct drm_device *dev, + struct drm_colorop *colorop, + struct drm_crtc *crtc, + enum drm_colorop_type type, uint32_t flags) +{ + int ret; + + ret =3D drm_common_colorop_init(dev, colorop, type, flags); + + colorop->crtc =3D crtc; + + return ret; +} + /** * drm_colorop_cleanup - Cleanup a drm_colorop object in color_pipeline * @@ -295,6 +309,23 @@ int drm_plane_colorop_curve_1d_init(struct drm_device = *dev, struct drm_colorop * } EXPORT_SYMBOL(drm_plane_colorop_curve_1d_init); =20 +int drm_crtc_colorop_curve_1d_init(struct drm_device *dev, struct drm_colo= rop *colorop, + struct drm_crtc *crtc, u64 supported_tfs, uint32_t flags) +{ + int ret; + + ret =3D drm_colorop_has_supported_tf(dev, &crtc->base, crtc->name, suppor= ted_tfs); + if (ret) + return ret; + + ret =3D drm_crtc_colorop_init(dev, colorop, crtc, DRM_COLOROP_1D_CURVE, f= lags); + if (ret) + return ret; + + return drm_common_colorop_curve_1d_init(dev, colorop, supported_tfs, flag= s); +} +EXPORT_SYMBOL(drm_crtc_colorop_curve_1d_init); + static int drm_colorop_create_data_prop(struct drm_device *dev, struct drm= _colorop *colorop) { struct drm_property *prop; @@ -383,6 +414,35 @@ drm_plane_colorop_curve_1d_lut_init(struct drm_device = *dev, struct drm_colorop * } EXPORT_SYMBOL(drm_plane_colorop_curve_1d_lut_init); =20 +/** + * drm_crtc_colorop_curve_1d_lut_init - Initialize a DRM_COLOROP_1D_LUT + * + * @dev: DRM device + * @colorop: The drm_colorop object to initialize + * @crtc: The associated drm_crtc + * @lut_size: LUT size supported by driver + * @interpolation: 1D LUT interpolation type + * @flags: bitmask of misc, see DRM_COLOROP_FLAG_* defines. + * @return zero on success, -E value on failure + */ +int +drm_crtc_colorop_curve_1d_lut_init(struct drm_device *dev, + struct drm_colorop *colorop, + struct drm_crtc *crtc, uint32_t lut_size, + enum drm_colorop_lut1d_interpolation_type interpolation, + uint32_t flags) +{ + int ret; + + ret =3D drm_crtc_colorop_init(dev, colorop, crtc, DRM_COLOROP_1D_LUT, fla= gs); + if (ret) + return ret; + + return drm_common_colorop_curve_1d_lut_init(dev, colorop, lut_size, + interpolation, flags); +} +EXPORT_SYMBOL(drm_crtc_colorop_curve_1d_lut_init); + static int drm_common_colorop_ctm_3x4_init(struct drm_device *dev, struct = drm_colorop *colorop, uint32_t flags) { @@ -410,6 +470,19 @@ int drm_plane_colorop_ctm_3x4_init(struct drm_device *= dev, struct drm_colorop *c } EXPORT_SYMBOL(drm_plane_colorop_ctm_3x4_init); =20 +int drm_crtc_colorop_ctm_3x4_init(struct drm_device *dev, struct drm_color= op *colorop, + struct drm_crtc *crtc, uint32_t flags) +{ + int ret; + + ret =3D drm_crtc_colorop_init(dev, colorop, crtc, DRM_COLOROP_CTM_3X4, fl= ags); + if (ret) + return ret; + + return drm_common_colorop_ctm_3x4_init(dev, colorop, flags); +} +EXPORT_SYMBOL(drm_crtc_colorop_ctm_3x4_init); + /** * drm_plane_colorop_mult_init - Initialize a DRM_COLOROP_MULTIPLIER * diff --git a/include/drm/drm_colorop.h b/include/drm/drm_colorop.h index 49d342b7f8b0b..a1f81fa96f66b 100644 --- a/include/drm/drm_colorop.h +++ b/include/drm/drm_colorop.h @@ -400,14 +400,22 @@ static inline struct drm_colorop *drm_colorop_find(st= ruct drm_device *dev, void drm_colorop_pipeline_destroy(struct drm_device *dev); void drm_colorop_cleanup(struct drm_colorop *colorop); =20 +int drm_crtc_colorop_curve_1d_lut_init(struct drm_device *dev, struct drm_= colorop *colorop, + struct drm_crtc *crtc, uint32_t lut_size, + enum drm_colorop_lut1d_interpolation_type interpolation, + uint32_t flags); int drm_plane_colorop_curve_1d_init(struct drm_device *dev, struct drm_col= orop *colorop, struct drm_plane *plane, u64 supported_tfs, uint32_t flags); +int drm_crtc_colorop_curve_1d_init(struct drm_device *dev, struct drm_colo= rop *colorop, + struct drm_crtc *crtc, u64 supported_tfs, uint32_t flags); int drm_plane_colorop_curve_1d_lut_init(struct drm_device *dev, struct drm= _colorop *colorop, struct drm_plane *plane, uint32_t lut_size, enum drm_colorop_lut1d_interpolation_type interpolation, uint32_t flags); int drm_plane_colorop_ctm_3x4_init(struct drm_device *dev, struct drm_colo= rop *colorop, struct drm_plane *plane, uint32_t flags); +int drm_crtc_colorop_ctm_3x4_init(struct drm_device *dev, struct drm_color= op *colorop, + struct drm_crtc *crtc, uint32_t flags); int drm_plane_colorop_mult_init(struct drm_device *dev, struct drm_colorop= *colorop, struct drm_plane *plane, uint32_t flags); int drm_plane_colorop_3dlut_init(struct drm_device *dev, struct drm_coloro= p *colorop, --=20 2.51.0