From nobody Tue Feb 10 02:44:03 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 481E73469F7 for ; Tue, 23 Dec 2025 17:00:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766509255; cv=none; b=awP/uQBMR/yt77jS/gnMT4X1U9YxuItaddDqQKA4QCoNh3GKTFHQPZVMBbGgZazUQLZjRzZKl54t2ELtDlq1wW/z86ZYva28aWnkaFx+UzEOa3w7+gabL28jY244O/aNKcfWwsfdkEE4cgOuRodNrKSQUFXL0eWikPV6yansA6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766509255; c=relaxed/simple; bh=FFeSBw1FMWIEtAaxrXlCm7QCuERTPjJL7GMbZA4DOXE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EjadZfqNu3Iz8qn73NmIda/YX9kKY4wbq/mQPlnqWlQHtgJ/3yLaPaHT+CLoX6Sn9glXMPWRaKz5oSR4uLd3U3WRKVHURfFUBYCZ3TudZgUkPfsKY5cG2a1ufV/UnVTk9tgRZkue6fpgSleHimj5H/vwsAYf1FkfbwTp+Cun+bI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=P9XFvVQC; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="P9XFvVQC" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42fb5810d39so2612205f8f.2 for ; Tue, 23 Dec 2025 09:00:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766509251; x=1767114051; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lZbTgcsl8S8+ff6/2oxkJI2TdhWxaQ+JXfess3SxhOo=; b=P9XFvVQCWhyHQa+MAfWIglYXc92IMA1nfKZrraQ7WVf6oKmV/fKDLmPSiTiwPOj1AI fp+h76SgtDFwhtaL0vbGsVESCO/c/zjI8TZAdHHm2JxdXjcW3N6OPvAZIwbiSDHm1UPi RjUdo6+q78N299zGbxAslOdEGnjFdSEW4qiuYiH21QRH/NSi9vNviVIffOvw4jlUJ06U KwqGgnxzyF+2P6LzImRUcUCMsfDFZACKu1R3981CaHs5fq/Ui/adVNCJ+YzXAa5ApQWG yHU2MhdqEyj8VztgO7bmr0Pr8hgCsn4BRJ1N7+8XpTmYnXOht0ggbQsZRa22VGyYJUxY qIYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766509251; x=1767114051; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lZbTgcsl8S8+ff6/2oxkJI2TdhWxaQ+JXfess3SxhOo=; b=A/7jkFFDZF3UnF/O6zurzOKk302iqmUDbRuz2VpL92t7uMq0SJAdikm/mjDbv+OxqR UjaWAIXyeAlHeoGRyZCcwNmS3dRFtCX4UYp70dXDRSdLl1stAzU1JPawEuliaVl1TjWq IZJ7wLqCY5avLiuDY2HtTCqJ09P3mcDYNorBxn9TOQZ+6InY2NXNcUGt4GH2F8javaz/ K6Dsq+cSG16AziJilmuBrankP8f+hQbzfAyxIlczDR6i24z0TaNCcoYIroinzFdj85rq T1G5dVn49+VHP9hKEXyd36mhDJVtqyGvieuQ/vnW31xKWiBFsNjwgjxXjtprdCFR0GP8 WFZw== X-Forwarded-Encrypted: i=1; AJvYcCVWQmPjXnoEIo5NmVs5Z6mn0F0LZOziR+q04KOI0DvQqPtlX+pEBnMNxquE6ObGm/csjIuK7rbpGjGZVbo=@vger.kernel.org X-Gm-Message-State: AOJu0YyMOhx1HsQnafWxjKD/x1hKy2eF5MQ6A2HInz6o90T8jqbbzzm3 Fw5GsDPoTTsvCmTI+zxafIXvf5p8gleV3xL6p5clzj1yzsFFa+FY2b5RzMrpUsZ7zRk= X-Gm-Gg: AY/fxX4ONZ/K5gTEsI1ISFG5Ks4KOu9moUgqrLLInS497xWYrIguafqtOncVTKUrL/H KkqxcWNJO3GtJCmxNk6kSJlKifj/saA5n+n1WyBPEAfA5oXzXUgw1K7mIB6eGdiHuZ9qOf3mok8 ESj4UuGHQzQF22Xvqcac1GuVUX/N1Puo7/+lX+/46gNIRolSIBDohGtGXYeE4L2y0qfUVLnukGN Ov7wNtNNNINFo1TwcPjfQfkspAfkYVpSseoZhVdXOQKww7AAul/qxh09gNYNgXyImIhFWMPwIHO 7Jy2NVNPZP/fhUwgLbTHPBQ0QWtcsIa3DhwsKiV6b6zO8fTGeia1zUXlQI3h/mI/hvV3A8l1L0H Q0d6GaxqqvvuaRnekXSNCRj56Si8srXuBYeY0cxk37ZOgxNv4mA9428NMX90R3+4mFRMo2yQeX5 kZDpPt21tGO6m33ryegEoC X-Google-Smtp-Source: AGHT+IHw266VIWmJq0XwT5qBef2T7bpj04WK99XObIIN7F2sHc70CND9LIepKuuHduut7Wrf49Jg3A== X-Received: by 2002:a05:6000:2907:b0:429:b751:7935 with SMTP id ffacd0b85a97d-4324e704a80mr17902125f8f.56.1766509251502; Tue, 23 Dec 2025 09:00:51 -0800 (PST) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1aef7sm28895137f8f.7.2025.12.23.09.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 09:00:51 -0800 (PST) From: James Clark Date: Tue, 23 Dec 2025 17:00:27 +0000 Subject: [PATCH 4/5] perf build: Feature test for libbfd thread safety API Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251223-james-libbfd-feat-check-v1-4-0e901ba32ed9@linaro.org> References: <20251223-james-libbfd-feat-check-v1-0-0e901ba32ed9@linaro.org> In-Reply-To: <20251223-james-libbfd-feat-check-v1-0-0e901ba32ed9@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Leo Yan , Justin Stitt Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Clark X-Mailer: b4 0.14.0 The non-distro build requires libbfd 2.42 since commit b72b8132d8fd ("perf libbfd: Ensure libbfd is initialized prior to use"). Add a feature test so that it's obvious why the build fails if this criteria isn't met. Signed-off-by: James Clark --- tools/build/Makefile.feature | 1 + tools/build/feature/Makefile | 4 ++++ tools/build/feature/test-libbfd-threadsafe.c | 18 ++++++++++++++++++ tools/perf/Makefile.config | 5 +++++ 4 files changed, 28 insertions(+) diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature index 20422853d1ac..d94548fff489 100644 --- a/tools/build/Makefile.feature +++ b/tools/build/Makefile.feature @@ -71,6 +71,7 @@ FEATURE_TESTS_BASIC :=3D \ gettid \ glibc \ libbfd \ + libbfd-threadsafe \ libelf \ libelf-getphdrnum \ libelf-gelf_getnote \ diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile index 63a97cdf78a3..731b19b84f4f 100644 --- a/tools/build/feature/Makefile +++ b/tools/build/feature/Makefile @@ -13,6 +13,7 @@ FILES=3D \ test-gtk2-infobar.bin \ test-hello.bin \ test-libbfd.bin \ + test-libbfd-threadsafe.bin \ test-disassembler-four-args.bin \ test-disassembler-init-styled.bin \ test-reallocarray.bin \ @@ -266,6 +267,9 @@ $(OUTPUT)test-libpython.bin: $(OUTPUT)test-libbfd.bin: $(BUILD_BFD) =20 +$(OUTPUT)test-libbfd-threadsafe.bin: + $(BUILD_BFD) || $(BUILD_BFD) -liberty || $(BUILD_BFD) -liberty -lz + $(OUTPUT)test-disassembler-four-args.bin: $(BUILD_BFD) -lopcodes || $(BUILD_BFD) -lopcodes -liberty || \ $(BUILD_BFD) -lopcodes -liberty -lz diff --git a/tools/build/feature/test-libbfd-threadsafe.c b/tools/build/fea= ture/test-libbfd-threadsafe.c new file mode 100644 index 000000000000..fe97f95f6f06 --- /dev/null +++ b/tools/build/feature/test-libbfd-threadsafe.c @@ -0,0 +1,18 @@ +// SPDX-License-Identifier: GPL-2.0 +#include + +static bool lock(void *unused) +{ + return true; +} + +static bool unlock(void *unused) +{ + return true; +} + +int main(void) +{ + /* Check for presence of new thread safety API (version 2.42) */ + return !bfd_thread_init(lock, unlock, NULL); +} diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index 5ff98b89c39a..1e35fbb5215d 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -927,9 +927,14 @@ ifdef BUILD_NONDISTRO $(call feature_check,libbfd) $(call feature_check,disassembler-four-args) $(call feature_check,disassembler-init-styled) + $(call feature_check,libbfd-threadsafe) $(call feature_check,libbfd-liberty) $(call feature_check,libbfd-liberty-z) =20 + ifneq ($(feature-libbfd-threadsafe), 1) + $(error binutils 2.42 or later is required for non-distro builds) + endif + # we may be on a system that requires -liberty and (maybe) -lz # to link against -lbfd; test each case individually here ifeq ($(feature-libbfd), 1) --=20 2.34.1