From nobody Mon Feb 9 19:37:44 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 573D9345758 for ; Tue, 23 Dec 2025 17:00:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766509253; cv=none; b=q2dDwr9/UcCk7bluZf1Z1ArHYFkG5YImgl7WBXwoNCMXwk55eot4bOqINVsa0AAtr1CAY5XQZCzWhuyAkkai0zUtQf6ayVfAKjAWHdiv3W8d+OQUR28guK0btMRBn1RvfvlwBGRV3GHW665euBDk/LbHvCcUTuffiE/y4yBXEJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766509253; c=relaxed/simple; bh=pUYrmgn7uq9Mo0NK2QK9zsQpEV/O2MlR+EPzwebQhY8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q7jvbxrYZhdFsn0Ih4Mv35m0+UDkZT9QbUnJagKR2MSS+QOw/+Zcr3yfYqbS6KRDbQEXqj8oHE0GL0kdkBltbn2gTF0nxZBPVzK3RrJXTJ+2kKgTTw/jf2Kps5ppnpQ6quGBzXl+JapSGfx4uf9NhCuvDNZ/tP4MVfP9lDjxFNw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GqQsQRIm; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GqQsQRIm" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-47d1d8a49f5so23921155e9.3 for ; Tue, 23 Dec 2025 09:00:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766509249; x=1767114049; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jY15ct2AtdcJrqbdqFR5HlO/a9tT55YDM1xtJfQUjyU=; b=GqQsQRImFltZ+cGurCFIOC8j+srxTT9D+RyQOv+BmuRy6bttNubYJs7Tt6r15u9AJD ByrWvBfeJOoxmaPKmqZsMNbesAhAmlUF5sPxFHGkteEFdamqSrWr7kg5nzuAvx2V0xOQ fNF4c62HyiJCVaySrRyOsCWS4XZAIzNhL3Fmf8jo0RHkZ/7ZKhkK9GdbjNN/Zr3OrODu /5ev42A63tWT2KkQkoTjhiWlm8ZQZRc5FjkzgYV106lwzgxVLbpMb9ZK4ChRW1QT5Yu1 l+kh62t7tY9QFM/no+ZoxzxaRmXpcYbrWNHVNglWxvjvTNw1oztLBKoFf6YQW5xOn35O 00Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766509249; x=1767114049; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jY15ct2AtdcJrqbdqFR5HlO/a9tT55YDM1xtJfQUjyU=; b=EZmHKMJpq+d2t8H0quxFh35wGyAguE6l7RpFyAtv9ljYwtdRzhcOKNUcVOVlxJ6CPB Fi0eIEB/3oTD+vvhMokWnL4uVUePUjeiHxno1FjfBi6twZGpOmzg9JV9qL648SDP0sFh E2noL4gfIjkwsryAojzZ0OCAOLe576pBoCybHTG9gtZesZVV7be0PX8ch3tFdlw8Z3Kp JnKgNdQEhzr2iXcMasqgXGtWNoD1DaqaoOFIe6urU87eCAVgEOnLBr/mYLALJkIKBcxw VpG/QBLgYb1qNHg3mOHOkA5otdGHEBvuGYhrv86/FaYAXVNkRhaSLi+GP9w5ygitDH+4 +A8Q== X-Forwarded-Encrypted: i=1; AJvYcCXuXEst4V7fAn7ZCtk0zYW9AcWAAcMkfg3ie1mtp97rnwd6/LuWpSpXN2v759ZDamoIJKrFKrhY2jCpWzM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxgdy6Ssx62CEz1Ke8kHc425pPhpt6cH4NSARUgl03vSlNU1Zzx E2F70E+uLaBkEvl1Z0aSFDi6QIIWnMA3XSjU+FYzRcQO+g1xgES7tPIZnxeRFJid+LU= X-Gm-Gg: AY/fxX6+tL4qvkhXSIPR39h0+ZN/3fgHpz/2+dhz33LN/bOK7nh1yZ1NL1wuBAW6MdH OCF4YlKeKFDLsrEUpcTK8DzNPb4o3qYQb3KtplX2J8YeRNioKXbrW2b+G7xN6GE9k6BVn7J3kiP 5vhQREcpAVTkdjq62QTs6/vKcTZLV7q0Smjy9VVlEy2QwAZAvx5kXTEvGeya1oRYzapEhbFvJdh I7oOPYWuThJ1zkGWRKBsbQIwKpYaq7+wYeWa9aw357mWTH8NQeocVQf3nhYYeMDpLMLd1fyXTfZ p/uSoYL75ISsaA8XMWYSVedp/Fj9xxjrrASJK3a66cdepbNoTNQEiKzbQ1Pw7bnKZ70avm4g3rj fZcSdmFeKLMcvBcKpjE+gDVUvISNnKuyhmhuCgtPLEaq0INSYajSWb32R7CHfRCO/4KaWrMSYLj IiOKekALEbsHOKmW8AzlV8 X-Google-Smtp-Source: AGHT+IE2RrxdNBawOcJgC1lywM/+u8T2O5P9U9OWWUIJAKyrwXRhaIEa/RxLHYXY0F/IIfkkW6BZWA== X-Received: by 2002:a05:600c:1d1d:b0:471:d2f:7987 with SMTP id 5b1f17b1804b1-47d1958f9c5mr146273855e9.26.1766509249044; Tue, 23 Dec 2025 09:00:49 -0800 (PST) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1aef7sm28895137f8f.7.2025.12.23.09.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 09:00:48 -0800 (PST) From: James Clark Date: Tue, 23 Dec 2025 17:00:25 +0000 Subject: [PATCH 2/5] perf build: Do all non-distro feature checks in one go Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251223-james-libbfd-feat-check-v1-2-0e901ba32ed9@linaro.org> References: <20251223-james-libbfd-feat-check-v1-0-0e901ba32ed9@linaro.org> In-Reply-To: <20251223-james-libbfd-feat-check-v1-0-0e901ba32ed9@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Leo Yan , Justin Stitt Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Clark X-Mailer: b4 0.14.0 None of the if statements or variable assignments in the non-distro block actually affect the feature checks. Just do them all in one place so the flow isn't obscured. Signed-off-by: James Clark --- tools/perf/Makefile.config | 32 ++++++++++++-------------------- 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index ea6636a09a95..594fe3ecfee0 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -923,36 +923,28 @@ ifneq ($(NO_JEVENTS),1) endif =20 ifdef BUILD_NONDISTRO + # call all detections now so we get correct status in VF output $(call feature_check,libbfd) + $(call feature_check,disassembler-four-args) + $(call feature_check,disassembler-init-styled) + $(call feature_check,libbfd-buildid) + $(call feature_check,libbfd-liberty) + $(call feature_check,libbfd-liberty-z) =20 + # we may be on a system that requires -liberty and (maybe) -lz + # to link against -lbfd; test each case individually here ifeq ($(feature-libbfd), 1) EXTLIBS +=3D -lbfd -lopcodes - else - # we are on a system that requires -liberty and (maybe) -lz - # to link against -lbfd; test each case individually here - - # call all detections now so we get correct - # status in VF output - $(call feature_check,libbfd-liberty) - $(call feature_check,libbfd-liberty-z) - - ifeq ($(feature-libbfd-liberty), 1) - EXTLIBS +=3D -lbfd -lopcodes -liberty - else - ifeq ($(feature-libbfd-liberty-z), 1) - EXTLIBS +=3D -lbfd -lopcodes -liberty -lz - endif - endif - $(call feature_check,disassembler-four-args) - $(call feature_check,disassembler-init-styled) + else ifeq ($(feature-libbfd-liberty), 1) + EXTLIBS +=3D -lbfd -lopcodes -liberty + else ifeq ($(feature-libbfd-liberty-z), 1) + EXTLIBS +=3D -lbfd -lopcodes -liberty -lz endif =20 CFLAGS +=3D -DHAVE_LIBBFD_SUPPORT CXXFLAGS +=3D -DHAVE_LIBBFD_SUPPORT $(call detected,CONFIG_LIBBFD) =20 - $(call feature_check,libbfd-buildid) - ifeq ($(feature-libbfd-buildid), 1) CFLAGS +=3D -DHAVE_LIBBFD_BUILDID_SUPPORT else --=20 2.34.1