From nobody Mon Feb 9 14:34:40 2026 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB46426CE2D for ; Mon, 22 Dec 2025 07:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766389818; cv=none; b=Xnd9GBw9lhaTNvALe+YD7qmTwQ8p34AK4+pT6S/7ydvokDilM6YqJIewfdWDlHRDKlYr2Vs3ho/vFMwHE/6Bjusth/NuBTT7sjRVGDSXHIwOawkSmfAE8WWszJ6PqbJOLMSL6BJusD6uQm3XlRqlpc76OTeRUornZiaTwhb/fxA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766389818; c=relaxed/simple; bh=FGaTm6J8pW+9i0l2xSEkIqU1XIexiaTAiReBQ+5rX/o=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=hlpZknZaHQKCSeD/ZHeT8pD2VylrICQJFZfacXu0YXSGauR3kr59nK7STpa25h1dGjiO46592KKiDM/PkdRjrXRHfrQSiTaU76xdsz7NoiyIfg7W68Di0h9otQPJiWxCdg9SREm0+JyITGm+jzVSel2Om4HQu9UVCN3XQzdXx8k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.209]) by APP-03 (Coremail) with SMTP id rQCowAAXMNcn+EhpfBmPAQ--.53390S2; Mon, 22 Dec 2025 15:49:59 +0800 (CST) From: Haoxiang Li To: ioana.ciornei@nxp.com Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Haoxiang Li , Dan Carpenter , Su Hui Subject: [PATCH] bus: fsl-mc: fix an error handling in fsl_mc_device_add() Date: Mon, 22 Dec 2025 15:49:58 +0800 Message-Id: <20251222074958.992911-1-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowAAXMNcn+EhpfBmPAQ--.53390S2 X-Coremail-Antispam: 1UD129KBjvdXoWrurykCrW8Aw4rCr45ZFyrJFb_yoWDAwbEyr 4Yvw47X3yDtrnrtw4ag3WSvrZ09w10gr4xXr43tFyfWrWYv398ZrZ5tr95Cw13uayIkr98 Aw17Jr1rJw1DWjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb48FF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6r1S6rWUM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_ Gr1l84ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr 1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v26r12 6r1DMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI 0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y 0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1l IxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUjuHq7UUUU U== X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiDAYEE2lIrR76BgAAsz Content-Type: text/plain; charset="utf-8" If device_add() fails, call put_device() to drop the device reference and do the cleanp. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/b767348e-d89c-416e-acea-1ebbff3bea20@st= anley.mountain/ Signed-off-by: Su Hui Signed-off-by: Haoxiang Li --- drivers/bus/fsl-mc/fsl-mc-bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bu= s.c index 25845c04e562..90a2107a9905 100644 --- a/drivers/bus/fsl-mc/fsl-mc-bus.c +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c @@ -896,7 +896,8 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc *obj_desc, dev_err(parent_dev, "device_add() failed for device %s: %d\n", dev_name(&mc_dev->dev), error); - goto error_cleanup_dev; + put_device(&mc_dev->dev) + return error; } =20 dev_dbg(parent_dev, "added %s\n", dev_name(&mc_dev->dev)); --=20 2.25.1