From nobody Tue Feb 10 00:24:14 2026 Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7D3B287245; Mon, 22 Dec 2025 03:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766373195; cv=none; b=SjXYhytSs5ab63es49BhWtFYPH50kuzDlm9E9ztj5llcBuB9FJOebq0kZfGX1IVkWjhPsnjcAn6dqsxgzw2aJ383DkkGe4WunknQ9mewwb+0yUckW/2quFSN9tx6xz8LrFm+KchkY1FofIUddH4zwxfxXGzcGUOgJxagDSECvRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766373195; c=relaxed/simple; bh=zi1QCOcLH8SdViYpLPnvX6eQfs6RrOmtImazwEm2dBc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=GC++saxDprzcvYVHNQCHc8RPFAHfyTHeo/hDbNmLptQM6fEwetcc4pWJBz47FHy8kbxyvjuKGj/jMJ7aqYPBQTjwFbVBUHvuXjAwPh9knFZPHPVIIuhekuOU79ExPaOjsJJSo4tr5JMmr4QPBzR/z/fc+A+8913aiUaK58O1iws= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.209]) by APP-05 (Coremail) with SMTP id zQCowABH3RAbt0hpYO9+AQ--.54336S2; Mon, 22 Dec 2025 11:12:27 +0800 (CST) From: Haoxiang Li To: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, akpm@linux-foundation.org, david@kernel.org, gregkh@linuxfoundation.org, ritesh.list@gmail.com, byungchul@sk.com, abarnas@google.com, kay.sievers@vrfy.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Haoxiang Li , stable@vger.kernel.org Subject: [PATCH] powerpc/pseries/cmm: fix the error handling in cmm_sysfs_register() Date: Mon, 22 Dec 2025 11:12:25 +0800 Message-Id: <20251222031225.968472-1-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowABH3RAbt0hpYO9+AQ--.54336S2 X-Coremail-Antispam: 1UD129KBjvdXoWrZrykuw1DZF4kXr4xJr4kCrg_yoWDZwb_Kw 109ayDuws3GrnakFZxAF1Uur1Syw1DtrW3tr1qqFs7t345XayDWw43ZrWYvr1xXF4xAr43 GF1DtwsxC34akjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb3xFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6r1S6rWUM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr 1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxa n2IY04v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4 AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE 17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMI IF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4l IxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvf C2KfnxnUUI43ZEXa7VUbGQ6JUUUUU== X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiBwsEE2lIrP0lygAAsE Content-Type: text/plain; charset="utf-8" If device_register() fails, put_device() should be called to drop the device reference. Thus add put_device() after subsys_unregister label and change device_unregister() to device_del() in fail label. Found by code review. Fixes: 6c9d29095264 ("power: cmm - convert sysdev_class to a regular subsys= tem") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li --- arch/powerpc/platforms/pseries/cmm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/pseries/cmm.c b/arch/powerpc/platforms/= pseries/cmm.c index 4cbbe2ee58ab..0666d3300bdb 100644 --- a/arch/powerpc/platforms/pseries/cmm.c +++ b/arch/powerpc/platforms/pseries/cmm.c @@ -419,8 +419,9 @@ static int cmm_sysfs_register(struct device *dev) fail: while (--i >=3D 0) device_remove_file(dev, cmm_attrs[i]); - device_unregister(dev); + device_del(dev); subsys_unregister: + put_device(dev); bus_unregister(&cmm_subsys); return rc; } --=20 2.25.1