From nobody Mon Feb 9 09:22:30 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A2A7326951 for ; Mon, 22 Dec 2025 10:12:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766398374; cv=none; b=ez3bQzKQsxeZTwkYD4fOii4ekRjPaQsJj5+cFQ/uwzI0nKWjuCHtkcLaMr1mX4UvAE81lsfFcy5mEZxuKKOONUQY1T6/4Aa33LFF80CrIOTV9qi+YH2wxfKpiH5XMa35/nKljwKGeCA1ECh/0t1uAZnCDev1q7LLf/Ix5oy/0ZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766398374; c=relaxed/simple; bh=yoSv2zmqsM08XpGUmJQS+2SLpyZ6XFDF5YGQcog13kY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TPxlkpb7pCHyqj31d4iF4GJrOUBArIAxU0tTTSjdsnd8UcdTZgTtMdnn4H7UCesLGCeERHPwIqwnmF6qSpCZZ1ABnEAVv6H3i1GxR+jiimaD4icLf8wwq0jQJOOW3zhew6QGFlAX3TZB1m8VK2fLdjFanI0A1VT7ThD2zrffyz8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=bsl812Fd; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="bsl812Fd" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 8CA3E1A2373; Mon, 22 Dec 2025 10:12:49 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 62C16606C1; Mon, 22 Dec 2025 10:12:49 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 6169C10AB01A2; Mon, 22 Dec 2025 11:12:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1766398368; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=J5RVBRf87Z75m13rh/8P2VEYGRdPDGtnY1g07bc3IJY=; b=bsl812FdCqEO+N+0WJtuN6pshbab9NIO37B5AcT34pIR5ccw6dx67sUxawso2fHS7g9YE3 F8R9CTWPyUvbfRT5zEGitaCHVlrn+6f/+JEXbvlcwacnEDvg++b96z/VYjN9p8e/08nNC6 1XZqddx21C7rwD2Wu4fHONEtB3WLr06zM/PkWxeqKH/+2brT6e+GQ+k/hcCIP8XEU0rOAn jMOs0dI89iVMufkY5l7XSJc+NbrP0M7sFN9dhGWZUR/SOKFoR1CXE3g3APQnUTrz+fSmNq Iypse/EuXXwtQFvB8MuHM7vsJsvalz1pLvDTplt9ldTuXSsGgiBlMDC5qrdDhQ== From: Louis Chauvet Date: Mon, 22 Dec 2025 11:11:33 +0100 Subject: [PATCH v3 31/33] drm/vkms: Extract common code for connector initialization Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251222-vkms-all-config-v3-31-ba42dc3fb9ff@bootlin.com> References: <20251222-vkms-all-config-v3-0-ba42dc3fb9ff@bootlin.com> In-Reply-To: <20251222-vkms-all-config-v3-0-ba42dc3fb9ff@bootlin.com> To: Haneen Mohammed , Simona Vetter , Melissa Wen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , jose.exposito89@gmail.com, Jonathan Corbet Cc: victoria@system76.com, sebastian.wick@redhat.com, victoria@system76.com, airlied@gmail.com, thomas.petazzoni@bootlin.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Louis Chauvet , Luca Ceresoli X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2829; i=louis.chauvet@bootlin.com; h=from:subject:message-id; bh=yoSv2zmqsM08XpGUmJQS+2SLpyZ6XFDF5YGQcog13kY=; b=owEBiQJ2/ZANAwAIASCtLsZbECziAcsmYgBpSRlEJCgtE5ARQGGmxPsWE4yqYjRrHcDbYsD3m 2RJNzKvn+GJAk8EAAEIADkWIQRPj7g/vng8MQxQWQQgrS7GWxAs4gUCaUkZRBsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMSwyLDIACgkQIK0uxlsQLOJnhg//bbmrzzKtS7SA6vQs1AyEkPLg3GEepj6 gSsOyymWjglj1v5udl/3z/bALIQASIcW6vH69RPGEEIzWlt482OZENL2GkcdbslE2jg1f9iES31 sOHe8PJyq2Rcrfe9s3a9IPPWUr2+4HWBzAjANtitFRF9thuUF5P7x61ZVtaTj6LDazMfWX46z51 GAZgVvKk1JCgeKJFeZyKLvVaAmIzp7FMvRAUL69sLWKPrnUc7GWx7JcpH18IL7CX+PDWiweuLff A0BRWWU0wgxVQv5s/SZ5PRPBvqT4KVIoOxZU6XBRdkKIPL5tryvmkBTdF8tUI8nVUYytmxDMfbW oz8wn8EnjiU7SiREn4mxFWyp7G4oiy2cpUl70zdWij/6OovZevC9Lqht7G2/NUZCUqzTfRZJfdx MgV1aSV50lqPoQEWyELJa+u+idKM8RCzzUDYMW8Ez+1u104XTS1X3lEd8Ke0SbrzMZMDVrQsflP hgsA7on7FyNbs7De6mE+1i0OHJaSL+VLtAbH5VmU1S8wG7ZDRCGVha+JTzxTfZ3b3I6vYr+hojj ZU3w2K+V9g6FjwT7YKgTQVR6TxzvdsjBMJCarDZRUmnul3zs8Yctim4xKPeq/l3K+1Ff6bpzMjm SL6Z29kGAaUPNiOy1+j4VStn5MExTC94kBgatHyVWHfza/nfgzeU= X-Developer-Key: i=louis.chauvet@bootlin.com; a=openpgp; fpr=8B7104AE9A272D6693F527F2EC1883F55E0B40A5 X-Last-TLS-Session-Version: TLSv1.3 With the introduction of dynamic connector, some code will be shared between dynamic and static connectors. Extract this part to avoid code duplication Reviewed-by: Luca Ceresoli Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_connector.c | 44 +++++++++++++++++++++++--------= ---- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_connector.c b/drivers/gpu/drm/vkms/v= kms_connector.c index 211f11c8473d..3ad614642355 100644 --- a/drivers/gpu/drm/vkms/vkms_connector.c +++ b/drivers/gpu/drm/vkms/vkms_connector.c @@ -110,22 +110,17 @@ static const struct drm_connector_helper_funcs vkms_c= onn_helper_funcs =3D { .best_encoder =3D vkms_conn_best_encoder, }; =20 -struct vkms_connector *vkms_connector_init_static(struct vkms_device *vkms= dev, - struct vkms_config_connector *connector_cfg) +/** + * vkms_connector_init() - Common initialization of vkms connector + * @vkmsdev: VKMS device containing the device + * @connector: VKMS connector to init. @connector->base must be + * already initialized by DRM core. + * @connector_cfg: Connector configuration to apply + */ +static void vkms_connector_init(struct vkms_device *vkmsdev, + struct vkms_connector *connector, + const struct vkms_config_connector *connector_cfg) { - struct drm_device *dev =3D &vkmsdev->drm; - struct vkms_connector *connector; - int ret; - - connector =3D drmm_kzalloc(dev, sizeof(*connector), GFP_KERNEL); - if (!connector) - return ERR_PTR(-ENOMEM); - - ret =3D drmm_connector_init(dev, &connector->base, &vkms_connector_funcs, - vkms_config_connector_get_type(connector_cfg), NULL); - if (ret) - return ERR_PTR(ret); - if (vkms_config_connector_get_supported_colorspaces(connector_cfg)) { if (connector_cfg->type =3D=3D DRM_MODE_CONNECTOR_HDMIA) { drm_mode_create_hdmi_colorspace_property(&connector->base, @@ -145,6 +140,25 @@ struct vkms_connector *vkms_connector_init_static(stru= ct vkms_device *vkmsdev, =20 if (vkms_config_connector_get_edid_enabled(connector_cfg)) drm_connector_attach_edid_property(&connector->base); +} + +struct vkms_connector *vkms_connector_init_static(struct vkms_device *vkms= dev, + struct vkms_config_connector *connector_cfg) +{ + struct drm_device *dev =3D &vkmsdev->drm; + struct vkms_connector *connector; + int ret; + + connector =3D drmm_kzalloc(dev, sizeof(*connector), GFP_KERNEL); + if (!connector) + return ERR_PTR(-ENOMEM); + + ret =3D drmm_connector_init(dev, &connector->base, &vkms_connector_funcs, + vkms_config_connector_get_type(connector_cfg), NULL); + if (ret) + return ERR_PTR(ret); + + vkms_connector_init(vkmsdev, connector, connector_cfg); =20 return connector; } --=20 2.51.2