From nobody Mon Feb 9 09:09:16 2026 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDB2A31771B for ; Mon, 22 Dec 2025 10:12:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766398324; cv=none; b=MK7W6orug0heVZ6JRbnfR1FrAeNvieUYNtetUktioiXslRjRwdj5GV/RmPXoW16y71hiEp+ARsglwVrgjJNQsSYikZ7yASDEOUPSqhi4Dx6GgVewaMG8GiB3PkcPrjswfzT36jWHwiwqut0TxbQErjHksHY/idqQctiQXXTTV2A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766398324; c=relaxed/simple; bh=GvzL7GhhrNe9khGOkjshp+QmQ+GxzH5YD39LavoAsgU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qREx/yF0/2+iDCYoSuGO95ZPb2eY/uTE5G4dXu4V826akfxBdBPAvdKuwHPey/fVKgmn2UiVw3TKBZkxzbc5B1bmd3E49XotjeZZjUfVgl8uQ1VEV8kxHAaq5DQErpfOTc3pbwfwl0Dy+NQNQ+cafdyknr1IxDKXgIFijYKnmlA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=I7uyW0f9; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="I7uyW0f9" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 69E7BC1AE07; Mon, 22 Dec 2025 10:11:35 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 65DA2606C1; Mon, 22 Dec 2025 10:12:00 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7067910AB019D; Mon, 22 Dec 2025 11:11:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1766398318; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=Z19aSMue5EyUWxQJrAm0oWhEPWe5muY+5GKKRbfkPYI=; b=I7uyW0f9JH7dW67DM9UM3Em+MSIgSDP3JYZJfdIIsUdBb/6jCJwnv1EclS8zPf9IKnZD15 Qn5rhefF0Bm2MYIlS++19cbHLBOi8cy+FAS4gGhyrxg8gDH1GDbQJOgzGNLfM+Nkena6EU ctnc8Is+W+494zttkco7f6/pZ0SJN+OLC1DFvA1nTZ6AV0Tho6zThzQvAvJCRstPq81VXj Pqh/t/do9AYxFNeOYSGx0yF0wynlHD1LqfW4IxIHNF3LEJ6dJVMokTqAb7Jv9kFsNEIEBB wvw8NQXdvzZs40lnX1DARNG5sZIHFALwzpPo7bW6UZasOu9rRS0QwWKpT/nobA== From: Louis Chauvet Date: Mon, 22 Dec 2025 11:11:18 +0100 Subject: [PATCH v3 16/33] drm/vkms: Introduce configfs for plane color range Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251222-vkms-all-config-v3-16-ba42dc3fb9ff@bootlin.com> References: <20251222-vkms-all-config-v3-0-ba42dc3fb9ff@bootlin.com> In-Reply-To: <20251222-vkms-all-config-v3-0-ba42dc3fb9ff@bootlin.com> To: Haneen Mohammed , Simona Vetter , Melissa Wen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , jose.exposito89@gmail.com, Jonathan Corbet Cc: victoria@system76.com, sebastian.wick@redhat.com, victoria@system76.com, airlied@gmail.com, thomas.petazzoni@bootlin.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=7379; i=louis.chauvet@bootlin.com; h=from:subject:message-id; bh=GvzL7GhhrNe9khGOkjshp+QmQ+GxzH5YD39LavoAsgU=; b=owEBiQJ2/ZANAwAIASCtLsZbECziAcsmYgBpSRlBGbQRGEaRq8WOntxQttW+rN+XXuVj9Sd3w cycRFVRX0uJAk8EAAEIADkWIQRPj7g/vng8MQxQWQQgrS7GWxAs4gUCaUkZQRsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMSwyLDIACgkQIK0uxlsQLOIMfg/+M+HvH+zPiPzcuVqPoup/xfYi287XA4I OjEIgMdhObpEczDLRQvpkpO5M6WNwXA70ZOuiu0c7VOQJZTVeuSVwHg+hnbGbewssGt0TK9O7qF SOEMMvpSUwgG8K2CCD/0b1/JhW96NzwJMfa10gYi1kt8QaNa5D6j56SxYEi+t35HdKK9YPjFvMN 4AkqRDufUYEsJ/2B8qMKGT6zmAAMkqFEyT32pEX3BabsR1XV340XKjllQTe5o0PkCn/++de4iiF GNrT6BT/Z5dqLRProQ2Q3YKAtqVg/HgvvOwM5q481EGWWBU6B1ddxzE5adc8eugYWwPoaZ9YrCH hzH4u8SbDahZ597Cc5hyXFPvk+MRU/Nm8UPqUhz2dLM4ie2BB0zKnMjpb7x8g3luXnjx3KGDN2l XyBagH+CmVlPSvBodZBK6rP+pD8HSmxZuY+JnW3rPu8Asvv0j5uBY6fItFAAhAIGpU7vGeUgfaQ 9hiEbW6QeHruy6h6E4xl2kU/yJKNEe9HDXQxBgviT8YboWoRkBbE07JHMl/kztsK4Nh5izxRpT/ xmJCDnuBluAGKFG0nCOLSlze07RiH1X2wzEkBiiWau0yiti5MZ6FMUHZilrkz22JFEYtYAARHzC G/JFh/0SotbxFducu6lSotrvW8jycF1dnkzI83UnVsWcC2pZj5Iw= X-Developer-Key: i=louis.chauvet@bootlin.com; a=openpgp; fpr=8B7104AE9A272D6693F527F2EC1883F55E0B40A5 X-Last-TLS-Session-Version: TLSv1.3 To allows the userspace to test many hardware configuration, introduce a new interface to configure the available color ranges per planes. VKMS supports multiple color ranges, so the userspace can choose any combination. The supported color ranges are configured by writing a color range bitmask to the file `supported_color_ranges` and the default color range is chosen by writing a color encoding bitmask to `default_color_range`. Signed-off-by: Louis Chauvet --- Documentation/ABI/testing/configfs-vkms | 15 ++++++ Documentation/gpu/vkms.rst | 10 +++- drivers/gpu/drm/vkms/vkms_configfs.c | 93 +++++++++++++++++++++++++++++= ++++ 3 files changed, 116 insertions(+), 2 deletions(-) diff --git a/Documentation/ABI/testing/configfs-vkms b/Documentation/ABI/te= sting/configfs-vkms index 242aae91289c..2ace79ce848a 100644 --- a/Documentation/ABI/testing/configfs-vkms +++ b/Documentation/ABI/testing/configfs-vkms @@ -138,6 +138,21 @@ Description: Default color encoding presented to userspace, same values as supported_color_encoding. =20 +What: /sys/kernel/config/vkms//planes//supported_color_ran= ges +Date: Nov 2025 +Contact: dri-devel@lists.freedesktop.org +Description: + Available color ranges for the plane, as a bitmask: + 0x1 - DRM_COLOR_YCBCR_LIMITED_RANGE, + 0x2 - DRM_COLOR_YCBCR_FULL_RANGE. + +What: /sys/kernel/config/vkms//planes//default_color_range +Date: Nov 2025 +Contact: dri-devel@lists.freedesktop.org +Description: + Default color range presented to userspace, same + values as supported_color_ranges. + What: /sys/kernel/config/vkms//planes//possible_crtcs Date: Nov 2025 Contact: dri-devel@lists.freedesktop.org diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index 0d4dae3ba8e5..ab0eb2f97fc2 100644 --- a/Documentation/gpu/vkms.rst +++ b/Documentation/gpu/vkms.rst @@ -87,7 +87,7 @@ Start by creating one or more planes:: =20 sudo mkdir /config/vkms/my-vkms/planes/plane0 =20 -Planes have 6 configurable attributes: +Planes have 8 configurable attributes: =20 - type: Plane type: 0 overlay, 1 primary, 2 cursor (same values as those exposed by the "type" property of a plane) @@ -99,10 +99,16 @@ Planes have 6 configurable attributes: possible_rotations. - supported_color_encodings: Available encodings for a plane, as a bitmask: 0x01 YCBCR_BT601, 0x02 YCBCR_BT709, 0x04 YCBCR_BT2020 (same values as th= ose exposed - by the COLOR_ENCODING property of a plane). If set, supported_color_range + by the COLOR_ENCODING property of a plane). If set, supported_color_rang= es must be set too. - default_color_encoding: Default color encoding presented to the userspac= e, same values as supported_color_encodings +- supported_color_ranges: Available color range for a plane, as a bitmask: + 0x1 DRM_COLOR_YCBCR_LIMITED_RANGE, 0x2 DRM_COLOR_YCBCR_FULL_RANGE (same = values as + those exposed by the COLOR_RANGE property of a plane). If set, supported= _color_encoding + must be set too. +- default_color_range: Default color range presented to the userspace, same + values as supported_color_ranges =20 Continue by creating one or more CRTCs:: =20 diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/drivers/gpu/drm/vkms/vk= ms_configfs.c index 755978b17c95..7be6d10b2b68 100644 --- a/drivers/gpu/drm/vkms/vkms_configfs.c +++ b/drivers/gpu/drm/vkms/vkms_configfs.c @@ -17,6 +17,13 @@ BIT(DRM_COLOR_YCBCR_BT709) | \ BIT(DRM_COLOR_YCBCR_BT2020)) =20 +/** + * VKMS_SUPPORTED_COLOR_RANGES - Bitmask of all supported color ranges in = VKMS + */ +#define VKMS_SUPPORTED_COLOR_RANGES ( \ + BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) | \ + BIT(DRM_COLOR_YCBCR_FULL_RANGE)) + /* To avoid registering configfs more than once or unregistering on error = */ static bool is_configfs_registered; =20 @@ -454,6 +461,88 @@ static ssize_t plane_default_rotation_store(struct con= fig_item *item, return count; } =20 +static ssize_t plane_supported_color_ranges_show(struct config_item *item,= char *page) +{ + struct vkms_configfs_plane *plane =3D plane_item_to_vkms_configfs_plane(i= tem); + unsigned int supported_color_ranges; + + scoped_guard(mutex, &plane->dev->lock) + supported_color_ranges =3D vkms_config_plane_get_supported_color_ranges(= plane->config); + + return sprintf(page, "%u", supported_color_ranges); +} + +static ssize_t plane_supported_color_ranges_store(struct config_item *item, + const char *page, size_t count) +{ + struct vkms_configfs_plane *plane =3D plane_item_to_vkms_configfs_plane(i= tem); + int ret, val =3D 0; + + ret =3D kstrtouint(page, 10, &val); + if (ret) + return ret; + + /* Should be a supported value */ + if (val & ~VKMS_SUPPORTED_COLOR_RANGES) + return -EINVAL; + /* Should at least provide one color range */ + if ((val & VKMS_SUPPORTED_COLOR_RANGES) =3D=3D 0) + return -EINVAL; + + scoped_guard(mutex, &plane->dev->lock) { + if (plane->dev->enabled) + return -EBUSY; + + vkms_config_plane_set_supported_color_ranges(plane->config, val); + } + + return count; +} + +static ssize_t plane_default_color_range_show(struct config_item *item, ch= ar *page) +{ + struct vkms_configfs_plane *plane =3D plane_item_to_vkms_configfs_plane(i= tem);; + unsigned int default_color_range; + + scoped_guard(mutex, &plane->dev->lock) + default_color_range =3D vkms_config_plane_get_default_color_range(plane-= >config); + + return sprintf(page, "%u", default_color_range); +} + +static ssize_t plane_default_color_range_store(struct config_item *item, + const char *page, size_t count) +{ + struct vkms_configfs_plane *plane =3D plane_item_to_vkms_configfs_plane(i= tem); + int ret, val =3D 0; + + ret =3D kstrtouint(page, 10, &val); + if (ret) + return ret; + + /* Should be a supported value */ + if (val & ~VKMS_SUPPORTED_COLOR_RANGES) + return -EINVAL; + /* Should at least provide one color range */ + if ((val & VKMS_SUPPORTED_COLOR_RANGES) =3D=3D 0) + return -EINVAL; + + if (!is_power_of_2(val)) + return -EINVAL; + + /* Convert bit position to the proper enum value */ + val =3D __ffs(val) + DRM_COLOR_YCBCR_LIMITED_RANGE; + + scoped_guard(mutex, &plane->dev->lock) { + if (plane->dev->enabled) + return -EBUSY; + + vkms_config_plane_set_default_color_range(plane->config, val); + } + + return count; +} + static ssize_t plane_supported_color_encodings_show(struct config_item *it= em, char *page) { struct vkms_configfs_plane *plane =3D plane_item_to_vkms_configfs_plane(i= tem); @@ -543,6 +632,8 @@ CONFIGFS_ATTR(plane_, type); CONFIGFS_ATTR(plane_, name); CONFIGFS_ATTR(plane_, supported_rotations); CONFIGFS_ATTR(plane_, default_rotation); +CONFIGFS_ATTR(plane_, supported_color_ranges); +CONFIGFS_ATTR(plane_, default_color_range); CONFIGFS_ATTR(plane_, supported_color_encodings); CONFIGFS_ATTR(plane_, default_color_encoding); =20 @@ -551,6 +642,8 @@ static struct configfs_attribute *plane_item_attrs[] = =3D { &plane_attr_name, &plane_attr_supported_rotations, &plane_attr_default_rotation, + &plane_attr_supported_color_ranges, + &plane_attr_default_color_range, &plane_attr_supported_color_encodings, &plane_attr_default_color_encoding, NULL, --=20 2.51.2