From nobody Mon Feb 9 19:06:48 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63113327C10 for ; Mon, 22 Dec 2025 15:14:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766416500; cv=none; b=jAIaWw7mARyv6MAO0tuGyR4GB6WD201APVSTQ2u8xk5MmRQtUWuIV7RkFiqVM/Mm9fkFyXchUsPvjox0e9apENRhJIbCTyK8THqT05Is2GSs0ynA1PH1v8g78cflEJSId/uqW0oIZtX4Ulr67t7iHY70Ikq3gBV6+QDhcJ6oxK4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766416500; c=relaxed/simple; bh=LQArxmrJrNZZsUxSMnAWJcE4cLQNPPNILpLMGRQk8pU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Bf0HOOlc1QfBUnuK4jp+NPjoEoFBNp5l9/AJz1dmoYZNsY/tEVU2un4wqN+PM9wpag9gEtX2YsMpg2iw2azpdhA6pla+I26qtRAYT5U3gn9cO7MdSrBzyEX1olTDJX8+3UC4dXSvcS7AFJ69tK/oXkV/B6KZqOgHYWB2pK50IXc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ldhyMf85; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ldhyMf85" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-431048c4068so2290803f8f.1 for ; Mon, 22 Dec 2025 07:14:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766416497; x=1767021297; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=i4eLrNTmJYNZqrOFXMkgnCrs/v9XFpKSoUUWAD+1qM0=; b=ldhyMf85C+ZDf74tOdg2TS42KCRk2rGngkOCR+jlOC4p/7ej8M2TgifKWPcbD9HpMi n6u2Esh9SzvSMQpefMYWn5UU6+tEtc0O57mxK530gdXSw2pM3fCtRVS1aI9nsSDVnOvu O9PILaA/TgQSeesCYBNVfi6FCGjcetvyARNzM/KKkXnyldiE2cRLm64p/51I+WaDg2vN xyadmJ4XdjOtqgnsMB8vqEGMqrQQmdyjyaD2lj8EOEQddB5SYmBmVew7b5QhHZyG09JK vYDSn6BP4pkfOH/kYOZj8NTIj0ljJUtmPGfT6xW5nq1/ALTjfwzEPeNfM7jZLrEWRxpD CpFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766416497; x=1767021297; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=i4eLrNTmJYNZqrOFXMkgnCrs/v9XFpKSoUUWAD+1qM0=; b=Z1QWsZxv5EgQAX+UHoZ3WNDGRdDBYD+Brnl5nnrdYqwu7MCUJef2ITp3E9e0ZaBv2o P9yZov3X3fnLKZyCx/45Y+Ty20TDXs6QYhqZ3j1+HSIDDKONv+Ex8jHb439serhCCCTw XBPKJr6qEA8CfgVIoxEbPm23FKNJIr/TO83mJu2f2xQQ5d73bmWNlxbJyEnzwjQv+U6F BBkp8Am9Zn8FJ43Ql8MSsbo+IKDZ3ncMq9INvHvXeCbKDYf7OXUF7chf1bH0kb8F2qOd YtO3jaMcWioiqaooEfRFmvuPir9CVhJCnGgG/hC0xLIsrZavch04vl+fRKeYXukAl4XO 8BMA== X-Forwarded-Encrypted: i=1; AJvYcCUQO/mxAYc+GF8uRvhee+cLxyD6kICncxumkyhg+EvlI3GG7QHRt1ZLQdve+DjylBaP0jrM33YoCGF/57g=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3erWTlGcog4oMQkMCho2aXbluU1Ldsvo1I9gQ+fjpQV+CGxJu +Rxz1/VbhEj5+cc7Mbif64KjngbLyI6yxLBo7ARUJ3hJnEYj+NxemN7aurg6SXs/QhQ= X-Gm-Gg: AY/fxX68ozaYMRlp4Co9DohZjXOKMlEnZ2SpO4+e/o8Q5qG3xMpkgKfsCkf8tnMRS9t LTW5Se93c+GcMyAcdskjYY8OUUTWNvm7yE8Vxcj2WkZ5dht6qgZ+t+ZQpIys6a4CNInzi7e5mId TldJ2JdMswj8KV3hdGtEjI2gHi05f6SE05IQ9HORYCqtzU06mbYo39TDwPVT2FlmXIcMraDIYNc 1buT9+ttUTcABiW3jSM/kr/CJW1lHk+7OuxR0B6Invg5RppdRUmBfDPIzu3lyJFHQDCUxpaC0Xq UeA5E5gphrcGZPEnRtGDON5Fykh6NJffMIZR6XIhTAFxc0wTO0LtJxK/AO8V7H1K1EeQZjXjg5V pNL257r+a2XJ4Lk7xIMvnwS3aKgax3tkw1x2BpLQIWtgfiMQfYN8OhKtB7fBcFz7iTQpcsQpdxl IS9ClzkFhaEdPkWJWJNtHc X-Google-Smtp-Source: AGHT+IEX38PKZ1aYnAoijx5riCeANgTFac47kzzgBW07ko1Xcrdxsb2Y6X78FNQXCIfizNz2p3XEYg== X-Received: by 2002:a05:6000:18a8:b0:430:f16b:d8cc with SMTP id ffacd0b85a97d-43244795353mr17080981f8f.3.1766416496632; Mon, 22 Dec 2025 07:14:56 -0800 (PST) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea830fesm22750093f8f.20.2025.12.22.07.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 07:14:56 -0800 (PST) From: James Clark Date: Mon, 22 Dec 2025 15:14:34 +0000 Subject: [PATCH v4 09/14] perf tests: Test evsel__set_config_if_unset() and config change tracking Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251222-james-perf-config-bits-v4-9-0608438186fc@linaro.org> References: <20251222-james-perf-config-bits-v4-0-0608438186fc@linaro.org> In-Reply-To: <20251222-james-perf-config-bits-v4-0-0608438186fc@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, James Clark X-Mailer: b4 0.14.0 Test that evsel__set_config_if_unset() behaves as expected. This also tests the user config change tracking mechanism as it depends on it. Reviewed-by: Ian Rogers Signed-off-by: James Clark --- tools/perf/tests/pmu.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 91 insertions(+) diff --git a/tools/perf/tests/pmu.c b/tools/perf/tests/pmu.c index cbded2c6faa4..0ebf2d7b2cb4 100644 --- a/tools/perf/tests/pmu.c +++ b/tools/perf/tests/pmu.c @@ -192,12 +192,102 @@ static int test__pmu_format(struct test_suite *test = __maybe_unused, int subtest } if (attr.config2 !=3D 0x0400000020041d07) { pr_err("Unexpected config2 value %llx\n", attr.config2); + } + + ret =3D TEST_OK; +err_out: + parse_events_terms__exit(&terms); + test_pmu_put(dir, pmu); + return ret; +} + +static int test__pmu_usr_chgs(struct test_suite *test __maybe_unused, int = subtest __maybe_unused) +{ + const char *event =3D "perf-pmu-test/config=3D15,config1=3D4,krava02=3D17= 0," + "krava03=3D1,krava11=3D27,krava12=3D1/"; + struct parse_events_terms terms; + struct parse_events_error err; + LIST_HEAD(config_terms); + struct evlist *evlist; + struct perf_pmu *pmu; + struct evsel *evsel; + int ret =3D TEST_FAIL; + char dir[PATH_MAX]; + u64 val; + + pmu =3D test_pmu_get(dir, sizeof(dir)); + if (!pmu) + return TEST_FAIL; + + evlist =3D evlist__new(); + if (evlist =3D=3D NULL) { + pr_err("Failed allocation"); + goto err_out; + } + + parse_events_terms__init(&terms); + ret =3D parse_events(evlist, event, &err); + if (ret) { + pr_debug("failed to parse event '%s', err %d\n", event, ret); + parse_events_error__print(&err, event); + if (parse_events_error__contains(&err, "can't access trace events")) + ret =3D TEST_SKIP; goto err_out; } + evsel =3D evlist__first(evlist); + + /* + * Set via config=3D15, krava01 bits 0-1 + * Set via config1=3D4, krava11 bit 1 + * Set values: krava02=3D170, krava03=3D1, krava11=3D27, krava12=3D1 + * + * Test that already set values aren't overwritten. + */ + evsel__set_config_if_unset(evsel, "krava01", 16); + evsel__get_config_val(evsel, "krava01", &val); + TEST_ASSERT_EQUAL("krava01 overwritten", (int) val, (15 & 0b11)); + + evsel__set_config_if_unset(evsel, "krava11", 45); + evsel__get_config_val(evsel, "krava11", &val); + TEST_ASSERT_EQUAL("krava11 overwritten", (int) val, (27 | (4 << 1))); + + evsel__set_config_if_unset(evsel, "krava02", 32); + evsel__get_config_val(evsel, "krava02", &val); + TEST_ASSERT_EQUAL("krava02 overwritten", (int) val, 170); + + evsel__set_config_if_unset(evsel, "krava03", 0); + evsel__get_config_val(evsel, "krava03", &val); + TEST_ASSERT_EQUAL("krava03 overwritten", (int) val, 1); + + /* + * krava13 doesn't have any bits set by either krava13=3D or config1=3D + * but setting _any_ raw value for config1 implies that krava13 + * shouldn't be overwritten. So it's value should remain as 0. + */ + evsel__set_config_if_unset(evsel, "krava13", 5); + evsel__get_config_val(evsel, "krava13", &val); + TEST_ASSERT_EQUAL("krava13 overwritten", (int) val, 0); + + /* + * Unset values: krava21, krava22, krava23 + * + * Test that unset values are overwritten. + */ + evsel__set_config_if_unset(evsel, "krava21", 13905); + evsel__get_config_val(evsel, "krava21", &val); + TEST_ASSERT_EQUAL("krava21 not overwritten", (int) val, 13905); + + evsel__set_config_if_unset(evsel, "krava22", 11); + evsel__get_config_val(evsel, "krava22", &val); + TEST_ASSERT_EQUAL("krava22 not overwritten", (int) val, 11); =20 + evsel__set_config_if_unset(evsel, "krava23", 0); + evsel__get_config_val(evsel, "krava23", &val); + TEST_ASSERT_EQUAL("krava23 not overwritten", (int) val, 0); ret =3D TEST_OK; err_out: parse_events_terms__exit(&terms); + evlist__delete(evlist); test_pmu_put(dir, pmu); return ret; } @@ -539,6 +629,7 @@ static struct test_case tests__pmu[] =3D { TEST_CASE("PMU name combining", name_len), TEST_CASE("PMU name comparison", name_cmp), TEST_CASE("PMU cmdline match", pmu_match), + TEST_CASE("PMU user config changes", pmu_usr_chgs), { .name =3D NULL, } }; =20 --=20 2.34.1