From nobody Tue Feb 10 16:18:31 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A7F33242C0 for ; Mon, 22 Dec 2025 15:14:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766416498; cv=none; b=b7fE0jg12mGB947rxJpCaSHa6YlItC98C8jBLuzwky7CBhscXFGKyjjna3NtEYzS+VK1YKF6XoxMPoN8ngNFr+PsJIFnrqAME185U2BKuRxMhut+YW1exwuydKU1wrAMMrY+Lk8lr8m/sc4ncI8DXscL4PWQ9CY8Zzls5qp4lSU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766416498; c=relaxed/simple; bh=M/zr80Oeo+sGWSF+YKiiItZy+uMJytYOw7BVT1B9KWU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IU59tRcoehtdMhasZppdgDv71P47OhhyVfkKoyXpOKpsmHgd9MJG+O2uL5EQcXIEtQrUnga84XPaxM5Gfpwl82dekKs/K1c9RMVpLqNUS71EhfHMp+31InSnnlY95oTCCfzu+WcJ/MMWOolt23IwjRPnwMTLi4C1exh5qeWTCts= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iG0aQ5Gk; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iG0aQ5Gk" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-43260a5a096so741228f8f.0 for ; Mon, 22 Dec 2025 07:14:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766416494; x=1767021294; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Dusq4givPs/+MmVLybQAr0PfVhdx73n3zpPLiMfCBqA=; b=iG0aQ5GkuCJSnTZy4dK3ZKUaz5u3bnd5l2+r7vlh4zBoOZnLr5U0/7wMPZjlM5XSaB MeY69w4r5BgeXx0Yno60Zvj6cjVyfEYHqy3rDc7FPERnnN9SpLXcgmCqsb+GiPldXnkf mp0dODM37AKRoAJzIJxPd09VvtxzYrbaA6l2A03ieo3geSjcG2IuXjjc7cc0kKjRJiQi 77x4X8g1wHu4oLY0gA/V+xZ340BoWorB0eUcdbI0hwJ0V2dgFkxWyuhpWdwpc5DF7qxb HVq+xw3kFfRsxLDsxGBRgn7xWraM9JlgwmL7qvDXJbmubtfD4LXdNG3O7lCupLf6FlNd 8BmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766416494; x=1767021294; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Dusq4givPs/+MmVLybQAr0PfVhdx73n3zpPLiMfCBqA=; b=sRVIDAZEEu9BvkXlAcgRDvnRGiNmiS8q27PJmacJrbrsljidi/ug/RBEBVzWBk4Q0u ukg33Zyr2EG93LCgMwqPWuhJnqmqeLg7JDPf/+KfIfu/2AvJcCLUdqVPCKGeeQ+GJ+vg 70CldRljVOoEsai9I3vZiHdoi9MpZJrwCZUXIMfVg7ExHVpBVkNG4ZFu3REWE5T0S5Nl BWFeMgtiVPnIoIh0rfeMUEk7JgOSA3AyTgMw+IoI/dlE2p+kzhYMQWcNiS0hLE/xWbmR W0wk7B5XCeRW7AR2tFitZZlDlmWf0xdC695vpNqwY8Z+wEkLaQ7OI9uLE4+OF4FhNg3o Fokw== X-Forwarded-Encrypted: i=1; AJvYcCUBjx008LIbUPEn6e9189R5o0x9otVPvJMFNJJXNDfQ3s3Iy6XhjD8axIfLhUP8uEN5FQh2701uMh/v/0c=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+DcXpSv5RUSIWRJrn4HqvFVYMMJm7XO1IABdZOYsJnmR9xSpZ wWWyGw8HLHpVrB4PxB8XDftu7IjIeFx4iJZyrIGaqCUr6k9/Dx4757H8Ph6WZDiQu/lgs9Cgr4x IG/sUbmE= X-Gm-Gg: AY/fxX4q9exJ+/yxzy2DsHg+HPNB6iVCxEMqu+qrtr44QynGba8/IoOnhsRnbyt3sEM GFw05IIIlmAEubsMYHwEW1HCUMmejrGIQwq+FYslqFJNq14qaNF3j7nlve/hbNmYxclnfYi0Eeb G65enQGN/ZHk+T1TTGUiK5Ep1JNK98aUv3dOA8ulCTqinfnb+M9ygS2uKTRoBByUuJxJAsbb8eK FQUYi23JsvBpCtM/ol9bpJlUKclvJFQd6EOANVDDje4LWIvc2VceBzmNocj374qnCojbkbmKFzv Dj8Tc+FB1ymH1J/WH2bY0PVoMb4v7xo5x2TRDBXUhhFm9VLQrxSwf+eFCJF0TU3YATSR/fVnv7/ dhMv7SnUL10iGvVIb+Ot2m3ZHU0HXPVLDNJGSy07yiBhy2Cto4KEVfRePLza3sAJUATw/PEk+qY 4Xae7RGut2DzbQ8dUM+533 X-Google-Smtp-Source: AGHT+IH25mEFFoPaM1cwim0haHxibCkaTMRRATJLhfsMoJuUgN3vVuqjq2nokfYWDZpCL4mdVJFaag== X-Received: by 2002:a05:6000:26d2:b0:430:fc5a:40ac with SMTP id ffacd0b85a97d-4324e70413emr14627279f8f.54.1766416494435; Mon, 22 Dec 2025 07:14:54 -0800 (PST) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea830fesm22750093f8f.20.2025.12.22.07.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 07:14:54 -0800 (PST) From: James Clark Date: Mon, 22 Dec 2025 15:14:32 +0000 Subject: [PATCH v4 07/14] perf evsel: Add a helper to get the value of a config field Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251222-james-perf-config-bits-v4-7-0608438186fc@linaro.org> References: <20251222-james-perf-config-bits-v4-0-0608438186fc@linaro.org> In-Reply-To: <20251222-james-perf-config-bits-v4-0-0608438186fc@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, James Clark X-Mailer: b4 0.14.0 This will be used by aux PMUs to read an already written value for configuring their events and for also testing. Its helper perf_pmu__format_unpack() does the opposite of the existing pmu_format_value() so rename that one to perf_pmu__format_pack() so it's clear how they are related. Reviewed-by: Ian Rogers Signed-off-by: James Clark --- tools/perf/util/evsel.c | 38 +++++++++++++++++++++++++++++++++++++- tools/perf/util/evsel.h | 2 ++ tools/perf/util/pmu.c | 35 ++++++++++++++++++++++++++++------- tools/perf/util/pmu.h | 4 +++- 4 files changed, 70 insertions(+), 9 deletions(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index b863096ed568..703a6f73d468 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -1374,7 +1374,43 @@ void evsel__set_config_if_unset(struct evsel *evsel,= const char *config_name, return; =20 /* Otherwise replace it */ - pmu_format_value(&bits, val, vp, /*zero=3D*/true); + perf_pmu__format_pack(&bits, val, vp, /*zero=3D*/true); +} + + +int evsel__get_config_val(const struct evsel *evsel, const char *config_na= me, + u64 *val) +{ + struct perf_pmu_format *format =3D pmu_find_format(&evsel->pmu->format, c= onfig_name); + u64 bits =3D perf_pmu__format_bits(evsel->pmu, config_name); + + if (!format || !bits) { + pr_err("Unknown/empty format name: %s\n", config_name); + *val =3D 0; + return -EINVAL; + } + + switch (format->value) { + case PERF_PMU_FORMAT_VALUE_CONFIG: + *val =3D perf_pmu__format_unpack(bits, evsel->core.attr.config); + return 0; + case PERF_PMU_FORMAT_VALUE_CONFIG1: + *val =3D perf_pmu__format_unpack(bits, evsel->core.attr.config1); + return 0; + case PERF_PMU_FORMAT_VALUE_CONFIG2: + *val =3D perf_pmu__format_unpack(bits, evsel->core.attr.config2); + return 0; + case PERF_PMU_FORMAT_VALUE_CONFIG3: + *val =3D perf_pmu__format_unpack(bits, evsel->core.attr.config3); + return 0; + case PERF_PMU_FORMAT_VALUE_CONFIG4: + *val =3D perf_pmu__format_unpack(bits, evsel->core.attr.config4); + return 0; + default: + pr_err("Unknown format value: %d\n", format->value); + *val =3D 0; + return -EINVAL; + } } =20 void __weak arch_evsel__set_sample_weight(struct evsel *evsel) diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h index 2cf87bc67df7..95c4bd0f0f2e 100644 --- a/tools/perf/util/evsel.h +++ b/tools/perf/util/evsel.h @@ -575,6 +575,8 @@ void evsel__uniquify_counter(struct evsel *counter); ((((src) >> (pos)) & ((1ull << (size)) - 1)) << (63 - ((pos) + (size) - 1= ))) =20 u64 evsel__bitfield_swap_branch_flags(u64 value); +int evsel__get_config_val(const struct evsel *evsel, const char *config_na= me, + u64 *val); void evsel__set_config_if_unset(struct evsel *evsel, const char *config_na= me, u64 val); =20 diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index dc5dab69151f..626c7307c8a3 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -1337,6 +1337,26 @@ void perf_pmu__warn_invalid_formats(struct perf_pmu = *pmu) } } =20 +/* + * Unpacks a raw config[n] value using the sparse bitfield that defines a + * format attr. For example "config1:1,6-7,44" defines a 4 bit value acros= s non + * contiguous bits and this function returns those 4 bits as a value. + */ +u64 perf_pmu__format_unpack(u64 format, u64 config_val) +{ + int val_bit =3D 0; + u64 res =3D 0; + int fmt_bit; + + for_each_set_bit(fmt_bit, &format, PERF_PMU_FORMAT_BITS) { + if (test_bit(fmt_bit, &config_val)) + res |=3D BIT_ULL(val_bit); + + val_bit++; + } + return res; +} + struct perf_pmu_format *pmu_find_format(const struct list_head *formats, const char *name) { @@ -1379,7 +1399,8 @@ int perf_pmu__format_type(const struct perf_pmu *pmu,= const char *name) * Sets value based on the format definition (format parameter) * and unformatted value (value parameter). */ -void pmu_format_value(unsigned long *format, __u64 value, __u64 *v, bool z= ero) +void perf_pmu__format_pack(unsigned long *format, __u64 value, __u64 *v, + bool zero) { unsigned long fbit, vbit; =20 @@ -1496,23 +1517,23 @@ static int pmu_config_term(const struct perf_pmu *p= mu, switch (term->type_term) { case PARSE_EVENTS__TERM_TYPE_CONFIG: assert(term->type_val =3D=3D PARSE_EVENTS__TERM_TYPE_NUM); - pmu_format_value(bits, term->val.num, &attr->config, zero); + perf_pmu__format_pack(bits, term->val.num, &attr->config, zero); break; case PARSE_EVENTS__TERM_TYPE_CONFIG1: assert(term->type_val =3D=3D PARSE_EVENTS__TERM_TYPE_NUM); - pmu_format_value(bits, term->val.num, &attr->config1, zero); + perf_pmu__format_pack(bits, term->val.num, &attr->config1, zero); break; case PARSE_EVENTS__TERM_TYPE_CONFIG2: assert(term->type_val =3D=3D PARSE_EVENTS__TERM_TYPE_NUM); - pmu_format_value(bits, term->val.num, &attr->config2, zero); + perf_pmu__format_pack(bits, term->val.num, &attr->config2, zero); break; case PARSE_EVENTS__TERM_TYPE_CONFIG3: assert(term->type_val =3D=3D PARSE_EVENTS__TERM_TYPE_NUM); - pmu_format_value(bits, term->val.num, &attr->config3, zero); + perf_pmu__format_pack(bits, term->val.num, &attr->config3, zero); break; case PARSE_EVENTS__TERM_TYPE_CONFIG4: assert(term->type_val =3D=3D PARSE_EVENTS__TERM_TYPE_NUM); - pmu_format_value(bits, term->val.num, &attr->config4, zero); + perf_pmu__format_pack(bits, term->val.num, &attr->config4, zero); break; case PARSE_EVENTS__TERM_TYPE_LEGACY_HARDWARE_CONFIG: assert(term->type_val =3D=3D PARSE_EVENTS__TERM_TYPE_NUM); @@ -1650,7 +1671,7 @@ static int pmu_config_term(const struct perf_pmu *pmu, */ } =20 - pmu_format_value(format->bits, val, vp, zero); + perf_pmu__format_pack(format->bits, val, vp, zero); return 0; } =20 diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h index 7655d996090a..a1255b3a8f91 100644 --- a/tools/perf/util/pmu.h +++ b/tools/perf/util/pmu.h @@ -279,12 +279,14 @@ int perf_pmu__check_alias(struct perf_pmu *pmu, struc= t parse_events_terms *head_ u64 *alternate_hw_config, struct parse_events_error *err); int perf_pmu__find_event(struct perf_pmu *pmu, const char *event, void *st= ate, pmu_event_callback cb); =20 -void pmu_format_value(unsigned long *format, __u64 value, __u64 *v, bool z= ero); +void perf_pmu__format_pack(unsigned long *format, __u64 value, __u64 *v, + bool zero); struct perf_pmu_format *pmu_find_format(const struct list_head *formats, const char *name); void perf_pmu_format__set_value(void *format, int config, unsigned long *b= its); bool perf_pmu__has_format(const struct perf_pmu *pmu, const char *name); int perf_pmu__for_each_format(struct perf_pmu *pmu, void *state, pmu_forma= t_callback cb); +u64 perf_pmu__format_unpack(u64 format, u64 config_val); =20 bool is_pmu_core(const char *name); bool perf_pmu__supports_legacy_cache(const struct perf_pmu *pmu); --=20 2.34.1