From nobody Tue Feb 10 07:41:26 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB2F4322C67 for ; Mon, 22 Dec 2025 15:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766416494; cv=none; b=tJXuwJ36AEH0mQ4bkpX2vGJGE5ehWiaL4l/2vKA9ZUc21aohqSxsPGfCVNZm1Ve6qNi5Dhrg1wwUS3DkE0fvFfItFe4Yoz2+ycmX38Al0Q+IFkLzFvBwwFD1QEXAzNJtUYMzF2rjuFNpcp61mj5ccrNyiypW4wpkyzY2n68Y/RQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766416494; c=relaxed/simple; bh=FTxDdPV8VRCnrc+wl5dgopj1RtcXYU68OejLvw73lKQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tNYiU8pP2Lfo1vOtbnSwR/ii9aw7Mf+eOeH34cRZ06BIcDZkiS9+pLkP/8muJMio781n9qn+LH36P5rEac63dO/dmO2oLL6lI7GrcIAptRelQq39AS97QFaGe7d+voi7C4vHSUv9Opyy7rX+KwA3a9YUOUfny/XoqR9sAc4Rs0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=B8850Ybp; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="B8850Ybp" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-477ba2c1ca2so41033815e9.2 for ; Mon, 22 Dec 2025 07:14:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766416491; x=1767021291; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=U1bJE594NjB5xayk5BHzRci/xs2vEOkVDLlHSZrqiYE=; b=B8850Ybpwr4E5WjIUjw3uVxj+xJGVer4XEn0ZCMDXdANzjxSky/NKkzAjdoFonksnI YnDms7W0iIW8p2+txwIGgLjefCJ3AbKaqdJA5W9842Mg3CK3hMpfETRFgZpUKmE8MTbU LQydx1aSqZfZRrjEBIfSHxDgnZ+gBZ7ljyVi+/07I7YklUcMzWoguqY5DYqBhLmNtIgr XWgpI1lnLPupmc/JhuxUGDG0Z6YzWBbVpc4OpNChyKZvaz2J8HZcxZUzrhOueV/cFkhr 8OB6EwUFuqxKuOyKG08znT/YvC4xNy4dC37DF8xW/WDISyDtHaF/i7citV+qVG0N7kHb dZxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766416491; x=1767021291; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=U1bJE594NjB5xayk5BHzRci/xs2vEOkVDLlHSZrqiYE=; b=sqmBuUGcQ2T84tY7aBHpBxWZTAoQvGljQ9OPSp+e7NcyYA+2RqCLbD69YQqFTWplJV B/D63Axhb5aDO194yiG2zqS/MqzUfZH1bNXL8UI5EgXulccw6Aks69Kr7lxjS5V5nNtM kLxlT75ZSIuf1YeJxtTbvLHP4cupfJ73effQGwQqRdn9phzCinPiFyQtSrPowk9JKtkP NfoKWYtr6Pt+UFkMMbUZteJnz/nUuZ13Achn5d/Fm3X4EBHPRxqLGArL4FyCzilgGEU2 TGPvccvs5S8O2nx1v8osbu+oBH1iqsbgIQLHC4zXpNp9F2W/14oDtPMcxYqG18qGzwkf bj/Q== X-Forwarded-Encrypted: i=1; AJvYcCUnqnSLmlzghWHPKiMOYVNUn66dqxD/+Zw7A9dHnbB/DfYv1gftQGWYQurmZFgwjB0YLn4G2Fcdwz/Tmag=@vger.kernel.org X-Gm-Message-State: AOJu0YxyR5glmouMdZay6+nWUwUeJCLRXIdKB46MKLV/FGIu9gHR1Qkj wWfRcPgQAU8AR7DyZezexFV8pHsvswEr8ImhiIUgroJWE+kxGKDQ/FWOGJoAb6rpYpE= X-Gm-Gg: AY/fxX50yQ+t4z4FpBH4//A8wOsT/nJKUtiwQ+29eLtVKjjfkFAbihASnud8C+/OClf EXC/TsTvtmnIgTpIQ7y/Osvft1DZpFc0pm2DmnQ3jJknZ38DhYWNo0EZ6fN7+XuDjJbtOAseNtP tyKlIjrZjhVukHIHwkFWmgw7W5XJBUpEtvMaBKuv4J5nSqgIbrGb02lwphYWMd0uuovie4Rr2QY DP3dt6w+svqbi/JkjtujUwCukrc7dCCt/Ash05EILLcH5T8RCt0KvnrK8A9s8rXwAnqhVtGJJ49 6F7gzD3Tgd80HrdwD48ufJTVMm+PwcYBHTsPAI0RnXP2ursCEH6yj/OC3whqTXeiKS3T6BfXfEJ TOnAguKsNYdhuM8mNVPuRgxrlYb+GtqcwRCJ15w44WmSY480lULINlnnEqofiZtKRGw/KU+CeJm OMLBB2EwAGNYtwe7wR4+6BnYXhWdZDo4E= X-Google-Smtp-Source: AGHT+IFddjiKvcVB6cB7sXuBjaeFQkW72VpuWm8Z2oCtbr9Um6xxbGDEDSw9Q4XBeyAlVCQFF3b1FQ== X-Received: by 2002:a05:6000:26d1:b0:430:f463:b6a7 with SMTP id ffacd0b85a97d-4324e50ec19mr13688757f8f.45.1766416491127; Mon, 22 Dec 2025 07:14:51 -0800 (PST) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea830fesm22750093f8f.20.2025.12.22.07.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 07:14:50 -0800 (PST) From: James Clark Date: Mon, 22 Dec 2025 15:14:29 +0000 Subject: [PATCH v4 04/14] perf evsel: Support sparse fields in evsel__set_config_if_unset() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251222-james-perf-config-bits-v4-4-0608438186fc@linaro.org> References: <20251222-james-perf-config-bits-v4-0-0608438186fc@linaro.org> In-Reply-To: <20251222-james-perf-config-bits-v4-0-0608438186fc@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, James Clark X-Mailer: b4 0.14.0 Sparse config fields are technically supported although currently unused. field_prep() only works for contiguous bitfields so replace it with pmu_format_value(). Reviewed-by: Ian Rogers Signed-off-by: James Clark --- tools/perf/util/evsel.c | 4 +--- tools/perf/util/pmu.c | 3 +-- tools/perf/util/pmu.h | 1 + 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 21878e9bd029..45ab97beeb34 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -1322,7 +1322,6 @@ struct evsel_config_term *__evsel__get_config_term(st= ruct evsel *evsel, enum evs * the bit pattern. It is shifted into position by this function, so to set * something to true, pass 1 for val rather than a pre shifted value. */ -#define field_prep(_mask, _val) (((_val) << (ffsll(_mask) - 1)) & (_mask)) void evsel__set_config_if_unset(struct evsel *evsel, const char *config_na= me, u64 val) { @@ -1339,8 +1338,7 @@ void evsel__set_config_if_unset(struct evsel *evsel, = const char *config_name, return; =20 /* Otherwise replace it */ - evsel->core.attr.config &=3D ~bits; - evsel->core.attr.config |=3D field_prep(bits, val); + pmu_format_value(&bits, val, &evsel->core.attr.config, /*zero=3D*/true); } =20 void __weak arch_evsel__set_sample_weight(struct evsel *evsel) diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index e3a1f26213ec..599fdf5e28ba 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -1404,8 +1404,7 @@ int perf_pmu__format_type(struct perf_pmu *pmu, const= char *name) * Sets value based on the format definition (format parameter) * and unformatted value (value parameter). */ -static void pmu_format_value(unsigned long *format, __u64 value, __u64 *v, - bool zero) +void pmu_format_value(unsigned long *format, __u64 value, __u64 *v, bool z= ero) { unsigned long fbit, vbit; =20 diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h index 8f11bfe8ed6d..e34db47ae5ef 100644 --- a/tools/perf/util/pmu.h +++ b/tools/perf/util/pmu.h @@ -254,6 +254,7 @@ int perf_pmu__check_alias(struct perf_pmu *pmu, struct = parse_events_terms *head_ u64 *alternate_hw_config, struct parse_events_error *err); int perf_pmu__find_event(struct perf_pmu *pmu, const char *event, void *st= ate, pmu_event_callback cb); =20 +void pmu_format_value(unsigned long *format, __u64 value, __u64 *v, bool z= ero); void perf_pmu_format__set_value(void *format, int config, unsigned long *b= its); bool perf_pmu__has_format(const struct perf_pmu *pmu, const char *name); int perf_pmu__for_each_format(struct perf_pmu *pmu, void *state, pmu_forma= t_callback cb); --=20 2.34.1