From nobody Mon Feb 9 19:52:43 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5A62326934 for ; Mon, 22 Dec 2025 16:30:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766421040; cv=none; b=I2VBM508AW0AVTuR+RaK66YBTduZxIYdTD3NS30DCXm5oPxPnbzecZLvcQciDeFK1wBxHEVEfoieYVzfKK/eKxhm9pDAFP5tKlYKsiqNTPchpL/Nl2zV5nYaeZmcP9s+Qnoxv2DmqJogGDmUTje4cUk81RYiQZxdNJip2QaDUtM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766421040; c=relaxed/simple; bh=M/Ht02RXnwpyI8/d82bw2pNNTOH9KcOIpttNOEpsz50=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Yz7iqCmnBqLArdfpBrF1xHYpVhIWIjlQp3+fvGrDej5mynoJnN3HYa5vioPYU55D+2iPg0hfMNtQnJ31l7FBmq/2XX4mCC/vNmwXx1lF+InSxR+rv7YSydgybecnmW90Sj5mXRCTh60D3C/WuVn6HIafkNcCamtXEWmzQUbTAy4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=N80xDzGN; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N80xDzGN" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-477aa218f20so25852415e9.0 for ; Mon, 22 Dec 2025 08:30:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766421036; x=1767025836; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OdZvrS1dE5qeSW0XzFKBJXtmzMM/4cC+vHFcMxasvWQ=; b=N80xDzGNXBLPzr952CwRB5mid4zJhYXE99Cl7wThVS+TOY4NzohzHLeyu2dndgiphO Hdx0FkU2kmqi654GRmUc0dCn7WvsXLIRd9MlVE5pmtmw1MJKsbX0M3QI2XkiSFaoIpHj kY+m+6/ROr7+IjJhc505YdJ8lYQLW6tggBLlk7ZnHQtXVUrtSv1CTLmdx/zOGAML6Y1I 2yScXoegVvgDdW6JcxbiXl6dwVixbhjIO0jWJ3jd81I6QYHKkem97sGWGfGbUwvzp+0w GmdZqZiBifBU3b7mra4LBViXnDY/BPJxGGMmxw39zQVlwtaULcqsNakhI0DVR55P1AU2 gWCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766421036; x=1767025836; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=OdZvrS1dE5qeSW0XzFKBJXtmzMM/4cC+vHFcMxasvWQ=; b=h5MMFHu0M7AZTZTN0tEVd3gzqrFHleJTlcitMOw7e3UXWtabGXYNXJfZLB+BzgSGc2 GBvWheHl1bxabB/4lyRLCEDafl2UP48t0evbiHWQvzaT0Y85r2JLKd1BUqoOecU2faZE +xZDUF79I/o8olpFu65Np5Y4+iy9LotimYj957yrwgiGBzrBYuF+NseS/6VvyvS4Rj40 p1e90vWi/qo6JfhCGsJbldbsC3aeIDVdjLsrXG+CwivoDLWhI0bkQS9YHJgwOkhPFQ6z JWrvMrZRiSYSLRcJQkvYSXL8rkDL7pHRT3T37mfPRbVzeKvE2U3JQrPvOghp9nmGCJig Ksqw== X-Forwarded-Encrypted: i=1; AJvYcCWSNaAH/P6RidyPLsf1DV9sVn4CC3rfB+PPCSmDdzzFisIWOvu3T9iECiN7OvkoDRTArf2wjwOq8jNqeW8=@vger.kernel.org X-Gm-Message-State: AOJu0YyVLOO/n9QdNTPREurMzvCVGSXbZA4iP2Bd7W9+yr1LF31r2YLR lZaiYwFLF+uLF6NaBEU5fGAYBPklRiX/81U6Hfvf6xEodORzBgyFjmEd+hmAYm2SK9c= X-Gm-Gg: AY/fxX6jMLAkcflnDnGql22wUZ0qQJTNFyOQho/yag/mLOAqJZUSqSwbGU0WL9XXvDl ygjBCz6CcmNQkcvssk2oxwd5f8gPVrLsqiBFjw/ylNCUlBWrcFpu2xH6Rdhjd9EhLd50R/udYyk 7CeWh+1G5ALZepoUGm2b/rSBHTrC/DUKkUFCre3Aa8zIzHR5UnaqDAG3PiNE3cVXB2WulRduBoB yKAmhLNOes4WeT2o1mLPpxrynyutCoWBSQFdtNK/4aM3RHx+pw67GMRMxY7Wsl+L6NDhx0L6daH AlEXCoGONIxiYqneq1tvWH6ruE3eVP94/dccJzZjKyv8KiugWFGsTZXi/WYBGSFeh/3oAM3T1Zt UfP4cq5+hULqIpTqyCNFygHAcrnOGPgzf+Tqaa8no4r4O0sVKMXVLWltYWiYMIiLdYKUiONrTiC W8+Fq/UHDsKwfPnPXsjliCnYuxAueNlgyMgBcSXbBUtKrpsueQfF7WCrn781ohj/Pk X-Google-Smtp-Source: AGHT+IFNrAPWGxzcsoaQLoabTeny92MuV3z4VFx51LTPkZKLWoAPMlDB5aYM21GbjGHuz92+M8hP8w== X-Received: by 2002:a05:600c:3489:b0:479:2a09:9262 with SMTP id 5b1f17b1804b1-47d1953dabamr123231785e9.9.1766421036091; Mon, 22 Dec 2025 08:30:36 -0800 (PST) Received: from ta2.c.googlers.com (62.221.76.34.bc.googleusercontent.com. [34.76.221.62]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa4749sm23071258f8f.37.2025.12.22.08.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 08:30:35 -0800 (PST) From: Tudor Ambarus Date: Mon, 22 Dec 2025 16:30:08 +0000 Subject: [PATCH v4 4/5] soc: samsung: exynos-chipid: add google,gs101-otp support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251222-gs101-chipid-v4-4-aa8e20ce7bb3@linaro.org> References: <20251222-gs101-chipid-v4-0-aa8e20ce7bb3@linaro.org> In-Reply-To: <20251222-gs101-chipid-v4-0-aa8e20ce7bb3@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766421032; l=5635; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=M/Ht02RXnwpyI8/d82bw2pNNTOH9KcOIpttNOEpsz50=; b=0wI3TjHRprHCL0MH4xmRPJElU8StjYDtY2qkStptCp0VsYE/h9uYZem6ZSzBlAAqwPiTmCoj4 eZhUU35XhVfA61saeDelePzXlNVEEF0o5EqhMfSa1e/APSjAs9qjfVa X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= GS101 is different (but also e850 and autov9 I assume) from the SoCs that are currently handled by the exynos-chipid driver because the chip ID info is part of the OTP registers. GS101 OTP has a clock, an interrupt line, a register space (that contains product and chip ID, TMU data, ASV, etc) and a 32Kbit memory space that can be read/program/locked with specific commands. On GS101 the "ChipID block" is just an abstraction, it's not a physical device. When the power-on sequence progresses, the OTP chipid values are loaded to the OTP registers. Add the GS101 chip ID support. The support is intentionally added in the exynos-chipid driver, and not in a dedicated Exynos OTP driver, because we estimate that there will not be any OTP consumers in the kernel other than the chip ID/SoC interface. The downstream GS101 drivers confirm this supposition. Signed-off-by: Tudor Ambarus --- drivers/soc/samsung/exynos-chipid.c | 70 ++++++++++++++++++++++++++++++++-= ---- 1 file changed, 61 insertions(+), 9 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index 5c8660374269c87ec38ebca242918bd7b1d362e5..6ef9751e2509c94bd9625072d0b= 81ddb93048d4a 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -15,7 +15,8 @@ #include #include #include -#include +#include +#include #include #include #include @@ -28,9 +29,11 @@ #include "exynos-asv.h" =20 struct exynos_chipid_variant { - unsigned int rev_reg; /* revision register offset */ + unsigned int main_rev_reg; /* main revision register offset */ + unsigned int sub_rev_reg; /* sub revision register offset */ unsigned int main_rev_shift; /* main revision offset in rev_reg */ unsigned int sub_rev_shift; /* sub revision offset in rev_reg */ + bool efuse; }; =20 struct exynos_chipid_info { @@ -69,6 +72,8 @@ static const struct exynos_soc_id { { "EXYNOS990", 0xE9830000 }, { "EXYNOSAUTOV9", 0xAAA80000 }, { "EXYNOSAUTOV920", 0x0A920000 }, + /* Compatible with: google,gs101-otp */ + { "GS101", 0x9845000 }, }; =20 static const char *exynos_product_id_to_name(unsigned int product_id) @@ -93,19 +98,53 @@ static int exynos_chipid_get_chipid_info(struct device = *dev, return dev_err_probe(dev, ret, "failed to read Product ID\n"); soc_info->product_id =3D val & EXYNOS_MASK; =20 - if (data->rev_reg !=3D EXYNOS_CHIPID_REG_PRO_ID) { - ret =3D regmap_read(regmap, data->rev_reg, &val); + if (data->sub_rev_reg =3D=3D EXYNOS_CHIPID_REG_PRO_ID) { + /* exynos4210 case */ + main_rev =3D (val >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; + sub_rev =3D (val >> data->sub_rev_shift) & EXYNOS_REV_PART_MASK; + } else { + unsigned int val2; + + ret =3D regmap_read(regmap, data->sub_rev_reg, &val2); if (ret < 0) return dev_err_probe(dev, ret, "failed to read revision\n"); + + if (data->main_rev_reg =3D=3D EXYNOS_CHIPID_REG_PRO_ID) + /* gs101 case */ + main_rev =3D (val >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; + else + /* exynos850 case */ + main_rev =3D (val2 >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; + + sub_rev =3D (val2 >> data->sub_rev_shift) & EXYNOS_REV_PART_MASK; } - main_rev =3D (val >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; - sub_rev =3D (val >> data->sub_rev_shift) & EXYNOS_REV_PART_MASK; + soc_info->revision =3D (main_rev << EXYNOS_REV_PART_SHIFT) | sub_rev; =20 return 0; } =20 +static struct regmap *exynos_chipid_get_efuse_regmap(struct platform_devic= e *pdev) +{ + struct resource *res; + void __iomem *base; + + base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); + if (IS_ERR(base)) + return ERR_CAST(base); + + const struct regmap_config reg_config =3D { + .reg_bits =3D 32, + .reg_stride =3D 4, + .val_bits =3D 32, + .use_relaxed_mmio =3D true, + .max_register =3D (resource_size(res) - reg_config.reg_stride), + }; + + return devm_regmap_init_mmio_clk(&pdev->dev, "pclk", base, ®_config); +} + static void exynos_chipid_unregister_soc(void *data) { soc_device_unregister(data); @@ -127,7 +166,11 @@ static int exynos_chipid_probe(struct platform_device = *pdev) return dev_err_probe(dev, -EINVAL, "failed to get match data\n"); =20 - regmap =3D device_node_to_regmap(dev->of_node); + if (drv_data->efuse) + regmap =3D exynos_chipid_get_efuse_regmap(pdev); + else + regmap =3D device_node_to_regmap(dev->of_node); + if (IS_ERR(regmap)) return dev_err_probe(dev, PTR_ERR(regmap), "failed to get regmap\n"); @@ -177,19 +220,28 @@ static int exynos_chipid_probe(struct platform_device= *pdev) } =20 static const struct exynos_chipid_variant exynos4210_chipid_drv_data =3D { - .rev_reg =3D 0x0, .main_rev_shift =3D 4, .sub_rev_shift =3D 0, }; =20 static const struct exynos_chipid_variant exynos850_chipid_drv_data =3D { - .rev_reg =3D 0x10, + .main_rev_reg =3D 0x10, + .sub_rev_reg =3D 0x10, .main_rev_shift =3D 20, .sub_rev_shift =3D 16, }; =20 +static const struct exynos_chipid_variant gs101_chipid_drv_data =3D { + .sub_rev_reg =3D 0x10, + .sub_rev_shift =3D 16, + .efuse =3D true, +}; + static const struct of_device_id exynos_chipid_of_device_ids[] =3D { { + .compatible =3D "google,gs101-otp", + .data =3D &gs101_chipid_drv_data, + }, { .compatible =3D "samsung,exynos4210-chipid", .data =3D &exynos4210_chipid_drv_data, }, { --=20 2.52.0.322.g1dd061c0dc-goog