From nobody Sat Feb 7 22:21:19 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D524246BC6; Mon, 22 Dec 2025 12:20:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766406011; cv=none; b=j/mvTuAO5TpBKqEFKthEZRf5cBc5FCw0bofIbdWOdOx7XZQyE96m47BHrMrdrBoLkLE2uA89Lijw+sIYDZWtWdvEPmOT8PXOpvadQKfCLT2mB+h31LHEa2h9ucbgT5N7ZXVoTM02jDWUoibHggpx3/nKFPG3rb0Cw4M3oTtfBUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766406011; c=relaxed/simple; bh=xUbDYRMhRGvhEuJm/NydkAH3/SfSiO2L4qbftyB1Grc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=kPBJrhitNM4pkqeFgDxbUa97BErrj4GHnEMspzGChLvfObi2fkYeYn6C5vC0oiEPbvKOBcszr2Uc394VUe71a2JiZDYhHIK8dNGWS6ZUszGpZpkXjhsXgxiHhu/wRRXhtqUHKpubG3x9BcLsom1NWXSg+02rXyddVJOACUOZNKU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WxPgH3Tb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WxPgH3Tb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78C72C4CEF1; Mon, 22 Dec 2025 12:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766406011; bh=xUbDYRMhRGvhEuJm/NydkAH3/SfSiO2L4qbftyB1Grc=; h=From:Date:Subject:To:Cc:From; b=WxPgH3TbeDo3foUeQiDX3qnI3FSvuoqS+1+kd1cDo+3NE16ffUv3jBWNNRc48qOcv ynhfbYuuaT/xtHNUZ2drLfkvsT4dmE1qeUR7mILlRA7Pvcd7loR2HGyfLoGcNGsZG7 tlonpH0G5or+dDWmWvt+hVUz74KWXmRWoEITbLW3LkhNRnVrStT3xnj24WtQDrtbUx 3pwKsebO5+uZpLG4x0WNDLOl+uEF8cwuDrJTM2ue8jJdFtbG8dRrZRT9D1lG7na7pv ng3Bg+avHb852oZ3IfBjQm1qH4imaLsaoBFjVP58kOB2NqupVFlb0sbzI22hYFktgW JJ+9oQBldRWZA== From: Tamir Duberstein Date: Mon, 22 Dec 2025 13:20:05 +0100 Subject: [PATCH] gpu: nova-core: replace `kernel::c_str!` with C-Strings Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251222-cstr-nova-v1-1-0e2353d5debe@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMwQpAQBCA4VfRnG3ZEcmryGGNwTgs7SAl725x/ Orvv0A5CCvUyQWBD1FZfIRNE6DJ+ZGN9NGAGRYWEQ3pFoxfDmfI5q5isn1WVhD7NfAg5/dq2t+ 6dzPT9g7gvh+naKmVbQAAAA== X-Change-ID: 20251222-cstr-nova-c13a8ec1d068 To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter , Alexandre Courbot , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Tamir Duberstein , Greg Kroah-Hartman X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1766406007; l=3053; i=tamird@gmail.com; h=from:subject:message-id; bh=dUjHOkrrvsSc1u9P7jrlnCVchHjcZqseOJZTYW8zbyk=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QFOoY1nRi3XD+xbrraMdWOBTctqzUO+id/xxlMbErl10DPk89P1KTUKoGzzK9QYDvmuWu4vLYBL b6NB0ILdiOQA= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc From: Tamir Duberstein C-String literals were added in Rust 1.77. Replace instances of `kernel::c_str!` with C-String literals where possible. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Acked-by: Danilo Krummrich Reviewed-by: Alexandre Courbot Signed-off-by: Tamir Duberstein Reviewed-by: Daniel Almeida --- drivers/gpu/drm/nova/driver.rs | 12 +++++------- drivers/gpu/nova-core/driver.rs | 5 ++--- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs index 2246d8e104e0..d24ade17f7a0 100644 --- a/drivers/gpu/drm/nova/driver.rs +++ b/drivers/gpu/drm/nova/driver.rs @@ -1,8 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 =20 -use kernel::{ - auxiliary, c_str, device::Core, drm, drm::gem, drm::ioctl, prelude::*,= sync::aref::ARef, -}; +use kernel::{auxiliary, device::Core, drm, drm::gem, drm::ioctl, prelude::= *, sync::aref::ARef}; =20 use crate::file::File; use crate::gem::NovaObject; @@ -24,12 +22,12 @@ pub(crate) struct NovaData { major: 0, minor: 0, patchlevel: 0, - name: c_str!("nova"), - desc: c_str!("Nvidia Graphics"), + name: c"nova", + desc: c"Nvidia Graphics", }; =20 -const NOVA_CORE_MODULE_NAME: &CStr =3D c_str!("NovaCore"); -const AUXILIARY_NAME: &CStr =3D c_str!("nova-drm"); +const NOVA_CORE_MODULE_NAME: &CStr =3D c"NovaCore"; +const AUXILIARY_NAME: &CStr =3D c"nova-drm"; =20 kernel::auxiliary_device_table!( AUX_TABLE, diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver= .rs index b8b0cc0f2d93..5a4cc047bcfc 100644 --- a/drivers/gpu/nova-core/driver.rs +++ b/drivers/gpu/nova-core/driver.rs @@ -2,7 +2,6 @@ =20 use kernel::{ auxiliary, - c_str, device::Core, devres::Devres, dma::Device, @@ -82,7 +81,7 @@ fn probe(pdev: &pci::Device, _info: &Self::IdInfo) = -> impl PinInit())? }; =20 let bar =3D Arc::pin_init( - pdev.iomap_region_sized::(0, c_str!("nova-core/= bar0")), + pdev.iomap_region_sized::(0, c"nova-core/bar0"), GFP_KERNEL, )?; =20 @@ -90,7 +89,7 @@ fn probe(pdev: &pci::Device, _info: &Self::IdInfo) = -> impl PinInit