From nobody Mon Feb 9 12:24:21 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81197313E20 for ; Mon, 22 Dec 2025 10:22:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766398949; cv=none; b=Vj+/Lhik46mKqsFPTnUSBy1VwObRS3aAz/7eCqi7MtiP07WSacxB4GOQhBNKrYpXswElNiGGvBD4OmAFtj6JmR/xz1g/wjsTebAdu/3m74L/DWpDh7Ye+vHjfk//dvQNI4dRuOir7odk/AJp1JfSSAFke8JRqx8aLhbgLu8LMTk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766398949; c=relaxed/simple; bh=HBZKxM+L4XbIj/0bVAaLELAMW01kR1SncGYaCmbhxbc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kr5tKlaEAv9sryiP2x8YxJfHUsDlggSsXvyAJHs5w1dNzaGOCf1H+rgTFB6tKW5VwdHvJ3ewj3vjwcSnb9prS572KuYc8trK/KnJFJhTupRjWAfCQH1SYRonJ5er+vqk2JpXYGE5j51n3LuR2llEnadFnY2HgFPb/U6CLbrrmqo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Obal92Ib; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Obal92Ib" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-430f3ef2d37so2838490f8f.3 for ; Mon, 22 Dec 2025 02:22:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766398946; x=1767003746; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gV3ODo6F13X1bXwo/uKA4praO9ZfNmVtiFryiaGb6Gs=; b=Obal92IbbBkK8Neum8MgXm5UQUhWeJZhX8lMa6IbVSUUf5UgR/kb/SEE7vuP91oyXb MsD0ZHiIOif52k5lqjnlvXmbPBAQY4tVstQDqKoPI7gAyVW4mj1200ym3kaNaUqSYIBs YtSuAYExZn/i1p6+LmpCCZQOWRTjAX9k1hY73YTArCCwFc/eRDWh02W4We0387lLHZfI mA8sm+hBSkAv31YL1zfDr5GFviLmAltzRGwJjIW6ovMycJiR5TGeQBH0aHI0q7bJv84x fvpi/Ee07hBvSoqsPkjqhhiX3AWx4DuqqP6V6lLVO/2HrNFgcSbalKSWsNS39AwmmjL6 KxQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766398946; x=1767003746; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gV3ODo6F13X1bXwo/uKA4praO9ZfNmVtiFryiaGb6Gs=; b=RxxZL7fP5ZpTQGuA22JLrgVScL/AhETOvc9C6IhTK8dwiknmWCr+OtWJKe2NF7BLjE xhumJn65+CfWYPtPnhLNELkhrsqR40L4YbZq7EPwgk3Rk6Tdk36s8di3LMxRs9v9GGWa lzTOcoIae0uw1U9dRKOhETwQIKuHlbkpH+H8V56HkYTMKC6/lmRxbokGiOcpxH2qujG/ Nc0RHEstJ0BWHCyT92fe/327xLl1vWY5sIxfSYjcOOnM3juIkyLgOhGYJXgFz2HUoQtW nJuTj2k3jEf/eyOncg8O8eagRGtX8npRoBwF+VFf69zIEd+WQ34515VB/p/AVNaktK/6 xbZg== X-Forwarded-Encrypted: i=1; AJvYcCUsR8F9fdnHbG/BTVEgyT14iivS8Uay0YxVJlFGYupJMH/JcAqpdtZ0HKhNJCDZMTjxYLzob4Kz/BSu7dI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzw1HCixYOUYHMo1AlYTgC34KutLBLYM8S2gTP+0SJALCxrdKO3 ca3k2mh4QpK32dJmZlpWob+td8CQBfslIVYWS1r22mAteALa372yynMfvx4uwUw8X4k= X-Gm-Gg: AY/fxX5oYt9HNZsReUg9BmdKssXptev9oJxvC14FJ1t+BEvaD/ewgDxpyRWrIrLjHaf CsF+I00zyWpDpS9LPBXe4IyZZHL355Qfn2Qku2PUhF1Y3DOWvfQP1WnhWhoJNflAPKAw7GTGwSq N9txjCoyjycQ876GEr+RsckE/TKED28soE7/EP1kyE+agsJR70IxvrIjBXsdwYzxsQjPIn5SL+m 5RgmF/FSX0n2f11uj53u+gUCbEnOR8jiqwL20YFQ/b2WHD3lfbC8lyASyD9zB6HCwSwEV2UybbL zDHHvKREk/CwVfCINMCERcXGz0irhDXfR1jpvx0EJJIj9VResW9QlDgp3SOc8wIU31zTRY2M7aC IYdQoG/FJ+RlGiuclE9Y+O95ZJOjWFSyWx/xj48eut4OsghiTKgRak0ymJZZ1i98+WDFCzKU5wz hTF2fUKZKPteesnNyWjN9Wuc6tTTt/re7omkQRFM8= X-Google-Smtp-Source: AGHT+IGgiHPoZfvEvLMMkvb40+kGv1VyoyONqoU2+qFBxEmmPGJZxre1hXPXFrJ0WJGq4sn/Equgjw== X-Received: by 2002:a05:6000:4202:b0:430:fd9f:e6e2 with SMTP id ffacd0b85a97d-4324e4c3e3cmr11605703f8f.9.1766398945842; Mon, 22 Dec 2025 02:22:25 -0800 (PST) Received: from gpeter-l.roam.corp.google.com ([150.228.9.32]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea82feasm21082813f8f.24.2025.12.22.02.22.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 02:22:25 -0800 (PST) From: Peter Griffin Date: Mon, 22 Dec 2025 10:22:12 +0000 Subject: [PATCH v7 1/4] dt-bindings: clock: google,gs101-clock: add samsung,sysreg property as required Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251222-automatic-clocks-v7-1-fec86fa89874@linaro.org> References: <20251222-automatic-clocks-v7-0-fec86fa89874@linaro.org> In-Reply-To: <20251222-automatic-clocks-v7-0-fec86fa89874@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , =?utf-8?q?Andr=C3=A9_Draszik?= , Tudor Ambarus , Michael Turquette , Stephen Boyd , Sam Protsenko , Sylwester Nawrocki , Chanwoo Choi Cc: Will McVicker , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, kernel-team@android.com, Peter Griffin , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3035; i=peter.griffin@linaro.org; h=from:subject:message-id; bh=HBZKxM+L4XbIj/0bVAaLELAMW01kR1SncGYaCmbhxbc=; b=owEBbQKS/ZANAwAKAc7ouNYCNHK6AcsmYgBpSRvdg60hfuVcDiZdNu950EdMWZySiihRxtyx3 EfLG5mp+eOJAjMEAAEKAB0WIQQO/I5vVXh1DVa1SfzO6LjWAjRyugUCaUkb3QAKCRDO6LjWAjRy utr3EACTGOAhJ1hCnCIVqJuSlu7QQ6AwrTPxufUoAzWVwcfqf8wjAG8/xe1khihoZz9SZ3O0RwG wEphnvoXD2NDEPUIteALxG5wUbu+3ottY+wRK4JU3jGRZeJ3TLaCNdJ5CKMElRVNVejVz9glVgw 6VE9bux7U+ZF3c6m4HwxqhXJhK0b92xnyKg9+dxB9qtbDvtoNMr8G8SXKsZvzFEbpNBCmeJLsUP YBcrVOLcavMFiEDVRox0BTXLOJjGezKsstV7NcHAcdSkQwwHvl8AlW50ezGh2W3nzs+I6l9zbxG AwiW713NWeb1h17mFZnKzLAlVG+JZnZxz4Qxv6AMmfnjxno5PxHoh9w7k4hpMJwg5oTwNfSrpTu dHjbL2xqwfKPLAj3Wy/gEcjgchqy8BZs33rbyvyScai7Hmv7SqBFyPOIoDVNAD4fWstsgxg7ME7 yvMe5IenPbHfF/hc28u4u+SYySU8DqLpyY9fHD7Ca0XW383DwC3aBKYKt04eVHB4jBanfN1pEEj HRjFpGHCRsOgGgfWUhS1jITkKYf8UHNslBftN3etW7HLW+dVre3CErFb7cdeGADIpek3EaaVuA8 YHUOEpsPCL5gvHQAybewVbWL71RipmUH7EyWPU5lIFABMrF5ZwFIhj9UvK3qSc+pbQ8p1qsfHKt FHwMq1yGPZZB5dw== X-Developer-Key: i=peter.griffin@linaro.org; a=openpgp; fpr=0EFC8E6F5578750D56B549FCCEE8B8D6023472BA Each CMU (with the exception of cmu_top) has a corresponding sysreg bank that contains the BUSCOMPONENT_DRCG_EN and optional MEMCLK registers. The BUSCOMPONENT_DRCG_EN register enables dynamic root clock gating of bus components and MEMCLK gates the sram clock. Now the clock driver supports automatic clock mode, to fully enable dynamic root clock gating it is required to configure these registers. Update the bindings documentation so that all CMUs (with the exception of gs101-cmu-top) have samsung,sysreg as a required property. Note this is NOT an ABI break, as if the property isn't specified the clock driver will fallback to the current behaviour of not initializing the registers. The system still boots, but bus components won't benefit from dynamic root clock gating and dynamic power will be higher (which has been the case until now anyway). Additionally update the DT example to included the correct CMU size as registers in that region are used for automatic clock mode. Acked-by: Rob Herring (Arm) Reviewed-by: Andr=C3=A9 Draszik Reviewed-by: Rob Herring (Arm) Signed-off-by: Peter Griffin --- Changes in v5: - Invert the test for google,gs101-cmu-top (Andre) Changes in v4 - Update commit description with additional requested details (Krzysztof) Changes in v3: - Update commit description as to why the sysreg is required (Krzysztof) Changes in v2: - Update commit description regarding updated example (Andre) --- .../devicetree/bindings/clock/google,gs101-clock.yaml | 19 +++++++++++++++= +++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yam= l b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml index 31e106ef913dead9a038b3b6d8b43b950587f6aa..09e679c1a9def03d53b8b493929= 911ea902a1763 100644 --- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml @@ -52,6 +52,11 @@ properties: reg: maxItems: 1 =20 + samsung,sysreg: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to system registers interface. + required: - compatible - "#clock-cells" @@ -166,6 +171,18 @@ allOf: - const: bus - const: ip =20 + - if: + properties: + compatible: + contains: + const: google,gs101-cmu-top + then: + properties: + samsung,sysreg: false + else: + required: + - samsung,sysreg + additionalProperties: false =20 examples: @@ -175,7 +192,7 @@ examples: =20 cmu_top: clock-controller@1e080000 { compatible =3D "google,gs101-cmu-top"; - reg =3D <0x1e080000 0x8000>; + reg =3D <0x1e080000 0x10000>; #clock-cells =3D <1>; clocks =3D <&ext_24_5m>; clock-names =3D "oscclk"; --=20 2.52.0.351.gbe84eed79e-goog