From nobody Tue Feb 10 20:28:33 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1853E25CC7A for ; Sun, 21 Dec 2025 21:36:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766353006; cv=none; b=OSmmJv41wBH2KJYIPFf1Nstxs6+gCDL8bR5395c38RmquCARHC/HPHpw2JTfPvig30quGy6ohFh7OrcTTj4dRs+18P+myNJnqODE+S7pPNn32AEBI9tcJPu/jMBZYB2vt15GmqSwWIlVVyKzqdxQQk4OPaDXSEog775fIFaJj3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766353006; c=relaxed/simple; bh=76x0waUT0Gi8/G+fPPa1V6w6ovWJhH1EZ6CFW2yDzKI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lSjufGYS5LN8zcNixAezk3yBzgVoOePOjyikvsyo+Anw+4iSh14WI+y1vM+HDmtvTlGL6KH6RxhVdn/4z+qMHh785AbwpNiC/fTLC1hOzHsTPhGGlL5la2gTZW8N3Xm0rJA0YfwgDdCT7a7Iz2PmgE/76XgKgmmhIEwFk/XNyTk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IcPyaoZf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bVXVGK0x; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IcPyaoZf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bVXVGK0x" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BLLGP9g1157964 for ; Sun, 21 Dec 2025 21:36:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=lTfUooU6YQ/ 6LN/6Wkk5DxaIFgRPD3nxUH9oNYW4Q6s=; b=IcPyaoZfxMeMxuH0tA75qrQ/t7f y5JuT69+LLOSAtvMdivQPIiRrgjFrtDwZH1A78hHwzOt7zoDcFZoCJuxFytpB9uZ aqSws+3dz2oEmEpsAviFZ7AjPBGelQNJ7BTWgRz9kkFp5vHOELcsJu0ssiFl970v 37xRrv2QyIPbwzQrveMZ1QGIcN5a1L3o9QzTZLxNtzCk+rny3oKk4GncUXgHZ2Qu KmwiBJWHD7Eg7j/cN/Kh0myZS4RwSYckL9ZgZfIFlCYgRauHNobo1f0kGfHvhr5s 71IBE7cy1Nqn23T1vOX0Nxqpg90nF3mrqwEPkoMDJ2EkKz6CFM0qHyZ2Cvw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b5mydtwnb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 21 Dec 2025 21:36:43 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-34e5a9f0d6aso3139262a91.0 for ; Sun, 21 Dec 2025 13:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766353003; x=1766957803; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lTfUooU6YQ/6LN/6Wkk5DxaIFgRPD3nxUH9oNYW4Q6s=; b=bVXVGK0xU3n6yFMLlYeD37HxGQ4bdYPStlGGL2vHypjDcJdNDbb9RFHpLtAWya46Vd Na7hPi8srVW/o5Ra4fyDjLY0HnYlb+GCGx4woPI8s+SD5gKb9+Qm8qruhOuOHiceC2Ql THbdku1hxPjqYwH/+9LTiRIX9+6Y1XwQVes+r5nHx/2nIdiQdAyWoRI/rtbb3Bq/z80z p4+n5xSidFJsGRRMc3W5HIjJHxJ9ec8FPItKiDtaGi4bNqHMr6Ji8UsgsgDMopCKL7r3 CJg9waOl8/moKiBVcf0bsazr6BRjfNH49Uvh7cbunYUtjgCsnR86fIAhLm11PJ9oBWVp +DDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766353003; x=1766957803; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lTfUooU6YQ/6LN/6Wkk5DxaIFgRPD3nxUH9oNYW4Q6s=; b=wFlZVQYw6LXuvlSs6hY4KCFCzTY9mNJUcG29tXtYObjN6/5IuTEPzhYN2U30j6xIb+ KLexasjgnxBeCX3LuKP8TR5hqfU7QZ5H1Fw7SFDd/zkvfnuS6yeC0OtYsRlLON8Z/biZ zVdzhkXJf1gyEa0abuQdFINp5MkuM4bAS1mPMo/9+FoTdTqIT7NtTlvZvLTyP8uSPNX8 0+keIwIqgOiycAidZIQ4TdT1rC40MHzE+w7f07WCsbIA/omLJ8XdtOUG0DGCXVHbBf0+ ZcRl93g/zt6cVPiVR7WZI9T10IbaE8r/iG9Ap6Z1N27wxm9v53PwxyoQ/k4KdeEtKF/W 8I9Q== X-Forwarded-Encrypted: i=1; AJvYcCWgoFTAOuamSpAWhyjhIXECU0rXg5ohDs2lIaF2dJdjfwBVMPode3wS+Ze/T7Bv4aqwwX3xhsWR3p5vr8Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxJDK3K3LN6X5Pjy6MeK1+F6kb4I6TqF71gcAxOOdQKBFb40Tmy VVdftqDFYwN33QYlo70sUcscyXFJ835hyNG2N5E6yN30zW+Z+5W2ewriczMo06iyo5rJF6g5Z9U DqXUjvUMpivWTcJ0t/AdOVpSs/X5DkH+UPTXNnNTWos4ac/7YEkAHGqdaReltWgcZME8= X-Gm-Gg: AY/fxX7kRwLoMma84JXhWmJ96xho3uzUIN+yt1pkKgNX0mSnqpqag7tAV/WuxBK+zS9 q7XtsHt4UejwNQ56L/rds1OvuJCLkRE6gz+izFeUPB+tPVzQy06ltBiejE3+JleMg4LQZx6NRR5 MTlZh20yBlTlDQz16lqLyEN49ARdetkpCo/KxZeaYxPJfm4U3xYmkXf7pq0ZKMtdtO8+xxunFco 6TeWTeHhe827NGyaSLrY3qfmu4CiphMoBmIivjgRU6hOTOGZQnd1smWRJFcPMPcJp/xxI1dClO1 /h2hCTTdlXO+CcFhvwRIANx2eL6Yx7F3+B/S0C5Vbyen9zluAqO1bVB5AnGzlW/Vdjv6y1Ktj0Y eL4aHyRPm8hzTGTlFtBCdj8icM0za7of8+6fUu7TY8IwB X-Received: by 2002:a17:90b:2cce:b0:343:6a63:85d5 with SMTP id 98e67ed59e1d1-34e90de2570mr8296069a91.16.1766353002574; Sun, 21 Dec 2025 13:36:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IExqI7Jno+XhZu6DZAHUuo8szMM/almYtDUdvO8izu0OaxMl7ybeXGhn2dL8JLTkTnp/7rKSg== X-Received: by 2002:a17:90b:2cce:b0:343:6a63:85d5 with SMTP id 98e67ed59e1d1-34e90de2570mr8296045a91.16.1766353002020; Sun, 21 Dec 2025 13:36:42 -0800 (PST) Received: from hu-vjitta-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34e70dcc7c8sm10950163a91.15.2025.12.21.13.36.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 13:36:41 -0800 (PST) From: Vijayanand Jitta To: robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, robh@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com, bod@kernel.org, conor+dt@kernel.org, krzk+dt@kernel.org, saravanak@google.com, prakash.gupta@oss.qualcomm.com, vikash.garodia@oss.qualcomm.com Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Vijayanand Jitta Subject: [PATCH v3 3/3] of: Respect #{iommu,msi}-cells in maps Date: Mon, 22 Dec 2025 03:06:02 +0530 Message-Id: <20251221213602.2413124-4-vijayanand.jitta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251221213602.2413124-1-vijayanand.jitta@oss.qualcomm.com> References: <20251221213602.2413124-1-vijayanand.jitta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: e9J4lv0OdUHP5uP3VXYFuW2RZ0ATLdCc X-Proofpoint-ORIG-GUID: e9J4lv0OdUHP5uP3VXYFuW2RZ0ATLdCc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIxMDIwNCBTYWx0ZWRfX1QwYakjAUjlJ doISELR76YIbT4T4cEN5CItpov2rQgRhxUoBL+lUdjPqCBPr+fyx+tQHzYt1lPX6n86UNCk1BHb j5DLkxv444WwJGzfbF42j+a6cfgOWfqiMYxBcd5AYvsoBklbuhLx7KJGWsrm4T66RWYKL46XzSY TVaFMDT2Lx8HAra4Kgh0gFEoictvnnbuLsHOXS+EQiNSQ2FsgzmJgDjNZcnj9ogx9VY7QkJFNtW JVtqLTQo3KYFmh7T2cgPNt/hp5to6+1mHHCWL8m1sopvwMv9VY/XQM3pgP5N1JvfPeQ/mKE5jdj Nlw67Ho01aa9VUlutyD9aB/ZFobZUHdF/lqP5Q82SH8KV2+0g/8IAwUr0+KdfnVyYsOUJ/V/tur tJyGo2Di++DOf6YyXxkeJ/pQ8DMUsK06R+t8mTeIcP6aL+rzGgW3ER4M/gvP+eFHUcgMfXzEOPl N16trChYYg912XLQoHQ== X-Authority-Analysis: v=2.4 cv=N6wk1m9B c=1 sm=1 tr=0 ts=6948686b cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=7CQSdrXTAAAA:8 a=EUspDBNiAAAA:8 a=wJGdY9mNwEi-N7fqGJcA:9 a=mQ_c8vxmzFEMiUWkPHU9:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-21_05,2025-12-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512210204 Content-Type: text/plain; charset="utf-8" From: Robin Murphy So far our parsing of {iommu,msi}-map properites has always blindly asusmed that the output specifiers will always have exactly 1 cell. This typically does happen to be the case, but is not actually enforced (and the PCI msi-map binding even explicitly states support for 0 or 1 cells) - as a result we've now ended up with dodgy DTs out in the field which depend on this behaviour to map a 1-cell specifier for a 2-cell provider, despite that being bogus per the bindings themselves. Since there is some potential use in being able to map at least single input IDs to multi-cell output specifiers (and properly support 0-cell outputs as well), add support for properly parsing and using the target nodes' #cells values, albeit with the unfortunate complication of still having to work around expectations of the old behaviour too. Since there are multi-cell output specifiers, the callers of of_map_id() may need to get the exact cell output value for further processing. Added support for that part --charan Signed-off-by: Robin Murphy Signed-off-by: Vijayanand Jitta --- drivers/iommu/of_iommu.c | 2 +- drivers/of/base.c | 116 +++++++++++++++++++++++++++++++-------- include/linux/of.h | 16 +++--- 3 files changed, 102 insertions(+), 32 deletions(-) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index 74779b77ba13..ece830ec4c19 100644 --- a/drivers/iommu/of_iommu.c +++ b/drivers/iommu/of_iommu.c @@ -45,7 +45,7 @@ static int of_iommu_configure_dev_id(struct device_node *= master_np, struct device *dev, const u32 *id) { - struct of_phandle_args iommu_spec =3D { .args_count =3D 1 }; + struct of_phandle_args iommu_spec =3D {}; struct of_map_id_arg arg =3D { .map_args =3D iommu_spec, }; diff --git a/drivers/of/base.c b/drivers/of/base.c index 4dca3d37a34b..aedff1c03995 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -2045,11 +2045,38 @@ int of_find_last_cache_level(unsigned int cpu) return cache_level; } =20 +/* + * Some DTs have an iommu-map targeting a 2-cell IOMMU node while + * specifying only 1 cell. Fortunately they all consist of value '1' + * as the 2nd cell entry with the same target, so check for that pattern. + * + * Example: + * IOMMU node: + * #iommu-cells =3D <2>; + * + * Device node: + * iommu-map =3D <0x0000 &smmu 0x0000 0x1>, + * <0x0100 &smmu 0x0100 0x1>; + */ +static bool of_check_bad_map(const __be32 *map, int len) +{ + __be32 phandle =3D map[1]; + + if (len % 4) + return false; + for (int i =3D 0; i < len; i +=3D 4) { + if (map[i + 1] !=3D phandle || map[i + 3] !=3D cpu_to_be32(1)) + return false; + } + return true; +} + /** * of_map_id - Translate an ID through a downstream mapping. * @np: root complex device node. * @id: device ID to map. * @map_name: property name of the map to use. + * @cells_name: property name of target specifier cells. * @map_mask_name: optional property name of the mask to use. * @arg: contains the optional params, wrapped in a struct of_phandle_args, * which includes: @@ -2067,18 +2094,19 @@ int of_find_last_cache_level(unsigned int cpu) * * Return: 0 on success or a standard error code on failure. */ -int of_map_id(const struct device_node *np, u32 id, - const char *map_name, const char *map_mask_name, - struct of_map_id_arg *arg) +int of_map_id(const struct device_node *np, u32 id, const char *map_name, + const char *cells_name, const char *map_mask_name, + struct of_map_id_arg *arg) { u32 map_mask, masked_id; - int map_len; + int map_bytes, map_len, offset =3D 0; + bool bad_map =3D false; const __be32 *map =3D NULL; =20 if (!np || !map_name || !arg || (!arg->map_args.np && !arg->map_args.args= )) return -EINVAL; =20 - map =3D of_get_property(np, map_name, &map_len); + map =3D of_get_property(np, map_name, &map_bytes); if (!map) { if (arg->map_args.np) return -ENODEV; @@ -2087,11 +2115,9 @@ int of_map_id(const struct device_node *np, u32 id, return 0; } =20 - if (!map_len || map_len % (4 * sizeof(*map))) { - pr_err("%pOF: Error: Bad %s length: %d\n", np, - map_name, map_len); - return -EINVAL; - } + if (map_bytes % sizeof(*map)) + goto err_map_len; + map_len =3D map_bytes / sizeof(*map); =20 /* The default is to select all bits. */ map_mask =3D 0xffffffff; @@ -2104,27 +2130,64 @@ int of_map_id(const struct device_node *np, u32 id, of_property_read_u32(np, map_mask_name, &map_mask); =20 masked_id =3D map_mask & id; - for ( ; map_len > 0; map_len -=3D 4 * sizeof(*map), map +=3D 4) { + while (offset < map_len) { struct device_node *phandle_node; - u32 id_base =3D be32_to_cpup(map + 0); - u32 phandle =3D be32_to_cpup(map + 1); - u32 out_base =3D be32_to_cpup(map + 2); - u32 id_len =3D be32_to_cpup(map + 3); + u32 id_base, phandle, id_len, id_off, cells =3D 0; + const __be32 *out_base; + + if (map_len - offset < 2) + goto err_map_len; + + id_base =3D be32_to_cpup(map + offset); =20 if (id_base & ~map_mask) { - pr_err("%pOF: Invalid %s translation - %s-mask (0x%x) ignores id-base (= 0x%x)\n", - np, map_name, map_name, + pr_err("%pOF: Invalid %s translation - %s (0x%x) ignores id-base (0x%x)= \n", + np, map_name, map_mask_name, map_mask, id_base); return -EFAULT; } =20 - if (masked_id < id_base || masked_id >=3D id_base + id_len) - continue; =20 + phandle =3D be32_to_cpup(map + offset + 1); phandle_node =3D of_find_node_by_phandle(phandle); if (!phandle_node) return -ENODEV; =20 + if (!bad_map && of_property_read_u32(phandle_node, cells_name, &cells)) { + pr_err("%pOF: missing %s property\n", phandle_node, cells_name); + return -EINVAL; + } + + if (map_len - offset < 3 + cells) + goto err_map_len; + + if (offset =3D=3D 0 && cells =3D=3D 2) { + bad_map =3D of_check_bad_map(map, map_len); + if (bad_map) { + pr_warn_once("%pOF: %s mismatches target %s, assuming extra cell of 0\= n", + np, map_name, cells_name); + cells =3D 1; + } + } + + out_base =3D map + offset + 2; + offset +=3D 3 + cells; + + id_len =3D be32_to_cpup(map + offset - 1); + if (id_len > 1 && cells > 1) { + /* + * With 1 output cell we reasonably assume its value + * has a linear relationship to the input; with more, + * we'd need help from the provider to know what to do. + */ + pr_err("%pOF: Unsupported %s - cannot handle %d-ID range with %d-cell o= utput specifier\n", + np, map_name, id_len, cells); + return -EINVAL; + } + id_off =3D masked_id - id_base; + if (masked_id < id_base || id_off >=3D id_len) + continue; + if (arg->map_args.np) of_node_put(phandle_node); else @@ -2133,12 +2196,15 @@ int of_map_id(const struct device_node *np, u32 id, if (arg->map_args.np !=3D phandle_node) continue; =20 - if (arg->map_args.args) - *arg->map_args.args =3D masked_id - id_base + out_base; + for (int i =3D 0; arg->map_args.args && i < cells; i++) + arg->map_args.args[i] +=3D (id_off + be32_to_cpu(out_base[i])); + + if (arg->map_args.args_count) + arg->map_args.args_count =3D cells; =20 pr_debug("%pOF: %s, using mask %08x, id-base: %08x, out-base: %08x, leng= th: %08x, id: %08x -> %08x\n", - np, map_name, map_mask, id_base, out_base, - id_len, id, masked_id - id_base + out_base); + np, map_name, map_mask, id_base, be32_to_cpup(out_base), + id_len, id, id_off + be32_to_cpup(out_base)); return 0; } =20 @@ -2149,5 +2215,9 @@ int of_map_id(const struct device_node *np, u32 id, if (arg->map_args.args) *arg->map_args.args =3D id; return 0; + +err_map_len: + pr_err("%pOF: Error: Bad %s length: %d\n", np, map_name, map_bytes); + return -EINVAL; } EXPORT_SYMBOL_GPL(of_map_id); diff --git a/include/linux/of.h b/include/linux/of.h index 0b0d545b80a3..ee07e8642133 100644 --- a/include/linux/of.h +++ b/include/linux/of.h @@ -460,9 +460,9 @@ const char *of_prop_next_string(const struct property *= prop, const char *cur); =20 bool of_console_check(const struct device_node *dn, char *name, int index); =20 -int of_map_id(const struct device_node *np, u32 id, - const char *map_name, const char *map_mask_name, - struct of_map_id_arg *arg); +int of_map_id(const struct device_node *np, u32 id, const char *map_name, + const char *cells_name, const char *map_mask_name, + struct of_map_id_arg *arg); =20 phys_addr_t of_dma_get_max_cpu_address(struct device_node *np); =20 @@ -909,9 +909,9 @@ static inline void of_property_clear_flag(struct proper= ty *p, unsigned long flag { } =20 -static inline int of_map_id(const struct device_node *np, u32 id, - const char *map_name, const char *map_mask_name, - struct of_map_id_arg *arg) +static inline int of_map_id(const struct device_node *np, u32 id, const ch= ar *map_name, + const char *cells_name, const char *map_mask_name, + struct of_map_id_arg *arg); { return -EINVAL; } @@ -1442,7 +1442,7 @@ static inline int of_property_read_s32(const struct d= evice_node *np, static inline int of_map_iommu_id(const struct device_node *np, u32 id, struct of_map_id_arg *arg) { - return of_map_id(np, id, "iommu-map", "iommu-map-mask", arg); + return of_map_id(np, id, "iommu-map", "#iommu-cells", "iommu-map-mask", a= rg); } =20 static inline int of_map_msi_id(const struct device_node *np, u32 id, @@ -1456,7 +1456,7 @@ static inline int of_map_msi_id(const struct device_n= ode *np, u32 id, }, }; =20 - return of_map_id(np, id, "msi-map", "msi-map-mask", &arg); + return of_map_id(np, id, "msi-map", "#msi-cells", "msi-map-mask", &arg); } =20 #define of_for_each_phandle(it, err, np, ln, cn, cc) \ --=20 2.34.1