From nobody Mon Feb 9 11:47:49 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DACF621883E for ; Sun, 21 Dec 2025 02:52:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766285575; cv=none; b=iaiSPcn/5iA4FcroRKVft6KJovdHWvzBeElqLmQ+zxdI2M5CdTIbv4mtLm/uoGAEA5Mz5UDUzUizY/t4r6Zf38nIxKwKQ7U8cmfi2ZvNgiwmxh4C/NlN2R2zwfYocPR7W3VguS+ea56e0ELfiMb06fZWBhP54MGde8deD/ih6ao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766285575; c=relaxed/simple; bh=s2FKoMxZd739dCzhmdB8JVLEUJx/RdFLnNDGdbuTA+s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HK9YCwUueX4s0oqkjCVulL0vTdrSnmmUAZyaS5JJr/qc1nc0YMETYOkuvunnuVsyEBWhXyCFBygss2cMWURtcdyU9LQW/2jP27ciZR9RVgqqWcV2HqToRZZjh0DHVOU9MtxA/V4nmt5VvoisHTFWHGZ5PV1Vdo5KyScVsa6ZhuI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BRHHYYbY; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BRHHYYbY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766285572; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z84twE+0dmUFQawUihISJPCYSTL4dhggfdILlETnyIY=; b=BRHHYYbYLQPXf7bJc892Ym5lyY4B+/U9fq3V6YFJdSbX6yWbh4fXuOY8eiM080uRWLyLqX YycSduvjQhsAaRr9QVAuhwzAk1EZiGHYAlbhcRx6RKxr5ShNwLqMGC7h/Atezy2zVhQOCZ Bb08ohsVOMBGH1HrnaZvZcl7KL7dF+M= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-iB9QqN7SOFaqUEEFzmQTgg-1; Sat, 20 Dec 2025 21:52:49 -0500 X-MC-Unique: iB9QqN7SOFaqUEEFzmQTgg-1 X-Mimecast-MFC-AGG-ID: iB9QqN7SOFaqUEEFzmQTgg_1766285567 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 341301956088; Sun, 21 Dec 2025 02:52:47 +0000 (UTC) Received: from pasta.fast.eng.rdu2.dc.redhat.com (unknown [10.44.32.8]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 863B8180049F; Sun, 21 Dec 2025 02:52:43 +0000 (UTC) From: Andreas Gruenbacher To: Christoph Hellwig , Jens Axboe , Chris Mason , David Sterba , Satya Tangirala Cc: Andreas Gruenbacher , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-raid@vger.kernel.org, dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: [RFC v2 02/17] bio: rename bio_chain arguments Date: Sun, 21 Dec 2025 03:52:17 +0100 Message-ID: <20251221025233.87087-3-agruenba@redhat.com> In-Reply-To: <20251221025233.87087-1-agruenba@redhat.com> References: <20251221025233.87087-1-agruenba@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Content-Type: text/plain; charset="utf-8" Use the same argument names in bio_chain() as in bio_chain_and_submit() to be consistent. Slightly improve the function description. Signed-off-by: Andreas Gruenbacher Reviewed-by: Christoph Hellwig --- block/bio.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/block/bio.c b/block/bio.c index b3a79285c278..3f408e1ba13f 100644 --- a/block/bio.c +++ b/block/bio.c @@ -327,22 +327,22 @@ static void bio_chain_endio(struct bio *bio) =20 /** * bio_chain - chain bio completions - * @bio: the target bio - * @parent: the parent bio of @bio + * @prev: the bio to chain + * @new: the bio to chain to * - * The caller won't have a bi_end_io called when @bio completes - instead, - * @parent's bi_end_io won't be called until both @parent and @bio have - * completed; the chained bio will also be freed when it completes. + * The caller won't have a bi_end_io called when @prev completes. Instead, + * @new's bi_end_io will be called once both @new and @prev have completed. + * Like an unchained bio, @prev will be put when it completes. * - * The caller must not set bi_private or bi_end_io in @bio. + * The caller must not set bi_private or bi_end_io in @prev. */ -void bio_chain(struct bio *bio, struct bio *parent) +void bio_chain(struct bio *prev, struct bio *new) { - BUG_ON(bio->bi_private || bio->bi_end_io); + BUG_ON(prev->bi_private || prev->bi_end_io); =20 - bio->bi_private =3D parent; - bio->bi_end_io =3D bio_chain_endio; - bio_inc_remaining(parent); + prev->bi_private =3D new; + prev->bi_end_io =3D bio_chain_endio; + bio_inc_remaining(new); } EXPORT_SYMBOL(bio_chain); =20 --=20 2.52.0