From nobody Mon Feb 9 09:33:15 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D91BF280324 for ; Sun, 21 Dec 2025 09:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766309836; cv=none; b=OoHlIMq7Mihb+rgnDteIMt2Jbf/aQJ4mK6YrsY0bnZ5sEWOJeXZDxjPsGPwbwl1u5CqvIsfNezgyF9tB82L9/r/+teHkPmOKuS0MegmLsGvy7PjgTD1EUs+CVfvddck5XaMF0xFg0v8mkPLPhLtYqoMKoQkWYf1gkzeuPGlt/gE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766309836; c=relaxed/simple; bh=BcCWaQDqk2hqFZcbljTe5TshvfrnYl4MYwks/r0wuug=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mDdvCwftXx3MpqJhcn5i9aLVFl54gk9kDkDgJ9Fs28uipHbcOirK7IRdyOxUX5KuWA17FkcHgdwovIuQMBC2hTx6oCogrfuZcA0wUaqL1qSUw7/o3u0097MidJbgiLV4DYPeP0Gp5UmJ8rfMamAGIEn2KCE04DkWhHlZspnZJqY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fRoR1zCb; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fRoR1zCb" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-29f30233d8aso39208275ad.0 for ; Sun, 21 Dec 2025 01:37:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766309833; x=1766914633; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=V5a5A+6f9bpZxYjLZ9S9FAbY+lPxNj4oyHeruadBhzY=; b=fRoR1zCbrhSm/ioatDa7PKrmUQ7gPp+XJUmKiZR0XjCBLwwwP4tO0Bz7bVUhAA1jtx g2KmbBkGaxNZcbxc5EJB61wa4z4KAD+sHDWA2hYmJ86Lgn3B4YyDkomV0MwZu3bdHUhZ 9C6Tyb3DiceK91CcIBgRIYy1+WpMgP5m8Gg8wpkXmr6FlPsF+nCQ/VZS9fPMPsjMXSEu XPUn7SzaYzVOxk2j5CrCrkApDyKrOZLcnwXDRRlzL5eGZjEtys7hccEKo2845M9xesXl O7gholAnrKJZ1ojcARk1aNqAQScwoA6G3z/UtFVHf2CL03PFXh31bOZZiW2GFi62D9D2 ZLVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766309833; x=1766914633; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=V5a5A+6f9bpZxYjLZ9S9FAbY+lPxNj4oyHeruadBhzY=; b=Y77Cual9xgG5W98kmFgpV2qu5PuZs5coPHRHINIDN6PC8SAz1mCqzOTLRl2M0eA1r4 XGvN5xgz96IMdSjbWx+b+N10/uw3LG8Cnt48qbdxXHXs7Rrdn3wK5QKB6FRb6BDHJCtQ TrB7X7I3XhFyH8VgqD3QH3bdFJAIlrUfImIZTqWowwbFC68iSEv6+c8cxUz2kydfH7Jq 0NLr9PrLkUIqrVFYpP7H+ujTjXacITtWF8/L1bbzxYVaRWzX+SDTyrTEvdvD5OkbGHOt jdO1TJ5+URto5HvSqkz7MGGCAD4PDNSYTr6LHzqcuyCyLS/9a7HLsZnASw8WYgh3llKM GZtQ== X-Forwarded-Encrypted: i=1; AJvYcCWmmYX85vUkYWeAyzJJ1+Rgn6/SblnaiY5ymFzrTGp+ezJSTk4U/ixBRKgDHXGyJPD1ldD3OPCi3SaT6mM=@vger.kernel.org X-Gm-Message-State: AOJu0YxHrujv2j2os3agyQi9j2BMSFVVpkaOZ8LsuWyR7M1GmUHkKw6z vZgCAlkRxJCd7txGTuufBFEte/h4Svcu2WZkXY2LVDHCBCzax6ogTO4J X-Gm-Gg: AY/fxX59Qx6q26CB+0bzCbllsBMP00M4/Kc1vEGYSYY34WP7XD///ewPR3wBW1786Vg DvSxGAxq5rRQgdVOeae7YUyvIGq7zWm2wyMJwW0LHkofpum5x31xqcHhvm1v64YHnv/VRoSzFzx sanEbuDJj9ml/WyACmyoho1M7YgBKXz6xr0k/lj468haGlmGW38ecXvnoIE88DPvuf+oYKsqtzS Re0QnUZ1g8Q4OyyAozks2a8dr0UJFY8ZYyAo+p1BDASl8jh4AscNwNCBorTJjfsCALrrV7Pxu1t HKvphti1Q+Ii+A036rBKj3Ua/NtnyNa6vQiDJUgoYyWzzd8lq2KVMOeAF0HEVblGDfvpcuZCusz jv/27JJR7vgpxBT2fu3DA2uRkiANe4abgXxcks8Rgs9xTIqAKjOD8frGXUX37XsqqdxEcPxh37D SApFYYcehAJvBptztrv6D64QbGhXd9mYAHHoEFWEG2fq3VFozhZVjzFVvF4z4N6x1GpOYsM9ABm ovYuxw6MtjqZDdF4efGjBrJ9MxBdkfPd/FAlSC8y6YnTSw69HoeAMjuUUeGuJukE6k5I7+c3mU9 EMl4seZ2pgIrZ+tO0IivQm0bv6ltOyX7+s//7RGBBI+XrraR3UQ= X-Google-Smtp-Source: AGHT+IGMdyycbEEhzOfaP2Ty3g+HwuUlrykYJWMidFb++M717umnxFkAmzfzB53xMVODmVdckFRerQ== X-Received: by 2002:a17:903:4b47:b0:2a0:e94e:5df6 with SMTP id d9443c01a7336-2a2f28335ffmr80140275ad.50.1766309832723; Sun, 21 Dec 2025 01:37:12 -0800 (PST) Received: from [192.168.2.3] (2403-580a-80ed-0-4835-5a07-49e7-f115.ip6.aussiebb.net. [2403:580a:80ed:0:4835:5a07:49e7:f115]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d4d363sm67629495ad.62.2025.12.21.01.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 01:37:12 -0800 (PST) From: James Calligeros Date: Sun, 21 Dec 2025 19:36:02 +1000 Subject: [PATCH v2 6/7] ASoC: tas2764: expose SDOUT bus keeper via set_tdm_idle operation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251221-tdm-idle-slots-v2-6-ed4d96413aec@gmail.com> References: <20251221-tdm-idle-slots-v2-0-ed4d96413aec@gmail.com> In-Reply-To: <20251221-tdm-idle-slots-v2-0-ed4d96413aec@gmail.com> To: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Kuninori Morimoto , Shengjiu Wang , Jaroslav Kysela , Takashi Iwai , Shenghao Ding , Kevin Lu , Baojun Xu Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, James Calligeros X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4983; i=jcalligeros99@gmail.com; h=from:subject:message-id; bh=BcCWaQDqk2hqFZcbljTe5TshvfrnYl4MYwks/r0wuug=; b=owGbwMvMwCV2xczoYuD3ygTG02pJDJnu+yeXTb3J8Yz9vVX1g5YygxSGhRIJQhKv88V+6ynkl dry++d1TGRhEONisBRTZNnQJOQx24jtZr9I5V6YOaxMIEOkRRoYgICFgS83Ma/USMdIz1TbUM/Q UMdYx4iBi1MApprhFMNvVq/fM9f3TeT60aaX+KHjVf/r6Qtvvb8j2Dvd+sMcxi2z4hgZ2o7JaDE r9c45+PQi8yW9U247y1WTJbRnm0ebf3E7s+IJGwA= X-Developer-Key: i=jcalligeros99@gmail.com; a=openpgp; fpr=B08212489B3206D98F1479BDD43632D151F77960 TAS2764, and the Apple-exclusive variant SN012776, include bus keepers on the SDOUT pin that can be configured to alter the behaviour of the SDOUT pin during specified TDM slots. The chip can either leave the bus floating (default/uninitialised behaviour) or fill the specified slots with zeroes. Expose the SDOUT bus keeper and allow it to be configured using the set_tdm_idle DAI op. The mask must be cropped to only cover slots valid for the configured BCLK ratio, so introduce a set_bclk_ratio op that properly configures this. Signed-off-by: James Calligeros --- sound/soc/codecs/tas2764.c | 95 +++++++++++++++++++++++++ sound/soc/codecs/tas2764.h | 11 +++ 2 files changed, 106 insertions(+) diff --git a/sound/soc/codecs/tas2764.c b/sound/soc/codecs/tas2764.c index 36e25e48b354..423b7073b302 100644 --- a/sound/soc/codecs/tas2764.c +++ b/sound/soc/codecs/tas2764.c @@ -44,6 +44,11 @@ struct tas2764_priv { =20 bool dac_powered; bool unmuted; + + struct { + int tx_mode; + unsigned int tx_mask; + } idle_slot_config; }; =20 #include "tas2764-quirks.h" @@ -509,11 +514,101 @@ static int tas2764_set_dai_tdm_slot(struct snd_soc_d= ai *dai, return 0; } =20 +static int tas2764_write_sdout_idle_mask(struct tas2764_priv *tas2764, u32= mask) +{ + struct snd_soc_component *component =3D tas2764->component; + int i, ret; + + /* Hardware supports up to 64 slots, but we don't */ + for (i =3D 0; i < 4; i++) { + ret =3D snd_soc_component_write(component, + TAS2764_SDOUT_HIZ_1 + i, + (mask >> (i * 8)) & 0xff); + if (ret < 0) + return ret; + } + + return 0; +} + +static int tas2764_set_dai_tdm_idle(struct snd_soc_dai *dai, + unsigned int tx_mask, unsigned int rx_mask, + int tx_mode, int rx_mode) +{ + struct snd_soc_component *component =3D dai->component; + struct tas2764_priv *tas2764 =3D snd_soc_component_get_drvdata(component); + int ret; + + /* We don't support setting anything on SDIN */ + if (rx_mode) + return -EOPNOTSUPP; + + if (tas2764->idle_slot_config.tx_mask =3D=3D tx_mask && + tas2764->idle_slot_config.tx_mode =3D=3D tx_mode) + return 0; + + switch (tx_mode) { + case SND_SOC_DAI_TDM_IDLE_ZERO: + if (!tx_mask) + return -EINVAL; + + ret =3D tas2764_write_sdout_idle_mask(tas2764, tx_mask); + if (ret < 0) + return ret; + + ret =3D snd_soc_component_update_bits(component, + TAS2764_SDOUT_HIZ_9, + TAS2764_SDOUT_HIZ_9_FORCE_0_EN, + TAS2764_SDOUT_HIZ_9_FORCE_0_EN); + if (ret < 0) + return ret; + + tas2764->idle_slot_config.tx_mask =3D tx_mask; + tas2764->idle_slot_config.tx_mode =3D tx_mode; + break; + case SND_SOC_DAI_TDM_IDLE_HIZ: + case SND_SOC_DAI_TDM_IDLE_OFF: + /* HiZ mode does not support a slot mask */ + ret =3D tas2764_write_sdout_idle_mask(tas2764, 0); + if (ret < 0) + return ret; + + ret =3D snd_soc_component_update_bits(component, + TAS2764_SDOUT_HIZ_9, + TAS2764_SDOUT_HIZ_9_FORCE_0_EN, 0); + if (ret < 0) + return ret; + + tas2764->idle_slot_config.tx_mask =3D 0; + tas2764->idle_slot_config.tx_mode =3D tx_mode; + break; + default: + return -EOPNOTSUPP; + } + + return 0; +} + +/* The SDOUT idle slot mask must be cropped based on the BCLK ratio */ +static int tas2764_set_bclk_ratio(struct snd_soc_dai *dai, unsigned int ra= tio) +{ + struct tas2764_priv *tas2764 =3D snd_soc_component_get_drvdata(dai->compo= nent); + + if (!tas2764->idle_slot_config.tx_mask) + return 0; + + tas2764->idle_slot_config.tx_mask &=3D GENMASK((ratio / 8) - 1, 0); + + return tas2764_write_sdout_idle_mask(tas2764, tas2764->idle_slot_config.t= x_mask); +} + static const struct snd_soc_dai_ops tas2764_dai_ops =3D { .mute_stream =3D tas2764_mute, .hw_params =3D tas2764_hw_params, .set_fmt =3D tas2764_set_fmt, + .set_bclk_ratio =3D tas2764_set_bclk_ratio, .set_tdm_slot =3D tas2764_set_dai_tdm_slot, + .set_tdm_idle =3D tas2764_set_dai_tdm_idle, .no_capture_mute =3D 1, }; =20 diff --git a/sound/soc/codecs/tas2764.h b/sound/soc/codecs/tas2764.h index 538290ed3d92..4494bc4889dc 100644 --- a/sound/soc/codecs/tas2764.h +++ b/sound/soc/codecs/tas2764.h @@ -126,4 +126,15 @@ =20 #define TAS2764_BOP_CFG0 TAS2764_REG(0X0, 0x1d) =20 +#define TAS2764_SDOUT_HIZ_1 TAS2764_REG(0x1, 0x3d) +#define TAS2764_SDOUT_HIZ_2 TAS2764_REG(0x1, 0x3e) +#define TAS2764_SDOUT_HIZ_3 TAS2764_REG(0x1, 0x3f) +#define TAS2764_SDOUT_HIZ_4 TAS2764_REG(0x1, 0x40) +#define TAS2764_SDOUT_HIZ_5 TAS2764_REG(0x1, 0x41) +#define TAS2764_SDOUT_HIZ_6 TAS2764_REG(0x1, 0x42) +#define TAS2764_SDOUT_HIZ_7 TAS2764_REG(0x1, 0x43) +#define TAS2764_SDOUT_HIZ_8 TAS2764_REG(0x1, 0x44) +#define TAS2764_SDOUT_HIZ_9 TAS2764_REG(0x1, 0x45) +#define TAS2764_SDOUT_HIZ_9_FORCE_0_EN BIT(7) + #endif /* __TAS2764__ */ --=20 2.52.0