From nobody Sun Feb 8 06:04:21 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 290DE78F20 for ; Sat, 20 Dec 2025 18:48:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766256533; cv=none; b=XPeiYh4Eqoei3HparNB0UE0mJJ1Vm7GATuoX3DklZ92VnTkX65zQ4EpJf34Eg9Vu5A+owtv0V/Z3adUk2qchAjmdFGJmMeSPWersAKIfstmK4K87fWbHtatqrS25othhJn2AGe1RNYDQp1BAfho4TMllf6kJBBpvet6GliTN4l0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766256533; c=relaxed/simple; bh=qAp/HNWCGtTrcIoAgMbiv4LMTmetnhgYc1sE87Bwo2w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eXAEz9X4syqzdknLyOLXqhrZsyT5b6Z4/N4VxWmllqJgFX4U3mukOs1jvimY20Lr0L5QK9HII8w4EP+M3rEJoEc+C1K291QYKOFLkaryed3hNLXsH5+/l6uBeNrgOHJoipad72/+wNKg9YoC/G+szejLl7cKXs7Q5UoRMYK4+Fc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DQzoIgdC; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DQzoIgdC" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7f0db5700b2so2573263b3a.0 for ; Sat, 20 Dec 2025 10:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766256531; x=1766861331; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/oncLln8FbSPaRUU+p2VE2LXXFaw2yjD++vmbH5oIfY=; b=DQzoIgdCsb/wPqut14hhJ6HrJbBU5yZM2fdBJv4g2IoeBG2MKVqLc5mIsu+SdJ1E2o y22a9sHDt73+W6fYrGxdTPSOyn9Sjolc3SscvN4x4gIr3/TYuLErSTOMDVW+8nelD2J7 idACbJnnLFKmBqKQbk8EDPyKE3IhrbqsYkj83LJcByxOEAFoeR5J2fxOTV9YG9ZxGQVT KvjsrjJSoVOYjtgtcLAVwD0uWKj633F/455nta/ILlNZ22d2iQRc1Nw6OaOfFZDmQ3Ur ZsUWw7W/zfYagW6v7pYIPa/ihTBAuMFwrG0AK2ghvHH5VYlXbPryfKcziMHBY++lU8Qp XcAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766256531; x=1766861331; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/oncLln8FbSPaRUU+p2VE2LXXFaw2yjD++vmbH5oIfY=; b=SWj0QhywJkILdgaZ8rJodGh+EOwKg+7K+0A04BI83h+955REg5wGIrX41Hl/todlfN O4AlEXHwJfn70m2rk2yJXXL36Z1PXlGFIbVLVYvi8J84vuNOUJxNPyX7o9Qd871HvAlA V3iwUlLG/89J2U48AtF1qoGdRuIYFWEZbi57jird8I2AyGS2A+2KXYxTdP+crXheDUbC sFNaF+1buBmJkxoqrwLRShQA+TNOjrZGleD2KMdGvEljju/rnqGGYNWI5rKXS6+sKNIo nbdHN6Je0WYzvn9DP4yGv53LdmUc53SATaOlNuIC8RRTJ+3UqWrpz/FFuDoqCsCeUzAT +t+Q== X-Forwarded-Encrypted: i=1; AJvYcCX4FNDDEJuUMo9QZu2YwBb7IhqQ5DWXDpxf2y6HOZXiP2ZEGf0xk7kvBWsFd5/KY5kaeIZlYnCOEtqqPa0=@vger.kernel.org X-Gm-Message-State: AOJu0YwH9cEuPA2Yu+EtRqbSIP7vybU1SDitiKygwv+4YC/s02e+JJ8M djjb+BbhP5f3tyw5BG393Mrtc06SKquYUz54IL+rhvey5cye1McU/Nc5 X-Gm-Gg: AY/fxX5uxPzEzkHcpxRL4sSOFR5oCLLJeDXjJ9ZDiknON7AKl3qgnhRfeBCuXXOvP+R rjrzx5ZMBPwVe8z4ofDoyrUyNoHe0mVwpL+K5ODQLuXWFYXGy66L4rfp9ImW8l4iJKGjBE50r+z aS95gceI57NzZdCBXvtSzkBwtJRp1+Jdfl++hMYn8aF/gk/mXyQ64wGuT6s1VqyVR+FRKI+3UIr yVafm/+dPQus71ChrigxFRF3eo2O+3Sd6sYOKJum4meMmGLEK2Fi6YJjinLT16SZry7cRt/c5CN EJOlGtsC6H+CYzNfvdofBJRnKaWjmyDb2Df1R3chMYnyEExxDtL3mF/xL/Lf+572C3OUGLA4fLC aMODSlXJsSNAxFOQo9V3QT7UpfEs76WftwQNitLpAgsaXAKY4FAoODxJarugEFHdWgsR89xAkeW nQp0I6gcmgFlc1E/sU2bDH1/8XqBlD//9hOCW28qF1McSHdserXHaJHjOE9uI0LA== X-Google-Smtp-Source: AGHT+IE/r1ZKcCOrAZwJE2R6ewFbpafDZ6VWGE4Pg71TQwfDZy+wfImVOERYUn/yZRaGiGCgTeRnUQ== X-Received: by 2002:a05:7022:b88b:b0:11b:b179:6e17 with SMTP id a92af1059eb24-121723092d6mr6262195c88.34.1766256531231; Sat, 20 Dec 2025 10:48:51 -0800 (PST) Received: from titanite-d300.amd.com ([165.204.154.57]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1217254d369sm23432761c88.16.2025.12.20.10.48.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Dec 2025 10:48:50 -0800 (PST) From: Mukesh Ogare To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@gmail.com, simona@ffwll.ch, amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Mukesh Ogare Subject: [PATCH] drm/radeon: convert UVD v1.0 logging to drm_* helpers Date: Sun, 21 Dec 2025 02:47:55 +0800 Message-ID: <20251220184755.1803625-1-mukeshogare871@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace legacy DRM_ERROR()/DRM_INFO() logging in the UVD v1.0 code with drm_err() and drm_info() helpers that take a struct drm_device. Using drm_* logging provides proper device context in dmesg, which is important for systems with multiple DRM devices, and aligns the radeon driver with current DRM logging practices. No functional change intended. Signed-off-by: Mukesh Ogare diff --git a/drivers/gpu/drm/radeon/uvd_v1_0.c b/drivers/gpu/drm/radeon/uvd= _v1_0.c index 5684639d20a6..5e6607e16244 100644 Reviewed-by: Christian K=C3=B6nig --- a/drivers/gpu/drm/radeon/uvd_v1_0.c +++ b/drivers/gpu/drm/radeon/uvd_v1_0.c @@ -179,7 +179,7 @@ int uvd_v1_0_init(struct radeon_device *rdev) =20 r =3D radeon_ring_lock(rdev, ring, 10); if (r) { - DRM_ERROR("radeon: ring failed to lock UVD ring (%d).\n", r); + drm_err(&rdev->ddev, "radeon: ring failed to lock UVD ring (%d).\n", r); goto done; } =20 @@ -232,7 +232,7 @@ int uvd_v1_0_init(struct radeon_device *rdev) break; } =20 - DRM_INFO("UVD initialized successfully.\n"); + drm_info(&rdev->ddev, "UVD initialized successfully.\n"); } =20 return r; @@ -338,7 +338,7 @@ int uvd_v1_0_start(struct radeon_device *rdev) if (status & 2) break; =20 - DRM_ERROR("UVD not responding, trying to reset the VCPU!!!\n"); + drm_err(&rdev->ddev, "UVD not responding, trying to reset the VCPU!!!\n"= ); WREG32_P(UVD_SOFT_RESET, VCPU_SOFT_RESET, ~VCPU_SOFT_RESET); mdelay(10); WREG32_P(UVD_SOFT_RESET, 0, ~VCPU_SOFT_RESET); @@ -347,7 +347,7 @@ int uvd_v1_0_start(struct radeon_device *rdev) } =20 if (r) { - DRM_ERROR("UVD not responding, giving up!!!\n"); + drm_err(&rdev->ddev, "UVD not responding, giving up!!!\n"); return r; } =20 @@ -427,7 +427,7 @@ int uvd_v1_0_ring_test(struct radeon_device *rdev, stru= ct radeon_ring *ring) WREG32(UVD_CONTEXT_ID, 0xCAFEDEAD); r =3D radeon_ring_lock(rdev, ring, 3); if (r) { - DRM_ERROR("radeon: cp failed to lock ring %d (%d).\n", + drm_err(&rdev->ddev, "radeon: cp failed to lock ring %d (%d).\n", ring->idx, r); return r; } @@ -442,10 +442,10 @@ int uvd_v1_0_ring_test(struct radeon_device *rdev, st= ruct radeon_ring *ring) } =20 if (i < rdev->usec_timeout) { - DRM_INFO("ring test on %d succeeded in %d usecs\n", + drm_info(&rdev->ddev, "ring test on %d succeeded in %d usecs\n", ring->idx, i); } else { - DRM_ERROR("radeon: ring %d test failed (0x%08X)\n", + drm_err(&rdev->ddev, "radeon: ring %d test failed (0x%08X)\n", ring->idx, tmp); r =3D -EINVAL; } @@ -507,34 +507,34 @@ int uvd_v1_0_ib_test(struct radeon_device *rdev, stru= ct radeon_ring *ring) else r =3D radeon_set_uvd_clocks(rdev, 53300, 40000); if (r) { - DRM_ERROR("radeon: failed to raise UVD clocks (%d).\n", r); + drm_err(&rdev->ddev, "radeon: failed to raise UVD clocks (%d).\n", r); return r; } =20 r =3D radeon_uvd_get_create_msg(rdev, ring->idx, 1, NULL); if (r) { - DRM_ERROR("radeon: failed to get create msg (%d).\n", r); + drm_err(&rdev->ddev, "radeon: failed to get create msg (%d).\n", r); goto error; } =20 r =3D radeon_uvd_get_destroy_msg(rdev, ring->idx, 1, &fence); if (r) { - DRM_ERROR("radeon: failed to get destroy ib (%d).\n", r); + drm_err(&rdev->ddev, "radeon: failed to get destroy ib (%d).\n", r); goto error; } =20 r =3D radeon_fence_wait_timeout(fence, false, usecs_to_jiffies( RADEON_USEC_IB_TEST_TIMEOUT)); if (r < 0) { - DRM_ERROR("radeon: fence wait failed (%d).\n", r); + drm_err(&rdev->ddev, "radeon: fence wait failed (%d).\n", r); goto error; } else if (r =3D=3D 0) { - DRM_ERROR("radeon: fence wait timed out.\n"); + drm_err(&rdev->ddev, "radeon: fence wait timed out.\n"); r =3D -ETIMEDOUT; goto error; } r =3D 0; - DRM_INFO("ib test on ring %d succeeded\n", ring->idx); + drm_info(&rdev->ddev, "ib test on ring %d succeeded\n", ring->idx); error: radeon_fence_unref(&fence); radeon_set_uvd_clocks(rdev, 0, 0); --=20 2.43.0