From nobody Sat Feb 7 15:10:00 2026 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 823772DAFC7 for ; Sat, 20 Dec 2025 12:55:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.189 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766235347; cv=none; b=Tw5Yk+fHAU2vDHnE9u0Pk4tOUIqF7RlU4RbfDnZX0Hch/5VgdWpqcl8MFRPtm0OtgQ9jRZGXKJ5U1LhKU7ylUue33td7Wur6UGWkf9HAlbSMPf4+1MC8VrC5f0RooI6pymgxYu7xV8+2C5gVCz1Q0L3VbYdb1fbFMcYo0QeBMJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766235347; c=relaxed/simple; bh=94W8BAZfuzeTXl9njgldfEHyeR2pWQLexpIDLixVx4A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NQzVBI9kr06s8wY9sZpWGqs2UzSuh1hsK3T2mkpUEjG0ikgEnUqpv96PwoQCztg/mKicfiuXHY2S4vMMD9ss3q3t8eP7Ua1B0JJmuVj5/fRwFNxOfBVKe0P0hFj+DTzwbWbAWmFTS3P6H0SeuJY0BlK8cBy/ClT7i/sYZwHMEtY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=GDuIRBQs; arc=none smtp.client-ip=95.215.58.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="GDuIRBQs" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1766235343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5SJKB6e4nk2R+eD/jLARTLRCQ4lGUXckj4w6zaMxRYE=; b=GDuIRBQseA/MCNt9l4BAv8/qjKI7bP2Wl4UGIHdM+xiSxhLy0bTp6M9PZD7y003Tpbq2Ps BpXqoLoKRp4zOzF1fGMRnCZBzK67ehWKvo4MusjY5nkkQF4bvhdajVfO6HNL2GJq5eAgqq 78uFG7xYID+fcEvk7iiLgjM3MxHQOGg= From: Thorsten Blum To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Rick Edgecombe Cc: Thorsten Blum , Ingo Molnar , linux-kernel@vger.kernel.org Subject: [PATCH RESEND] x86/fpu: Replace vmalloc + copy_from_user with vmemdup_user in xstateregs_set Date: Sat, 20 Dec 2025 13:54:59 +0100 Message-ID: <20251220125501.76470-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Replace vmalloc() followed by copy_from_user() with vmemdup_user() to improve and simplify xstateregs_set(). Use kvfree() to free the memory. Return early if an error occurs and remove the obsolete 'out' label. Signed-off-by: Thorsten Blum --- arch/x86/kernel/fpu/regset.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/fpu/regset.c b/arch/x86/kernel/fpu/regset.c index 0986c2200adc..00cc009918e6 100644 --- a/arch/x86/kernel/fpu/regset.c +++ b/arch/x86/kernel/fpu/regset.c @@ -3,6 +3,7 @@ * FPU register's regset abstraction, for ptrace, core dumps, etc. */ #include +#include #include =20 #include @@ -157,21 +158,15 @@ int xstateregs_set(struct task_struct *target, const = struct user_regset *regset, return -EFAULT; =20 if (!kbuf) { - tmpbuf =3D vmalloc(count); - if (!tmpbuf) - return -ENOMEM; - - if (copy_from_user(tmpbuf, ubuf, count)) { - ret =3D -EFAULT; - goto out; - } + tmpbuf =3D vmemdup_user(ubuf, count); + if (IS_ERR(tmpbuf)) + return PTR_ERR(tmpbuf); } =20 fpu_force_restore(fpu); ret =3D copy_uabi_from_kernel_to_xstate(fpu->fpstate, kbuf ?: tmpbuf, &ta= rget->thread.pkru); =20 -out: - vfree(tmpbuf); + kvfree(tmpbuf); return ret; } =20 --=20 Thorsten Blum GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4