From nobody Sat Feb 7 17:41:12 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0996422DA1C for ; Sat, 20 Dec 2025 11:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766229433; cv=none; b=XR0ShgekbsE89Aq367xnlllzvyMxJO0UwRkcS+D6STizdbfQlfhqstDpMjlc/HlAUg7udccLAF4jz1dXr7D6+J6eHaLgzmnwxBprdc8i/0If085jaoY2fcRSsrgqOfQjzmiYDSpfBYMteLp/3cp0s/4k/0QtywYic3Tqn8OyY+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766229433; c=relaxed/simple; bh=Ts67dJpg2LQC8V4h7uuHU8YNl9jQ58mTDjPFn9Yicvs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nj1C23LzHJQ/A9X366POoUXelZqiwONQoziC9Qm6oNILC7lD+tAnzPyIq0K3bw/MIZU2SZALY3ATbeue2QyhjuYY7dOVhkuH0C2+0IMVAxXLomdo0sgZjmvyc5ke9PlS9xh/0wa40bpH5JAEs1HviIqw4KVBvTOaMoKuzBdLR6Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dHHdmXQP; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dHHdmXQP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766229429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C5kBTxWJa2eNeFiRt+EFDa1P9P2/qpjVXOHl0w8hecE=; b=dHHdmXQPwI5hbOBqxR+MbQkdgG+CE4+KjgB1ii4gM/CgGlvfepbfhV/OdZUVZoI//grlPQ 84WdVpvAMfBdsBCUGDrwhimWgdIqO5k7IlCXNjbXQrH8W7ndtFA1LeKdm0fzCmXcX0qfuf tTQ8mB+ktv7ckP0cOjphjZPrACRycrw= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-532-CzDuxXM-PSOh1jjNwt91Iw-1; Sat, 20 Dec 2025 06:17:03 -0500 X-MC-Unique: CzDuxXM-PSOh1jjNwt91Iw-1 X-Mimecast-MFC-AGG-ID: CzDuxXM-PSOh1jjNwt91Iw_1766229422 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DDA891800358; Sat, 20 Dec 2025 11:17:01 +0000 (UTC) Received: from dell-per7425-02.rhts.eng.pek2.redhat.com (dell-per7425-02.rhts.eng.pek2.redhat.com [10.73.116.18]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 81BB1180066C; Sat, 20 Dec 2025 11:16:53 +0000 (UTC) From: Li Wang To: linux-kselftest@vger.kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: David Hildenbrand , Mark Brown , Shuah Khan , Waiman Long Subject: [PATCH 1/3] selftests/mm/write_to_hugetlbfs: parse -s with strtoull and use size_t Date: Sat, 20 Dec 2025 19:16:43 +0800 Message-ID: <20251220111645.2246009-2-liwang@redhat.com> In-Reply-To: <20251220111645.2246009-1-liwang@redhat.com> References: <20251220111645.2246009-1-liwang@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Type: text/plain; charset="utf-8" write_to_hugetlbfs currently parses the -s size argument with atoi() into an int. This silently accepts malformed input, cannot report overflow, and can truncate large sizes. --- Error log --- # uname -r 6.12.0-xxx.el10.aarch64+64k # ls /sys/kernel/mm/hugepages/hugepages-* hugepages-16777216kB/ hugepages-2048kB/ hugepages-524288kB/ #./charge_reserved_hugetlb.sh -cgroup-v2 # ----------------------------------------- ... # nr hugepages =3D 10 # writing cgroup limit: 5368709120 # writing reseravation limit: 5368709120 ... # Writing to this path: /mnt/huge/test # Writing this size: -1610612736 <-------- Switch size to size_t and parse -s using strtoull() with proper validation. Also print the size using %zu. This makes the test utility more robust and avoids undefined/incorrect behavior with large or invalid -s values. Signed-off-by: Li Wang Cc: David Hildenbrand Cc: Mark Brown Cc: Shuah Khan Cc: Waiman Long --- .../testing/selftests/mm/write_to_hugetlbfs.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/mm/write_to_hugetlbfs.c b/tools/testin= g/selftests/mm/write_to_hugetlbfs.c index 34c91f7e6128..61f34b35dc27 100644 --- a/tools/testing/selftests/mm/write_to_hugetlbfs.c +++ b/tools/testing/selftests/mm/write_to_hugetlbfs.c @@ -68,7 +68,7 @@ int main(int argc, char **argv) int key =3D 0; int *ptr =3D NULL; int c =3D 0; - int size =3D 0; + size_t size =3D 0; char path[256] =3D ""; enum method method =3D MAX_METHOD; int want_sleep =3D 0, private =3D 0; @@ -86,7 +86,20 @@ int main(int argc, char **argv) while ((c =3D getopt(argc, argv, "s:p:m:owlrn")) !=3D -1) { switch (c) { case 's': - size =3D atoi(optarg); + errno =3D 0; + char *end =3D NULL; + unsigned long long tmp =3D strtoull(optarg, &end, 10); + if (errno || end =3D=3D optarg || *end !=3D '\0') { + errno =3D EINVAL; + perror("Invalid -s size"); + exit_usage(); + } + if (tmp =3D=3D 0) { + errno =3D EINVAL; + perror("size not found"); + exit_usage(); + } + size =3D (size_t)tmp; break; case 'p': strncpy(path, optarg, sizeof(path) - 1); @@ -131,7 +144,7 @@ int main(int argc, char **argv) } =20 if (size !=3D 0) { - printf("Writing this size: %d\n", size); + printf("Writing this size: %zu\n", size); } else { errno =3D EINVAL; perror("size not found"); --=20 2.49.0 From nobody Sat Feb 7 17:41:12 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F21E46F2F2 for ; Sat, 20 Dec 2025 11:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766229432; cv=none; b=mW6uHFm1mymrKk1XTfcxWXAGY21knm+vSt5+S6Au7+A8kuajxrQLQ5B+e98XbCoFM1Q02Rq5N4zDFywvFeVrPlyQFV3BpXLEN7r3OxrUAvSwgKunDgIRwidIqE3F7Y/UQvoh8uYTAPzkEZ9QXSuwGyBzyoDjqBAhPyW5Fvx3bFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766229432; c=relaxed/simple; bh=pVvObGlmoXaYv72+/xpcjgkdU9ns+C2pRLp5LLfe+tY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NHRL8/HnxUzNF7AU4ZZcKkPpJzL5dC/s1daZriWUMeiFRBfgHpCwlriL3UrY7WtXFOGjOF2l/hRrOj7fZ5HH03io6i+t4aNh51KafepY2CfTLiKOjxsVbP4tOjKFndDOrcE4dM0FsyOCsxmhlLw5LrhyGjDncfmq4ssbWbeGi5c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KHxD0LVj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KHxD0LVj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766229429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MoEkhGDkCRG45o46/v13ZWZW2kUp5bUq6J0F6pVCYGY=; b=KHxD0LVjhPtiDAv+GcYhrk92jtlNnXuvIcVObqarHmbNiJayME5ohVpIMEbekA1XPl4prB DKV202ZqKgwCTzX7WT6zY4sA94h9EELucoMuhKvEk0eL6sfaDCN1i7WJvwnib9SPyoiP6t mjuBX8df4lQbCLXlFmbWFnWEEcsA6KQ= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-SCxEloExNByrp4qCAn0xiQ-1; Sat, 20 Dec 2025 06:17:07 -0500 X-MC-Unique: SCxEloExNByrp4qCAn0xiQ-1 X-Mimecast-MFC-AGG-ID: SCxEloExNByrp4qCAn0xiQ_1766229426 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5406B1956054; Sat, 20 Dec 2025 11:17:06 +0000 (UTC) Received: from dell-per7425-02.rhts.eng.pek2.redhat.com (dell-per7425-02.rhts.eng.pek2.redhat.com [10.73.116.18]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8C80A180035A; Sat, 20 Dec 2025 11:17:02 +0000 (UTC) From: Li Wang To: linux-kselftest@vger.kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: David Hildenbrand , Mark Brown , Shuah Khan , Waiman Long Subject: [PATCH 2/3] selftests/mm/charge_reserved_hugetlb.sh: add waits with timeout helper Date: Sat, 20 Dec 2025 19:16:44 +0800 Message-ID: <20251220111645.2246009-3-liwang@redhat.com> In-Reply-To: <20251220111645.2246009-1-liwang@redhat.com> References: <20251220111645.2246009-1-liwang@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Type: text/plain; charset="utf-8" The hugetlb cgroup usage wait loops in charge_reserved_hugetlb.sh were unbounded and could hang forever if the expected cgroup file value never appears (e.g. due to bugs, timing issues, or unexpected behavior). --- Error log --- # uname -r 6.12.0-xxx.el10.aarch64+64k # ls /sys/kernel/mm/hugepages/hugepages-* hugepages-16777216kB/ hugepages-2048kB/ hugepages-524288kB/ #./charge_reserved_hugetlb.sh -cgroup-v2 # ----------------------------------------- ... # nr hugepages =3D 10 # writing cgroup limit: 5368709120 # writing reseravation limit: 5368709120 ... # write_to_hugetlbfs: Error mapping the file: Cannot allocate memory # Waiting for hugetlb memory reservation to reach size 2684354560. # 0 # Waiting for hugetlb memory reservation to reach size 2684354560. # 0 # Waiting for hugetlb memory reservation to reach size 2684354560. # 0 # Waiting for hugetlb memory reservation to reach size 2684354560. # 0 # Waiting for hugetlb memory reservation to reach size 2684354560. # 0 # Waiting for hugetlb memory reservation to reach size 2684354560. # 0 ... Introduce a small helper, wait_for_file_value(), and use it for: - waiting for reservation usage to drop to 0, - waiting for reservation usage to reach a given size, - waiting for fault usage to reach a given size. This makes the waits consistent and adds a hard timeout (120 tries with 0.5s sleep) so the test fails instead of stalling indefinitely. Signed-off-by: Li Wang Cc: David Hildenbrand Cc: Mark Brown Cc: Shuah Khan Cc: Waiman Long --- .../selftests/mm/charge_reserved_hugetlb.sh | 45 ++++++++++--------- 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh b/tools/= testing/selftests/mm/charge_reserved_hugetlb.sh index e1fe16bcbbe8..6aa4ce66922c 100755 --- a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh +++ b/tools/testing/selftests/mm/charge_reserved_hugetlb.sh @@ -112,41 +112,46 @@ function setup_cgroup() { fi } =20 +function wait_for_file_value() { + local path=3D"$1" + local expect=3D"$2" + local max_tries=3D"120" + + local i cur + for ((i=3D1; i<=3Dmax_tries; i++)); do + cur=3D"$(cat "$path")" + if [[ "$cur" =3D=3D "$expect" ]]; then + return 0 + fi + echo "Waiting for $path to become '$expect' (current: '$cur') (try $i/= $max_tries)" + sleep 0.5 + done + + echo "ERROR: timeout waiting for $path to become '$expect' (last: '$cur'= )" + return 1 +} + function wait_for_hugetlb_memory_to_get_depleted() { local cgroup=3D"$1" local path=3D"$cgroup_path/$cgroup/hugetlb.${MB}MB.$reservation_usage_fi= le" - # Wait for hugetlbfs memory to get depleted. - while [ $(cat $path) !=3D 0 ]; do - echo Waiting for hugetlb memory to get depleted. - cat $path - sleep 0.5 - done + + wait_for_file_value "$path" "0" } =20 function wait_for_hugetlb_memory_to_get_reserved() { local cgroup=3D"$1" local size=3D"$2" - local path=3D"$cgroup_path/$cgroup/hugetlb.${MB}MB.$reservation_usage_fi= le" - # Wait for hugetlbfs memory to get written. - while [ $(cat $path) !=3D $size ]; do - echo Waiting for hugetlb memory reservation to reach size $size. - cat $path - sleep 0.5 - done + + wait_for_file_value "$path" "$size" } =20 function wait_for_hugetlb_memory_to_get_written() { local cgroup=3D"$1" local size=3D"$2" - local path=3D"$cgroup_path/$cgroup/hugetlb.${MB}MB.$fault_usage_file" - # Wait for hugetlbfs memory to get written. - while [ $(cat $path) !=3D $size ]; do - echo Waiting for hugetlb memory to reach size $size. - cat $path - sleep 0.5 - done + + wait_for_file_value "$path" "$size" } =20 function write_hugetlbfs_and_get_usage() { --=20 2.49.0 From nobody Sat Feb 7 17:41:12 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E57A2D46B4 for ; Sat, 20 Dec 2025 11:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766229440; cv=none; b=IvxM7Z9eP2mWkkHGgdPRPGJC3X2PFCWFNTguJyjkWEQ0xXY3kAVr9oMmgaXX+g+BNO6IjTCgzN80iByePC0OmmBE6rdS1maqfUqT0JT5JgNgEXCRGb8f/qx2KGUZveKGh76FMGN+ZERKocMJpN5KR5hFVyTk32A49fQ2ONiRyUc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766229440; c=relaxed/simple; bh=fURT7vwM9crV5rps9En6u63N762gzMQq0l0eUn7sZ3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DfaUZy6e42Ay9brEinCXs91EDLGdw/515yl+oihGvjknPoiEeMpG+5OmIlBa1AK2fK7UEeuT2PDBF5pmfL4RkDoNiarP2jQJMIFsMJNM5oftA9shJmQ2Uw5m1ER10feqKcLBQhHpwOtlScQBzh6nbWYbDpvSTj26BRyE6zV6Hzw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=X+JhSh+g; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X+JhSh+g" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766229437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AeYBXDIL9p75os/GitpdF41KNLUSWbRtlTHaY5hYAc0=; b=X+JhSh+gqQu59bzbBVCrDna0p6AqXoI2zbDaxGUKH8l5H1H78qAPVohyQlf3eYbxaG2KCm n2izhIzi+OuiW14hVDWjbsfymv5TbHc2QHJKgR7wfY8KqRF1SCd8TxCvvU7IP8Qcku97ef T8jOkk2YPu4RM6Hm19zdVqvj3XaBTdU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-Sm7oz34fNhKy_ydVLDNVhg-1; Sat, 20 Dec 2025 06:17:11 -0500 X-MC-Unique: Sm7oz34fNhKy_ydVLDNVhg-1 X-Mimecast-MFC-AGG-ID: Sm7oz34fNhKy_ydVLDNVhg_1766229430 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 72A18195DE56; Sat, 20 Dec 2025 11:17:10 +0000 (UTC) Received: from dell-per7425-02.rhts.eng.pek2.redhat.com (dell-per7425-02.rhts.eng.pek2.redhat.com [10.73.116.18]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 02FA9180066C; Sat, 20 Dec 2025 11:17:06 +0000 (UTC) From: Li Wang To: linux-kselftest@vger.kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: David Hildenbrand , Mark Brown , Shuah Khan , Waiman Long Subject: [PATCH 3/3] selftests/mm/charge_reserved_hugetlb: fix hugetlbfs mount size for large hugepages Date: Sat, 20 Dec 2025 19:16:45 +0800 Message-ID: <20251220111645.2246009-4-liwang@redhat.com> In-Reply-To: <20251220111645.2246009-1-liwang@redhat.com> References: <20251220111645.2246009-1-liwang@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Type: text/plain; charset="utf-8" charge_reserved_hugetlb.sh mounts a hugetlbfs instance at /mnt/huge with a fixed size of 256M. On systems with large base hugepages (e.g. 512MB), this is smaller than a single hugepage, so the hugetlbfs mount ends up with effectively zero capacity (often visible as size=3D0 in mount output). As a result, write_to_hugetlbfs fails with ENOMEM and the test can hang waiting for progress. --- Error log --- # uname -r 6.12.0-xxx.el10.aarch64+64k #./charge_reserved_hugetlb.sh -cgroup-v2 # ----------------------------------------- ... # nr hugepages =3D 10 # writing cgroup limit: 5368709120 # writing reseravation limit: 5368709120 ... # write_to_hugetlbfs: Error mapping the file: Cannot allocate memory # Waiting for hugetlb memory reservation to reach size 2684354560. # 0 # Waiting for hugetlb memory reservation to reach size 2684354560. # 0 ... # mount |grep /mnt/huge none on /mnt/huge type hugetlbfs (rw,relatime,seclabel,pagesize=3D512M,si= ze=3D0) # grep -i huge /proc/meminfo ... HugePages_Total: 10 HugePages_Free: 10 HugePages_Rsvd: 0 HugePages_Surp: 0 Hugepagesize: 524288 kB Hugetlb: 5242880 kB Mount hugetlbfs with size=3D${size}, the number of bytes the test will reserve/write, so the filesystem capacity is sufficient regardless of HugeTLB page size. Signed-off-by: Li Wang Cc: David Hildenbrand Cc: Mark Brown Cc: Shuah Khan Cc: Waiman Long --- tools/testing/selftests/mm/charge_reserved_hugetlb.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh b/tools/= testing/selftests/mm/charge_reserved_hugetlb.sh index 6aa4ce66922c..9deb3dc2cbce 100755 --- a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh +++ b/tools/testing/selftests/mm/charge_reserved_hugetlb.sh @@ -295,7 +295,7 @@ function run_test() { setup_cgroup "hugetlb_cgroup_test" "$cgroup_limit" "$reservation_limit" =20 mkdir -p /mnt/huge - mount -t hugetlbfs -o pagesize=3D${MB}M,size=3D256M none /mnt/huge + mount -t hugetlbfs -o pagesize=3D${MB}M,size=3D${size} none /mnt/huge =20 write_hugetlbfs_and_get_usage "hugetlb_cgroup_test" "$size" "$populate" \ "$write" "/mnt/huge/test" "$method" "$private" "$expect_failure" \ @@ -349,7 +349,7 @@ function run_multiple_cgroup_test() { setup_cgroup "hugetlb_cgroup_test2" "$cgroup_limit2" "$reservation_limit= 2" =20 mkdir -p /mnt/huge - mount -t hugetlbfs -o pagesize=3D${MB}M,size=3D256M none /mnt/huge + mount -t hugetlbfs -o pagesize=3D${MB}M,size=3D${size} none /mnt/huge =20 write_hugetlbfs_and_get_usage "hugetlb_cgroup_test1" "$size1" \ "$populate1" "$write1" "/mnt/huge/test1" "$method" "$private" \ --=20 2.49.0