From nobody Sat Feb 7 19:41:38 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F65C259CBD; Sat, 20 Dec 2025 11:03:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766228594; cv=none; b=I1TUZBU01k27oGnZvsgnV2y+wQ+rMVCaEzw8V2i9T+IqzldchWU5cFujPlAb/YTLVPdguxi4pJmNLlhd8Nz/60LRHN/HAmCK4tndPvY4Xar/n11vgGMD8WmWRrQKz0bpHIPmaeYYV3eZriKP5u+J7ZEcb0X2WRt3LcM3+GecqPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766228594; c=relaxed/simple; bh=ap8MRB6u43PIFW27qfddd/82fqc/71rc4wGTDPI7wLo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hxKHlPTiqvtQG508PPU8Aea0Y6iotW0eXhKVf11oePxTxxk+Uz6a8p0LjVsYk68DjvYZzKYuLUd36OEF6xTOblpTOHIaDxHbpmGDZaigDFOAMwFXrQpD+YehHazrc3Yl19DmQAcwD+6UBbmLk0IYvj46wZSGCRVU1I8BHIAEN4g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eSp2z9oh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eSp2z9oh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D249C116B1; Sat, 20 Dec 2025 11:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766228594; bh=ap8MRB6u43PIFW27qfddd/82fqc/71rc4wGTDPI7wLo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=eSp2z9ohjB6vYInRQZAjAFrvEjUyT/DzO1gHOyAbUXyzXq1as2FowCXDAAplhRIFe i1vcvNC4VrKYrhCs77Nj/tm6WwIh5K7j8tQkObTiQEZLDX1JFIv5L8Zp6bO0cHc5Uf nhke2tbaUU1z3fYRMkQET3wW9XLiprqu7eIBJbOhsU4Ia+aM/cqdw2W5Vux/Ox9xrB Mqf05/UXcE2wUGDDse/9rIYUJhTvhWiw36T5XBOwff+aWxfLMeLZPSo8hG44WMfPXC 79M5/xgBIe1zTidgdDSEHpcj4ra2KZ/uF+C22MQnxnC5qG3igk2QrLrpjPgROdlTJm Q6bd5aMblMu2w== From: Vincent Mailhol Date: Sat, 20 Dec 2025 12:02:19 +0100 Subject: [PATCH v3 1/3] kbuild: remove gcc's -Wtype-limits Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251220-remove_wtype-limits-v3-1-24b170af700e@kernel.org> References: <20251220-remove_wtype-limits-v3-0-24b170af700e@kernel.org> In-Reply-To: <20251220-remove_wtype-limits-v3-0-24b170af700e@kernel.org> To: Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chris Mason , David Sterba , Kees Cook , "Gustavo A. R. Silva" Cc: Linus Torvalds , linux-kbuild@vger.kernel.org, linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-btrfs@vger.kernel.org, linux-hardening@vger.kernel.org, Vincent Mailhol X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3600; i=mailhol@kernel.org; h=from:subject:message-id; bh=ap8MRB6u43PIFW27qfddd/82fqc/71rc4wGTDPI7wLo=; b=owGbwMvMwCV2McXO4Xp97WbG02pJDJluTTH2PxvED5iem9T/9fZyodSYGb+mLK9ffoWxL+p+h FkPhzFjx0QWBjEuBksxRZZl5ZzcCh2F3mGH/lrCzGFlAhkiLdLAAAQsDHy5iXmlRjpGeqbahnqG hjpAJgMXpwBM9fQYRobrzVs2h7V82sLAk8/wzdbv79rGOl+NXefexIX/WfH09bRmRoaXtQIOKhN vybgals7N2bjbdr6VcsRenz/nWOvPnCk0ruMBAA== X-Developer-Key: i=mailhol@kernel.org; a=openpgp; fpr=ED8F700574E67F20E574E8E2AB5FEB886DBB99C2 W=3D2 builds are heavily polluted by the -Wtype-limits warning. Here are some W=3D12 statistics on Linux v6.19-rc1 for an x86_64 defconfig (with just CONFIG_WERROR set to "n") using gcc 14.3.1: Warning name count percent ------------------------------------------------- -Wlogical-op 2 0.00 % -Wmaybe-uninitialized 138 0.20 % -Wunused-macros 869 1.24 % -Wmissing-field-initializers 1418 2.02 % -Wshadow 2234 3.19 % -Wtype-limits 65378 93.35 % ------------------------------------------------- Total 70039 100.00 % As we can see, -Wtype-limits represents the vast majority of all warnings. The reason behind this is that these warnings appear in some common header files, meaning that some unique warnings are repeated tens of thousands of times (once per header inclusion). Add to this the fact that each warning is coupled with a dozen lines detailing some macro expansion. The end result is that the W=3D2 output is just too bloated and painful to use. Three years ago, I proposed in [1] modifying one such header to silence that noise. Because the code was not faulty, Linus rejected the idea and instead suggested simply removing that warning. At that time, I could not bring myself to send such a patch because, despite its problems, -Wtype-limits would still catch the below bug: unsigned int ret; ret =3D check(); if (ret < 0) error(); Meanwhile, based on another suggestion from Linus, I added a new check to sparse [2] that would catch the above bug without the useless spam. With this, remove gcc's -Wtype-limits. People who still want to catch incorrect comparisons between unsigned integers and zero can now use sparse instead. On a side note, clang also has a -Wtype-limits warning but: * it is not enabled in the kernel at the moment because, contrary to gcc, clang did not include it under -Wextra. * it does not warn if the code results from a macro expansion. So, if activated, it would not cause as much spam as gcc does. * -Wtype-limits is split into four sub-warnings [3] meaning that if it were to be activated, we could select which one to keep. So there is no present need to explicitly disable -Wtype-limits in clang. [1] linux/bits.h: GENMASK_INPUT_CHECK: reduce W=3D2 noise by 31% treewide Link: https://lore.kernel.org/all/20220308141201.2343757-1-mailhol.vincent@= wanadoo.fr/ [2] Warn about "unsigned value that used to be signed against zero" Link: https://lore.kernel.org/all/20250921061337.3047616-1-mailhol@kernel.o= rg/ [3] clang's -Wtype-limits Link: https://clang.llvm.org/docs/DiagnosticsReference.html#wtype-limits Reviewed-by: Nicolas Schier Signed-off-by: Vincent Mailhol --- scripts/Makefile.warn | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.warn b/scripts/Makefile.warn index 68e6fafcb80c..c593ab1257de 100644 --- a/scripts/Makefile.warn +++ b/scripts/Makefile.warn @@ -55,6 +55,9 @@ else KBUILD_CFLAGS +=3D -Wno-main endif =20 +# Too noisy on range checks and in macros handling both signed and unsigne= d. +KBUILD_CFLAGS +=3D -Wno-type-limits + # These result in bogus false positives KBUILD_CFLAGS +=3D $(call cc-option, -Wno-dangling-pointer) =20 @@ -174,7 +177,6 @@ else =20 # The following turn off the warnings enabled by -Wextra KBUILD_CFLAGS +=3D -Wno-missing-field-initializers -KBUILD_CFLAGS +=3D -Wno-type-limits KBUILD_CFLAGS +=3D -Wno-shift-negative-value =20 ifdef CONFIG_CC_IS_CLANG --=20 2.51.2 From nobody Sat Feb 7 19:41:38 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9CE8224240; Sat, 20 Dec 2025 11:03:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766228601; cv=none; b=Mvhh2Hmdf3jk5yvxvpZTm2ydYuqmq1iuRlBOLlOmxuWdQkj/2DzKqDy41ZRmJlVeDX4726Q1w4D2P4Q1DTV2HM2yw4VHzi/p5rirTWvgHu/YEnZ3JdhLKKs6M908mvg4/PxGlMmRfi1Dhayk0UFnh1kPp2g+tAWMPoAqhpziNf8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766228601; c=relaxed/simple; bh=CH51omHx3p6qsRzlcGdmz4sS4fZYMW+MUawnsQlkKh8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kYTdNgIWgel0zWZRsMKQOfhQXd0P7K6qM5Wrig28ABOf7qgd15U1XSd+f0cqHwu2ijbuPl0kVX0WXQ181JxzG9FVqfCNh7FX8jhcOb+ynRWIFaLfHVrD+oM2Q8TtC544P+Xz4YhgYzIsvYQB2OwXOVXnItyz1B07R+wlqoneYtQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i3y9ecv7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i3y9ecv7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 905DCC4AF09; Sat, 20 Dec 2025 11:03:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766228600; bh=CH51omHx3p6qsRzlcGdmz4sS4fZYMW+MUawnsQlkKh8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=i3y9ecv7bvRQk3YtF39GlefNaX3OsbHoy5nLsuWeL6PK/UBqH1hpdQIBkM7L1cpkR 0MgQZKsRV8qlsdWBp88FtLtxyeZ/OAzTcnkkvsM/lceYvf36X8K1Sxq212pptnhY0c 3jmBhS1DnfaMmRL/vpR1UDnKFWfKYMxaVF/C8gEMKJbsYWcJCxQCQVYwDLcXHozWmS YS8tjzAwltomC7xfC16XuIYZAEjsXQtxtDcze9cz26Sh9RDO1RKemmsZAwNKZYd2cd SlGT0920qYU5dWeF2MbvX5C1PY3mmvaAaRI2g6zUO8UxTv/1hg2N/YoEB4Bttv7aw1 +W+14yTrcjEbg== From: Vincent Mailhol Date: Sat, 20 Dec 2025 12:02:20 +0100 Subject: [PATCH v3 2/3] kbuild: cleanup local -Wno-type-limits exceptions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251220-remove_wtype-limits-v3-2-24b170af700e@kernel.org> References: <20251220-remove_wtype-limits-v3-0-24b170af700e@kernel.org> In-Reply-To: <20251220-remove_wtype-limits-v3-0-24b170af700e@kernel.org> To: Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chris Mason , David Sterba , Kees Cook , "Gustavo A. R. Silva" Cc: Linus Torvalds , linux-kbuild@vger.kernel.org, linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-btrfs@vger.kernel.org, linux-hardening@vger.kernel.org, Vincent Mailhol X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1412; i=mailhol@kernel.org; h=from:subject:message-id; bh=CH51omHx3p6qsRzlcGdmz4sS4fZYMW+MUawnsQlkKh8=; b=owGbwMvMwCV2McXO4Xp97WbG02pJDJluTfGt60/e33Q355CkRrPV9k+JlVOaP/FKlmXMDF/b2 mo7+caVjoksDGJcDJZiiizLyjm5FToKvcMO/bWEmcPKBDJEWqSBAQhYGPhyE/NKjXSM9Ey1DfUM DXWATAYuTgGY6n0RjAw776t6N/8vXK+pLbv8i8KtLY76jD2bZfnS0p5+XLJYrfMAw/+cjRsOWO5 RWDQ3KGPOqaUL1jnXqB00sUopmnZYJGfRQSl+AA== X-Developer-Key: i=mailhol@kernel.org; a=openpgp; fpr=ED8F700574E67F20E574E8E2AB5FEB886DBB99C2 Now that -Wtype-limits is globally deactivated, there is no need for local exceptions anymore. Acked-by: David Sterba Signed-off-by: Vincent Mailhol --- Changelog: v1 -> v2: small change in patch description --- drivers/gpu/drm/Makefile | 1 - fs/btrfs/Makefile | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 0e1c668b46d2..b879a60ca79a 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -22,7 +22,6 @@ subdir-ccflags-y +=3D $(call cc-option, -Wstringop-trunca= tion) # The following turn off the warnings enabled by -Wextra ifeq ($(findstring 2, $(KBUILD_EXTRA_WARN)),) subdir-ccflags-y +=3D -Wno-missing-field-initializers -subdir-ccflags-y +=3D -Wno-type-limits subdir-ccflags-y +=3D -Wno-shift-negative-value endif ifeq ($(findstring 3, $(KBUILD_EXTRA_WARN)),) diff --git a/fs/btrfs/Makefile b/fs/btrfs/Makefile index 743d7677b175..40bc2f7e6f6b 100644 --- a/fs/btrfs/Makefile +++ b/fs/btrfs/Makefile @@ -17,7 +17,6 @@ subdir-ccflags-y +=3D $(condflags) # The following turn off the warnings enabled by -Wextra subdir-ccflags-y +=3D -Wno-missing-field-initializers subdir-ccflags-y +=3D -Wno-sign-compare -subdir-ccflags-y +=3D -Wno-type-limits subdir-ccflags-y +=3D -Wno-shift-negative-value =20 obj-$(CONFIG_BTRFS_FS) :=3D btrfs.o --=20 2.51.2 From nobody Sat Feb 7 19:41:38 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27CEB304BBF; Sat, 20 Dec 2025 11:03:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766228607; cv=none; b=TayqaG01yIXO9fz6pQPQnBr5nMPyjBXc+tuSGjc9arT9/FoF8m13j7Kbu6QPr8oy6zG87bnn6EDrnLXcvs27IkpNJYcH/SXMZlmupc/YHIk+/H5/6L/6dWmGgSR2ThsDfETrR3CBDCsh1YceKTKPjrwhJGgQPyIdoSg70G13lDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766228607; c=relaxed/simple; bh=wtRlhF0E9lAMAS6RF9a/BuSBeDduKYxm9+amQIF8Ki8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Xv35inQWsAqoxh06i4m2ecWewYIY2fhqbZBTNDfg+JG4YcXTHk+gId3+XUc9dueEQBsW8Pw/anlk1E1UfiQCsvDvOqmyM7D1hjqMo0YikfCKH9yq8NVYoQAFF7ixSUPIoLwnG5HfnuJH53zlTVrGA6BXJgzDPTGTMIuyw2Zjcck= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VSPoVXNo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VSPoVXNo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF2D8C116B1; Sat, 20 Dec 2025 11:03:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766228606; bh=wtRlhF0E9lAMAS6RF9a/BuSBeDduKYxm9+amQIF8Ki8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=VSPoVXNoHS3RNQvTOYjLCUlocYoKN64Jb5AHozNJBz2hFUthq8VjIPrQRpk+ZHAAp L204OyuxQ2CA9zkvFcUy3BHSR26W9vsQm8jGIA5vM9yJu3gMX+pB+cDKEUsfO5NLoP FE+EjDc0De7GA31kEu5dMGxdgUCW7T8zwJrLN9yPa9gPq9534EE07uEA4B+/HYz2GD PrqCMutIPcWXHGMh1gHaB15xD0GfGvocsHvYG5tumarKEwCiphUMAHODcw64QFG2Am BOg2iWcTKD6e77pXaYLve8sEWKsAZxUmodWRRx8A6YXQeIcFtC5yCAHICKrMy/mVPi gGgc7YxGG12Dg== From: Vincent Mailhol Date: Sat, 20 Dec 2025 12:02:21 +0100 Subject: [PATCH v3 3/3] overflow: Remove is_non_negative() and is_negative() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251220-remove_wtype-limits-v3-3-24b170af700e@kernel.org> References: <20251220-remove_wtype-limits-v3-0-24b170af700e@kernel.org> In-Reply-To: <20251220-remove_wtype-limits-v3-0-24b170af700e@kernel.org> To: Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chris Mason , David Sterba , Kees Cook , "Gustavo A. R. Silva" Cc: Linus Torvalds , linux-kbuild@vger.kernel.org, linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-btrfs@vger.kernel.org, linux-hardening@vger.kernel.org, Vincent Mailhol X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1738; i=mailhol@kernel.org; h=from:subject:message-id; bh=wtRlhF0E9lAMAS6RF9a/BuSBeDduKYxm9+amQIF8Ki8=; b=owGbwMvMwCV2McXO4Xp97WbG02pJDJluTUm3l+97LbU1RvNDcJztnoiThbzHipZctnsjGj/Df K5D44/MjoksDGJcDJZiiizLyjm5FToKvcMO/bWEmcPKBDJEWqSBAQhYGPhyE/NKjXSM9Ey1DfUM DXWATAYuTgGYasdHDP+dPpXOt9++4L208hczbeEroXx/j1fWeUvK6U209r8Xo5vFyLD/T3zCU4M HDjGK6xv2igf+eP3h4euUrR+ZAlbGBz40fcYLAA== X-Developer-Key: i=mailhol@kernel.org; a=openpgp; fpr=ED8F700574E67F20E574E8E2AB5FEB886DBB99C2 The is_non_negative() and is_negative() function-like macros just exist as a workaround to silence the -Wtype-limits warning. Now that this warning is disabled, those two macros have lost their raison d'=C3=AAtre. Remove them. This reverts commit dc7fe518b049 ("overflow: Fix -Wtype-limits compilation warnings"). Suggested-by: Nicolas Schier Link: https://lore.kernel.org/all/aUT_yWin_xslnOFh@derry.ads.avm.de Signed-off-by: Vincent Mailhol --- Changelog: v1 -> v2: new patch --- include/linux/overflow.h | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/include/linux/overflow.h b/include/linux/overflow.h index 736f633b2d5f..ab142d60c6b5 100644 --- a/include/linux/overflow.h +++ b/include/linux/overflow.h @@ -36,12 +36,6 @@ #define __type_min(T) ((T)((T)-type_max(T)-(T)1)) #define type_min(t) __type_min(typeof(t)) =20 -/* - * Avoids triggering -Wtype-limits compilation warning, - * while using unsigned data types to check a < 0. - */ -#define is_non_negative(a) ((a) > 0 || (a) =3D=3D 0) -#define is_negative(a) (!(is_non_negative(a))) =20 /* * Allows for effectively applying __must_check to a macro so we can have @@ -201,9 +195,9 @@ static inline bool __must_check __must_check_overflow(b= ool overflow) typeof(d) _d =3D d; \ unsigned long long _a_full =3D _a; \ unsigned int _to_shift =3D \ - is_non_negative(_s) && _s < 8 * sizeof(*d) ? _s : 0; \ + _s >=3D 0 && _s < 8 * sizeof(*d) ? _s : 0; \ *_d =3D (_a_full << _to_shift); \ - (_to_shift !=3D _s || is_negative(*_d) || is_negative(_a) || \ + (_to_shift !=3D _s || *_d < 0 || _a < 0 || \ (*_d >> _to_shift) !=3D _a); \ })) =20 --=20 2.51.2