From nobody Mon Feb 9 09:32:49 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61A833101AE; Sat, 20 Dec 2025 18:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766256693; cv=pass; b=C+b6D8IAcIFCI4Qjao+DV9ZTWMRvQQh0xQi5+Np+2tZhGggc+4jfN3PiNvM3T/TkTCJlCM6eVfvfMEPYzUh2vIKKXDeJWwQv4Ib5b1SlDf1p/h+xxC+OQmrPebgNyzdz9V98/W8B60u9B5cLexB5cblCvGiLWOzEiCJhfSfPTDk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766256693; c=relaxed/simple; bh=ZatUZYCF/cHOR33QjkB+YNbdZjxbeNr+Lg6rp1tov5M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nrDdFm01LJ1rALfeAnsVXWsSR9UG6IWvz8vqFyr3GT0u+02/H3Vu5TSXnArIZ/TlNZ4liAOhgfy8JnFUw7hWets8Z6qxe1hDWR83+F+J95yIMZGgnKF2XgBB7Ueu57CJV5X1+FBMt42HKslO84fBFNT9UVt4kXW+yCOobhRGO1I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=YxRCapuL; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="YxRCapuL" ARC-Seal: i=1; a=rsa-sha256; t=1766256646; cv=none; d=zohomail.com; s=zohoarc; b=k+ps33RBoTWzNAlrymFBqhrJ55XvdVPAT3xq+aTba7zUdV7Z+/k3sFXbqkjStnwU3fKC4DLCfbfstyss83JbuvavywOY0EcDg3VIAPGHH3hBOKeMPjfB6xGPa73x19e+tvR3/xrJ+igMvn99fS524VdlG+VU1mvIh/aMxVQmBqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766256646; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=5j17v1GY5ZUui5Rtx97+9pI639Hi6bT0WnwCtzvrtAQ=; b=DXXW5zq0m7GofuoNuxOsUEqA1LuHa4dN/fLdZPkE1PXL79G/77pNl7LEZ5RoXzPQJ6ptLSf8TVX25ws6N8kMHKFepV2GWyZw0sMPwxApZhcmIXUVM2QWGhKoHoqgbAMoxlBJw+mQ0RebKzWb9RnkajGbAmGyL4unhOdY/vuyfHU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1766256646; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=5j17v1GY5ZUui5Rtx97+9pI639Hi6bT0WnwCtzvrtAQ=; b=YxRCapuLlpcgveZ8ge+9Vt9yL4zoF7BeXltj21O4pBcGxMmo4PKr67dZOWJgacT9 4LGATQCtFbN3QrbIoPAc5Wyk8dy9fLAHt1gHOZDn198/kWRImzStGT7ic1eIp2BDdU8 EIaJSJZXXNJaG07RIi1ArCYZ4JYC0mCUo1E3Vuf4= Received: by mx.zohomail.com with SMTPS id 1766256644626461.8229840632764; Sat, 20 Dec 2025 10:50:44 -0800 (PST) From: Nicolas Frattaroli Date: Sat, 20 Dec 2025 19:49:55 +0100 Subject: [PATCH v2 4/4] pmdomain: mediatek: mtk-mfg: Expose shader_present as nvmem cell Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251220-mt8196-shader-present-v2-4-45b1ff1dfab0@collabora.com> References: <20251220-mt8196-shader-present-v2-0-45b1ff1dfab0@collabora.com> In-Reply-To: <20251220-mt8196-shader-present-v2-0-45b1ff1dfab0@collabora.com> To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Ulf Hansson Cc: Chen-Yu Tsai , Chia-I Wu , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 Implement nvmem-provider functionality in mtk-mfg-pmdomain, such that it can expose its GF_REG_SHADER_PRESENT value in the shared memory as an nvmem cell for panthor. Signed-off-by: Nicolas Frattaroli --- drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c | 59 ++++++++++++++++++++++++= ++++ 1 file changed, 59 insertions(+) diff --git a/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c b/drivers/pmdomai= n/mediatek/mtk-mfg-pmdomain.c index 9bad577b3ae4..3ce6fb74dd53 100644 --- a/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c +++ b/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -872,6 +873,60 @@ static int mtk_mfg_init_clk_provider(struct mtk_mfg *m= fg) return 0; } =20 +static int mtk_mfg_read_nvmem(void *priv, unsigned int offset, void *val, = size_t bytes) +{ + struct mtk_mfg *mfg =3D priv; + u32 *buf =3D val; + + if (bytes !=3D 4) + return -EINVAL; + + if (!mfg->shared_mem) + return -ENODEV; + + if (offset + bytes >=3D mfg->shared_mem_size) + return -EINVAL; + + *buf =3D readl(mfg->shared_mem + offset); + + return 0; +} + +static int mtk_mfg_init_nvmem_provider(struct mtk_mfg *mfg) +{ + struct device *dev =3D &mfg->pdev->dev; + struct nvmem_cell_info cell =3D {}; + struct nvmem_config config =3D {}; + struct nvmem_device *nvdev; + int ret; + + config.reg_read =3D mtk_mfg_read_nvmem; + config.dev =3D dev; + config.read_only =3D true; + config.priv =3D mfg; + config.size =3D 4; + config.word_size =3D 4; + + nvdev =3D devm_nvmem_register(dev, &config); + if (IS_ERR(nvdev)) + return dev_err_probe(dev, PTR_ERR(nvdev), "Couldn't register nvmem provi= der\n"); + + cell.name =3D "shader-present"; + cell.offset =3D GF_REG_SHADER_PRESENT; + cell.bytes =3D 4; + cell.np =3D of_get_child_by_name(dev->of_node, cell.name); + + ret =3D nvmem_add_one_cell(nvdev, &cell); + if (ret) { + of_node_put(cell.np); + return dev_err_probe(dev, ret, "Couldn't add cell %s\n", cell.name); + } + + /* cell.np purposefully not put as nvmem_add_one_cell does not increase r= efcount */ + + return 0; +} + static int mtk_mfg_probe(struct platform_device *pdev) { struct mtk_mfg *mfg; @@ -984,6 +1039,10 @@ static int mtk_mfg_probe(struct platform_device *pdev) if (ret) goto err_power_off; =20 + ret =3D mtk_mfg_init_nvmem_provider(mfg); + if (ret) + goto err_power_off; + ret =3D of_genpd_add_provider_simple(dev->of_node, &mfg->pd); if (ret) { dev_err_probe(dev, ret, "Failed to add pmdomain provider\n"); --=20 2.52.0