From nobody Sun Feb 8 12:19:55 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EE373101B4; Sat, 20 Dec 2025 18:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766256693; cv=pass; b=ky/GxONuylnP9D5xoknKYJQgI4MfF9Dx4+6KK83RagFSdCOvQIq4D2incCE8GaQRO710g632olzSvCpkm6A6nzQKwez5+9p/9xG6ZeuI72pDUepazr69KGl8epe/IRhV5eq93rYm3/AeeiquQPLDcFswXnFEgUY83uPG0vmoVPc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766256693; c=relaxed/simple; bh=l8GFAMteQwDOPcHMRwlYGJAGz14nVP7EwRua/mTh5A4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=K9JTpxp8JkNtYate9LCuuVRDh9QCm0qHAwejfoJIcnsNYSlzs4YEsMSwtvmfmWhFwTBcDeL3MH1RwykemFzk5BC2TU0FKyFtpWxY0zZmEKloOOs54iLbSspSx7fqis5/H/uixhDOLxJbxCgpc8dKtNay5F5sSSzLkWQPWjCpYfk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=jEa18x1N; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="jEa18x1N" ARC-Seal: i=1; a=rsa-sha256; t=1766256629; cv=none; d=zohomail.com; s=zohoarc; b=G8xgTZWTJjB4ImOOXFRogkyAppca3TcwYZiVjfFeoWw4cnf3J6yz1l0TmFFFM69NVBZKqPXvn9qVxy8axHJzrAjdanOreLGymgDlXr19Y7ud5gjoh2mrcYVQCCz+DN4sKfQKMUF7CBihUxC0XwKABVYfHrqRvrjJR46bDyrf8vw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766256629; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=8IbRY714eO2zGl6q64FE7lg6CXtlWXzXvxXQfYH5rwI=; b=kyZmEgzFo3uCZqEt92Fqf1irIMioiyGvG4VCWM0XG6OY1+lX1o6vtUu9yFuocGMKQrBoM8gmxJc4Qk57fsYGruRAVHkLTy5x7LTZ9A1WgvOc+3Jovg7Bsf/zfk5g43lC+OivDYF4gltniOLqdMvn6Sn8r+TyP5acGEdedyGK7Cc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1766256629; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=8IbRY714eO2zGl6q64FE7lg6CXtlWXzXvxXQfYH5rwI=; b=jEa18x1NgxTIWetBz2e1aTELkeupFac1ViPHoq7QhKZkaVQrtk55dqLMOL0RR9hZ b8KoIp+hlNHz9aVpsO0h+1GKcn9zR0Ai4Px2QJm5PBEz3xdUYuBTqMexCkgRUYF/pEU 8FII1oDeCA1XiYsC9keOrmMm7hYhBu7JiR2iX/jE= Received: by mx.zohomail.com with SMTPS id 1766256628125717.7120182725639; Sat, 20 Dec 2025 10:50:28 -0800 (PST) From: Nicolas Frattaroli Date: Sat, 20 Dec 2025 19:49:52 +0100 Subject: [PATCH v2 1/4] dt-bindings: gpu: mali-valhall-csf: Add shader-present nvmem cell Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251220-mt8196-shader-present-v2-1-45b1ff1dfab0@collabora.com> References: <20251220-mt8196-shader-present-v2-0-45b1ff1dfab0@collabora.com> In-Reply-To: <20251220-mt8196-shader-present-v2-0-45b1ff1dfab0@collabora.com> To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Ulf Hansson Cc: Chen-Yu Tsai , Chia-I Wu , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 On the MediaTek MT8196 SoC, the bitmask for which shader cores are present and functional is not the one in the Mali GPU's registers, but in an external efuse. Add the nvmem cell properties to describe such a setup, and make them required on MT8196. Reviewed-by: Rob Herring (Arm) Signed-off-by: Nicolas Frattaroli --- .../devicetree/bindings/gpu/arm,mali-valhall-csf.yaml | 14 ++++++++++= ++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yam= l b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml index bee9faf1d3f8..8eccd4338a2b 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml @@ -51,6 +51,14 @@ properties: - stacks - const: stacks =20 + nvmem-cells: + items: + - description: bitmask of functional shader cores + + nvmem-cell-names: + items: + - const: shader-present + mali-supply: true =20 operating-points-v2: true @@ -108,6 +116,8 @@ allOf: properties: clocks: minItems: 3 + nvmem-cells: false + nvmem-cell-names: false power-domains: maxItems: 1 power-domain-names: false @@ -133,6 +143,8 @@ allOf: - const: core - const: stacks required: + - nvmem-cells + - nvmem-cell-names - power-domains =20 examples: @@ -179,6 +191,8 @@ examples: , ; interrupt-names =3D "job", "mmu", "gpu"; + nvmem-cells =3D <&shader_present>; + nvmem-cell-names =3D "shader-present"; power-domains =3D <&gpufreq>; }; =20 --=20 2.52.0 From nobody Sun Feb 8 12:19:55 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67C8C30FC22; Sat, 20 Dec 2025 18:51:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766256692; cv=pass; b=Zo3wH7Is+JZEbuoNKBWKsJ3mdYU3ofFZU7RM8Ig3GFG7zpwa0vcDIJdjcyhBTHc66s+C8op19PQmbXrsOf755Kphos7BFrt58K3WMy3MuOQ8HGXkq41Oa9wTlvLWeb7XgXkWAmkmTuEbH4Zw6LefWNDu7Zf4BRiu5jsixCm7j4g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766256692; c=relaxed/simple; bh=ttC9oOJ4k8J1XToYpWDv/nbXkNlNjaFMSyqfvuK/aiM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EGgdK8CB+9oZtRW01egZwZVw1HvyJ+Dl1MeFAU6DizL2a8nJuYdD5fPgD5k/3XL3W9UvWy1DMzkW5flU9wpiFmNuSjvJLcRsBGrkWkFuDfE3FmzE0SHG7wybol6eLJGtmxLq+/ync9oVX62ViOuXZ0Tx2PBNcyGptgOlKnn9DLU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=ItW7jbSZ; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="ItW7jbSZ" ARC-Seal: i=1; a=rsa-sha256; t=1766256635; cv=none; d=zohomail.com; s=zohoarc; b=RcSApAUIVHOQQ/PxKnGD95WnMzfQvGyERWSxzZMbadXIeaP0GjeVMJE1dpYqFjvkS3Z8RvxlJ+apXRiuNwoTwkS53Wzi1neqpgLaAurOwhhB2mOIPcQBiSamSZSbcytmHzi6A5P9XPkLOlDG6T07cGKdz9M3cIH2qUXimMYS9Kk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766256635; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=cKOC4sPnmtkQ7L+JdsUlBb5Bsh8vjqzfoYmPcpjnenM=; b=gXoPv05aAM4S9McpI7E5eUhlRoG5iRR+B6VmdOdKkSqrxNTHuxR9HuO83Tq1Wcw5ICftOPCSS22TxcMzT1VGoWSk8fUwm9F1kzyQvX6He/R9uJ67I1Z061GCevUC3vvQ1T1OPxRNmdR6WIir+XWzYGVNnkm36WA1rlGRo+9TSMQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1766256635; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=cKOC4sPnmtkQ7L+JdsUlBb5Bsh8vjqzfoYmPcpjnenM=; b=ItW7jbSZjDFdna655b7OCzhvdzkW0QxENSTZ6BK+Jp7zm4AIrDNFQHft3sklcy7T 2Wx+pRZtz90Eg7AZ8rLe3Q9N8YHUUf8Ie3FcC6PFyvq4aRMkz+1bXRgBo/ASAFDpj6P uZa6RFtTQ/4w4N+GpTwBMIYIZFAgVjr3K2j5NX90= Received: by mx.zohomail.com with SMTPS id 1766256633664149.3015413763843; Sat, 20 Dec 2025 10:50:33 -0800 (PST) From: Nicolas Frattaroli Date: Sat, 20 Dec 2025 19:49:53 +0100 Subject: [PATCH v2 2/4] dt-bindings: power: mt8196-gpufreq: Describe nvmem provider ability Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251220-mt8196-shader-present-v2-2-45b1ff1dfab0@collabora.com> References: <20251220-mt8196-shader-present-v2-0-45b1ff1dfab0@collabora.com> In-Reply-To: <20251220-mt8196-shader-present-v2-0-45b1ff1dfab0@collabora.com> To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Ulf Hansson Cc: Chen-Yu Tsai , Chia-I Wu , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 On the MediaTek MT8196 SoC, the Mali GPU's "shader_present" hardware register may also include a non-functional shader core, along with the present shader cores. An efuse elsewhere in the SoC provides the shader_present mask with the fused off core omitted. However, the efuse address is not publicly disclosed. What is known though is that the GPUEB MCU reads this efuse, and exposes its contents in the memory it shares with the application processor. We can therefore describe the mediatek,mt8196-gpufreq device as being an nvmem provider for this purpose, as it does provide nvmem access in an indirect way. The shader-present child node is left out of the list of required properties as we may one day be able to describe the actual efuse region this value comes from, so the gpufreq device isn't necessarily the only device that can provide this cell, and implementations shouldn't need to implement this functionality once this is the case. Reviewed-by: Rob Herring (Arm) Signed-off-by: Nicolas Frattaroli --- .../devicetree/bindings/power/mediatek,mt8196-gpufreq.yaml | 13 +++++++++= ++++ 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/power/mediatek,mt8196-gpufre= q.yaml b/Documentation/devicetree/bindings/power/mediatek,mt8196-gpufreq.ya= ml index b9e43abaf8a4..66fc59b3c8b4 100644 --- a/Documentation/devicetree/bindings/power/mediatek,mt8196-gpufreq.yaml +++ b/Documentation/devicetree/bindings/power/mediatek,mt8196-gpufreq.yaml @@ -74,9 +74,18 @@ properties: "#clock-cells": const: 1 =20 + "#nvmem-cell-cells": + const: 0 + "#power-domain-cells": const: 0 =20 + shader-present: + type: object + +dependencies: + shader-present: [ "#nvmem-cell-cells" ] + required: - compatible - reg @@ -113,5 +122,9 @@ examples: "ccf", "fast-dvfs"; memory-region =3D <&gpueb_shared_memory>; #clock-cells =3D <1>; + #nvmem-cell-cells =3D <0>; #power-domain-cells =3D <0>; + + shader-present { + }; }; --=20 2.52.0 From nobody Sun Feb 8 12:19:55 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61E0B27CB04; Sat, 20 Dec 2025 18:51:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766256690; cv=pass; b=eH7zSPet/X6wjz6To5plSrmdDzRsMVRz4izmNxtZ2glB92PtRp9J2ULJBhziROBi7jYzDlFneau0BMXEgW4nTFANkKKaggMAvAppwauB0At/2tC+C7ZL540t5epe++Y2Ao1BBKylrnZ+a/LgEEygHw/0S/6LCcRgvD4hO1bgRo8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766256690; c=relaxed/simple; bh=CqYHrHAH/Jsla26IK8xYrtLEa0nb+PUDFvp4jEXJNyg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WQB6GiMsV1ppjFd47ycg3/3IijmpyRKl1buBCEEQOHJzxpKv2SvWCs8J/xy3f3jePKO0KCHutPeXRY9GtGF4rcFEQoScAn4yGpw/L8bknCGLZkBkJq4McW+qHIJ8lt9Q+eT3NVOqIJB0+u7XA7wwowEd7cGvFqCU9vzj/buGz3c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=MJepbfoS; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="MJepbfoS" ARC-Seal: i=1; a=rsa-sha256; t=1766256639; cv=none; d=zohomail.com; s=zohoarc; b=MsNirVtsBPgMUKM4LqhhRrIx3Ur9lC+OTQZL6dxKUkOHuy7b35NUfB2b7cqxe9PvBxP7l3ay09KENoO/mdpARgxTHZHbWNjfDnV2vMob/1yuPzI1NHDoYQj9D1WG/O+De7riAcPU2bqNFSyfzpGrKBHiA0rsko8FJvZenAs4pN4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766256639; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=8rRlnY9LZnCWGx1zTU/aPAeZJrjVXsHfEKZP3E41uXI=; b=XzZkCm2B7Gaihpm0ONGK0/VfiawLu4hI2foGyi5f8mnjmm7CDjoTaLwQvQKm7OPmWR0dH1ZrSuMjRjvweFQtXW66sP/clPFzq9qH97Y7LqN4x8TLKbr7RMBcu4Jo4zod6c9xCbNjmimj8ca1lkagYNxCEfSxgrNL2ee0ZANVLao= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1766256639; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=8rRlnY9LZnCWGx1zTU/aPAeZJrjVXsHfEKZP3E41uXI=; b=MJepbfoSqB0kxqG/gC3DSa4eX2BPv0L6tb4Ksi3eTDBPWdgarkE4y5lgUiEOrw9o 02rsAe65LLLwrZw0tO8R9NnCgAg/uVes1yHeW/WpR0oZ6ihyoAdyxykoCkYQH9Bkn99 /yuJbYxKLcX/ZVA0Fp+Io9anLVWWACLlojAsSm9E= Received: by mx.zohomail.com with SMTPS id 1766256639151549.0735477560279; Sat, 20 Dec 2025 10:50:39 -0800 (PST) From: Nicolas Frattaroli Date: Sat, 20 Dec 2025 19:49:54 +0100 Subject: [PATCH v2 3/4] drm/panthor: Implement reading shader_present from nvmem Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251220-mt8196-shader-present-v2-3-45b1ff1dfab0@collabora.com> References: <20251220-mt8196-shader-present-v2-0-45b1ff1dfab0@collabora.com> In-Reply-To: <20251220-mt8196-shader-present-v2-0-45b1ff1dfab0@collabora.com> To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Ulf Hansson Cc: Chen-Yu Tsai , Chia-I Wu , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 On some platforms, notably MediaTek MT8196, the shader_present bitmask in the Mali GPU register for it has cores enabled that may be faulty. The true shader_present bitmask is found in an efuse instead. Implement reading shader_present from an nvmem cell if one is present, falling back to the Mali register if it's absent. The error codes are trickled up through to the probe function so that probe deferral works. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/panthor/panthor_hw.c | 36 ++++++++++++++++++++++++++++++--= ---- 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor= /panthor_hw.c index 87ebb7ae42c4..80c521784cd3 100644 --- a/drivers/gpu/drm/panthor/panthor_hw.c +++ b/drivers/gpu/drm/panthor/panthor_hw.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 or MIT /* Copyright 2025 ARM Limited. All rights reserved. */ =20 +#include #include =20 #include "panthor_device.h" @@ -109,7 +110,25 @@ static char *get_gpu_model_name(struct panthor_device = *ptdev) return "(Unknown Mali GPU)"; } =20 -static void panthor_gpu_info_init(struct panthor_device *ptdev) +static int overload_shader_present(struct panthor_device *ptdev) +{ + u64 contents; + int ret; + + ret =3D nvmem_cell_read_variable_le_u64(ptdev->base.dev, "shader-present", + &contents); + if (!ret) + ptdev->gpu_info.shader_present =3D contents; + else if (ret =3D=3D -ENOENT) + return 0; + else + return dev_err_probe(ptdev->base.dev, ret, + "Failed to read shader-present nvmem cell\n"); + + return 0; +} + +static int panthor_gpu_info_init(struct panthor_device *ptdev) { unsigned int i; =20 @@ -143,13 +162,18 @@ static void panthor_gpu_info_init(struct panthor_devi= ce *ptdev) ptdev->gpu_info.tiler_present =3D gpu_read64(ptdev, GPU_TILER_PRESENT); ptdev->gpu_info.l2_present =3D gpu_read64(ptdev, GPU_L2_PRESENT); } + + return overload_shader_present(ptdev); } =20 -static void panthor_hw_info_init(struct panthor_device *ptdev) +static int panthor_hw_info_init(struct panthor_device *ptdev) { u32 major, minor, status; + int ret; =20 - panthor_gpu_info_init(ptdev); + ret =3D panthor_gpu_info_init(ptdev); + if (ret) + return ret; =20 major =3D GPU_VER_MAJOR(ptdev->gpu_info.gpu_id); minor =3D GPU_VER_MINOR(ptdev->gpu_info.gpu_id); @@ -172,6 +196,8 @@ static void panthor_hw_info_init(struct panthor_device = *ptdev) "shader_present=3D0x%0llx l2_present=3D0x%0llx tiler_present=3D0x%0llx", ptdev->gpu_info.shader_present, ptdev->gpu_info.l2_present, ptdev->gpu_info.tiler_present); + + return 0; } =20 static int panthor_hw_bind_device(struct panthor_device *ptdev) @@ -218,7 +244,5 @@ int panthor_hw_init(struct panthor_device *ptdev) if (ret) return ret; =20 - panthor_hw_info_init(ptdev); - - return 0; + return panthor_hw_info_init(ptdev); } --=20 2.52.0 From nobody Sun Feb 8 12:19:55 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61A833101AE; Sat, 20 Dec 2025 18:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766256693; cv=pass; b=C+b6D8IAcIFCI4Qjao+DV9ZTWMRvQQh0xQi5+Np+2tZhGggc+4jfN3PiNvM3T/TkTCJlCM6eVfvfMEPYzUh2vIKKXDeJWwQv4Ib5b1SlDf1p/h+xxC+OQmrPebgNyzdz9V98/W8B60u9B5cLexB5cblCvGiLWOzEiCJhfSfPTDk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766256693; c=relaxed/simple; bh=ZatUZYCF/cHOR33QjkB+YNbdZjxbeNr+Lg6rp1tov5M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nrDdFm01LJ1rALfeAnsVXWsSR9UG6IWvz8vqFyr3GT0u+02/H3Vu5TSXnArIZ/TlNZ4liAOhgfy8JnFUw7hWets8Z6qxe1hDWR83+F+J95yIMZGgnKF2XgBB7Ueu57CJV5X1+FBMt42HKslO84fBFNT9UVt4kXW+yCOobhRGO1I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=YxRCapuL; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="YxRCapuL" ARC-Seal: i=1; a=rsa-sha256; t=1766256646; cv=none; d=zohomail.com; s=zohoarc; b=k+ps33RBoTWzNAlrymFBqhrJ55XvdVPAT3xq+aTba7zUdV7Z+/k3sFXbqkjStnwU3fKC4DLCfbfstyss83JbuvavywOY0EcDg3VIAPGHH3hBOKeMPjfB6xGPa73x19e+tvR3/xrJ+igMvn99fS524VdlG+VU1mvIh/aMxVQmBqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766256646; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=5j17v1GY5ZUui5Rtx97+9pI639Hi6bT0WnwCtzvrtAQ=; b=DXXW5zq0m7GofuoNuxOsUEqA1LuHa4dN/fLdZPkE1PXL79G/77pNl7LEZ5RoXzPQJ6ptLSf8TVX25ws6N8kMHKFepV2GWyZw0sMPwxApZhcmIXUVM2QWGhKoHoqgbAMoxlBJw+mQ0RebKzWb9RnkajGbAmGyL4unhOdY/vuyfHU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1766256646; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=5j17v1GY5ZUui5Rtx97+9pI639Hi6bT0WnwCtzvrtAQ=; b=YxRCapuLlpcgveZ8ge+9Vt9yL4zoF7BeXltj21O4pBcGxMmo4PKr67dZOWJgacT9 4LGATQCtFbN3QrbIoPAc5Wyk8dy9fLAHt1gHOZDn198/kWRImzStGT7ic1eIp2BDdU8 EIaJSJZXXNJaG07RIi1ArCYZ4JYC0mCUo1E3Vuf4= Received: by mx.zohomail.com with SMTPS id 1766256644626461.8229840632764; Sat, 20 Dec 2025 10:50:44 -0800 (PST) From: Nicolas Frattaroli Date: Sat, 20 Dec 2025 19:49:55 +0100 Subject: [PATCH v2 4/4] pmdomain: mediatek: mtk-mfg: Expose shader_present as nvmem cell Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251220-mt8196-shader-present-v2-4-45b1ff1dfab0@collabora.com> References: <20251220-mt8196-shader-present-v2-0-45b1ff1dfab0@collabora.com> In-Reply-To: <20251220-mt8196-shader-present-v2-0-45b1ff1dfab0@collabora.com> To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Ulf Hansson Cc: Chen-Yu Tsai , Chia-I Wu , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 Implement nvmem-provider functionality in mtk-mfg-pmdomain, such that it can expose its GF_REG_SHADER_PRESENT value in the shared memory as an nvmem cell for panthor. Signed-off-by: Nicolas Frattaroli --- drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c | 59 ++++++++++++++++++++++++= ++++ 1 file changed, 59 insertions(+) diff --git a/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c b/drivers/pmdomai= n/mediatek/mtk-mfg-pmdomain.c index 9bad577b3ae4..3ce6fb74dd53 100644 --- a/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c +++ b/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -872,6 +873,60 @@ static int mtk_mfg_init_clk_provider(struct mtk_mfg *m= fg) return 0; } =20 +static int mtk_mfg_read_nvmem(void *priv, unsigned int offset, void *val, = size_t bytes) +{ + struct mtk_mfg *mfg =3D priv; + u32 *buf =3D val; + + if (bytes !=3D 4) + return -EINVAL; + + if (!mfg->shared_mem) + return -ENODEV; + + if (offset + bytes >=3D mfg->shared_mem_size) + return -EINVAL; + + *buf =3D readl(mfg->shared_mem + offset); + + return 0; +} + +static int mtk_mfg_init_nvmem_provider(struct mtk_mfg *mfg) +{ + struct device *dev =3D &mfg->pdev->dev; + struct nvmem_cell_info cell =3D {}; + struct nvmem_config config =3D {}; + struct nvmem_device *nvdev; + int ret; + + config.reg_read =3D mtk_mfg_read_nvmem; + config.dev =3D dev; + config.read_only =3D true; + config.priv =3D mfg; + config.size =3D 4; + config.word_size =3D 4; + + nvdev =3D devm_nvmem_register(dev, &config); + if (IS_ERR(nvdev)) + return dev_err_probe(dev, PTR_ERR(nvdev), "Couldn't register nvmem provi= der\n"); + + cell.name =3D "shader-present"; + cell.offset =3D GF_REG_SHADER_PRESENT; + cell.bytes =3D 4; + cell.np =3D of_get_child_by_name(dev->of_node, cell.name); + + ret =3D nvmem_add_one_cell(nvdev, &cell); + if (ret) { + of_node_put(cell.np); + return dev_err_probe(dev, ret, "Couldn't add cell %s\n", cell.name); + } + + /* cell.np purposefully not put as nvmem_add_one_cell does not increase r= efcount */ + + return 0; +} + static int mtk_mfg_probe(struct platform_device *pdev) { struct mtk_mfg *mfg; @@ -984,6 +1039,10 @@ static int mtk_mfg_probe(struct platform_device *pdev) if (ret) goto err_power_off; =20 + ret =3D mtk_mfg_init_nvmem_provider(mfg); + if (ret) + goto err_power_off; + ret =3D of_genpd_add_provider_simple(dev->of_node, &mfg->pd); if (ret) { dev_err_probe(dev, ret, "Failed to add pmdomain provider\n"); --=20 2.52.0