From nobody Sun Feb 8 05:28:23 2026 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6129B346A11; Fri, 19 Dec 2025 17:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766166209; cv=none; b=YV5zzJLtyZRAYChwFoS6A7Ix+7mdb9iCqzzCiO3bCPTb8AJ2n16XRbqXN4YthnXITqu3dEAGCM2P0nRy/EQVn8xUxqd3UsxtRb6He3S66jmpOigfbAnqN8ONbIW/4nO2ogWz7ErVnHjhJJbQJn2heRfyvD2CfgMo1xt4aC1XdnQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766166209; c=relaxed/simple; bh=o2THcKPo45z5soGXRcN2mbZHgWmy2NNFFA3LWEdNAII=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pqCavgFj528QIeT/nrWnLoRUSsysMM/13dbCa14F3gZP3uReLwmQA+SkqySzt8sFMjH/PVAZPocGpIkncpbfZZVYMIFpMJm9khyR6nLavhmtuJ3/+yJZc38OeoTG4Ru49BuRxJYzWlYWWTR3/nanbW95rJv81yei9jM53GeNL5A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=I2dAHbn5; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="I2dAHbn5" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SUoJ2Z89QW3dSM6PxQOR2ZbZPL+zegxwu/TizFfaWoY=; b=I2dAHbn5FR84Rhr73Mlon61yhD MEg1qGs73DpcWFcv+eAF+ljTydZGDOgLTJKvl1ZFJNFOsFNwWeVecQD3njc90QmmnDlGqrRv2GHM4 CzuWhhexrEKQiA/55Vzgm8Ez9qDqA2lU2XTkQZ9cm6gMpm1Wsq/0dNK+zDE2FuZnC8XNoqItaHx7Z ho+R63gpU8iyFai6s8vqWUjToAJu8x3/s6kDXh5PtTzZ8sRAnmZIICQIZOknxT6kd6NvhMQtYdJ33 XYO9kLc/gqO0cNhqS3TPC4YBrxKXlISQ3IceWrJ2Bf/2Zoml1kLVHBf3IgfJUtUdddpvyZVR/Ctfv QjxS+FVQ==; Received: from bl17-145-117.dsl.telepac.pt ([188.82.145.117] helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1vWeVZ-00EjFk-On; Fri, 19 Dec 2025 18:43:17 +0100 From: Luis Henriques To: Miklos Szeredi , Al Viro Cc: mszeredi@suse.cz, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, Luis Henriques Subject: [PATCH] fuse: add missing iput() in fuse_lookup() error path Date: Fri, 19 Dec 2025 17:43:09 +0000 Message-ID: <20251219174310.41703-1-luis@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The inode use count needs to be dropped in the fuse_lookup() error path, when there's an error returned by d_splice_alias(). (While there, remove extra white spaces before labels.) Fixes: 5835f3390e35 ("fuse: use d_materialise_unique()") Signed-off-by: Luis Henriques --- fs/fuse/dir.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index 4b6b3d2758ff..75032b947a13 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c @@ -636,7 +636,7 @@ static struct dentry *fuse_lookup(struct inode *dir, st= ruct dentry *entry, newent =3D d_splice_alias(inode, entry); err =3D PTR_ERR(newent); if (IS_ERR(newent)) - goto out_err; + goto out_iput; =20 entry =3D newent ? newent : entry; entry->d_time =3D epoch; @@ -649,9 +649,9 @@ static struct dentry *fuse_lookup(struct inode *dir, st= ruct dentry *entry, fuse_advise_use_readdirplus(dir); return newent; =20 - out_iput: +out_iput: iput(inode); - out_err: +out_err: return ERR_PTR(err); }